GNU bug report logs - #38131
27.0.50; [PATCH] lisp/icomplete.el: put text property when text is not nil

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38131 in the body.
You can then email your comments to 38131 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; [PATCH] lisp/icomplete.el: put text property when text is
 not nil
Date: Fri, 8 Nov 2019 15:17:31 +0200

[Message part 1 (text/plain, inline)]

With commit 5761a1a3939e23d8e8c725241dd9398a12f191b0

1. emacs -Q
2. M-x icomplete-mode RET
3. M-x icomplete-mode

After typing last "e" there are error:

Error in post-command-hook (icomplete-post-command-hook):
(args-out-of-range -1 1)

[0001-lisp-icomplete.el-put-text-property-when-text-is-not.patch (application/octet-stream, attachment)]

Message #8 received at 38131 <at> debbugs.gnu.org (full text, mbox):

From: Pankaj Jangid <pankaj.jangid <at> gmail.com>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 38131 <at> debbugs.gnu.org
Subject: Re: bug#38131: 27.0.50; [PATCH] lisp/icomplete.el: put text
 property when text is not nil
Date: Fri, 08 Nov 2019 23:33:00 +0530

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:
> With commit 5761a1a3939e23d8e8c725241dd9398a12f191b0
> 1. emacs -Q
> 2. M-x icomplete-mode RET
> 3. M-x icomplete-mode
>
> After typing last "e" there are error:
>
> Error in post-command-hook (icomplete-post-command-hook):
> (args-out-of-range -1 1)

I just verified it. The error is occurring in my build as well. Commit
0a51c7012268d764ac4282b5969e4901ebeabfdb.

Regards,
-- 
Pankaj Jangid

Message #11 received at 38131 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Pankaj Jangid <pankaj.jangid <at> gmail.com>
Cc: 38131 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>,
 Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Subject: Re: bug#38131: 27.0.50; [PATCH] lisp/icomplete.el: put text property
 when text is not nil
Date: Sat, 9 Nov 2019 02:42:40 +0100

[Message part 1 (text/plain, inline)]

Apparently caused by this patch:

commit 5761a1a3939e23d8e8c725241dd9398a12f191b0
 Author: João Távora <joaotavora <at> gmail.com>
 Date:   2019-11-08 00:11:34 +0000

     Nudge icomplete-mode a little closer to fido-mode

     * lisp/icomplete.el (icomplete-completions): Don't use ellipsis when
     truncating determ in fido-mode.  Highlight the center part of
     determ with icomplete-first-match.

[Message part 2 (text/html, inline)]

Message #14 received at 38131 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Pankaj Jangid <pankaj.jangid <at> gmail.com>, 38131 <at> debbugs.gnu.org,
 Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Subject: Re: bug#38131: 27.0.50; [PATCH] lisp/icomplete.el: put text property
 when text is not nil
Date: Sat, 9 Nov 2019 11:51:22 +0000

Sorry about that, will fix it ASAP.

Thanks for the stable reproduction recipe (I thought I saw
it but it was elusive).

João

On Sat, Nov 9, 2019 at 1:43 AM Juanma Barranquero <lekktu <at> gmail.com> wrote:
>
> Apparently caused by this patch:
>
> commit 5761a1a3939e23d8e8c725241dd9398a12f191b0
>  Author: João Távora <joaotavora <at> gmail.com>
>  Date:   2019-11-08 00:11:34 +0000
>
>      Nudge icomplete-mode a little closer to fido-mode
>
>      * lisp/icomplete.el (icomplete-completions): Don't use ellipsis when
>      truncating determ in fido-mode.  Highlight the center part of
>      determ with icomplete-first-match.



-- 
João Távora

Message #17 received at 38131 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Pankaj Jangid <pankaj.jangid <at> gmail.com>, 38131 <at> debbugs.gnu.org,
 Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Subject: Re: bug#38131: 27.0.50; [PATCH] lisp/icomplete.el: put text property
 when text is not nil
Date: Sat, 9 Nov 2019 14:58:35 +0000

I've reverted that commit.  It had other problems.  I will try again
soon to find some other way to make fido-mode behave closer to
ido-mode.  This can be closed, I think.

João

On Sat, Nov 9, 2019 at 11:51 AM João Távora <joaotavora <at> gmail.com> wrote:
>
> Sorry about that, will fix it ASAP.
>
> Thanks for the stable reproduction recipe (I thought I saw
> it but it was elusive).
>
> João
>
> On Sat, Nov 9, 2019 at 1:43 AM Juanma Barranquero <lekktu <at> gmail.com> wrote:
> >
> > Apparently caused by this patch:
> >
> > commit 5761a1a3939e23d8e8c725241dd9398a12f191b0
> >  Author: João Távora <joaotavora <at> gmail.com>
> >  Date:   2019-11-08 00:11:34 +0000
> >
> >      Nudge icomplete-mode a little closer to fido-mode
> >
> >      * lisp/icomplete.el (icomplete-completions): Don't use ellipsis when
> >      truncating determ in fido-mode.  Highlight the center part of
> >      determ with icomplete-first-match.
>
>
>
> --
> João Távora



-- 
João Távora

Message #22 received at 38131-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: João Távora <joaotavora <at> gmail.com>
Cc: Pankaj Jangid <pankaj.jangid <at> gmail.com>, 38131-done <at> debbugs.gnu.org,
 Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Subject: Re: bug#38131: 27.0.50; [PATCH] lisp/icomplete.el: put text property
 when text is not nil
Date: Sat, 9 Nov 2019 16:31:45 +0100

[Message part 1 (text/plain, inline)]

On Sat, Nov 9, 2019 at 3:58 PM João Távora <joaotavora <at> gmail.com> wrote:

> This can be closed, I think.

Closed.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.