Subject: Re: [bug#38129] [PATCH] gnu: Add sherlock-lv2.

From: Marius Bakke <[email-masked]>
Date: Sun, 10 Nov 2019 22:31:07 +0100

Alexandros,

Thanks for these patches.  I think your MUA might have mangled these
patches somehow, as many of them are "corrupt" according to git.  Can
you try to resend these?  I'll comment on the patches individually
meanwhile.

Alexandros Theodotou <[email-masked]> writes:

>  From 5207795bcce201e019c33bb0274e06a460cf6c3f Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <[email-masked]>
> Date: Fri, 8 Nov 2019 10:59:52 +0000
> Subject: [PATCH] gnu: Add sherlock-lv2.
>
> * gnu/packages/music.scm: (sherlock-lv2): New variable.

[...]

> +(define-public sherlock-lv2
> +  (package
> +    (name "sherlock-lv2")
> +    (version "0.20.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +               "https://git.open-music-kontrollers.ch/lv2/"
> +               "sherlock.lv2/snapshot/sherlock.lv2-"
> +               version ".tar.xz"))
> +        (sha256
> +          (base32
> +            "1c5xajpss9h8lbyx160bbzg8va50n2d74qwnxig9sf468rzmha1y"))))
> +    (build-system meson-build-system)
> +    (inputs
> +     `(("glibc" ,glibc)

I don't think this is needed?

> +       ("libx11" ,libx11)
> +       ("mesa" ,mesa)
> +       ("serd" ,serd)
> +       ("sratom" ,sratom)))
> +    (native-inputs
> +     `(("flex" ,flex)
> +       ("lv2" ,lv2)
> +       ("sord" ,sord)

I don't know anything about LV2 and sord, are these inputs really only
used for the build process itself?  :-)

> +       ("pkg-config" ,pkg-config)))
> +    (synopsis "Investigative LV2 plugin bundle")
> +    (description "The Sherlock plugin bundle contains LV2 plugins for
> +visualizing LV2 atom, MIDI and OSC events. They can be used for 
> monitoring and
> +debugging of event signal flows inside plugin graphs.")

Two spaces after periods, as per 'guix lint'.