Subject: Re: [bug#38126] [PATCH] gnu: Add libltc.

From: Marius Bakke <[email-masked]>
Date: Sun, 10 Nov 2019 23:05:16 +0100

Alexandros Theodotou <[email-masked]> writes:

>  From 061201b2179f5ac1c0a3cce89a256d7722c31978 Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <[email-masked]>
> Date: Fri, 8 Nov 2019 10:45:11 +0000
> Subject: [PATCH] gnu: Add libltc.
>
> * gnu/packages/audio.scm: (libltc): New variable.

[...]

> +(define-public libltc
> +  (package
> +    (name "libltc")
> +    (version "1.3.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +               "https://github.com/x42/libltc/releases/download/v"
> +               version "/libltc-" version ".tar.gz"))
> +        (sha256
> +          (base32
> +            "173h9dgmain3nyrwk6q2d7yl4fnh4vacag4s2p01n5b7nyrkxrjh"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f)) ; tests fail

Could you give some information as to why the tests fail?  Often it's
simply because of '/bin/sh' references and similar.  You can investigate
a failed build with 'guix build --keep-failed'.

> +    (inputs
> +     `(("glibc" ,glibc)))

glibc is always available and does not need to be explicitly provided.

> +    (native-inputs
> +     `(("doxygen" ,doxygen)
> +       ("pkg-config" ,pkg-config)))
> +    (synopsis "Linear/Logitudinal Time Code (LTC) Library")
> +    (description "Libltc is a POSIX-C Library for handling 
> Linear/Logitudinal
> +Time Code (LTC).")
> +    (home-page "http://x42.github.io/libltc/")
                     ^^^
                   HTTPS
> +    (license license:lgpl3+)))
> -- 
> 2.24.0