Subject: Re: [bug#38120] [PATCH] gnu: Add geonkick.

From: Marius Bakke <[email-masked]>
Date: Wed, 13 Nov 2019 23:30:07 +0100

Alexandros Theodotou <[email-masked]> writes:

> From 98c080f2f27d9f7a99dd635948dc062bde75ed1c Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <[email-masked]>
> Date: Fri, 8 Nov 2019 10:11:50 +0000
> Subject: [PATCH] gnu: Add geonkick.
>
> * gnu/packages/music.scm: (geonkick): New variable.

[...]

> +(define-public geonkick
> +  (package
> +    (name "geonkick")
> +    (version "1.9.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://gitlab.com/iurie/geonkick/-/archive/v"
> +                            version "/geonkick-v" version ".tar.gz"))
> +        (sha256
> +          (base32
> +            "0wp8w5q69c1nrcc4qkcg0slakkpzp9ngw25iih8zhcl4hrjv42fd"))))

As with redkite, I followed the redirect and changed to a git checkout.

> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f ; no tests included
> +       #:configure-flags
> +       (list (string-append "-DGKICK_REDKITE_SDK_PATH="
> +                            (assoc-ref %build-inputs "redkite"))
> +             (string-append "-DCMAKE_INSTALL_PREFIX="
> +                            (assoc-ref %outputs "out")))))
> +    (inputs
> +     `(("cairo" ,cairo)
> +       ("hicolor-icon-theme" ,hicolor-icon-theme)
> +       ("jack" ,jack-1) ; for the standalone JACK application
> +       ("libsndfile" ,libsndfile)
> +       ("libx11" ,libx11)))
> +    (native-inputs
> +     `(("lv2" ,lv2)
> +       ("pkg-config" ,pkg-config)
> +       ("sord" ,sord)
> +       ("rapidjson" ,rapidjson)
> +       ("redkite" ,redkite)))

I moved rapidjson and redkite to inputs, because the package embeds
their static libraries, so the architecture has to match when
cross-compiling.

Applied!