GNU bug report logs - #38118
[PATCH] gnu: Add avldrums-lv2.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#38118: closed ([PATCH] gnu: Add avldrums-lv2.)
Date: Wed, 13 Nov 2019 22:34:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 13 Nov 2019 23:33:12 +0100
with message-id <87imnniezb.fsf <at> devup.no>
and subject line Re: [bug#38118] [PATCH] gnu: Add avldrums-lv2.
has caused the debbugs.gnu.org bug report #38118,
regarding [PATCH] gnu: Add avldrums-lv2.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
38118: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38118
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add avldrums-lv2.
Date: Fri, 08 Nov 2019 10:38:03 +0100

From aae805260db2b830a35459ae219c780e6619cc14 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex <at> zrythm.org>
Date: Fri, 8 Nov 2019 09:35:38 +0000
Subject: [PATCH] gnu: Add avldrums-lv2.

* gnu/packages/music.scm: (avldrums-lv2): New variable.
---
 gnu/packages/music.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a30765e87f..38d30c5438 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays <at> sdf.lonestar.org>
 ;;; Copyright © 2019 raingloom <raingloom <at> protonmail.com>
 ;;; Copyright © 2019 David Wilson <david <at> daviwil.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex <at> zrythm.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4699,3 +4700,45 @@ You can also get metadata about the playing track 
such as the artist and title
 for integration into status line generators or other command-line 
tools.")
     (home-page "https://github.com/altdesktop/playerctl")
     (license license:lgpl3+)))
+
+(define-public avldrums-lv2
+  (package
+    (name "avldrums-lv2")
+    (version "0.4.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+          (git-reference
+            (url "https://github.com/x42/avldrums.lv2.git")
+            (commit (string-append "v" version))
+            (recursive? #t)))   ; for the 'robtk' submodule
+        (file-name (string-append name "-v" version))
+        (sha256
+          (base32
+            "1z70rcq6z3gkb4fm8dm9hs31bslwr97zdh2n012fzki9b9rdj5qv"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f  ; no "check" target
+       #:make-flags
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'set-CC-variable
+           (lambda _ (setenv "CC" "gcc") #t))
+         (delete 'configure))))
+    (inputs
+     `(("cairo" ,cairo)
+       ("dssi" ,dssi)
+       ("glu" ,glu)
+       ("mesa" ,mesa)
+       ("pango" ,pango)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("lv2" ,lv2)))
+    (home-page "http://x42-plugins.com/x42/x42-avldrums")
+    (synopsis "Drum sample player LV2 plugin dedicated to the AVLinux 
Drumkits")
+    (description "avldrums.lv2 is a drum sample player LV2 plugin 
dedicated to Glen MacArthur's
+AVLdrums. This plugin provides a convenient way to sequence and mix 
MIDI drums and
+comes as two separate drumkits: Black Pearl and Red Zeppelin.")
+    (license license:gpl2+)))
-- 
2.24.0

[Message part 3 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38118-done <at> debbugs.gnu.org
Subject: Re: [bug#38118] [PATCH] gnu: Add avldrums-lv2.
Date: Wed, 13 Nov 2019 23:33:12 +0100

[Message part 4 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> From e6d30dd87ae46bfba50de7a0e549a13a0368dfcc Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 09:35:38 +0000
> Subject: [PATCH] gnu: Add avldrums-lv2.
>
> * gnu/packages/music.scm: (avldrums-lv2): New variable.

Thanks!  Applied with indentation fixes like the other patches.  This is
the last review I had time for today.

In the future, when sending many related patches at once, please send as
a "patch series" (commits on top of each other) instead of individual
patches all branching out from the same commit.

The reason is that applying the first patch to music.scm broke the other
patches for music.scm, because the context became different.  I managed
to work around it with a workflow involving
`git am --show-current-patch | git apply`, but it would be better if all
applied cleanly when committed in order.  :-)

Anyway, impressive first series of patches!  I look forward to the next
one.  ;-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.