GNU bug report logs - #38116
[PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#38116: closed ([PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and
 qtbase.)
Date: Sun, 10 Nov 2019 22:40:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 10 Nov 2019 23:39:43 +0100
with message-id <87mud3jqz4.fsf <at> devup.no>
and subject line Re: [bug#38116] [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.
has caused the debbugs.gnu.org bug report #38116,
regarding [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
38116: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38116
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.
Date: Fri, 08 Nov 2019 10:14:10 +0100

The gtkmm passed to inputs was unused. Jalv does not support gtkmm 3 at 
the moment.

Also, Jalv is the main tool LV2 plugin developers use to test their 
plugins. Having more variants
(qt5, gtk2) means you have more types of hosts to test your plugins in 
so this is an
extremely useful addition.

From 2ec5fb34c2600c893763ae95d69bf2bd77d17b61 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex <at> zrythm.org>
Date: Fri, 8 Nov 2019 09:05:10 +0000
Subject: [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.

* gnu/packages/audio.scm (jalv)[inputs]:
Add gtk+-2 and qtbase.
Change unused gtkmm to gtkmm-2.
---
 gnu/packages/audio.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 28dbf06f3b..ca2d86d525 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1599,8 +1599,10 @@ synchronous execution of all clients, and low 
latency operation.")
      `(("lv2" ,lv2)
        ("lilv" ,lilv)
        ("suil" ,suil)
-       ("gtk" ,gtk+)
-       ("gtkmm" ,gtkmm)
+       ("gtk2" ,gtk+-2)
+       ("gtk3" ,gtk+)
+       ("gtkmm" ,gtkmm-2)
+       ("qtbase" ,qtbase)
        ("jack" ,jack-1)))
     (native-inputs
      `(("pkg-config" ,pkg-config)))
-- 
2.24.0

[Message part 3 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alexandros Theodotou <alex <at> zrythm.org>, 38116-done <at> debbugs.gnu.org
Subject: Re: [bug#38116] [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.
Date: Sun, 10 Nov 2019 23:39:43 +0100

[Message part 4 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> The gtkmm passed to inputs was unused. Jalv does not support gtkmm 3 at 
> the moment.
>
> Also, Jalv is the main tool LV2 plugin developers use to test their 
> plugins. Having more variants
> (qt5, gtk2) means you have more types of hosts to test your plugins in 
> so this is an
> extremely useful addition.
>
>  From 2ec5fb34c2600c893763ae95d69bf2bd77d17b61 Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Fri, 8 Nov 2019 09:05:10 +0000
> Subject: [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.
>
> * gnu/packages/audio.scm (jalv)[inputs]:
> Add gtk+-2 and qtbase.
> Change unused gtkmm to gtkmm-2.

Thanks!  'guix size jalv' increases from 1482.2 MiB to 1501.2 MiB with
this patch due to the addition of gtkmm <at> 2, which seems fine.

Applied!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.