GNU bug report logs - #38109
27.0.50; xpm image scaling doesn't work

Previous Next

Package: emacs;

Reported by: Adam Sjøgren <asjo <at> koldfront.dk>

Date: Thu, 7 Nov 2019 21:12:02 UTC

Severity: normal

Found in version 27.0.50

Done: Alan Third <alan <at> idiocy.org>

Bug is archived. No further changes may be made.

Full log


Message #95 received at 38109 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: asjo <at> koldfront.dk, 38109 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#38109: Updated Emacs to HEAD, consistently not scaling now
Date: Sat, 9 Nov 2019 18:11:28 +0000
On Sat, Nov 09, 2019 at 07:58:19PM +0200, Eli Zaretskii wrote:
> > Date: Sat, 9 Nov 2019 17:22:41 +0000
> > From: Alan Third <alan <at> idiocy.org>
> > Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 38109 <at> debbugs.gnu.org
> > 
> > OK, so when there’s a mask there’s a different function called in
> > xterm.c to draw the image. I’m not sure what the deal with that is but
> > I had to modify it to use x_composite_image. We also need pretty much
> > every other patch that we’ve posted to this thread, so I’ve attached
> > something that works for me.
> 
> Can you explain why you moved the call to image_set_transform?

postprocess_image can create or modify the mask, which causes problems
if we’ve already changed the width and height of the image. The
simplest solution I could see was to move image_set_transform to after
it, as I don’t think there’s anything in that function that relies on
it having happened already.

-- 
Alan Third




This bug report was last modified 5 years and 176 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.