GNU bug report logs - #38107
[PATCH 0/1] Warn about etc/indent-code.el when Emacs is absent.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#38107: closed ([PATCH 0/1] Warn about etc/indent-code.el when
 Emacs is absent.)
Date: Fri, 08 Nov 2019 22:57:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 08 Nov 2019 23:56:26 +0100
with message-id <878soqc6zp.fsf <at> gnu.org>
and subject line Re: [bug#38107] [PATCH 1/1] configure.ac: Warn about etc/indent-code.el when Emacs is absent.
has caused the debbugs.gnu.org bug report #38107,
regarding [PATCH 0/1] Warn about etc/indent-code.el when Emacs is absent.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
38107: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38107
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 0/1] Warn about etc/indent-code.el when Emacs is absent.
Date: Thu,  7 Nov 2019 19:25:18 +0100

Dear,

Currently, if Emacs is absent of PATH then ./configure defaults to
/usr/bin/emacs, therefore the script etc/indent-code.el fails when the user
runs it.

With the patch, the file etc/indent-code.el will not be outputed if Emacs is
absent and ./configure warns the user.

From my point of view, it avoids trivial mistake of non-Emacs-er newcomers and
ease their experience when contributing.


All the best,
simon


zimoun (1):
  configure.ac: Warn about etc/indent-code.el when Emacs is absent.

 configure.ac | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

-- 
2.23.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 38107-done <at> debbugs.gnu.org
Subject: Re: [bug#38107] [PATCH 1/1] configure.ac: Warn about
 etc/indent-code.el when Emacs is absent.
Date: Fri, 08 Nov 2019 23:56:26 +0100

zimoun <zimon.toutoune <at> gmail.com> skribis:

> ---
>  configure.ac | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 689b28d984..599addfe59 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -280,9 +280,14 @@ dnl Documentation translation.
>  AM_MISSING_PROG([PO4A_TRANSLATE], [po4a-translate])
>  AM_MISSING_PROG([PO4A_UPDATEPO], [po4a-updatepo])
>  
> -dnl Emacs (optional), for 'etc/indent-package.el'.
> -AC_PATH_PROG([EMACS], [emacs], [/usr/bin/emacs])
> -AC_SUBST([EMACS])
> +dnl Emacs (optional), for 'etc/indent-code.el'.
> +AC_PATH_PROG([EMACS], [emacs])
> +if test "x$EMACS" = x; then
> +    AC_MSG_WARN([Install GNU Emacs to use etc/indent-code.el])
> +else
> +    AC_SUBST([EMACS])
> +    AC_CONFIG_FILES([etc/indent-code.el], [chmod +x etc/indent-code.el])
> +fi

I removed the redundant ‘AC_CONFIG_FILES’ from the bottom, adjusted the
commit log, and applied.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.