From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 13:25:36 2019 Received: (at submit) by debbugs.gnu.org; 7 Nov 2019 18:25:36 +0000 Received: from localhost ([127.0.0.1]:43895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSmTQ-00057F-Hl for submit@debbugs.gnu.org; Thu, 07 Nov 2019 13:25:36 -0500 Received: from lists.gnu.org ([209.51.188.17]:59533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSmTK-000573-7y for submit@debbugs.gnu.org; Thu, 07 Nov 2019 13:25:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34227) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSmTJ-0002qa-7g for guix-patches@gnu.org; Thu, 07 Nov 2019 13:25:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSmTD-00062c-FO for guix-patches@gnu.org; Thu, 07 Nov 2019 13:25:29 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:39213) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSmTD-00062F-9W for guix-patches@gnu.org; Thu, 07 Nov 2019 13:25:23 -0500 Received: by mail-wm1-x32a.google.com with SMTP id t26so3540354wmi.4 for ; Thu, 07 Nov 2019 10:25:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=U+iS0kiSq1Gu3U8WirgbTeZRrHK/Ia5K7LmIxtBBzTQ=; b=KIhlRCJxw0HRcMlHTH6wmbVEion1oSgT4AD1xMCDFakkiyLj0k0Uj7VYkLdf4STbrp /LInOv+0NLhYJJ0dz2z/qvCnazBgRIGCK0Zl5hg2FeYhN3S2PBXidYyKxywCAIN12aCP pEHuJ1B7oBfO91fuaDwUn7JW5QcN2jBol3+Wq7n1G3XUDav79b9LRR28QYKVMYPb42BB TDp3ZMEIaSSPw5hdrsHGNeTBGu7mZb3aZ8U7pa7vKKjI5Fve2MTwfdT3yXVywVz2Ziv+ xK7+Unc7YWvIOBWLx0MGQDJ3xTAIpi8B/n9plvu5ZajaD9r02nK8yKlZc2WAoYhlJEme 9TAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=U+iS0kiSq1Gu3U8WirgbTeZRrHK/Ia5K7LmIxtBBzTQ=; b=H+S1KTSmHUZjzyVbFbs1WCRbdwQhiq3T0oPBUX1CN5UWQRD6/8Gx8C+g7l8PAGYqGp 3pKnvKZCXf/W5HvHtvKz06+sNbaU7e0Bv6G9Atpw3lEjE8WCqbatxB3zdtwvGJwLBAQ1 vIBQCNfeLGeThMuDuJUTvqvNcl4kx5DSxxn7Xcu7sXk7HUeWCGlT+eTN6NpKn1p3jPgg nbMz8/I4L3+EF9FgmWF0+qD2217jQ9rtaOFizxhzAOfs5UdVoxs3Mo+H31pbivrBwRBu v3eKfwQpVDvi9TWhi7FJUVuaof78RWNXRNH4ouV71RW3OLwLWpG8wFHNePSICeBkfhWZ qOmg== X-Gm-Message-State: APjAAAU+yk7irqTY6be4iB1Y+YnlweEM25M9NBDfb/qRJI+nxKV++MSj CwfK5RpKoj5KTQ3pO9NjwYJS4MFe X-Google-Smtp-Source: APXvYqwgxHaFxSKdl1yA0bSVrZtB6BHARH0fF+wnoYYMf0+kVM2a7FLk1mC6iDgR6ISNOYQHMqyqVw== X-Received: by 2002:a05:600c:2383:: with SMTP id m3mr1289705wma.66.1573151121765; Thu, 07 Nov 2019 10:25:21 -0800 (PST) Received: from pfiuh02.univ-paris-diderot.fr ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id r5sm3156099wrl.86.2019.11.07.10.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 10:25:21 -0800 (PST) From: zimoun To: guix-patches@gnu.org Subject: [PATCH 0/1] Warn about etc/indent-code.el when Emacs is absent. Date: Thu, 7 Nov 2019 19:25:18 +0100 Message-Id: <20191107182518.9823-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32a X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Dear, Currently, if Emacs is absent of PATH then ./configure defaults to /usr/bin/emacs, therefore the script etc/indent-code.el fails when the user runs it. With the patch, the file etc/indent-code.el will not be outputed if Emacs is absent and ./configure warns the user. >From my point of view, it avoids trivial mistake of non-Emacs-er newcomers and ease their experience when contributing. All the best, simon zimoun (1): configure.ac: Warn about etc/indent-code.el when Emacs is absent. configure.ac | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) -- 2.23.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 13:27:36 2019 Received: (at 38107) by debbugs.gnu.org; 7 Nov 2019 18:27:36 +0000 Received: from localhost ([127.0.0.1]:43901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSmVM-0005Ah-0m for submit@debbugs.gnu.org; Thu, 07 Nov 2019 13:27:36 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:41137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSmVJ-0005AT-Ih for 38107@debbugs.gnu.org; Thu, 07 Nov 2019 13:27:34 -0500 Received: by mail-wr1-f51.google.com with SMTP id p4so4171311wrm.8 for <38107@debbugs.gnu.org>; Thu, 07 Nov 2019 10:27:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1s/pB2ltZVbrwh3AuVr5tohVnu6i9/UQN1N5KYjiXdY=; b=kg6TxNxrOWjspWaJsd4vCUiZ0omOD1Q3B7+C6T6C/QscLJqrDm0RWyUj6bsuzEiMRk dAqdZkREUrdWiwQkUyZkmKn8s+82m9z7103L/1V23SOAX93R5qFCgPwUaFlFR9AClbH9 fotUTHXE2HQc5KOb6V/XZg/v1uqHM5Tz/BB/qgo8zDxb1x+fLOiS6rWhlowa8uKeQUKm Umu87xb7SeH8GozLBvDK8ZNbbKSmYgj3HAslDpKy/i7XZp1ZZXNI7Wm58+heFQeOnruP Y0wfc+g3rW2fhOWTa/l+ptjMJ7AiO+CGORwngOpv8GEqGs+C5N4bu4QmEKuMKlfCDiRJ MgCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1s/pB2ltZVbrwh3AuVr5tohVnu6i9/UQN1N5KYjiXdY=; b=N6Q2QL7dLiPAQ4t+RatQDSu2+AE7TxAPfVeaQT/om6f80XAAHuMuVDPt4/jxZmr75b lCLwJz/Cbn5DF6vEIpcd8aCznOE7K6Sg0LKI7v+KxuLeunbGQGQqX2k3/Eg7S0+FECOl tw7NAOAWZK4UKdlPR6NuhEaP28JtlvKvWa2fJiqmxkeefadmQc0RC6L7+sJwEYWNYR0P 5ivfecyDwTslp8NTERFjb1H2X1DPqA94F9MNIAq3x83LTzr30SFb/SR/br7WYKzpsdhN I8R1r1ItkN5+4b98vAr5kbIVXUpmweQrM+8Lz6xXG/lYHL0CPbu9g+yt0J2TRL0XvrTb Vziw== X-Gm-Message-State: APjAAAXE74USKIRogz4G9eLzqS07PqzrGDnF2DGn6WaSo8G27hJakA6W 2rWPYk6pylVMnW/65wY8NQAWSu9B X-Google-Smtp-Source: APXvYqzvry0EM2OekEn9grae/5Vs3hHusafak59/XrSnEzx44QcSCNQJbSvMhxFwKFB3tx9nJ5hZZw== X-Received: by 2002:a5d:4946:: with SMTP id r6mr3545984wrs.155.1573151247467; Thu, 07 Nov 2019 10:27:27 -0800 (PST) Received: from pfiuh02.univ-paris-diderot.fr ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id s9sm2485212wmj.22.2019.11.07.10.27.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 10:27:26 -0800 (PST) From: zimoun To: 38107@debbugs.gnu.org Subject: [PATCH 1/1] configure.ac: Warn about etc/indent-code.el when Emacs is absent. Date: Thu, 7 Nov 2019 19:27:25 +0100 Message-Id: <20191107182725.9919-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38107 Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --- configure.ac | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 689b28d984..599addfe59 100644 --- a/configure.ac +++ b/configure.ac @@ -280,9 +280,14 @@ dnl Documentation translation. AM_MISSING_PROG([PO4A_TRANSLATE], [po4a-translate]) AM_MISSING_PROG([PO4A_UPDATEPO], [po4a-updatepo]) -dnl Emacs (optional), for 'etc/indent-package.el'. -AC_PATH_PROG([EMACS], [emacs], [/usr/bin/emacs]) -AC_SUBST([EMACS]) +dnl Emacs (optional), for 'etc/indent-code.el'. +AC_PATH_PROG([EMACS], [emacs]) +if test "x$EMACS" = x; then + AC_MSG_WARN([Install GNU Emacs to use etc/indent-code.el]) +else + AC_SUBST([EMACS]) + AC_CONFIG_FILES([etc/indent-code.el], [chmod +x etc/indent-code.el]) +fi case "$storedir" in /gnu/store) -- 2.23.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 08 17:56:40 2019 Received: (at 38107-done) by debbugs.gnu.org; 8 Nov 2019 22:56:40 +0000 Received: from localhost ([127.0.0.1]:47906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTDBH-0007e0-Pc for submit@debbugs.gnu.org; Fri, 08 Nov 2019 17:56:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTDBC-0007de-E4 for 38107-done@debbugs.gnu.org; Fri, 08 Nov 2019 17:56:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iTDB7-0001m8-6i; Fri, 08 Nov 2019 17:56:29 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41070 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iTDB6-0004Kb-4p; Fri, 08 Nov 2019 17:56:28 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: [bug#38107] [PATCH 1/1] configure.ac: Warn about etc/indent-code.el when Emacs is absent. References: <20191107182518.9823-1-zimon.toutoune@gmail.com> <20191107182725.9919-1-zimon.toutoune@gmail.com> Date: Fri, 08 Nov 2019 23:56:26 +0100 In-Reply-To: <20191107182725.9919-1-zimon.toutoune@gmail.com> (zimoun's message of "Thu, 7 Nov 2019 19:27:25 +0100") Message-ID: <878soqc6zp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38107-done Cc: 38107-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) zimoun skribis: > --- > configure.ac | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 689b28d984..599addfe59 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -280,9 +280,14 @@ dnl Documentation translation. > AM_MISSING_PROG([PO4A_TRANSLATE], [po4a-translate]) > AM_MISSING_PROG([PO4A_UPDATEPO], [po4a-updatepo]) >=20=20 > -dnl Emacs (optional), for 'etc/indent-package.el'. > -AC_PATH_PROG([EMACS], [emacs], [/usr/bin/emacs]) > -AC_SUBST([EMACS]) > +dnl Emacs (optional), for 'etc/indent-code.el'. > +AC_PATH_PROG([EMACS], [emacs]) > +if test "x$EMACS" =3D x; then > + AC_MSG_WARN([Install GNU Emacs to use etc/indent-code.el]) > +else > + AC_SUBST([EMACS]) > + AC_CONFIG_FILES([etc/indent-code.el], [chmod +x etc/indent-code.el]) > +fi I removed the redundant =E2=80=98AC_CONFIG_FILES=E2=80=99 from the bottom, = adjusted the commit log, and applied. Thanks! Ludo=E2=80=99. From unknown Fri Aug 15 20:28:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Dec 2019 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator