GNU bug report logs - #38097
Add gnome-xyz for themes and shell extensions

Previous Next

Full log

View this message in rfc822 format

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: m.othacehe <at> gmail.com
Cc: 38097 <at> debbugs.gnu.org
Subject: [bug#38097] Add gnome-xyz for themes and shell extensions
Date: Thu, 07 Nov 2019 19:34:23 +0100

[Message part 1 (text/plain, inline)]

> Overall this looks fine, thanks. The indentation of the first patch
> is
> wrong. Also you have several lines hitting the 78 columns limit. You
> need to wrap them manually.
Forgetting to hit TAB, my old nemesis.  I assume this limit counts for
ChangeLog entries too, does it?

> Can you please send an updated version?
Of course.  I've reformatted all three of them and added them again
here as attachments.  I also ran `guix lint` this time with the
formatting checks enabled, as I should have before sending the first
one :)

Regards,

Leo

[0001-gnu-Add-delft-icon-theme.patch (text/x-patch, attachment)]

[0002-gnu-add-gnome-shell-extension-dash-to-dock.patch (text/x-patch, attachment)]

[0003-gnu-add-gnome-shell-extension-noannoyance.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.