GNU bug report logs - #38079
On Windows tramp hangs after server-start is called

Previous Next

Package: emacs;

Reported by: Wanrong Lin <wrglin <at> gmail.com>

Date: Wed, 6 Nov 2019 00:54:02 UTC

Severity: normal

Tags: patch

Fixed in version 27.1

Done: Michael Albinus <michael.albinus <at> gmx.de>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Wanrong Lin <wrglin <at> gmail.com>
Cc: 38079 <at> debbugs.gnu.org
Subject: bug#38079: On Windows tramp hangs after server-start is called
Date: Wed, 06 Nov 2019 18:06:02 +0200
> From: Wanrong Lin <wrglin <at> gmail.com>
> Date: Tue, 5 Nov 2019 19:52:59 -0500
> 
> ;; On Windows, after "server-start" is called, somehow (system-name) 
> will return lower case host name. If the original
> ;; (system-name) returns upper case host name now 
> tramp-restricted-shell-hosts-alist will be out-of-date and cause
> ;; tramp not to function properly.
> (defadvice server-start (after update-restricted-host-list last activate)
>    (setf tramp-restricted-shell-hosts-alist
>          (when (memq system-type '(windows-nt))
>            (list (concat "\\`" (regexp-quote (system-name)) "\\'")))))
> 
> But the proper fix should be to make sure (system-name) always returns 
> the same string consistently. I found it is this sexp in "server-start" 
> function that changes the return value of (system-name):
> 
>        (setq server-process
>          (apply #'make-network-process ....))

Thanks.  However, your proposed solution is very hard to implement
(for boring technical reasons), so my suggestion is for Trump to
compare system names case insensitively, at least on MS-Windows, with
a proper comment to explain why.




This bug report was last modified 5 years and 281 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.