Subject: bug#38079: On Windows tramp hangs after server-start is called

From: Wanrong Lin <[email-masked]>
Date: Wed, 6 Nov 2019 11:50:59 -0500

Yes that can be another way to fix. The downside is we don't know this 
system-name upper/lower case change will cause any surprises somewhere 
else. But I don't understand the underlying difficulty to ensure 
system-name never changes. Thanks for fixing it either way.

Warren

On 11/6/2019 11:06 AM, Eli Zaretskii wrote:
>> From: Wanrong Lin <[email-masked]>
>> Date: Tue, 5 Nov 2019 19:52:59 -0500
>>
>> ;; On Windows, after "server-start" is called, somehow (system-name)
>> will return lower case host name. If the original
>> ;; (system-name) returns upper case host name now
>> tramp-restricted-shell-hosts-alist will be out-of-date and cause
>> ;; tramp not to function properly.
>> (defadvice server-start (after update-restricted-host-list last activate)
>>     (setf tramp-restricted-shell-hosts-alist
>>           (when (memq system-type '(windows-nt))
>>             (list (concat "\\`" (regexp-quote (system-name)) "\\'")))))
>>
>> But the proper fix should be to make sure (system-name) always returns
>> the same string consistently. I found it is this sexp in "server-start"
>> function that changes the return value of (system-name):
>>
>>         (setq server-process
>>           (apply #'make-network-process ....))
> Thanks.  However, your proposed solution is very hard to implement
> (for boring technical reasons), so my suggestion is for Trump to
> compare system names case insensitively, at least on MS-Windows, with
> a proper comment to explain why.