From unknown Sat Aug 09 15:56:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#38044 <38044@debbugs.gnu.org> To: bug#38044 <38044@debbugs.gnu.org> Subject: Status: 27.0.50; There should be an easier way to look at a specific vc commit Reply-To: bug#38044 <38044@debbugs.gnu.org> Date: Sat, 09 Aug 2025 22:56:48 +0000 retitle 38044 27.0.50; There should be an easier way to look at a specific = vc commit reassign 38044 emacs submitter 38044 Lars Ingebrigtsen severity 38044 wishlist tag 38044 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 03 10:17:16 2019 Received: (at submit) by debbugs.gnu.org; 3 Nov 2019 15:17:16 +0000 Received: from localhost ([127.0.0.1]:34839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRHcx-0003hs-Nu for submit@debbugs.gnu.org; Sun, 03 Nov 2019 10:17:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:50887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRHcu-0003g2-JO for submit@debbugs.gnu.org; Sun, 03 Nov 2019 10:17:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41898) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRHct-0003DA-7r for bug-gnu-emacs@gnu.org; Sun, 03 Nov 2019 10:17:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRHcs-0005ug-5w for bug-gnu-emacs@gnu.org; Sun, 03 Nov 2019 10:17:11 -0500 Received: from quimby.gnus.org ([80.91.231.51]:39030) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iRHcr-0005uY-Vi for bug-gnu-emacs@gnu.org; Sun, 03 Nov 2019 10:17:10 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iRHco-0006qo-4e for bug-gnu-emacs@gnu.org; Sun, 03 Nov 2019 16:17:08 +0100 From: Lars Ingebrigtsen To: bug-gnu-emacs@gnu.org Subject: 27.0.50; There should be an easier way to look at a specific vc commit Date: Sun, 03 Nov 2019 16:17:05 +0100 Message-ID: <87ftj5at1q.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.231.51 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Often when discussing code changes, people will send an email saying something like "this was fixed by ", but Emacs doesn't have a convenient way to display that. For that case, Emacs should have a command that prompts for an ID (defaulting to the ID under point), and then (unless default-directory is already in a vc-controlled directory), prompts for the directory to look for that ID, and then display the commit. Stefan M also commented: > It's worse: if the commit is not in the current branch it won't be > listed at all, and `C-x v L` doesn't let you show the log corresponding > to another branch. > > If `C-x v l` accepted a C-u to specify the "revision" for which to show > the log, then it would solve both problems: you could get the log > of other branches and you could see the commit message and the diff of > a specific REVision with: > > C-u C-x v l RET > followed by hitting `D` on the first element to see the diff This would be a separate change, because it can also be useful to see a commit in context. In GNU Emacs 27.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.5) of 2019-11-01 built on marnie Repository revision: eda98211e31ed969823c1048b3cde635e08eebe5 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 03 10:43:20 2019 Received: (at 38044) by debbugs.gnu.org; 3 Nov 2019 15:43:20 +0000 Received: from localhost ([127.0.0.1]:34856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRI2B-0004U7-P9 for submit@debbugs.gnu.org; Sun, 03 Nov 2019 10:43:20 -0500 Received: from mout.gmx.net ([212.227.17.22]:33369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRI29-0004Tr-Ak for 38044@debbugs.gnu.org; Sun, 03 Nov 2019 10:43:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1572795790; bh=yX4UaxTPE5N6en0fl6F22xN0rCf+oHJ+kqDPU92nYh8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=TtvqAbJC8AA/6QFWQ8UoNC3ssWeg5F1gfGD4qkg2Uc8V6IVnQTFRgh7JaiFKafmyp nfYBxVgXZD2F7sykRgvoLcDmtgvW6QfZSQSbLpX9YIHtcXn4/GN3XRmanJAUaCgF6v W63jjjHc2YN6JzuY5lGfVYJrjZZ7JlUDz81uvQxY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-lfs84 ([178.6.96.234]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M1ps8-1iP6Ag2k1Y-002Egt; Sun, 03 Nov 2019 16:43:10 +0100 From: Stephen Berman To: Lars Ingebrigtsen Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> Date: Sun, 03 Nov 2019 16:43:08 +0100 In-Reply-To: <87ftj5at1q.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 03 Nov 2019 16:17:05 +0100") Message-ID: <87r22phsoj.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:O6AtYyBLYFvNYkaDQ1LeKoaQRA9JPek8vy3dJTgl8kL1VuIkKkg crrdAV01ePOmb8dU9opVNcFtKtdzK8CWtIqPcvz5nbf+g0lic786hdHr9oN40gYGpezdSxE MZ4kvZWSzkYm92UqZqqZeFgfsQqmUQbuCaJivCf8ey9aD6gLClHAE3XGbCXKe4u+mLQh7Sd q0/i5uy0siwx2JYizfd4w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:SBuMCSQjlnk=:uNHex5wthWMcbdG5j70wU6 4Sg+1+RLAfdGzgvLzBnTvlknfh3+IHNB9pZ3qWg3ILu7SFl/CDgbeVkfJ/g0URcqdEzLjCrcp SHxyCLUdwjNs7m55m5HMzlBL2oC+tZU2qhCIaq2uRj3YVtMO2DQET/AOhRKlXtOzb9VVWqiMK 5sOlFPfdV2eCMRBGBD/MfaodF6snvgusUhFDP+pK/Bg1Iyq0zSX5wfln6YGbA80SBU2/UU6Sg mDW8XaUtmvvKEN5UNIMXvyjRb9txcsB8YKGXPteSDnDKoWK+5j20mqJOkDxd676laDbF1HMAp PYzvPt78Wb/NUFIXAV1aCuaLsZAiuHSPwuPRy4Qqf98RpstB9d5j8PI8lCtSdIeSc7ewVir9C FeQ9CDRJqKRjh3S2JaRtIiZ/Kth0xsghMezlx2a8U3t0ex3iXPgGyw7ea+KKF4Xq6wZdKwt68 4xy7BumYiOrRVCeH0zER5txLNBMVucIde+eL6jaPv6wXnoSYYuNgr2TZ+fdpCCUm1vGwYZS4a tjcXds/f5l8WYFE+oXDC2M+LldpjkLKDfwr8gB+HJHPEEqNlLeMXTTWRIutU8kG4t3CLrlPPx 22tUhwxdbDsoaaXhq0oRbqpxb25xLDBzRc1egz7ikd5cUncKlChzq0reqhLTO4Vg3WetikIV9 eE0JU13mNH68KHqcpc7LywVZms2qnjq3nmqXYor8cY9NU6AyuRoAhbE8e7bDXMVGqkRTq2ftb Rek6lKo5ug77yF7BdUA/XIjlIxTVgfwE2ZIXDlZR9GUiBUhaGP1+aLNNVvg/9nWcIMWtjCr5W LVyOC6v46oVGD7HIOnZNP4nvYjwHZCeFm9t/KG1DC6C0xYCioETqPrm+oQRmRGp5uiqCRDlPE wQtsk64PLQx+yEW+TbVfbh/7Y6200nk32tbSIKzW6AzF0AcIoE9EKDvRNNggS6JIXXzgJwMpn KXjgc/MenGA0QreZXc1dSavXGRdy+TI67ASrxMH3dS6q0Dr1TnRqQgDqUbUZRlRdr0Iz89flt Xc1XR87cHkSqMD6VwR+sX431PXCkMk+4yPL/jNBP1lRpQBqBqBfX40clBW7OW6Xvza08NhrSX SbVR/ulZFvyBF1he9OoRlM5QKfBEJ9d+iCHEfS+PJ3oPYSls/6VNWeJ2efDQokdrKa7ylF9SS dfPF1lF3gpBHoP3in+9AD6fFRPCW8fPcZblaR5FJIXQLXHpDuz15B8QYdH6CLiol+glxKHVF6 ODCMLANTaYfxcGUzVMJcDG7arVa2v+qY92DTzrrUxojtdUoxsXfBRAgynQP0= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38044 Cc: 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, 03 Nov 2019 16:17:05 +0100 Lars Ingebrigtsen wrote: > Often when discussing code changes, people will send an email saying > something like "this was fixed by ", but Emacs doesn't have a > convenient way to display that. > > For that case, Emacs should have a command that prompts for an ID > (defaulting to the ID under point), and then (unless default-directory > is already in a vc-controlled directory), prompts for the directory to > look for that ID, and then display the commit. I wrote such a command (appended below) for my own use, but it's git-specific and I don't know the innards of VC well enough to adapt it, which is why I haven't proposed it for inclusion in Emacs. Maybe some of it could be used for a VC command. Steve Berman (defun srb-git-log (&optional repo commit) "Check REPO for COMMIT and if it exists, display its commit message. Interactively, prompt for REPO, defaulting to emacs-master, and for COMMIT, defaulting to the commit hash at point. If called with a prefix argument `C-u', show the commit diff in addition to the commit message." (interactive "P") (let* ((show (equal current-prefix-arg '(4))) (git-dir (if repo (read-directory-name "Repo: " "~/src/emacs/" nil t "emacs-master") "~/src/emacs/emacs-master")) (commit0 (substring-no-properties (or commit (read-string "Commit: " nil nil (word-at-point))))) (default-directory git-dir) (output-buffer (get-buffer-create "*git log*")) (args (split-string (mapconcat #'concat (if show `("show" ,commit0) `("log" "-1" ,commit0)) " "))) ;; FIXME: output of `git branch --contains' can be ambiguous (even ;; when `git log isn't, because one hash is for a commit, one for a ;; tree?). Can use `git rev-parse --disambiguate=' to find matching ;; full hashes. (proc (progn (with-current-buffer output-buffer (erase-buffer)) (call-process "git" nil output-buffer nil "branch" "--contains" commit0)))) (when proc (with-current-buffer output-buffer (goto-char (point-min)) (unless (looking-at "[ *]") (user-error "%s is not on branch %s" commit0 (file-name-base git-dir))) (insert "Branches:\n") (goto-char (point-max)) (apply #'call-process "git" nil output-buffer nil args) (when show (with-current-buffer output-buffer (diff-mode))) (pop-to-buffer output-buffer))))) From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 03 15:31:24 2019 Received: (at 38044) by debbugs.gnu.org; 3 Nov 2019 20:31:24 +0000 Received: from localhost ([127.0.0.1]:35174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRMWx-0003jK-OA for submit@debbugs.gnu.org; Sun, 03 Nov 2019 15:31:23 -0500 Received: from cheetah.birch.relay.mailchannels.net ([23.83.209.34]:15856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRMWu-0003j8-HR for 38044@debbugs.gnu.org; Sun, 03 Nov 2019 15:31:21 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6CC415A0CCF; Sun, 3 Nov 2019 20:31:19 +0000 (UTC) Received: from pdx1-sub0-mail-a83.g.dreamhost.com (100-96-187-103.trex.outbound.svc.cluster.local [100.96.187.103]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id CA2DB5A0C79; Sun, 3 Nov 2019 20:31:18 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a83.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sun, 03 Nov 2019 20:31:19 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Ruddy-Wiry: 7ff467485778fb35_1572813079067_4077534863 X-MC-Loop-Signature: 1572813079066:3475094053 X-MC-Ingress-Time: 1572813079066 Received: from pdx1-sub0-mail-a83.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a83.g.dreamhost.com (Postfix) with ESMTP id C952482D8C; Sun, 3 Nov 2019 12:31:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=xVDydxXepWwABDcL4eT07vhA34k=; b= xIEYBZy2SqEiAjPC7oa6l7uY2oOONBZpfKOqYWRfUdihoQIdZwh5HgEh9RdPUWk9 R0xnmivyUrBwQ+lU/Fy24rOnYLo+fAhXnPB+qV8UE8m+p7xwgrGSZvjsYR5wlUfK 7TxZl0qasRjMwGc1gGNqCrW4d7QHr+w3j/NrJVDR4k0= Received: from mail.jurta.org (m91-129-101-77.cust.tele2.ee [91.129.101.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a83.g.dreamhost.com (Postfix) with ESMTPSA id 1DB7682D8D; Sun, 3 Nov 2019 12:31:10 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a83 From: Juri Linkov To: Stephen Berman Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> Date: Sun, 03 Nov 2019 22:16:51 +0200 In-Reply-To: <87r22phsoj.fsf@gmx.net> (Stephen Berman's message of "Sun, 03 Nov 2019 16:43:08 +0100") Message-ID: <87bltslnpo.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: Lars Ingebrigtsen , 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> For that case, Emacs should have a command that prompts for an ID >> (defaulting to the ID under point), and then (unless default-directory >> is already in a vc-controlled directory), prompts for the directory to >> look for that ID, and then display the commit. > > I wrote such a command (appended below) for my own use, but it's > git-specific and I don't know the innards of VC well enough to adapt it, > which is why I haven't proposed it for inclusion in Emacs. Maybe some > of it could be used for a VC command. It should be easy to add a command properly integrated into the innards of VC by just grepping for "log-search" in lisp/vc/vc*.el (there are only 7 matches), and after copying to replace "log-search" with "log-show", and the new command is ready. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 13 16:49:48 2019 Received: (at 38044) by debbugs.gnu.org; 13 Nov 2019 21:49:48 +0000 Received: from localhost ([127.0.0.1]:60255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iV0WK-0007oV-0T for submit@debbugs.gnu.org; Wed, 13 Nov 2019 16:49:48 -0500 Received: from dog.birch.relay.mailchannels.net ([23.83.209.48]:11061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iV0WH-0007oM-I0 for 38044@debbugs.gnu.org; Wed, 13 Nov 2019 16:49:46 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6C13A2122F; Wed, 13 Nov 2019 21:49:44 +0000 (UTC) Received: from pdx1-sub0-mail-a44.g.dreamhost.com (100-96-60-110.trex.outbound.svc.cluster.local [100.96.60.110]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E976D21E95; Wed, 13 Nov 2019 21:49:43 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a44.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 13 Nov 2019 21:49:44 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Vacuous-Wipe: 08d0671549c4c1f3_1573681784217_2400347332 X-MC-Loop-Signature: 1573681784217:3761484787 X-MC-Ingress-Time: 1573681784217 Received: from pdx1-sub0-mail-a44.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTP id E9F5485225; Wed, 13 Nov 2019 13:49:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=KcX/3+ASO/WCAf/qJb3nbPz2LKA=; b= zY8eRElqkVvP3XTz4evgZrHwkFLbX6qLXR/0CMrLEJtHykblmzEF8+9Pofkhr54l XXdBOO0R1jT4pluMw8YZQDxyTDo9nwe29+fn2gw6OY28HRcpJ4aH0UR9PBqA3fQb BbLrhpzSfdu1CbDQ6ig+FLeWpd4DFLF9I35o58UYcQ0= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTPSA id 128C485224; Wed, 13 Nov 2019 13:49:38 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a44 From: Juri Linkov To: Stephen Berman Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> Date: Wed, 13 Nov 2019 23:03:27 +0200 In-Reply-To: <87bltslnpo.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 03 Nov 2019 22:16:51 +0200") Message-ID: <87d0dvmqu8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: Lars Ingebrigtsen , 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> For that case, Emacs should have a command that prompts for an ID >>> (defaulting to the ID under point), and then (unless default-directory >>> is already in a vc-controlled directory), prompts for the directory to >>> look for that ID, and then display the commit. >> >> I wrote such a command (appended below) for my own use, but it's >> git-specific and I don't know the innards of VC well enough to adapt it, >> which is why I haven't proposed it for inclusion in Emacs. Maybe some >> of it could be used for a VC command. > > It should be easy to add a command properly integrated into the innards of VC > by just grepping for "log-search" in lisp/vc/vc*.el (there are only 7 matches), > and after copying to replace "log-search" with "log-show", and the new command > is ready. Actually "log-show" is a bad name. It's too git-specific OT1H, and OTOH it's too general since its output varies that doesn't fit to log-view-mode. I hoped git would be able to search both sha and commit message in one command, something like: git log -1 5761a1a393 --grep=5761a1a393 to output the log of sha 5761a1a393, and logs of matching commit messages, but this is not possible in git. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 16 16:07:47 2019 Received: (at 38044) by debbugs.gnu.org; 16 Nov 2019 21:07:47 +0000 Received: from localhost ([127.0.0.1]:39782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iW5IG-0005j8-Nc for submit@debbugs.gnu.org; Sat, 16 Nov 2019 16:07:46 -0500 Received: from brown.birch.relay.mailchannels.net ([23.83.209.23]:35169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iW5IE-0005iz-GZ for 38044@debbugs.gnu.org; Sat, 16 Nov 2019 16:07:43 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 85D546A1730; Sat, 16 Nov 2019 21:07:41 +0000 (UTC) Received: from pdx1-sub0-mail-a75.g.dreamhost.com (100-96-92-164.trex.outbound.svc.cluster.local [100.96.92.164]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 257BF6A1638; Sat, 16 Nov 2019 21:07:41 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a75.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sat, 16 Nov 2019 21:07:41 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Cooing-Towering: 2f7b2d722d90c5b7_1573938461377_1542986650 X-MC-Loop-Signature: 1573938461377:3681637371 X-MC-Ingress-Time: 1573938461377 Received: from pdx1-sub0-mail-a75.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTP id DC5E07F6FA; Sat, 16 Nov 2019 13:07:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=vqbpbJ4EeHeJXmPVmnqhfPPtrzE=; b= IiWeNGrei5MdlGv9nJaq4059iz5FN5DuauhFMA5RPw0DdbHhtVgVfFFcuKRauCre 4XggnZEj8nHNSBSGRySUhWo2VKvY7xSWvg4yd+3t8V0YR1UM8hwtDrYbgN0nemEO PK3JegrAPJtaMoAj2n2d7J8aQJbJLLHeNUVRn3N5n3g= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTPSA id C9E4C7F702; Sat, 16 Nov 2019 13:07:33 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a75 From: Juri Linkov To: Stephen Berman Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> Date: Sat, 16 Nov 2019 22:31:14 +0200 In-Reply-To: <87d0dvmqu8.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 13 Nov 2019 23:03:27 +0200") Message-ID: <875zjjr8f1.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: Lars Ingebrigtsen , 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I hoped git would be able to search both sha and commit message > in one command, something like: > > git log -1 5761a1a393 --grep=5761a1a393 > > to output the log of sha 5761a1a393, and logs of matching commit messages, > but this is not possible in git. We could support a special syntax for sha search, e.g. M-x vc-log-search RET sha:5761a1a393 RET or using quoted strings as sha search instead of text search: M-x vc-log-search RET "5761a1a393" RET or add a rule that if the search string matches only hex numbers with a regexp like /[0-9A-F]+/, then run sha search: M-x vc-log-search RET 5761a1a393 RET and any other text will run text search: M-x vc-log-search RET text RET From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 06:53:18 2019 Received: (at 38044) by debbugs.gnu.org; 17 Nov 2019 11:53:18 +0000 Received: from localhost ([127.0.0.1]:40427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWJ7G-0001Vk-2j for submit@debbugs.gnu.org; Sun, 17 Nov 2019 06:53:18 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:35481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWJ7E-0001VW-Do for 38044@debbugs.gnu.org; Sun, 17 Nov 2019 06:53:16 -0500 Received: by mail-wr1-f47.google.com with SMTP id s5so16192621wrw.2 for <38044@debbugs.gnu.org>; Sun, 17 Nov 2019 03:53:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j+VRmZB3WL3mCkNM1zfOtKx7WU75SQt76V7tcOjDsyE=; b=e8v1st9aEjTC6ctvw7vtaotLtYTb8use9noeQUQaDJIAlbqkhTO42hv06mmyaxi2Vj 1FI35DPjwZESqIZYxcgGpaVn8Mf24b499tQbzPAZJLKPiLsYLrorkDJMMPszs7Ns6VV0 MQzhVK7k0d7a+cCscjiB10OAVSI1FeFsXQKH7UIoJoMehQfz5+wa+/P74fvAAEREfJwU iGQDzBRZycpGDqAqDzdNbtAj9/kE+HO7sE3KNkytfodK+KKs8Y2zGjtd5ZjUUOkPd04l /KGDEeg9kk99l+IyYf94T3Ee40vkX9V5avXaynQQYfaidAWQwvJJSnjuF/ffViSKWZkv lGjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j+VRmZB3WL3mCkNM1zfOtKx7WU75SQt76V7tcOjDsyE=; b=TqKj7faPKrPWfxh9FsTC98Xvqarpv8yG098M47+4IHNFmOjlOKMI7R7tDHCQXQQ8AS pu6HSeuuta1piy+pmMii7ObbjRk8au0mf9Rfj+kz/HZabCrMIXP4YAzh1GFEWaSKjOL9 R09JvLq7LeokwF8xZZfhivRz/69q+lfoFJLxNwuZQL+XeFfcAkxlB6oZbEl+BXf5Cz+e YWgRXpPbhAagGCmMWkDnNrWekQSoOSqeMWYGxnmt+xik2XZPbsEVfqXNYPCN9G+PSjsb XUdNgDrjNO0raQRk8zCxuTwcD8xzS3+eT+vgaW+oQ6lBnG2eHpS1kiPR7FtPUQAJrdCG tyMQ== X-Gm-Message-State: APjAAAXc9c55l79vjX9IE0u2hgQVhRT+UwSpEVbLn5w/bKkUypU0ND3h BwT3t+VQFSdWnQx5yFUjytsO93snMl0= X-Google-Smtp-Source: APXvYqyByAddpYgnizxxMwkNI1SpglyruqDHaEVgLZ9Jgt/+ibZ8fXvNsO/WRBaN5ENGBAjG5sVBOQ== X-Received: by 2002:adf:f147:: with SMTP id y7mr17561966wro.236.1573991590178; Sun, 17 Nov 2019 03:53:10 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id o5sm18568232wrx.15.2019.11.17.03.53.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Nov 2019 03:53:09 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Juri Linkov , Stephen Berman References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> Date: Sun, 17 Nov 2019 13:53:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87d0dvmqu8.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: Lars Ingebrigtsen , 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 13.11.2019 23:03, Juri Linkov wrote: > Actually "log-show" is a bad name. It's too git-specific OT1H, > and OTOH it's too general since its output varies that doesn't fit > to log-view-mode. Git's log output is flexible, isn't it? It can be changed using a template. > I hoped git would be able to search both sha and commit message > in one command, something like: > > git log -1 5761a1a393 --grep=5761a1a393 > > to output the log of sha 5761a1a393, and logs of matching commit messages, > but this is not possible in git. It's feasible: just call Git twice and concat the results. But I don't think it's a good idea to mix the results of two different searches. I think there should be two of them. But there could be an extra -dwim- command that makes the choice based on the word under point (and whether it's hexinumeric). From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 16:31:52 2019 Received: (at 38044) by debbugs.gnu.org; 17 Nov 2019 21:31:52 +0000 Received: from localhost ([127.0.0.1]:42811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWS99-0002Oy-WF for submit@debbugs.gnu.org; Sun, 17 Nov 2019 16:31:52 -0500 Received: from aye.elm.relay.mailchannels.net ([23.83.212.6]:40520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWS97-0002Op-Gb for 38044@debbugs.gnu.org; Sun, 17 Nov 2019 16:31:50 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 2A9045A071C; Sun, 17 Nov 2019 21:31:48 +0000 (UTC) Received: from pdx1-sub0-mail-a42.g.dreamhost.com (100-96-6-199.trex.outbound.svc.cluster.local [100.96.6.199]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B2BBB5A0767; Sun, 17 Nov 2019 21:31:47 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a42.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sun, 17 Nov 2019 21:31:48 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Wipe-Plucky: 43938f3a2ce87068_1574026307967_3230883832 X-MC-Loop-Signature: 1574026307967:3284610698 X-MC-Ingress-Time: 1574026307967 Received: from pdx1-sub0-mail-a42.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a42.g.dreamhost.com (Postfix) with ESMTP id 5971E8014F; Sun, 17 Nov 2019 13:31:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=5ZavlnHdN7FFng3oUt60ILqmbRY=; b= C3jMLNl5fzgdH9vsHymXshr1X97T3VpIa/a8wJygOxHCz5lhd/+GM/Hi13Zr5OWP HFRytPkkzEG0OVdrMSpOYs81W4SwN3k7WmfJzJx7pXm6Tt5ppzq60e4nTCJC4Ax9 qSGX5sepfBjKE0B8rhJoKA8QZJ7VXgpN2g4CQQmYsM4= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a42.g.dreamhost.com (Postfix) with ESMTPSA id BD7CE8015C; Sun, 17 Nov 2019 13:31:39 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a42 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> Date: Sun, 17 Nov 2019 23:20:17 +0200 In-Reply-To: <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> (Dmitry Gutov's message of "Sun, 17 Nov 2019 13:53:07 +0200") Message-ID: <87r226xl8m.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: Lars Ingebrigtsen , Stephen Berman , 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > But I don't think it's a good idea to mix the results of two different > searches. I think there should be two of them. But there could be an > extra -dwim- command I agree than dwim would be better. But what a hint to use for deciding on showing a commit by sha instead of matching it in the commit messages? > that makes the choice based on the word under point > (and whether it's hexinumeric). Making the choice whether the word is hexinumeric doesn't look too unambiguous. What if the user wants to search a hexinumeric word in the text of commit messages? For example, searching for "5761a1a393" to find messages that contain "Revert commit 5761a1a393 ..." From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 16:58:47 2019 Received: (at 38044) by debbugs.gnu.org; 17 Nov 2019 21:58:47 +0000 Received: from localhost ([127.0.0.1]:42851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWSZC-00034t-Qx for submit@debbugs.gnu.org; Sun, 17 Nov 2019 16:58:47 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:39545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWSZ4-00034W-N1 for 38044@debbugs.gnu.org; Sun, 17 Nov 2019 16:58:46 -0500 Received: by mail-wr1-f48.google.com with SMTP id l7so17174139wrp.6 for <38044@debbugs.gnu.org>; Sun, 17 Nov 2019 13:58:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zmbzywdqcBfzv77reecYhCvFITY2hXVCn/famU3Weg4=; b=cBC58gMl1PngBBe9HVdC8iBOZzxEcUAIamnCjOHcI01b1PmVnWTPfC4K5R7LcuAlVh TseZrnKQDJNxKPZdOHgx9lh9zsuVqDIrdgBsY4Wdr0q323aMQkD4pbNUVOAPAxNnYIte EzwWfqwqkPF1ysaPXnk+MGT2NPQXUk5XSuZU4cAm07p91ZnQJxh5VkBvgg1U4XENsw9G VZTsM1QioIoHndjBvAJJIzDhjXfz/HdE+n6tHAYc9RnN62od+7PoBdmqW/C7f9qUyRWR yRXJCkhfi/dmsjCy5Jc8StfiCe5hSpJ51oKdXxSkWgduptOjtGqBeBr/MZTjXHELhSRI Xh+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zmbzywdqcBfzv77reecYhCvFITY2hXVCn/famU3Weg4=; b=gmy8atRv38SPcsmisDofHktb7yd5ihw8UmSsHinfU0uSL7GDcQpdu+jNGnToDQBGi/ 3TlfIf7KAJxbWSe72tAEYGbhcRdvqtfnv5a7uIi7a2W1KJoV+2Y3wcvwDRRbHaVqON4f 8YQ1WLalbrtK/nEamc14Vo2ZNR3vaDe3rwKIkiPv86nP4bPM8FT9p8pXv7jphGOmccdq BPPmntlSDC7xw9reaJgQlAKNcF1FSHLcr7T9bzt0brPZkvE65TCyAX7YLqVhhuAfcuog mbU6Ra0zTIXNJoDgIvTioqzQ/QB6gxpVN9RN/q1YQhdJzoKZPwoLuii5kWTs+2aF0ofz 25Lg== X-Gm-Message-State: APjAAAU3lZiyk3Azj8NFC076RriRa7pgn2r4THV2dg4AtKDsqnk3luGf VF0joFo7XuHEmb3rm5HktpXpXdb4BE4= X-Google-Smtp-Source: APXvYqz5IYTLqXScw6FgAKn/VwFn4iDe9wa6y/OpoioBJe+vZtldhWjgkTPFAy85k+YLq4WsW0TWrA== X-Received: by 2002:adf:f9c4:: with SMTP id w4mr25878856wrr.88.1574027912552; Sun, 17 Nov 2019 13:58:32 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id l4sm17917976wml.33.2019.11.17.13.58.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Nov 2019 13:58:32 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Juri Linkov References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> Date: Sun, 17 Nov 2019 23:58:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87r226xl8m.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 38044 Cc: Lars Ingebrigtsen , Stephen Berman , 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 17.11.2019 23:20, Juri Linkov wrote: > Making the choice whether the word is hexinumeric doesn't look too > unambiguous. What if the user wants to search a hexinumeric word > in the text of commit messages? For example, searching for "5761a1a393" > to find messages that contain "Revert commit 5761a1a393 ..." Then they would call one of the non-dwim commands. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 18:04:04 2019 Received: (at 38044) by debbugs.gnu.org; 17 Nov 2019 23:04:04 +0000 Received: from localhost ([127.0.0.1]:42908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWTaN-0006bs-N2 for submit@debbugs.gnu.org; Sun, 17 Nov 2019 18:04:04 -0500 Received: from dog.birch.relay.mailchannels.net ([23.83.209.48]:5896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWTaL-0006bS-Pp for 38044@debbugs.gnu.org; Sun, 17 Nov 2019 18:04:02 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 420765008EE; Sun, 17 Nov 2019 23:04:00 +0000 (UTC) Received: from pdx1-sub0-mail-a52.g.dreamhost.com (100-96-196-51.trex.outbound.svc.cluster.local [100.96.196.51]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C54BE5005A0; Sun, 17 Nov 2019 23:03:59 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a52.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sun, 17 Nov 2019 23:04:00 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Illegal-Celery: 73fe28023269805b_1574031840054_1250324939 X-MC-Loop-Signature: 1574031840054:3861742250 X-MC-Ingress-Time: 1574031840053 Received: from pdx1-sub0-mail-a52.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a52.g.dreamhost.com (Postfix) with ESMTP id C19CF8189E; Sun, 17 Nov 2019 15:03:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=o/nlOvXR/ocYnyqGtvmzhPaokVY=; b= Rb/MxEHvflO55CofhjknbJ5k9MbBW6t5pNzwFP9h53/oC84a7kcJQazXWX8gwd7z sw+KPRLqRtmWZ01gWnm5RGAPjl0UxgqOqIrrJsIXbU8/yeMsdsOdx1XjBRqMav3V 6aoM/kKBVb88jSljN8rof/tK8HsYw/uM76MfZcVhqIk= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a52.g.dreamhost.com (Postfix) with ESMTPSA id E3BCB818A5; Sun, 17 Nov 2019 15:03:51 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a52 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> Date: Mon, 18 Nov 2019 00:36:11 +0200 In-Reply-To: <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> (Dmitry Gutov's message of "Sun, 17 Nov 2019 23:58:30 +0200") Message-ID: <87pnhquo4k.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: Lars Ingebrigtsen , Stephen Berman , 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Making the choice whether the word is hexinumeric doesn't look too >> unambiguous. What if the user wants to search a hexinumeric word >> in the text of commit messages? For example, searching for "5761a1a393" >> to find messages that contain "Revert commit 5761a1a393 ..." > > Then they would call one of the non-dwim commands. Then no dwim command is needed. We'll just add vc-log-revision and done. The user will decide whether to use vc-log-search to search in commit messages, or vc-log-revision to show the log message of one commit. If adding a new command is not desirable, then add a prefix to existing. 'C-x v L' already uses a prefix arg to prompt for LIMIT, that can be 1. Another prefix arg could ask for a revision, e.g. 'C-u C-u C-x L 5761a1a393'. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 18:19:32 2019 Received: (at 38044) by debbugs.gnu.org; 17 Nov 2019 23:19:33 +0000 Received: from localhost ([127.0.0.1]:42918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWTpM-0006xD-Is for submit@debbugs.gnu.org; Sun, 17 Nov 2019 18:19:32 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:35935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWTpK-0006x0-G3 for 38044@debbugs.gnu.org; Sun, 17 Nov 2019 18:19:31 -0500 Received: by mail-wr1-f54.google.com with SMTP id r10so17318126wrx.3 for <38044@debbugs.gnu.org>; Sun, 17 Nov 2019 15:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4hdRvj0tT3dZAkWUgUhPRbJiPSo9fs6Z5YWQEy8R2Dk=; b=P2hSmln+hEhOPwl6TBOe8UNx3YKYfXciZGODWoAZvNKJBRPwXWdA+zq5b5GoOwd9NR AiffncSI5JcYX486KQX/Uo+KN8uYvh1qof8pAciw3i1BQ1sEUm5sXSOo7Cdbg5G0TKsW vPcR8S3dS1BV9PtKUB8g+qdg/HJItFT/F4J2EHzvfVgE58NKD61fmPe919asKKrWhGX2 +Ze/Yh8v0u5fUSAfXWCgWsgbJ882QjiXs+UDQVK7pYQcf8kvUy3rp8AY3XC0Okj2g1FP QH2GWbM4qVVQT3qtCnzpky6vo1V8OPkdXPZ7gj4OBOEOIWIVXkW3J/1i/g2zqevJOD7W xPZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4hdRvj0tT3dZAkWUgUhPRbJiPSo9fs6Z5YWQEy8R2Dk=; b=FK88dA7pZg2H/E0elW3owfiX1HxMxRLklWJfTwQhbuCl+SWZMnpDGGdljjP06vvO0W /1qeVtQzJTywptqA3mal4te6yti3bCDEW/+489N7EXAwxqsrQ8X9yRE6W5sxw2JcQvOg 1Ilzsv2P1d7RbV+VGJYJYkGiYD7rorJOfhYd96nRtVFTm/pQBWA7Q7yy1zVBE6Zig9GW ipJnRJMb9pnLeD0/A7SWHsG7ZZx2OR++RcQWWbUt8fH1RIF11DHBGUjTYT/3QRUxZSD/ 2zwwM3c2upa4pu2fcpLqwUw+rXh42gW/46NdP9KaIh93mTDX1omcI03MNGxNVkVOIQw8 cVKw== X-Gm-Message-State: APjAAAU1DflGtTFWQtHCTwNpPL1fUyjICoH2WMIpMp59a6/mvaXhV4Dt +bTSNlhypvelcFPhmKTCvstaxr7BFZs= X-Google-Smtp-Source: APXvYqxuo4jV+Zj9Kw14QwBPbOPmDamZndjuAsmSylUjl/gML82tdvZy2wahtoURb7tYp+BJH5xQdQ== X-Received: by 2002:adf:fd84:: with SMTP id d4mr12630258wrr.152.1574032764286; Sun, 17 Nov 2019 15:19:24 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id a17sm7279708wrs.33.2019.11.17.15.19.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Nov 2019 15:19:23 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Juri Linkov References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> Date: Mon, 18 Nov 2019 01:19:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87pnhquo4k.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 38044 Cc: Lars Ingebrigtsen , Stephen Berman , 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 18.11.2019 0:36, Juri Linkov wrote: > Then no dwim command is needed. We'll just add vc-log-revision and done. > The user will decide whether to use vc-log-search to search in commit > messages, or vc-log-revision to show the log message of one commit. I'm fine with having two commands. Having a '-dwim-' one could save on key bindings, but we don't have one for vc-log-search anyway. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 16:52:22 2019 Received: (at 38044) by debbugs.gnu.org; 18 Nov 2019 21:52:22 +0000 Received: from localhost ([127.0.0.1]:46373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWowX-0005HH-Nb for submit@debbugs.gnu.org; Mon, 18 Nov 2019 16:52:22 -0500 Received: from bongo.elm.relay.mailchannels.net ([23.83.212.21]:46673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWowV-0005H9-PU for 38044@debbugs.gnu.org; Mon, 18 Nov 2019 16:52:20 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7ABC33C0782; Mon, 18 Nov 2019 21:52:18 +0000 (UTC) Received: from pdx1-sub0-mail-a6.g.dreamhost.com (100-96-169-13.trex.outbound.svc.cluster.local [100.96.169.13]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 036D63C06C6; Mon, 18 Nov 2019 21:52:18 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a6.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Mon, 18 Nov 2019 21:52:18 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Grain-Belong: 32d497b533ccfb1f_1574113938284_3139119331 X-MC-Loop-Signature: 1574113938284:962268052 X-MC-Ingress-Time: 1574113938284 Received: from pdx1-sub0-mail-a6.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTP id C63CAA7010; Mon, 18 Nov 2019 13:52:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=2I0ovwI4MKDnXUWwh4jik2LCv0k=; b= ux325V38VERgWENE31FuagdUvR42zugfhHLVPSU0BD9/COlNVua7M8E3Wl76MZdL 7bD0DclidZguMEPl7siTX8HUssjEucqZrXjzJORvkV+MfborLg+/QJDlZ/Ir5cMt oJ/HRE90B5A9iKT9hN8iimku2GYq86soCumQEIV68GM= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTPSA id 20EAFA7014; Mon, 18 Nov 2019 13:52:04 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a6 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> Date: Mon, 18 Nov 2019 23:31:50 +0200 In-Reply-To: <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> (Dmitry Gutov's message of "Mon, 18 Nov 2019 01:19:20 +0200") Message-ID: <877e3wub09.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: Lars Ingebrigtsen , Stephen Berman , 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain >> Then no dwim command is needed. We'll just add vc-log-revision and done. >> The user will decide whether to use vc-log-search to search in commit >> messages, or vc-log-revision to show the log message of one commit. > > I'm fine with having two commands. Having a '-dwim-' one could save on key > bindings, but we don't have one for vc-log-search anyway. Ok, here is a new command vc-log-revision: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-log-revision.patch diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 5ab8e7ec53..f379c3d890 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1189,7 +1189,7 @@ vc-git-log-incoming "@{upstream}" remote-location)))) -(defun vc-git-log-search (buffer pattern) +(defun vc-git-log-search (buffer pattern &optional limit) "Search the log of changes for PATTERN and output results into BUFFER. PATTERN is a basic regular expression by default in Git. @@ -1197,8 +1197,10 @@ vc-git-log-search Display all entries that match log messages in long format. With a prefix argument, ask for a command to run that will output log entries." - (let ((args `("log" "--no-color" "-i" - ,(format "--grep=%s" (or pattern ""))))) + (let ((args (if limit + `("log" "--no-color" "-n" "1" ,(or pattern "")) + `("log" "--no-color" "-i" + ,(format "--grep=%s" (or pattern "")))))) (when current-prefix-arg (setq args (cdr (split-string (read-shell-command diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 0d29c80d02..92faa59502 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2542,6 +2542,16 @@ vc-log-outgoing (vc-incoming-outgoing-internal backend (or remote-location "") "*vc-outgoing*" 'log-outgoing))) +(defun vc-log-search-internal (backend buffer-name type pattern &optional limit) + (vc-log-internal-common + backend buffer-name nil type + (lambda (bk buf type-arg _files) + (vc-call-backend bk type-arg buf pattern limit)) + (lambda (_bk _files-arg _ret) nil) + nil ;; Don't move point. + (lambda (_ignore-auto _noconfirm) + (vc-log-search-internal backend pattern buffer-name type)))) + ;;;###autoload (defun vc-log-search (pattern) "Search the log of changes for PATTERN. @@ -2558,8 +2568,25 @@ vc-log-search (let ((backend (vc-deduce-backend))) (unless backend (error "Buffer is not version controlled")) - (vc-incoming-outgoing-internal backend pattern - "*vc-search-log*" 'log-search))) + (vc-log-search-internal backend "*vc-search-log*" 'log-search pattern))) + +;;;###autoload +(defun vc-log-revision (revision) + "Search the log of changes for REVISION. +Display the REVISION log entry in long format." + (interactive (list (unless current-prefix-arg + (let ((default (thing-at-point 'word))) + (vc-read-revision + (if default + (format "Revision to log (default %s): " default) + "Revision to log: ") + nil nil default))))) + (when (equal revision "") + (error "No revision specified")) + (let ((backend (vc-deduce-backend))) + (unless backend + (error "Buffer is not version controlled")) + (vc-log-search-internal backend "*vc-search-log*" 'log-search revision 1))) ;;;###autoload (defun vc-log-mergebase (_files rev1 rev2) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 22:34:53 2019 Received: (at 38044) by debbugs.gnu.org; 19 Nov 2019 03:34:53 +0000 Received: from localhost ([127.0.0.1]:46493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWuI1-0004xh-Di for submit@debbugs.gnu.org; Mon, 18 Nov 2019 22:34:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWuI0-0004xW-8b for 38044@debbugs.gnu.org; Mon, 18 Nov 2019 22:34:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iWuHt-0007qL-UJ; Mon, 18 Nov 2019 22:34:45 -0500 Received: from [176.228.60.248] (port=2790 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iWuHt-0001yZ-9I; Mon, 18 Nov 2019 22:34:45 -0500 Date: Tue, 19 Nov 2019 05:34:50 +0200 Message-Id: <83eey435et.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <877e3wub09.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 18 Nov 2019 23:31:50 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Mon, 18 Nov 2019 23:31:50 +0200 > Cc: Lars Ingebrigtsen , Stephen Berman , > 38044@debbugs.gnu.org > > +(defun vc-log-revision (revision) > + "Search the log of changes for REVISION. > +Display the REVISION log entry in long format." The first sentence says that it "searches the log", but the second says that it shows the log. I think the first sentence is wrong and the second is right: there's no "search" here, is there? Even if the implementation does search, the doc string should describe the result, not the implementation. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 06:12:22 2019 Received: (at 38044) by debbugs.gnu.org; 19 Nov 2019 11:12:22 +0000 Received: from localhost ([127.0.0.1]:46688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX1Qj-0003MI-PD for submit@debbugs.gnu.org; Tue, 19 Nov 2019 06:12:21 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:54596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX1Qh-0003Lv-Fo for 38044@debbugs.gnu.org; Tue, 19 Nov 2019 06:12:19 -0500 Received: by mail-wm1-f43.google.com with SMTP id z26so2711213wmi.4 for <38044@debbugs.gnu.org>; Tue, 19 Nov 2019 03:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iF8xm+387vtRJ+4NdCc/OdJYKoSocdqpGGyDCyWa0NE=; b=gjzjD2H/dUpN0eGLEwjPtxQ3kAwFHdQvI0O9R3t+rrgO73NPmlAdBBHwyU8/MjU7bj BeGE7VKWlUHpyxUYGmrBO5wZTdj2cLAHngfvbjIhzwS2o0DMdmakwqUapiVpd0oByuSx 5UROWeMoBUefa9vlQgf7tdaZz4wVUIe59paE4rdTFHqwWUNyWGFe9HQ3nwpX0RQgJuSR BQMQc/ugJ3NY04+cbMSC3Ftl79HzX9pkITE+A7Fl+LzAeVykYODy03qP+n4LowTp2ytR 9e0sKg10Cs4QC8zY6VKC2D4P7MXVlG97rzbbhnEWUoxFOjGRBfoZLVebNt6hL/BvZbql 1LPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iF8xm+387vtRJ+4NdCc/OdJYKoSocdqpGGyDCyWa0NE=; b=s7WQ1IYFcGAzYILcdp5skC5lcuhioUsoLpm7J+MuNmxteQZB9+kws+Q0S1nsD1HoGO brq/5NOo8U0Eg4rijsu2gsjItXUeDsgAJzbXB29+Ne7OZrfU9jtRgLvXB1wP4aFeRtT4 2O75fYIzJoW+ti9y6+V58d4Xuj6GYS+mlHZ+Tqv0hmI2GHUx88ts4ZR9WtuqVHqKww0L AVAuy+iWavKFfGmZpwF/E2gLZlTU/gLBumv59s5W96Jz20rkHsKhBWBYhJU9IxvPdWWF Ma/WQ4u5lIlI9URziyRnjukdtUdFIPJw6vFGlsQGL7XVrsNyOtinmYXyLlEizQ3ek6NF msng== X-Gm-Message-State: APjAAAUXs0gLQzsU+Yy2lFFprd8vfh/yExyUB2QdcHaQqqJ734RwPB6O cegJcVMlXXAZ6IZ8flfl1mQ9SLx2 X-Google-Smtp-Source: APXvYqyll31aZNmbG32CMpZLQVMMrInlgQC/UOrsjyTaNyl2iD63IdrQ2PSaDYm4kKiBFQ42AcOm7w== X-Received: by 2002:a05:600c:2549:: with SMTP id e9mr4627638wma.177.1574161933040; Tue, 19 Nov 2019 03:12:13 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id z8sm26167208wrp.49.2019.11.19.03.12.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Nov 2019 03:12:11 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Juri Linkov References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> Date: Tue, 19 Nov 2019 13:12:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <877e3wub09.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: Lars Ingebrigtsen , Stephen Berman , 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.11.2019 23:31, Juri Linkov wrote: > +(defun vc-git-log-search (buffer pattern &optional limit) > > + (let ((args (if limit > + `("log" "--no-color" "-n" "1" ,(or pattern "")) > + `("log" "--no-color" "-i" > + ,(format "--grep=%s" (or pattern "")))))) Why would we hardcode that if LIMIT is passed then PATTERN is a revision, not a search string? Let's please make it another backend command instead of piggy-backing on 'log-search'. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 11:12:38 2019 Received: (at 38044) by debbugs.gnu.org; 19 Nov 2019 16:12:38 +0000 Received: from localhost ([127.0.0.1]:48323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX67H-0008LY-8Y for submit@debbugs.gnu.org; Tue, 19 Nov 2019 11:12:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX67G-0008LM-8h for 38044@debbugs.gnu.org; Tue, 19 Nov 2019 11:12:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iX676-0008MM-Qm; Tue, 19 Nov 2019 11:12:24 -0500 Received: from [176.228.60.248] (port=1055 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iX675-0006sC-UB; Tue, 19 Nov 2019 11:12:24 -0500 Date: Tue, 19 Nov 2019 18:12:28 +0200 Message-Id: <83zhgr26c3.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> (message from Dmitry Gutov on Tue, 19 Nov 2019 13:12:10 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Why would we hardcode that if LIMIT is passed then PATTERN is a > revision, not a search string? > > Let's please make it another backend command instead of piggy-backing on > 'log-search'. I agree. Stepping a notch back, wasn't the original request to have a command that would display a specific commit? If so, that's not a "log" command, that's closer to a "diff" command. And don't we already have a "diff" command which shows diffs for a specific revision? If not, let's provide that. The fact that Git can show diffs in some sub-commands of 'log' shouldn't dupe us into thinking that this is about "log" in any way. A command that searches the log entries for a string/pattern should be a separate command, which could be a "log" command. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 11:59:48 2019 Received: (at 38044) by debbugs.gnu.org; 19 Nov 2019 16:59:48 +0000 Received: from localhost ([127.0.0.1]:48418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX6qy-000334-3M for submit@debbugs.gnu.org; Tue, 19 Nov 2019 11:59:48 -0500 Received: from mail-ed1-f49.google.com ([209.85.208.49]:35662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX6qw-00032o-Ih for 38044@debbugs.gnu.org; Tue, 19 Nov 2019 11:59:46 -0500 Received: by mail-ed1-f49.google.com with SMTP id r16so17684354edq.2 for <38044@debbugs.gnu.org>; Tue, 19 Nov 2019 08:59:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rxvuZ/hXnnr2/urgiJJl+tbcr0FtX3zu4XMKdvvH1SE=; b=IgopZJf0e33TLC+9e0PHmUZldweS5ZFGvW53HuNhUJUAzYe4U0VmnuY5ZUDCJtshtF 8fxlbONo1ompwTBtCP+pkFK+vcdbytKFGHjPWPoaiBuFxBnfUls5jNlTAbF0ymFBzKmW 8vhjwKRR7Nys+kGuPPXZYIwPjWuUSAkoPMUJwgB6MdKsI6Uel0cndjFADp6wzNPfwK+6 HNYyO7HUQ+wqYKhQh1xYQLrNUFHhZ8nz7VYOhnP4IyfP9qZKs3DPGmVETZSiTmX7fMEI mEzA+5fpZKuw2LHx9zul5zXtC0q06j+Lbs/oExBrDjr4rhnoihnfiUt2Srvqvgiqgd2K M+yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rxvuZ/hXnnr2/urgiJJl+tbcr0FtX3zu4XMKdvvH1SE=; b=tAcph3WoZdu4KavyT54K4hfKs8elCUNK5GH1X6RUgfrIBtrLX+FRDAD+6gJL4rRBqv ObOFtBGZ81I+R/Ivd+1wDBvWVitO9ZRAW4g8TruyZapf1Z5sLqDhGmkH6kZW433BRC6o ruNYqu/FSl9xJT/q09GkIi8xADx3VXaqCNqZdemyRqpO0eHLXJTb3d3EoOLX15dImKHB nzfcA0BnnUmsJ/paOznJJtvLVx0rZeYgElFzI4W4JUyILpT4a5imy+XRZ9U6KB/cQ+RF wN6cQILC1iaVQLAtoEibL0KRMwCkeBlH2vxEqa9BPtdcdJvzGN5oli3ClQV/eUu91EW5 PB8g== X-Gm-Message-State: APjAAAXRje11ujQsaijUZJHxv9GeZk5u1c+HHrbu8jU56yRI6gMjL/y1 zygFssmHlu0AgeTcdyhL43I= X-Google-Smtp-Source: APXvYqzSMrPYyYhBM0E+L90hi2pkR03kEZYywCFZWcsxvm5IGxK1VDD/EEz0C9ylelQMaR5+8QFyuw== X-Received: by 2002:a17:906:5502:: with SMTP id r2mr37248775ejp.3.1574182780643; Tue, 19 Nov 2019 08:59:40 -0800 (PST) Received: from [192.168.0.149] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id b22sm1274174edj.25.2019.11.19.08.59.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Nov 2019 08:59:39 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> From: Dmitry Gutov Message-ID: <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> Date: Tue, 19 Nov 2019 18:59:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83zhgr26c3.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 19.11.2019 18:12, Eli Zaretskii wrote: > If so, that's not a "log" > command, that's closer to a "diff" command. It's kind of both. 'git show HEAD' is the format that I'd personally expect: some meta info, including the commit message, followed by the diff contents. > And don't we already have > a "diff" command which shows diffs for a specific revision? It *can* do that. And we also have a command that shows the revision log message and stuff: vc-annotate-show-log-revision-at-line. We could reuse its logic. And either add a diff output at the botton (making it a different command an dealing with major mode having to support both the headers and the diff), or rely on log-view-mode's bindings (the user can press 'd' or 'D' there). From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 12:43:11 2019 Received: (at 38044) by debbugs.gnu.org; 19 Nov 2019 17:43:12 +0000 Received: from localhost ([127.0.0.1]:48489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX7Ww-0004EQ-Tx for submit@debbugs.gnu.org; Tue, 19 Nov 2019 12:43:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX7Wu-0004EA-TK for 38044@debbugs.gnu.org; Tue, 19 Nov 2019 12:43:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iX7Wo-0007Vn-Sc; Tue, 19 Nov 2019 12:43:02 -0500 Received: from [176.228.60.248] (port=2987 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iX7Wo-0007X6-2b; Tue, 19 Nov 2019 12:43:02 -0500 Date: Tue, 19 Nov 2019 19:43:07 +0200 Message-Id: <83h82z2250.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> (message from Dmitry Gutov on Tue, 19 Nov 2019 18:59:36 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Tue, 19 Nov 2019 18:59:36 +0200 > > On 19.11.2019 18:12, Eli Zaretskii wrote: > > If so, that's not a "log" > > command, that's closer to a "diff" command. > > It's kind of both. 'git show HEAD' is the format that I'd personally > expect: some meta info, including the commit message, followed by the > diff contents. That's true, but I'd hesitate to introduce a new class of "show" commands just because Git has it. I see no problem showing the meta-data with diffs (when Git is the back-end), perhaps with an option to disable that. My rationale is that other VCSes have a diff command that shows only the diffs, and that command is used "to show" a revision with those VCSes. > > And don't we already have > > a "diff" command which shows diffs for a specific revision? > > It *can* do that. And we also have a command that shows the revision log > message and stuff: vc-annotate-show-log-revision-at-line. We could reuse > its logic. > > And either add a diff output at the botton (making it a different > command an dealing with major mode having to support both the headers > and the diff), or rely on log-view-mode's bindings (the user can press > 'd' or 'D' there). I think we should disconnect this "show" command from "log". It is conceptually wrong to make them related. Of course a vc-log buffer could have (and already has, AFAIK) a binding to a command that shows the revision at point's line. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 18:17:46 2019 Received: (at 38044) by debbugs.gnu.org; 19 Nov 2019 23:17:46 +0000 Received: from localhost ([127.0.0.1]:48679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXCkX-0004K8-Bq for submit@debbugs.gnu.org; Tue, 19 Nov 2019 18:17:46 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:33685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXCkT-0004Jt-Ek for 38044@debbugs.gnu.org; Tue, 19 Nov 2019 18:17:29 -0500 Received: by mail-wm1-f46.google.com with SMTP id a17so3671757wmb.0 for <38044@debbugs.gnu.org>; Tue, 19 Nov 2019 15:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xCPeupys8RSgdrXPzr2mrY+gX8leHSUoQTX3ZPrvjbw=; b=QE66sseqBG199uQtTHQp1/d6wpWeIKxQ+QXhsFF6/w75sq8mdPvLYM4EkVDOsotYdl JEOSHu7EoZqY7/+cCvD3XyJ0Q6wDehu98Ff6f3xtAsEITDF99Zc4IvetJNZGzFyDkGi6 6XTnmbDsPXOrgYuBsE1VlzzAE/sn0YloNfYurVwHvrybB8Z55Dei7bDDmTDlNCW21iN9 zFq3p0ffNxP/k5cn6xoHTko/qL8EBQ6x4yLrKJWj6ElpmDQDAqTbKRD6nD7kmAqnWCQp +LvOM7J1dSwa0DTX5PRiCpysGM1OVJB+oVv40jXvoSMY3rSj+lI6paa3kqmNBWE+yGuz sYcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xCPeupys8RSgdrXPzr2mrY+gX8leHSUoQTX3ZPrvjbw=; b=pCoppOlzYNbajovqfXbO99xYORQ2y771EqKxSSHWmJa5CTF+Dgm8e0vKvo6owo/MOp 8QXz/4gU2u2UjwOKIIbRLb2lcjOPy9GD2ho1K6dPolJHdZimPIRHY0FwoNny7O9g+bS6 0TdjmDw8hnMqQxl4goYei8+gsRk92hfiVAutTnvn7gEezWNLjVal7SS5xSBuUXECicyn eSZ8lJSGHWEfaDOGc0NFxU8TCefP89lMjaUxf/8G2C2SJFARYw/NBgwETU6iFl2eorNm vOARO7CmD6XcTVqTQKTrAlgeYsQlnnEGb8jcKS8Jo7DdxIGTLwgCo1MRCjmFpTKDBO+3 5vrw== X-Gm-Message-State: APjAAAXcIcCf3uMpwcheDmF2IPAkCdynn7+Nd0hpL+SvjqV9zWtNRcpQ sEJhBzTcUT5bjveJvpCvZH0= X-Google-Smtp-Source: APXvYqwxOpE+Mb8vLv4/FG8HzsY2kSrYY6zX9HDs+ePjO1wP1a67Ek9BOB4lUn73BoTUWk6fEVsN7Q== X-Received: by 2002:a1c:2e8f:: with SMTP id u137mr338503wmu.105.1574205443532; Tue, 19 Nov 2019 15:17:23 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id b3sm4473457wmj.44.2019.11.19.15.17.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Nov 2019 15:17:22 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> <83h82z2250.fsf@gnu.org> From: Dmitry Gutov Message-ID: <448da651-20ac-14ba-6916-98ab3c23c9d1@yandex.ru> Date: Wed, 20 Nov 2019 01:17:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83h82z2250.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 19.11.2019 19:43, Eli Zaretskii wrote: >> It's kind of both. 'git show HEAD' is the format that I'd personally >> expect: some meta info, including the commit message, followed by the >> diff contents. > > That's true, but I'd hesitate to introduce a new class of "show" > commands just because Git has it. I see no problem showing the > meta-data with diffs (when Git is the back-end), perhaps with an > option to disable that. These two sentences seem to contradict each other. To do the latter, we need to "introduce a new class of show commands". Because vc-git-diff won't print any metadata. > My rationale is that other VCSes have a diff > command that shows only the diffs, and that command is used "to show" > a revision with those VCSes. IMO the log message is more important because it describes and justifies what happened. Showing the diff is good as well. Maybe the other VCSes don't have a simple command to do the same, but they can either be called twice, or use special formatting. For instance, Hg can use this command: hg log -r -p >>> And don't we already have >>> a "diff" command which shows diffs for a specific revision? >> >> It *can* do that. And we also have a command that shows the revision log >> message and stuff: vc-annotate-show-log-revision-at-line. We could reuse >> its logic. >> >> And either add a diff output at the botton (making it a different >> command an dealing with major mode having to support both the headers >> and the diff), or rely on log-view-mode's bindings (the user can press >> 'd' or 'D' there). > > I think we should disconnect this "show" command from "log". It is > conceptually wrong to make them related. Of course a vc-log buffer > could have (and already has, AFAIK) a binding to a command that shows > the revision at point's line. Linking to a commit message from a diff buffer wouldn't really work. But we can "link" to a diff buffer from a common message buffer. Of course, it's better to just display both. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 18:20:16 2019 Received: (at 38044) by debbugs.gnu.org; 19 Nov 2019 23:20:16 +0000 Received: from localhost ([127.0.0.1]:48692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXCn9-0004Pc-Tq for submit@debbugs.gnu.org; Tue, 19 Nov 2019 18:20:16 -0500 Received: from bonobo.birch.relay.mailchannels.net ([23.83.209.22]:59217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXCn7-0004PQ-2v for 38044@debbugs.gnu.org; Tue, 19 Nov 2019 18:20:14 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A61831422A7; Tue, 19 Nov 2019 23:20:11 +0000 (UTC) Received: from pdx1-sub0-mail-a94.g.dreamhost.com (100-96-45-206.trex.outbound.svc.cluster.local [100.96.45.206]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 14DA51411E7; Tue, 19 Nov 2019 23:20:11 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a94.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Tue, 19 Nov 2019 23:20:11 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Cooperative-Society: 78528ee52f5da91d_1574205611449_2711626660 X-MC-Loop-Signature: 1574205611449:1361180869 X-MC-Ingress-Time: 1574205611448 Received: from pdx1-sub0-mail-a94.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTP id A54657FC58; Tue, 19 Nov 2019 15:20:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=bpzC6j8NGrhUUkIeDMtmr2ANTiw=; b= po887m0LMEXkl/X+7PzXdBb9heWJ69BDm0lMAzgtIugoUK2v+0Pgy+Ql+0oJ9aYn adQyGBiqnKLNZDWVkdiuJpWsklcxbAD3dVtACkt9r1XmqVt/2fAorIcCX5SC8wub T83Cr76aJdvsU1z1ASaw2HtYzpSMuX7yDmZKzNQT6rs= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTPSA id F34777FC11; Tue, 19 Nov 2019 15:20:01 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a94 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> Date: Wed, 20 Nov 2019 00:20:08 +0200 In-Reply-To: <83zhgr26c3.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Nov 2019 18:12:28 +0200") Message-ID: <87blt7qxhz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Let's please make it another backend command instead of piggy-backing on >> 'log-search'. > > I agree. > > Stepping a notch back, wasn't the original request to have a command > that would display a specific commit? If so, that's not a "log" > command, that's closer to a "diff" command. And don't we already have > a "diff" command which shows diffs for a specific revision? Then we could use something like the existing backend 'region-history' that for vc-git uses 'git log', but displays both the log and diff in one output buffer. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 22:43:20 2019 Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 03:43:20 +0000 Received: from localhost ([127.0.0.1]:48816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXGtj-00035z-OR for submit@debbugs.gnu.org; Tue, 19 Nov 2019 22:43:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXGth-00035f-9r for 38044@debbugs.gnu.org; Tue, 19 Nov 2019 22:43:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:32908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXGtb-0003fe-Nr; Tue, 19 Nov 2019 22:43:11 -0500 Received: from [176.228.60.248] (port=3871 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iXGtb-0002UC-D3; Tue, 19 Nov 2019 22:43:11 -0500 Date: Wed, 20 Nov 2019 05:43:18 +0200 Message-Id: <838sob1acp.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <448da651-20ac-14ba-6916-98ab3c23c9d1@yandex.ru> (message from Dmitry Gutov on Wed, 20 Nov 2019 01:17:18 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> <83h82z2250.fsf@gnu.org> <448da651-20ac-14ba-6916-98ab3c23c9d1@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Wed, 20 Nov 2019 01:17:18 +0200 > > > That's true, but I'd hesitate to introduce a new class of "show" > > commands just because Git has it. I see no problem showing the > > meta-data with diffs (when Git is the back-end), perhaps with an > > option to disable that. > > These two sentences seem to contradict each other. To do the latter, we > need to "introduce a new class of show commands". Because vc-git-diff > won't print any metadata. I was talking about the VC level, not the vc-git level. vc-git could have a show command, but the user of VC would still invoke a variant of vc-diff. > > My rationale is that other VCSes have a diff > > command that shows only the diffs, and that command is used "to show" > > a revision with those VCSes. > > IMO the log message is more important because it describes and justifies > what happened. Showing the diff is good as well. That's not relevant to the issue at hand. Like it or not, VCSes other than Git describe a revision by the diffs alone. > Maybe the other VCSes don't have a simple command to do the same, but > they can either be called twice, or use special formatting. For > instance, Hg can use this command: > > hg log -r -p IMO, this is over-engineering. If the VCS developers don't see the need to have a commands which shows meta-data together with the diffs, we should not force that on that VCS. IOW, what Git does is not necessarily the only game in town. The VC level should be clean and uniform. Any VCS-specific mindset should not enter it too far, or else VC will not do its job of insulating the user from the VCS differences well. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 22:44:43 2019 Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 03:44:43 +0000 Received: from localhost ([127.0.0.1]:48820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXGv5-00038S-7o for submit@debbugs.gnu.org; Tue, 19 Nov 2019 22:44:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXGv3-00038E-Ke for 38044@debbugs.gnu.org; Tue, 19 Nov 2019 22:44:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:32915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXGuw-0004n5-Hp; Tue, 19 Nov 2019 22:44:36 -0500 Received: from [176.228.60.248] (port=3955 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iXGuu-0002YB-L0; Tue, 19 Nov 2019 22:44:33 -0500 Date: Wed, 20 Nov 2019 05:44:41 +0200 Message-Id: <837e3v1aae.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87blt7qxhz.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 20 Nov 2019 00:20:08 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Dmitry Gutov , larsi@gnus.org, > stephen.berman@gmx.net, 38044@debbugs.gnu.org > Date: Wed, 20 Nov 2019 00:20:08 +0200 > > > Stepping a notch back, wasn't the original request to have a command > > that would display a specific commit? If so, that's not a "log" > > command, that's closer to a "diff" command. And don't we already have > > a "diff" command which shows diffs for a specific revision? > > Then we could use something like the existing backend 'region-history' > that for vc-git uses 'git log', but displays both the log and diff > in one output buffer. region-history is slow, so I'm not sure it is a good starting point for this feature. A diff command is usually very fats with every VCS. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 06:05:06 2019 Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 11:05:06 +0000 Received: from localhost ([127.0.0.1]:49011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXNnG-0007aV-1b for submit@debbugs.gnu.org; Wed, 20 Nov 2019 06:05:06 -0500 Received: from quimby.gnus.org ([95.216.78.240]:40358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXNnD-0007Zx-PN for 38044@debbugs.gnu.org; Wed, 20 Nov 2019 06:05:04 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iXNn2-0006qO-77; Wed, 20 Nov 2019 12:04:54 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> Date: Wed, 20 Nov 2019 12:04:51 +0100 In-Reply-To: <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> (Dmitry Gutov's message of "Tue, 19 Nov 2019 18:59:36 +0200") Message-ID: <87h82ykdv0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > It's kind of both. 'git show HEAD' is the format that I'd personally > expect: some meta info, including the commit message, followed by the > diff contents. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: Eli Zaretskii , stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > It's kind of both. 'git show HEAD' is the format that I'd personally > expect: some meta info, including the commit message, followed by the > diff contents. Yup; that is indeed what I wanted when I opened this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 07:20:05 2019 Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 12:20:05 +0000 Received: from localhost ([127.0.0.1]:49059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXOxo-0002tu-Rl for submit@debbugs.gnu.org; Wed, 20 Nov 2019 07:20:05 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:36220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXOxk-0002tJ-TI for 38044@debbugs.gnu.org; Wed, 20 Nov 2019 07:20:03 -0500 Received: by mail-wr1-f53.google.com with SMTP id z3so988232wru.3 for <38044@debbugs.gnu.org>; Wed, 20 Nov 2019 04:20:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=t67kv1+r8Vh/CqWqsuATLLIzvAawqUwcwhHKPWE1v6Q=; b=tGEgk22gGS/tw0FjooE4b2C1qTh5Vv7VnRP+t6J7M2RSw2Pr0iqqt1GmD5tANJOoIU zPi0SVivQ86VaRlUTZmWpbM+9nv9i2gz5L0FowMx9U7y1iW7wugM6BwW6AehGsfJbz98 XPtvbDFXDAVS9Lf5rkCsRFghrddpXakYXHY6f+uYAfgbPEAgYj/ItAr0DQJ9seql18eh /vq9M3Hd7VQQhzA2N61BbbWIg8PsBNPAX/mpRekYo+8VW+pfqYzqR1VeXU6SjkjPvlmj hmqTMZwoWGU5fC5PahV4O4kvikfvnvrHO233AzwOPNXJTn3h7ycAapZBCsZVA+LUJkrO gKxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t67kv1+r8Vh/CqWqsuATLLIzvAawqUwcwhHKPWE1v6Q=; b=hvEqgdEWo+4hX4PER0NBIGazyqx0yPpn5WWYEe5jH8xvbG0Jm1xNcQbmGcR8n68Cs+ 4abnG+xgoHt42N1bWBorkGsNPeEChY1oCUsyvY8p3sPSGZ5Jti/nsMMoubvWlAHRDnoQ P7wF2eFo1AbboHsLLkJ4r60JTjSnEHl2Z3X4g7vRwTeFd8JCgaqOGM45WvfkvCsUuE/M +bec6LsamYGdkGE44RusWAU45LmxJ7VK+sboJB+PvnXYZQqeAGybyuUK9rUeVoWMlxm8 TQ5SW5J4n3nrDAYFZzNdH0RT9M8icelxHPdW5aOvO9Nyw1QR0TigsBLgqIPJyehNa7+k 4KAw== X-Gm-Message-State: APjAAAXF/JD1OS1YZLeXs150fnBVwls+z0K65DB/NGmJ9Zs948uvzqyi 1ASurhIVKU9CQ3W1eDhe8NQ= X-Google-Smtp-Source: APXvYqwahPZgtaEsZNdI4wcOmnGTD0rhY4YF5EZ5mFx1PjwE3bUMEDUgO+zIbwZyql0FnLrlYM44Sw== X-Received: by 2002:adf:de0a:: with SMTP id b10mr2969061wrm.268.1574252394868; Wed, 20 Nov 2019 04:19:54 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id z2sm19190285wrs.89.2019.11.20.04.19.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Nov 2019 04:19:53 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> <83h82z2250.fsf@gnu.org> <448da651-20ac-14ba-6916-98ab3c23c9d1@yandex.ru> <838sob1acp.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Wed, 20 Nov 2019 14:19:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <838sob1acp.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 20.11.2019 5:43, Eli Zaretskii wrote: >>> That's true, but I'd hesitate to introduce a new class of "show" >>> commands just because Git has it. I see no problem showing the >>> meta-data with diffs (when Git is the back-end), perhaps with an >>> option to disable that. >> >> These two sentences seem to contradict each other. To do the latter, we >> need to "introduce a new class of show commands". Because vc-git-diff >> won't print any metadata. > > I was talking about the VC level, not the vc-git level. vc-git could > have a show command, but the user of VC would still invoke a variant > of vc-diff. How would that even work? vc-diff will always delegate to vc-git-diff. >>> My rationale is that other VCSes have a diff >>> command that shows only the diffs, and that command is used "to show" >>> a revision with those VCSes. >> >> IMO the log message is more important because it describes and justifies >> what happened. Showing the diff is good as well. > > That's not relevant to the issue at hand. Like it or not, VCSes other > than Git describe a revision by the diffs alone. It's 100% relevant, and the fact that certain older VCSes can't do this should have no bearing on whether we implement a satisfactory UI in VC or not. That's the whole purpose of VC: make interacting with different VS systems easier. >> Maybe the other VCSes don't have a simple command to do the same, but >> they can either be called twice, or use special formatting. For >> instance, Hg can use this command: >> >> hg log -r -p > > IMO, this is over-engineering. If the VCS developers don't see the > need to have a commands which shows meta-data together with the diffs, > we should not force that on that VCS. They added the '-p' flag. So apparently they did see the need. And this kind of invocation is certainly in demand (I found it in "answers" on StackOverflow). > The VC level should be clean and uniform. Any VCS-specific mindset > should not enter it too far, or else VC will not do its job of > insulating the user from the VCS differences well. There's nothing VCS-specific in what I'm proposing. Any of them should be able to do that (though some will only manage it in two invocations). In any case, the solution you're suggesting is trivial to implement indeed, but that's not what I would expect from the feature, nor, apparently, what Lars wanted either. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 11:35:03 2019 Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 16:35:03 +0000 Received: from localhost ([127.0.0.1]:50795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXSwY-0003Fk-S6 for submit@debbugs.gnu.org; Wed, 20 Nov 2019 11:35:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXSwW-0003FD-Jp for 38044@debbugs.gnu.org; Wed, 20 Nov 2019 11:35:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXSwQ-0006bP-Sx; Wed, 20 Nov 2019 11:34:54 -0500 Received: from [176.228.60.248] (port=3110 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iXSwJ-0007Oa-Lt; Wed, 20 Nov 2019 11:34:54 -0500 Date: Wed, 20 Nov 2019 18:34:55 +0200 Message-Id: <83tv6yzets.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Wed, 20 Nov 2019 14:19:47 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> <83h82z2250.fsf@gnu.org> <448da651-20ac-14ba-6916-98ab3c23c9d1@yandex.ru> <838sob1acp.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Wed, 20 Nov 2019 14:19:47 +0200 > > > I was talking about the VC level, not the vc-git level. vc-git could > > have a show command, but the user of VC would still invoke a variant > > of vc-diff. > > How would that even work? vc-diff will always delegate to vc-git-diff. It will work if we program either vc-diff or vc-git-diff to call "git show" under some specific circumstances. > >> IMO the log message is more important because it describes and justifies > >> what happened. Showing the diff is good as well. > > > > That's not relevant to the issue at hand. Like it or not, VCSes other > > than Git describe a revision by the diffs alone. > > It's 100% relevant, and the fact that certain older VCSes can't do this > should have no bearing on whether we implement a satisfactory UI in VC > or not. That's the whole purpose of VC: make interacting with different > VS systems easier. Easier, yes. But also present the results in a familiar enough form. If users are accustomed to seeing a revision described by diffs, then this is what they should by default see in VC, IMO. > >> Maybe the other VCSes don't have a simple command to do the same, but > >> they can either be called twice, or use special formatting. For > >> instance, Hg can use this command: > >> > >> hg log -r -p > > > > IMO, this is over-engineering. If the VCS developers don't see the > > need to have a commands which shows meta-data together with the diffs, > > we should not force that on that VCS. > > They added the '-p' flag. So apparently they did see the need. Then maybe the hg back-end should indeed call "log -r -p", if that's what hg users are used to (I don't use hg). What I mean is that we should show a revision like users are accustomed to see it with the particular back-end; jumping through hoops to produce Git-like display where users don't really expect it is IMO over-engineering. And I'm also saying that conceptually a revision's description is a kind of "diff" operation, so it should preferably be a sub-command of "C-x v =". From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 14:40:44 2019 Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 19:40:44 +0000 Received: from localhost ([127.0.0.1]:50938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXVqG-0007l1-42 for submit@debbugs.gnu.org; Wed, 20 Nov 2019 14:40:44 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:40739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXVqE-0007ko-4Q for 38044@debbugs.gnu.org; Wed, 20 Nov 2019 14:40:43 -0500 Received: by mail-wr1-f48.google.com with SMTP id q15so1330487wrw.7 for <38044@debbugs.gnu.org>; Wed, 20 Nov 2019 11:40:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3Pq0YYXCQgDW/1fv8aHcQltc12u6Itf2bLPqrdM28+o=; b=Uke9+vrUH4ZM7PJw92CHWjq9hPLMtmBgZgjm4BfD/U9qV3C85dljWVMK6gIugE56ZR TdrKSpsWrG+VfVzopu+4AUGITopDRcNj7hXq798cxVaUi4FfvL+nSDoqr2ZRjWgLKIoV vjP3qO+29fAi92JvsRu8KFELH0AsU7d1WYxP35Yq5jpJavrUDeWyIE/oOZNerV5BGHt0 cEtlncAfPt9EnK04ktVGQyq1FoPs73Y9VHo+xO7hzVYMh8igpyga12rf6Jiw46Svnf6Q Zg4iM3IDtGxU1ME5pmL6yXHBa5X++dKU61KL8iyJe9Ut4ftg717g/uHoBogPPncZvfM1 fIaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3Pq0YYXCQgDW/1fv8aHcQltc12u6Itf2bLPqrdM28+o=; b=hHukKNQ8j3FClilXzhP+eTNUmVeIMcItcQ8iRh2FBLIwoahRR+V4on1s/y9mOgZ8EW Dt5K2fqx3Jx+6osmJmVzOoAOCV/pZBEO9G9RkRSXJQKw6g8f+l7BAbwPFDVGNPvnQzIA ++spNCkEIGjcPM8GMlXWEz8yM0Zt7Fba/62GVgw/SQohwD40cdFwRvL6chQpaV79Nd9p kEIItzu3vr1/fvjZmnsbbDU6NNfl9JVF+f6LtH9psbPs90mabvFgsHJGvuhDTUcIS03W 6i+bJ16t+6JjcAeMapaSpmMoSiVg7siiY0QTwiRE5f5vqbdEpRK59vsDGmDaQFZW9tTp tuSQ== X-Gm-Message-State: APjAAAVrs57gGrmr4IGvycqW8Gcvvc0IfwtAaLGkJzIo+vuN7hS7o7sN KlHT5ilCuVjRFSTI8/CJLOU= X-Google-Smtp-Source: APXvYqzzvwavVe4xmYlXMIf02ea/qRIowrulwMznGBq1IbrOzibijczsX56RtADoachkeKtGiO1htQ== X-Received: by 2002:adf:fe0e:: with SMTP id n14mr5970753wrr.72.1574278836148; Wed, 20 Nov 2019 11:40:36 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id j63sm288475wmj.46.2019.11.20.11.40.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Nov 2019 11:40:34 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> <83h82z2250.fsf@gnu.org> <448da651-20ac-14ba-6916-98ab3c23c9d1@yandex.ru> <838sob1acp.fsf@gnu.org> <83tv6yzets.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Wed, 20 Nov 2019 21:40:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83tv6yzets.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 20.11.2019 18:34, Eli Zaretskii wrote: >> How would that even work? vc-diff will always delegate to vc-git-diff. > > It will work if we program either vc-diff or vc-git-diff to call "git > show" under some specific circumstances. That makes little sense to me, sorry. >>>> IMO the log message is more important because it describes and justifies >>>> what happened. Showing the diff is good as well. >>> >>> That's not relevant to the issue at hand. Like it or not, VCSes other >>> than Git describe a revision by the diffs alone. >> >> It's 100% relevant, and the fact that certain older VCSes can't do this >> should have no bearing on whether we implement a satisfactory UI in VC >> or not. That's the whole purpose of VC: make interacting with different >> VS systems easier. > > Easier, yes. But also present the results in a familiar enough form. > If users are accustomed to seeing a revision described by diffs, then > this is what they should by default see in VC, IMO. There's nothing unfamiliar about also seeing the author name and the commit message. Also: most of our users are Git users. Hence, users are accustomed to 'git show'. >>>> Maybe the other VCSes don't have a simple command to do the same, but >>>> they can either be called twice, or use special formatting. For >>>> instance, Hg can use this command: >>>> >>>> hg log -r -p >>> >>> IMO, this is over-engineering. If the VCS developers don't see the >>> need to have a commands which shows meta-data together with the diffs, >>> we should not force that on that VCS. >> >> They added the '-p' flag. So apparently they did see the need. > > Then maybe the hg back-end should indeed call "log -r -p", if that's > what hg users are used to (I don't use hg). What I mean is that we > should show a revision like users are accustomed to see it with the > particular back-end; jumping through hoops to produce Git-like display > where users don't really expect it is IMO over-engineering. I disagree. I think the possible arguments are exhausted at this point. Are you going to invoke the privilege of the Emacs maintainer? All I got to say to this is "lisp/vc/*" is near my name in admin/MAINTAINERS. > And I'm also saying that conceptually a revision's description is a > kind of "diff" operation, so it should preferably be a sub-command of > "C-x v =". That's not how I think about it either. Again: I think the metadata is just as important. And we can't get to that metadata from the diff output. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 14:57:24 2019 Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 19:57:25 +0000 Received: from localhost ([127.0.0.1]:50957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXW6O-0008CZ-N1 for submit@debbugs.gnu.org; Wed, 20 Nov 2019 14:57:24 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:43420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXW6J-0008CH-V9 for 38044@debbugs.gnu.org; Wed, 20 Nov 2019 14:57:22 -0500 Received: by mail-wr1-f41.google.com with SMTP id n1so1358518wra.10 for <38044@debbugs.gnu.org>; Wed, 20 Nov 2019 11:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0v+PkhB97Dj8MBm5Rvg6tJ/QZSZJecmpVqKtnCojRyU=; b=G5EmWkOjw9adYGqPMyBk5wKUUqHnCw6u1xtHXsBBgYMXYNZqYJla4P9MkwlZi++RqE zuKcFsDyNX1DiuacxjqW+qxB/y+B2IiWTQO6RzuFUGXNXhyBMMzEFWB/o20yj8OeuIHM drR6arCWPl/57RN0jN5lSl58MzB9t2EBBHhvvGZs36k2x0u9NpvVIqIRGQ5Z8VkWpQAx bn8cpZVH/u/uhS6E0BqgSenjy2mSUM/hZZWQupENcZZCb5aAz1hphUZ/88qCLtpvugex pLlNOa2ICm6oN35rgqq1/vsl9h/pXdXSJchtqx/6GOdpZONnc2nPHSMmCdndWcaidTdi lQAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0v+PkhB97Dj8MBm5Rvg6tJ/QZSZJecmpVqKtnCojRyU=; b=CmNnOGUsvql+1a7WA3W5SjWIk+HzI7+FOB7hPJT9mkAIuHiQuEsD+Gyiomi96XZ8G8 MUSdy9ktzTWaRUGONey6hNMHEjqFw/JMfqQB5A+rGEH0cSr0SGA85w+mFW1xgMXYqeLy 8LnRdtP/44vk8manrDD/66/LejSkuY10RZ+ECd2aa4k8IxDplgGNL1A34YIPoDKfPY0j hnODzTEfye1smSZXj0SODCAVfJP3MAGDEnVGZDLi6qBQrOk/bZj24/csUjposyYk/Oi2 0LCueZzCryOBFP6hLaRQhwj0J6Ry6afY6OQW2wA7hYse9LB4d+u5IJ/BFJYjgKKURznc ZqCQ== X-Gm-Message-State: APjAAAXxna8n7mO1Uu3YwdG+5/+MnuOl0Nb5PHA7eujU8YdTFr5QTo7D fVaMoiMOrHEd+jCB9luJ8DE= X-Google-Smtp-Source: APXvYqx8AhLqe6NuSfpf1bVMewhfIBZcFDFS4Wfjr42Y7X+nAEJj9qeDkp8bAQsi8d4E1wNxyfiQZg== X-Received: by 2002:adf:979a:: with SMTP id s26mr5967153wrb.92.1574279833997; Wed, 20 Nov 2019 11:57:13 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id d202sm293115wmd.47.2019.11.20.11.57.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Nov 2019 11:57:13 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit From: Dmitry Gutov To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> <83h82z2250.fsf@gnu.org> <448da651-20ac-14ba-6916-98ab3c23c9d1@yandex.ru> <838sob1acp.fsf@gnu.org> <83tv6yzets.fsf@gnu.org> Message-ID: Date: Wed, 20 Nov 2019 21:57:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 20.11.2019 21:40, Dmitry Gutov wrote: >>> How would that even work? vc-diff will always delegate to vc-git-diff. >> >> It will work if we program either vc-diff or vc-git-diff to call "git >> show" under some specific circumstances. > > That makes little sense to me, sorry. What we can try instead: A new command: vc-describe-revision (for example; call it however you want) which first invokes vc-print-log-internal like vc-annotate-show-log-revision-at-line does, followed by calling vc-diff-internal like vc-annotate-show-diff-revision-at-line-internal does. The only difficulty there is coloring diff output properly. Maybe just take the fontified buffer strings from the above commands and copy them over into a new buffer. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 15:07:04 2019 Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 20:07:04 +0000 Received: from localhost ([127.0.0.1]:50962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXWFj-0001xb-MM for submit@debbugs.gnu.org; Wed, 20 Nov 2019 15:07:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXWFg-0001x2-H2 for 38044@debbugs.gnu.org; Wed, 20 Nov 2019 15:07:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXWFa-0004dT-Sv; Wed, 20 Nov 2019 15:06:54 -0500 Received: from [176.228.60.248] (port=4419 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iXWFZ-00020p-IQ; Wed, 20 Nov 2019 15:06:54 -0500 Date: Wed, 20 Nov 2019 22:07:02 +0200 Message-Id: <83eey2z509.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Wed, 20 Nov 2019 21:40:32 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> <83h82z2250.fsf@gnu.org> <448da651-20ac-14ba-6916-98ab3c23c9d1@yandex.ru> <838sob1acp.fsf@gnu.org> <83tv6yzets.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Wed, 20 Nov 2019 21:40:32 +0200 > > On 20.11.2019 18:34, Eli Zaretskii wrote: > > >> How would that even work? vc-diff will always delegate to vc-git-diff. > > > > It will work if we program either vc-diff or vc-git-diff to call "git > > show" under some specific circumstances. > > That makes little sense to me, sorry. I'm sorry, I'm not interested in continuing this discussion with you. Maybe in the future I should simply avoid chiming into discussions you are part of. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 15:12:25 2019 Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 20:12:26 +0000 Received: from localhost ([127.0.0.1]:50967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXWKv-00025h-Id for submit@debbugs.gnu.org; Wed, 20 Nov 2019 15:12:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXWKu-00025V-BA for 38044@debbugs.gnu.org; Wed, 20 Nov 2019 15:12:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXWKo-0007Np-Dr; Wed, 20 Nov 2019 15:12:18 -0500 Received: from [176.228.60.248] (port=4755 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iXWKn-0002Uj-Pa; Wed, 20 Nov 2019 15:12:18 -0500 Date: Wed, 20 Nov 2019 22:12:26 +0200 Message-Id: <83blt6z4r9.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Wed, 20 Nov 2019 21:57:11 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> <83h82z2250.fsf@gnu.org> <448da651-20ac-14ba-6916-98ab3c23c9d1@yandex.ru> <838sob1acp.fsf@gnu.org> <83tv6yzets.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Dmitry Gutov > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > Date: Wed, 20 Nov 2019 21:57:11 +0200 > > On 20.11.2019 21:40, Dmitry Gutov wrote: > >>> How would that even work? vc-diff will always delegate to vc-git-diff. > >> > >> It will work if we program either vc-diff or vc-git-diff to call "git > >> show" under some specific circumstances. > > > > That makes little sense to me, sorry. > > What we can try instead: > > A new command: vc-describe-revision Sorry, I'm not interested in bending VC to Git's twisted mindset. The description of a revision is its diffs, perhaps accompanied by some meta-data, as per the back-end users' expectations. But inventing a new VC command class because Git has it makes no sense to me. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 17:47:09 2019 Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 22:47:09 +0000 Received: from localhost ([127.0.0.1]:51019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXYke-0005zr-Ny for submit@debbugs.gnu.org; Wed, 20 Nov 2019 17:47:09 -0500 Received: from dragonfly.birch.relay.mailchannels.net ([23.83.209.51]:21529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXYkW-0005zL-O1 for 38044@debbugs.gnu.org; Wed, 20 Nov 2019 17:47:07 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 066CF5A0C1B; Wed, 20 Nov 2019 22:46:59 +0000 (UTC) Received: from pdx1-sub0-mail-a44.g.dreamhost.com (100-96-4-107.trex.outbound.svc.cluster.local [100.96.4.107]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 66D375A1058; Wed, 20 Nov 2019 22:46:58 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a44.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 20 Nov 2019 22:46:58 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Decisive-Descriptive: 526ae3e412871bd1_1574290018674_3340243958 X-MC-Loop-Signature: 1574290018674:2073534326 X-MC-Ingress-Time: 1574290018674 Received: from pdx1-sub0-mail-a44.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTP id 707E5832D8; Wed, 20 Nov 2019 14:46:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=Q2m43f2r7UwrFaPu02Jtllg4Jyo=; b= zlszsaJg7PhdPj3Ex2HDMwVdMvLaGUOpjRkbR75S9xRLkt7/AiZra2Qo+eG5QBs5 e0lnAEQo+MMHeKN5uBiXN0W1Z0OfWaxejNci/Bzjwf+S46SwekQCdXNk7vb+c+YG ysPUfOIVZe9SyC3Ckq6g4Xwn+rXJymRLE1bZhuHHuVc= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTPSA id A87D4832D5; Wed, 20 Nov 2019 14:46:53 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a44 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> Date: Wed, 20 Nov 2019 23:50:00 +0200 In-Reply-To: <837e3v1aae.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Nov 2019 05:44:41 +0200") Message-ID: <87y2warzv3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain >> > Stepping a notch back, wasn't the original request to have a command >> > that would display a specific commit? If so, that's not a "log" >> > command, that's closer to a "diff" command. And don't we already have >> > a "diff" command which shows diffs for a specific revision? >> >> Then we could use something like the existing backend 'region-history' >> that for vc-git uses 'git log', but displays both the log and diff >> in one output buffer. > > region-history is slow, so I'm not sure it is a good starting point > for this feature. A diff command is usually very fats with every VCS. It doesn't use 'region-history'. I meant using 'region-history-mode' on the output buffer. Everything works perfectly with this patch that also implements defaulting to the revision under point and prompting for the directory like Lars asked to do: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-print-revision.patch diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 0d29c80d02..fedc30e932 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -359,6 +359,10 @@ ;; and make sure it is displayed in the buffer's window. The default ;; implementation of this function works for RCS-style logs. ;; +;; - print-revision (revision) +;; +;; Show details of REVISION. +;; ;; - comment-history (file) ;; ;; Return a string containing all log entries that were made for FILE. @@ -2516,6 +2520,31 @@ vc-print-branch-log (list default-directory) branch t (when (> vc-log-show-limit 0) vc-log-show-limit))) +;;;###autoload +(defun vc-print-revision (revision) + "Show the details of the revision REVISION." + (interactive (list (unless current-prefix-arg + (let ((default (thing-at-point 'word))) + (vc-read-revision + (if default + (format "Revision to show (default %s): " default) + "Revision to show: ") + nil nil default))))) + (when (equal revision "") + (error "No revision specified")) + (let ((backend (vc-deduce-backend)) + rootdir) + (if backend + (setq rootdir (vc-call-backend backend 'root default-directory)) + (setq rootdir (read-directory-name "Directory for VC print-revision: ")) + (setq backend (vc-responsible-backend rootdir)) + (unless backend + (error "Directory is not version controlled"))) + (setq default-directory rootdir) + (vc-incoming-outgoing-internal backend revision + "*vc-revision*" 'print-revision) + (vc-call-backend backend 'region-history-mode))) + ;;;###autoload (defun vc-log-incoming (&optional remote-location) "Show a log of changes that will be received with a pull operation from REMOTE-LOCATION. diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 5ab8e7ec53..a330adaa52 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -80,6 +80,7 @@ ;; - log-search (buffer pattern) OK ;; - log-view-mode () OK ;; - show-log-entry (revision) OK +;; - print-revision (revision) OK ;; - comment-history (file) ?? ;; - update-changelog (files) COULD BE SUPPORTED ;; * diff (file &optional rev1 rev2 buffer async) OK @@ -1163,6 +1164,22 @@ vc-git-print-log (list start-revision))) '("--"))))))) +(defun vc-git-print-revision (buffer revision) + "Show the details of REVISION with output in BUFFER. +With a prefix argument, ask for a command to run that will output +the revision information." + (let ((args `("show" "--no-color" ,(or revision "")))) + (when current-prefix-arg + (setq args (cdr (split-string + (read-shell-command + "Show revision with command: " + (format "%s %s" vc-git-program + (mapconcat 'identity args " ")) + 'vc-git-history) + " " t)))) + (vc-setup-buffer buffer) + (apply 'vc-git-command buffer 'async nil args))) + (defun vc-git-log-outgoing (buffer remote-location) (vc-setup-buffer buffer) (vc-git-command @@ -1226,7 +1243,7 @@ vc-git-log-view-mode (set (make-local-variable 'log-view-file-re) regexp-unmatchable) (set (make-local-variable 'log-view-per-file-logs) nil) (set (make-local-variable 'log-view-message-re) - (if (not (memq vc-log-view-type '(long log-search))) + (if (not (memq vc-log-view-type '(long log-search print-revision))) (cadr vc-git-root-log-format) "^commit *\\([0-9a-z]+\\)")) ;; Allow expanding short log entries. @@ -1235,7 +1252,7 @@ vc-git-log-view-mode (set (make-local-variable 'log-view-expanded-log-entry-function) 'vc-git-expanded-log-entry)) (set (make-local-variable 'log-view-font-lock-keywords) - (if (not (memq vc-log-view-type '(long log-search))) + (if (not (memq vc-log-view-type '(long log-search print-revision))) (list (cons (nth 1 vc-git-root-log-format) (nth 2 vc-git-root-log-format))) (append --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 18:37:27 2019 Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 23:37:27 +0000 Received: from localhost ([127.0.0.1]:51089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXZXK-0007Hw-Q3 for submit@debbugs.gnu.org; Wed, 20 Nov 2019 18:37:26 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:33003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXZXG-0007Hc-Pl for 38044@debbugs.gnu.org; Wed, 20 Nov 2019 18:37:23 -0500 Received: by mail-wm1-f49.google.com with SMTP id t26so2369080wmi.0 for <38044@debbugs.gnu.org>; Wed, 20 Nov 2019 15:37:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Wok/0m8BLfZtek+di9AAEtGxhWejoVRsNIyAE4tSlc8=; b=LJiEIj0OoOB55z3DZI7NvFYRQngdJC3cwhJXS9rxtliPcaanT5sDB2Yxh58lQwI4X7 KMRTy5zRxImDefIAt9WxvZKK0l7rNPlvH+/UFnwsMj1Va4prqAdrO4793jqfsHoH61PF iOCFNMpcXCPFOJxtKG47qbpTW1kfqikU1zbhOD8J75e8mcU0/FwPbpC5bEHWN+aKKjEd zcOzGj4oYMSAMfhA2+f+r/JSGKWfSGF1tKodK5QHTYtCxP02kclEDUhY1+xgakIrsU65 4YjsdC9SJtT4rH7nhZmJNLfKqi4ZVFqx84tgpieVwGUhhtfuzsxT0RH4Pi3CkIlEEHjv KWKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Wok/0m8BLfZtek+di9AAEtGxhWejoVRsNIyAE4tSlc8=; b=mt7RQT2oLfvgEvZAEJM6vZbExRwbNi2OSLo0wxxBlg+/l+3oRnI9GU5FMLwAUxf6G6 3dC+q0OqHToZN+iYS/9XrzyQnhYETkmcuQnWsuxgVTXGbIefjQuqb54e68VsZEwRMyJv k6XjtR8zEXRMdnsjg/Se3Irqj90VAaEyEBKSsG1Ii7pP7lLYIzBbYero88DQzih/tsa0 3xbt/zoVT73J9s8BvvXSiHxpGKU/tjevD7JNbhepsO0I90ZWs7SiT9i7nyVUrMV90Aqn iSMTxjWzfXjmDHA32l+2wGBUM0LnvrDAt6TNGryQ8s8xloxua+gLVLU2LXMNVlXNykZd gepA== X-Gm-Message-State: APjAAAW6sdOQ0hq5LcUpPg/pstTX+iKPUv5kJWapBFpysI57VzPDhNE/ vJGOu14odd5S2aAUKk0siB+9Oi30 X-Google-Smtp-Source: APXvYqzOTSrBqWmbpPjtT6PTtGpfwEznxiFPVN+KMWXbW8HyhShkKwN3gl3bvPysp2sMgBu6X5Ss2A== X-Received: by 2002:a05:600c:2919:: with SMTP id i25mr6306496wmd.158.1574293035922; Wed, 20 Nov 2019 15:37:15 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id l4sm924789wme.4.2019.11.20.15.37.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Nov 2019 15:37:15 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Juri Linkov , Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <29e2e877-6dc3-b03b-7463-01cff35e05d1@yandex.ru> Date: Thu, 21 Nov 2019 01:37:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87y2warzv3.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Juri, The approach LGTM. I'd have used "describe" or "show", but it's not important. Some minor nits: On 20.11.2019 23:50, Juri Linkov wrote: > (setq default-directory rootdir) This probably needs a saving (let ((default-directory default-directory)) ...) above it. > +With a prefix argument, ask for a command to run that will output > +the revision information." This sentence should be into the docstring of the new command, not in the backend implementation. > + (read-shell-command > + "Show revision with command: " > + (format "%s %s" vc-git-program > + (mapconcat 'identity args " ")) > + 'vc-git-history) > + " " t)))) If wonder if some user someday is going to try and input there something that doesn't start with 'git '. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 09:59:14 2019 Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 14:59:14 +0000 Received: from localhost ([127.0.0.1]:53178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXnvN-0001nU-FW for submit@debbugs.gnu.org; Thu, 21 Nov 2019 09:59:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXnv8-0001mx-If for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 09:59:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXnv2-0007Hd-Pz; Thu, 21 Nov 2019 09:58:52 -0500 Received: from [176.228.60.248] (port=1556 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iXnv1-00045E-NX; Thu, 21 Nov 2019 09:58:52 -0500 Date: Thu, 21 Nov 2019 16:59:02 +0200 Message-Id: <83r221xoll.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87y2warzv3.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 20 Nov 2019 23:50:00 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, larsi@gnus.org, stephen.berman@gmx.net, > 38044@debbugs.gnu.org > Date: Wed, 20 Nov 2019 23:50:00 +0200 > > >> Then we could use something like the existing backend 'region-history' > >> that for vc-git uses 'git log', but displays both the log and diff > >> in one output buffer. > > > > region-history is slow, so I'm not sure it is a good starting point > > for this feature. A diff command is usually very fats with every VCS. > > It doesn't use 'region-history'. I meant using 'region-history-mode' > on the output buffer. Ah, okay. Btw, region-history-mode is a Git-only feature, so I don't think I understand why it is in vc.el and not in vc-git.el. > Everything works perfectly with this patch that also implements > defaulting to the revision under point and prompting for the > directory like Lars asked to do: Thanks. A few comments: > +;; - print-revision (revision) > +;; > +;; Show details of REVISION. > +;; I'd prefer this to be a variant of vc-diff, and bound to "C-x v =". The "C-u C-x v =" form is already taken, and tweaking it to accept a single revision would not be easy. So how about "C-u C-u C-x v ="? The reason I think this should be a vc-diff subcommand is that most kinds of VCS describe a revision as diffs. Where a revision's description is expected to include meta-data, i.e. the VCS backend provides a command to show a revision in that format, we should use that backend command, of course. But conceptually we just show diffs, so inventing a whole new class of VC commands for a minor variant of diffs display sounds sub-optimal to me. Also, why only implement this for a single backend? The corresponding diff commands exist in every VCS we support, so let's implement this for all of them, okay? Let us know if you need help with other VCSes. Finally, this needs documentation in NEWS and in the user manual. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 10:00:50 2019 Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 15:00:50 +0000 Received: from localhost ([127.0.0.1]:53187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXnwv-0001rn-S9 for submit@debbugs.gnu.org; Thu, 21 Nov 2019 10:00:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXnwp-0001rI-R5 for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 10:00:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXnwg-0008Q6-Q8; Thu, 21 Nov 2019 10:00:35 -0500 Received: from [176.228.60.248] (port=1663 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iXnwf-0000yd-Vo; Thu, 21 Nov 2019 10:00:34 -0500 Date: Thu, 21 Nov 2019 17:00:46 +0200 Message-Id: <83pnhlxoip.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87h82ykdv0.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 20 Nov 2019 12:04:51 +0100) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> <87h82ykdv0.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: juri@linkov.net, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Eli Zaretskii , stephen.berman@gmx.net, > 38044@debbugs.gnu.org, juri@linkov.net > Date: Wed, 20 Nov 2019 12:04:51 +0100 > > Dmitry Gutov writes: > > > It's kind of both. 'git show HEAD' is the format that I'd personally > > expect: some meta info, including the commit message, followed by the > > diff contents. > > Yup; that is indeed what I wanted when I opened this bug report. And you will, with Git (and probably hg as well). I was talking about other backends, where users are used to describing a revision by diffs alone. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 10:34:14 2019 Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 15:34:14 +0000 Received: from localhost ([127.0.0.1]:53224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXoTG-0002kz-CC for submit@debbugs.gnu.org; Thu, 21 Nov 2019 10:34:14 -0500 Received: from mail-ed1-f54.google.com ([209.85.208.54]:38042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXoTB-0002kh-Sl for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 10:34:10 -0500 Received: by mail-ed1-f54.google.com with SMTP id s10so3165777edi.5 for <38044@debbugs.gnu.org>; Thu, 21 Nov 2019 07:34:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7phs0Vbs0rhSpCHKHO1Sy6w2jprN8E9hLt+tSUV1LLc=; b=m1qGRNOcnq/0U+zn6sUcVc9dWO3tXAzmRsdn3oiL/Eox4oTRnZ5WCpyDkW/OaczefD ItMj0dw8siZMAZ6FMF2VGgL/9LG1g/QroqE4mVMUmHJSBOAdvEao1fyR7F2HopogJVcu Nhv9sqcYOlkDNn70c1x0DUp3Rz9nyAsgY1WC6EtMzDWF3K1sT+RWOmP/M2mnRyLRh2rr v7cdHYFjzUjCYkYkKHKTnabQhw1jO2dUfuPKBMtztXZ0tsgOgFMS79TQkyOHAcNJ1coj BPHtBAfOv9cEmZXLzkEiCoa2pV0CAT/r33Z4dVQ1YH5nZPugij3shh8kxVaJ0Cpx0CfU bqAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7phs0Vbs0rhSpCHKHO1Sy6w2jprN8E9hLt+tSUV1LLc=; b=NvrvdD8XuIsJzoWb7WV13Ja36RLpouKq7Ca3p+IR5DscEuOEVEASCcmfEpkH2EF+lv xR3kGbd101q2m/8WjKuNi7eBlpWE1zspBrSCB+CKwFT3qier9iMzG/FWnL/ei7R8B6wM w01uwAJQSeAhAIrZvMo0S0mJ062yVbiK2HUPiSBwC8bYfuZuP8uZFp2L2fr4HgwFa2Tm IFTm9JNmZC2WOINV1gHYkHUCUm66no+SM1RizX9sY8Y1IL8HXDnkDcx/MSS1J/PT4IV1 qJEo3oiyl2LIhZnwe1QSSbOCQdYF2jQ2yMul9pUuYnwElzOkXTrXOm/0qT/EkbihX4Zi BX6w== X-Gm-Message-State: APjAAAXbZaKtGPW6smf5PN3NIBtZ2JcoqsSgQKnTVc5YxiFDMt0PoA+C fa0xTpqOGSQu3KvA9Ks1NQYodSjD X-Google-Smtp-Source: APXvYqwignAUVXTL0EmEiUzJftbzg+9/0kutnhX0XWLswellReGeMtuDqkAmb62Rzt3TVnErCGKStw== X-Received: by 2002:a17:906:2f09:: with SMTP id v9mr14496751eji.91.1574350443079; Thu, 21 Nov 2019 07:34:03 -0800 (PST) Received: from [192.168.0.149] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id h23sm104748edj.77.2019.11.21.07.34.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2019 07:34:02 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii , Juri Linkov References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> From: Dmitry Gutov Message-ID: <2aa7b032-b11a-5cd3-e394-f83f313f3f9e@yandex.ru> Date: Thu, 21 Nov 2019 17:34:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83r221xoll.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 21.11.2019 16:59, Eli Zaretskii wrote: > The reason I think this should be a vc-diff subcommand is that most > kinds of VCS describe a revision as diffs. I strongly disagree with that idea. When we create a revision, we specify both the changes, *and* a commit message. And some other metadata, like author, etc. That happens in *every* VCS I had worked with, starting with CVS. So no, a revision can't be described simply by a diff. The info should include all of the above. Any VCS that doesn't support commit messages, etc, can simply show a diff. But we shouldn't cater to the lowest commit denominator in the API. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 10:50:22 2019 Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 15:50:22 +0000 Received: from localhost ([127.0.0.1]:53229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXoir-00038X-Qk for submit@debbugs.gnu.org; Thu, 21 Nov 2019 10:50:22 -0500 Received: from mail-ed1-f53.google.com ([209.85.208.53]:37473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXoiq-00038I-FH for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 10:50:21 -0500 Received: by mail-ed1-f53.google.com with SMTP id k14so3215505eds.4 for <38044@debbugs.gnu.org>; Thu, 21 Nov 2019 07:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BDTazJ4PYSHRaet8EOkxnZLhVuxIhSgdg8Zf/tihVMM=; b=c++0kNPOKeKweEjlmIcMZ0i7thLr4kdZOiXb7c128MePcKcUPlLUzWXi5m41M7CaBi RxaB5VArkqBK5ZJYTq6HzlziAcfQ3tBeWu2pf+L9gyZaUeGODHwozOytGqWte73yEZcU 0Zn/vC8X9eSgcRnxOebeDo9Us94A2v8uf0sRGiwnkwUg77IP0xZqaNpB6ZNmm9yhjh/n k+uZIi0czlaRdNfRK5s1CbpZEGmiQJYW1HJOZkhJl+osamfv6kafokDaSbrCWp0Lf8AC /fEFoTssvPVlkF3DXXgCXkjKZYtScQmj1VvETnNdSmdpANYDTR+VO1piNNH01MfkWNsp OJWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BDTazJ4PYSHRaet8EOkxnZLhVuxIhSgdg8Zf/tihVMM=; b=fSjoWxpiB1ODHvJWBUEryeQuXZ8BdIT/tW82HNbmCYg9eRgSw271cP5biPQb5y9RtO JoIo+M0Lj8L+1Warrj55rcR8XWR5ToBAIfxOULX4mzcAOuzxG2MxW2ZfwyTXhhCpGUj2 nqjbP6Tb0Jy2RloQa0ElNmCZ8Vn2rmHR6FTlUj+u6vXpNrfqwZhfBayyKshuJP7pPzxH mCkXGsyjyH1b4MKoGxl3Bd8g8RpKaYvk768Jfuhyw8GJkneKy2zuQk+N7KwUS43nfWbS yHS+VOsGMoqSOeyOYkqZgSQ4EvnhbgrDPs7qJLj0I+MfnYfoCYFsPqJhAsPSZr5CLjM3 rZcQ== X-Gm-Message-State: APjAAAVmsho26H4gX6LFsHaemLAJkfTy66Flu+V/EBtYA6arOBbIXVfr EPyF9OZg4ZktYLV/N4YP5nnp3wzt X-Google-Smtp-Source: APXvYqyNDVSY3hjUJ1cs4sJ8gMBuFV5PRjlZ5JuVnnQOb1iUX6lg/wlwpbbVzQMdAjg9VAuxiKeY6A== X-Received: by 2002:a17:906:4e48:: with SMTP id g8mr14437587ejw.67.1574351413960; Thu, 21 Nov 2019 07:50:13 -0800 (PST) Received: from [192.168.0.149] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id z31sm109125edz.13.2019.11.21.07.50.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2019 07:50:13 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii , Juri Linkov References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Thu, 21 Nov 2019 17:50:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83r221xoll.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 21.11.2019 16:59, Eli Zaretskii wrote: > I'd prefer this to be a variant of vc-diff, and bound to "C-x v =". > The "C-u C-x v =" form is already taken, and tweaking it to accept a > single revision would not be easy. So how about "C-u C-u C-x v ="? Okay, I see what you mean now: you're basically suggesting to tackle the new behavior (the one everybody wants apparently) on top the 'diff' backend action. Which can kind of work, but I don't see why we would make that choice. Adding a new backend command is relatively cheap, and we won't force the backend implementation to try to reconcile incompatible arguments (e.g. REV1 that is not a parent of REV2 and SHOW-METADATA=t). I also think the current patch proposed by Juri is cleaner than the one that is required to implement your idea. Finally, "C-u C-u C-x v =" doesn't look semantic enough for me (revision != diff in my mind, at least not entirely). I think it would be nicer to have a new command, but opinions welcome on this. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 13:33:40 2019 Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 18:33:41 +0000 Received: from localhost ([127.0.0.1]:53311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXrGt-0007KA-0Y for submit@debbugs.gnu.org; Thu, 21 Nov 2019 13:33:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXrGq-0007Jw-LU for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 13:33:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXrGk-0003LK-93; Thu, 21 Nov 2019 13:33:30 -0500 Received: from [176.228.60.248] (port=2790 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iXrGj-0008T3-LN; Thu, 21 Nov 2019 13:33:30 -0500 Date: Thu, 21 Nov 2019 20:33:41 +0200 Message-Id: <83a78pxenu.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Thu, 21 Nov 2019 17:50:10 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 21 Nov 2019 17:50:10 +0200 > > Okay, I see what you mean now: you're basically suggesting to tackle the > new behavior (the one everybody wants apparently) on top the 'diff' > backend action. Which can kind of work, but I don't see why we would > make that choice. I think it's the logical place for such a command, because, as I said before, in many VCSes a description of a revision _is_ the diffs of that revision against its parent. That is how we always presented a revision before Git. And "git show" also presents diffs, it just prepends some meta-data to it. So it's actually a minor variation of "diff". > Adding a new backend command is relatively cheap, and we won't force the > backend implementation to try to reconcile incompatible arguments (e.g. > REV1 that is not a parent of REV2 and SHOW-METADATA=t). I agree that adding a command is cheap. But it makes the system more complex and harder to remember and make sense of. So IMO we should only add a new class of commands if the command is radically different from others. > I also think the current patch proposed by Juri is cleaner than the one > that is required to implement your idea. I think the difference is very small, because the function Juri wrote can simply be called from vc-diff given a special value of prefix arg. > Finally, "C-u C-u C-x v =" doesn't look semantic enough for me (revision > != diff in my mind, at least not entirely). I think it would be nicer to > have a new command, but opinions welcome on this. I think that's because you keep the command issued by the backend in mind all the time, and that command is not "diff" for Git and Mercurial. But the output is almost exactly that of "diff", so IMO the mental model is simple and easy to remember. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 14:09:00 2019 Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 19:09:00 +0000 Received: from localhost ([127.0.0.1]:53345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXrp5-0008Dv-Dh for submit@debbugs.gnu.org; Thu, 21 Nov 2019 14:08:59 -0500 Received: from mail-wm1-f50.google.com ([209.85.128.50]:40941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXrp3-0008Df-AA for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 14:08:57 -0500 Received: by mail-wm1-f50.google.com with SMTP id y5so4982828wmi.5 for <38044@debbugs.gnu.org>; Thu, 21 Nov 2019 11:08:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GH+nttOv+tLMKHliuc5zHxohoI7VfdnCa1fmahy2TRY=; b=BHp/aBS8zkKTAO2T3/M0uezg0jiOIajEgB9FOaaSSvUAg5/TvJ4KA+YIgXNjwFVkiU 0PluBMNnaUpb++mKIDENhZAdam0iqE7v41feLWoTewGZ90zkQfAQjRjaPTVaMCq4gRBD gN7q7goiSawhmJtvNDluy9WxIerSsjF1S7TTEjQyqN+QUVNBiR0astBFZkcunylt8GmP ICel42XBn9rt4LkDt93FP1QAsQhcHsw0Z6fnEYRYF7QdiVcEcX04efZZp7aJ5Pc45W4X evzPVJ5tUIHmKjR8XXccCnu+dYshd0Qpj/E4Ad1GV8wrhvZlkajLXmV5IqBcajJXHFal CiKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GH+nttOv+tLMKHliuc5zHxohoI7VfdnCa1fmahy2TRY=; b=Zw8fQSbT6bm9GMqGaBUwiCyHmWP4IizQEgiZPYFQ7TasgaxuhLsM8er+W9aXg2/Crb ETKA4xqOqm/NgGfq81Qs4sx5X4McWzqEqRm42vteujK3MzjxB///gNrCCfPISpiFEDDy Tgp9LIBf5K90dZA5ai2Ek57Dnc93+6np+K+Vo7F7P2ivhWVYfDSXZAistlUBjmL48GnC D7KUnf/Y2w6OQnHDVQ2DO3YVBoq/AR8dFLIsDhcWAAsKNu7lYuU6l7RzHxII8AZRKbfL NGpa9VNSk6b4vdBrFNIlfWqZvQk4P3YCNW7UrEuK5fS08bo4QmtzEXbe4+now2Cbr39a NBZA== X-Gm-Message-State: APjAAAU5HwoCnFXhoFTqV/YurXFjaymWka2D0/K9bhE73IZR/ZHPugjE veI9LjHyabTyftafbnBttmItGJnJ X-Google-Smtp-Source: APXvYqzzFCUy+RZPczBhhFkmpzxZFMcx5pCdBokDz0Zt//wy8LkkLXYQ5qCspAqmY9kooQm8Xg+4ig== X-Received: by 2002:a05:600c:299:: with SMTP id 25mr12429177wmk.50.1574363331141; Thu, 21 Nov 2019 11:08:51 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id 188sm623036wmz.13.2019.11.21.11.08.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2019 11:08:50 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> From: Dmitry Gutov Message-ID: <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> Date: Thu, 21 Nov 2019 21:08:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83a78pxenu.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 21.11.2019 20:33, Eli Zaretskii wrote: >> Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org >> From: Dmitry Gutov >> Date: Thu, 21 Nov 2019 17:50:10 +0200 >> >> Okay, I see what y [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnus.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.50 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.50 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 1.0 FREEMAIL_REPLY From and body contain different freemails X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 21.11.2019 20:33, Eli Zaretskii wrote: >> Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org >> From: Dmitry Gutov >> Date: Thu, 21 Nov 2019 17:50:10 +0200 >> >> Okay, I see what you mean now: you're basically suggesting to tackle the >> new behavior (the one everybody wants apparently) on top the 'diff' >> backend action. Which can kind of work, but I don't see why we would >> make that choice. > > I think it's the logical place for such a command, because, as I said > before, in many VCSes a description of a revision _is_ the diffs of > that revision against its parent. That is how we always presented a > revision before Git. And "git show" also presents diffs, it just > prepends some meta-data to it. So it's actually a minor variation of > "diff". "As I said before", when a revision is created, we fill in a number of different fields, most importantly, the commit message. That's in every VCS except some ancient ones. So to show a revision means to show all that stuff. The fact that some VCS's command line doesn't provide an easy way to do this is incidental. >> Adding a new backend command is relatively cheap, and we won't force the >> backend implementation to try to reconcile incompatible arguments (e.g. >> REV1 that is not a parent of REV2 and SHOW-METADATA=t). > > I agree that adding a command is cheap. But it makes the system more > complex and harder to remember and make sense of. So IMO we should > only add a new class of commands if the command is radically different > from others. An awkward implementation is even harder to make sense of. And creating a function that does something different based on an optional argument is bad programming. Anyway, we could implement this new command using *zero* new backend actions. Even without calling 'git show'. >> I also think the current patch proposed by Juri is cleaner than the one >> that is required to implement your idea. > > I think the difference is very small, because the function Juri wrote > can simply be called from vc-diff given a special value of prefix arg. Does this make sense for anybody else here? For me, the diff command, even VCS diff, is about showing differences between file trees, or states of the file system. Not about describing one revision. >> Finally, "C-u C-u C-x v =" doesn't look semantic enough for me (revision >> != diff in my mind, at least not entirely). I think it would be nicer to >> have a new command, but opinions welcome on this. > > I think that's because you keep the command issued by the backend in > mind all the time, and that command is not "diff" for Git and > Mercurial. Not necessarily. And see above. > But the output is almost exactly that of "diff", so IMO > the mental model is simple and easy to remember. We all have our biases. You apparently dislike Git (VCS used by most of everybody these days, including our users) and prefer the way command line interfaces looked in previous systems. That's a valid preference, but it's unlikely to reflect the expectations of most of our users. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 15:19:05 2019 Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 20:19:05 +0000 Received: from localhost ([127.0.0.1]:53364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXsuu-0001eC-S3 for submit@debbugs.gnu.org; Thu, 21 Nov 2019 15:19:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXsuo-0001de-VM for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 15:19:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXsui-0006kU-3W; Thu, 21 Nov 2019 15:18:53 -0500 Received: from [176.228.60.248] (port=1558 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iXsuh-0002sC-Fg; Thu, 21 Nov 2019 15:18:51 -0500 Date: Thu, 21 Nov 2019 22:19:03 +0200 Message-Id: <837e3tx9s8.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> (message from Dmitry Gutov on Thu, 21 Nov 2019 21:08:49 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: juri@linkov.net, larsi@gnus.org, stephen.berman@gmx.net, > 38044@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 21 Nov 2019 21:08:49 +0200 > > "As I said before", when a revision is created, we fill in a number of > different fields, most importantly, the commit message. That's in every > VCS except some ancient ones. So to show a revision means to show all > that stuff. Here's an alternative proposal. It seems like almost all VCS backends we support provide a variant of a "log" command that shows the diffs together with the usual meta-data shown by "log". Only RCS and CVS don't have such an option of "log", all the rest do (most of them via "log -p"). So we could make this a subcommand of vc-log, more accurately vc-print-root-log, such that "C-u C-u C-x v L" will prompt for a revision ID, and display the information produced by such a "log -p" command (and fall back to displaying just the diffs for RCS and CVS). Does this sound better? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 16:05:32 2019 Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 21:05:32 +0000 Received: from localhost ([127.0.0.1]:53387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtds-0002kO-AT for submit@debbugs.gnu.org; Thu, 21 Nov 2019 16:05:32 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtdq-0002k6-4e for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 16:05:30 -0500 Received: by mail-wr1-f68.google.com with SMTP id t2so6193781wrr.1 for <38044@debbugs.gnu.org>; Thu, 21 Nov 2019 13:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EDpVRbz6a3E6v20985EMr4p+kA6OGt5Yv0OmUfI3rO0=; b=A8/9iX12/vVayKVVCXSmcGlL18qSYQzUvarMXJq13PdNdibJTMrh8PR/LZiMaYS0zS vCXqOBd3JCv0A66NDw+CzJnCkdD+n8mWqN97I/8e/fM+d4IIFxM3D+48S+cs5BdP9Crq 60WUXLvLvsGLXnFrDXQZA/16Jpxfo2azDeSPpBZw+5Hbzg3XgUikKcmk61CGwCAMXZdH fr87/W1fThC4yU8RSBJwEXUYbm9SUXxYwd0nHbQUhhYFUR2wUr3m1gU+Dpxe35Gl7zHA raxCeH1SN6YbrDAHmXONtZICPEBeLF2dJ6yahAb/p5On0JpFBb3aqwtQfibw8GIIZcMv ExZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EDpVRbz6a3E6v20985EMr4p+kA6OGt5Yv0OmUfI3rO0=; b=SAGPEzyDBuFLp1nXfZ6dyP6RFJQA18tRrdeVg+89pEhV0Opig4O91RnHlX7HzJFeSc lzl/Qp2Vgcxflx/NCB1pfGw2CbiY7tHg3NbdhJS3l5Q85SbuWvfYSyq9FCkeX2yn0hJd tGN/4XqoLh6tq6oJ40UHWYxCX8xcSFinJRPWNE6hI4x5tumEocdDhjjQcEGm8fnx9PF9 gLGg8k4LB1JARGPHz1fAEIwfx+k/UDvHYEgEZ9MDjqCveeNKZEZwTlrrzGKX1T8TwGgI 44hDgDdwE2Hy7VD9+j1PRaxGk3VF1sTrTosWujod9FcErzwBeaB1hD9KJO7EVv0GPzYI TbVg== X-Gm-Message-State: APjAAAVkRFwXuS7gkzB5ZPjDNCJUTE/6LdF/8e7QKw744cFaVFIRE/+7 wN6+TBF0ROj+m2ErnxSkJ9E= X-Google-Smtp-Source: APXvYqxpw32jvqDjBgJdvLY091CsPoCZRC2e8PHWxtezm87ZJ+vi8YdxcdmAcVmZoh9pb8bw1FYobw== X-Received: by 2002:adf:a497:: with SMTP id g23mr13796414wrb.129.1574370319514; Thu, 21 Nov 2019 13:05:19 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id 205sm1160103wmb.3.2019.11.21.13.05.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2019 13:05:18 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> From: Dmitry Gutov Message-ID: <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> Date: Thu, 21 Nov 2019 23:05:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <837e3tx9s8.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 21.11.2019 22:19, Eli Zaretskii wrote: >> "As I said before", when a revision is created, we fill in a number of >> different fields, most importantly, the commit message. That's in every >> VCS except some ancient ones. So to show a revision means to show all >> that stuff. > > Here's an alternative proposal. It seems like almost all VCS backends > we support provide a variant of a "log" command that shows the diffs > together with the usual meta-data shown by "log". Only RCS and CVS > don't have such an option of "log", all the rest do (most of them via > "log -p"). Somewhat better, but all backends would have to be updated anyway, for this to work. So the change in VC backend API is comparable to adding a new action. I don't mind this too much (asking vc-git-print-log to include the diffs makes sense, at least), but doing it this way loses out on the opportunity to support all backends in one fell swoop. And we can do that by adding a default 'print-revision' implementation that calls two other backend actions (print-log and diff). Or, again, we can do that for all backends and forego a new backend action altogether. > So we could make this a subcommand of vc-log, more accurately > vc-print-root-log, such that "C-u C-u C-x v L" will prompt for a > revision ID, and display the information produced by such a "log -p" > command (and fall back to displaying just the diffs for RCS and CVS). > > Does this sound better? I hardly see myself ever choosing 'C-u C-u C-x v L' instead of 'M-x vc-print-revision'. Simply because I'll never remember the former. Are you really that against a new command? Considering we have vc-print-branch-log for simply showing the same thing for a different branch, that feels... inconsistent. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 16:15:46 2019 Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 21:15:46 +0000 Received: from localhost ([127.0.0.1]:53396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtnl-0002yh-RI for submit@debbugs.gnu.org; Thu, 21 Nov 2019 16:15:46 -0500 Received: from mout.gmx.net ([212.227.15.18]:44281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtng-0002yO-PN for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 16:15:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1574370927; bh=sKqHobDPKSwtnq4jeCXqPnUNg8jWKZu23uH12PDosO0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=izVfn16y0h3qTrVoprZQ2+XRaWYvA5GUnHMHEWGtv2wwFh60X5mjQKrGqbGqYyefd 7zZBA7w23jEqeT1Ni71wrkFDUaM6wxlMv597H0WPyCsGgJbokAN2Pvy/4tgLAzezL8 p1QYoNLt6puoTgVgguEf88R8LUxGBX0R5JnqN69s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-lfs84 ([92.78.62.223]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1McYCl-1hzvYQ0Z01-00d1NV; Thu, 21 Nov 2019 22:15:27 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> Date: Thu, 21 Nov 2019 22:15:21 +0100 In-Reply-To: <837e3tx9s8.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Nov 2019 22:19:03 +0200") Message-ID: <87pnhl9biu.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Ag2iJx3jjsdaLWp0uiUguW9GaLj5uUTCnx5LvNiqal2/YOS3MUE /3odyiCRu3z7nW1OBme6vI8H/iekMCpASnwxSaxZkpxh+XCnRRuYT1qN7Esfma6HP2NgPG8 AZ+vs7KXTQIKNRpdRJgbE36MpVZKPslTDqqstOEKO9AmlxvNVZFVRlwMRBbTRXry56QL26i 1cayell6ormaU7ZSItrcg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:xG1T4DlSe1k=:mq4Rvyo4QpKVRftqmdqIGb KioCd7a+Lez+nmF2ZbM7T72qVeayfvhVPuRXKTaL/+v04K+tqbJpKlhTEn/PgK5U/XwCkQs18 j1/2JgPQX74y+34zOg4HwWTLu17z/tajADPQfe/SffkwWejM7QQ8b15hFF/Amlf0dYs3VT+Gf C+6aHAuh/Wby9BNvDQ70JSQCntBjd8BdiP6Z464l0BX2IIUwOJyq/d9a7I4I5xAIZoVJaUSE8 OoBio+q6NvGawX4NOpervc/umsY6V3U36aszaa2IJZSw2W6GXSZgIwQVrp3Kl0OBr4PK/6CEz LJSBs+xkZySO8BP6OFV9milbP2nGbgxvt7FugfykyseD+LS7vulqps3qoBFeaqjhR+r8fqsMd KMrjwkOeqIip8hW4y4cvrqrGw72TIGou+nP4zeCmEXNDph004k4XHq4HRGlIHZX/jgtxlxDSO xtLiQTb3wAk0l/jU6ZaIZA15+Fid0qC+d0SnKmSjbS592+Re9FAbxbaMOUWXoEL4J7UKnQPuS 1p5e+0FlDnO3suJcDLWMTy1CnAQE7qmIxVfbvoeaZwz/kjL+MvW3Eb/iOJr14JeQpz4kO6BVO Zmdh3L8PsrQlaelklMFdmj6/SQEdfa+wvoJfV5jPa8UyUi3KkQTB+98w0w46y7L2QC5rwE+NH j8E8mLymraKE1FccER+LSFaGPbeXUQbB93Xf4/qeajg7fih9cS/tvHZo5g4YRtn3/QMe0cFxO hRir8LvxIaHm27xhWFwATlwUylrfOJxiZnD+YwrWmGSuKf1poESFldZYY8nmr5tY3nYrMEb33 5J+VMI359fQS+boNN5v29R1rUnFdhrJuKfZHCk3/b2FhRbCdMatbFboTDg4LFtmGpfE0yfTrG hR7MvUysHoWtiXoFIjZoSl7fTPuRDz3DRfzlWSYwf5i9wTFLa2WPJlzAo+9giZGpQ+fou9SCM 9eXaNHOXAwCEpWNFDKAZYBqIEWcQd58QdCuVOgp2+r3fQdLNvMGbNk4S/lA8MuvE586BzLE1k OKrq9/Q94FLdp6x2EGp8CmHKNLfXkbPgtptyyOiUeKbf+/JpZwSEwHbL3uMILdCI1tJQuAhti 8e4LwXuuDlnpovtpznmzhBpjlo0pgLiefd9M4FTCpr67QT+0hxmx1iaoHehA0WS/zdENHHvIe zHfKMXT6ChBWLi8ZuH1P0Z4BZEatxC2abgpGp2neI7SJMEuZvT9uKYYfMHmdreeAfqpsoI5FI 9pz1cJSKj/8klSa0vtcQtS6GERkw2XTzHElEtKlAjVlFtFyoYWRIHHWyyIWw= Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, juri@linkov.net, 38044@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 21 Nov 2019 22:19:03 +0200 Eli Zaretskii wrote: >> Cc: juri@linkov.net, larsi@gnus.org, stephen.berman@gmx.net, >> 38044@debbugs.gnu.org >> From: Dmitry Gutov >> Date: Thu, 21 Nov 2019 21:08:49 +0200 >> >> "As I said before", when a revision is created, we fill in a number of >> different fields, most importantly, the commit message. That's in every >> VCS except some ancient ones. So to show a revision means to show all >> that stuff. > > Here's an alternative proposal. It seems like almost all VCS backends > we support provide a variant of a "log" command that shows the diffs > together with the usual meta-data shown by "log". Only RCS and CVS > don't have such an option of "log", all the rest do (most of them via > "log -p"). > > So we could make this a subcommand of vc-log, more accurately > vc-print-root-log, such that "C-u C-u C-x v L" will prompt for a > revision ID, and display the information produced by such a "log -p" > command (and fall back to displaying just the diffs for RCS and CVS). > > Does this sound better? If it's to be assigned to an existing VC command and key binding, I think `log' is better than `diff' (FWIW, I named the git-specific command I wrote for myself, posted near the top of this thread, srb-git-log). However, I'm not thrilled with the thought of having to type two prefix keys to invoke it. Since one of the desiderata of this command, perhaps even the main one, is that it should act on the revision ID at point, how about making just `C-x v L' do that if it recognizes the word at point as a revision ID? If this is deemed to unreliable, it could be conditioned by a user option, or perhaps (though more annoying) by asking for confirmation. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 17:36:30 2019 Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 22:36:31 +0000 Received: from localhost ([127.0.0.1]:53454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXv3s-00053E-J4 for submit@debbugs.gnu.org; Thu, 21 Nov 2019 17:36:30 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:41076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXv3q-00052q-4Q for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 17:36:26 -0500 Received: by mail-lf1-f66.google.com with SMTP id m30so2090331lfp.8 for <38044@debbugs.gnu.org>; Thu, 21 Nov 2019 14:36:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :cc:to; bh=aCqh+oNjtkXS+R6mNxWjJDvEM01Gk33vKuuw3TavTns=; b=ijveMRbLLvehDU1hwpGnOROX5lvSIgAhCf2iHFgDfid3gzn7jln6W6BEVVCLGu+qwP AWFCL9NPpjyFtqQQmSaWH7BKIlFlDXkM0HTG1STGgGa2iW8J6DfqrHQ/mPabjWCTgbRc OHhYQ3wneZovkMCv8KFKoG4STSejVykVTUAlgwsG+Wiy3FYaTk17TVreJEAPU1odyPIl FJ5eDHYljFlhXBBGY1fL3yeVsdlk0eCgqzHJV9GZ+oMXR8ZwHxfSRmMDeKQPy30eAAqx S7uUkQajZtmbg5a/K6X5tnpjk3amoTF6BVnByT9UEf1wDncQWRvFvsynoy3ownaomHac vGGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:cc:to; bh=aCqh+oNjtkXS+R6mNxWjJDvEM01Gk33vKuuw3TavTns=; b=Oc3VhwTVjfX0JJwiypqvB8lImHA6gAKSw7yhyI4jQi+OOe+RXojGoCT/MmPV5n1S6o k2ic653eQcCLnDdEt5dimtW5tFkDTzdRpJJV+WYN4NJyXt9QwcgV3Qd/hZvLeAmVhBS7 Ud9bfnGD8OGC8mdEymwqt1H5y6Cibj/5QFs+KzUv+GpJ0Pr7tsK96ja/fVH21ajPE0Fx uED6XcCPZDubvRx6uBk9tq0xeJwX+WKPrzi80FLVj/INIG8+IRGR/BDfEo/uJ0J7cAFi H4yGVAu5BWuNbzOiLxewgzvCLJ4lEQ5OvAHj2KvGgyutNcnK5deIDjSAoD9ZGe2gsxAG yWTw== X-Gm-Message-State: APjAAAVcV93E/q8JAeo2JuILtGKMZ4hHoSnmQqV3pssXlsLzrUsMKGhQ vQhNf9cFKTOS3K6XlH8zuss= X-Google-Smtp-Source: APXvYqzSQxqWM60Gh8R5eRBG1MmsplOcDjboG8Nwezg9y41RU03zh7VLSRo1TXNnUm30RgowgYvEmQ== X-Received: by 2002:ac2:5935:: with SMTP id v21mr9701978lfi.19.1574375779998; Thu, 21 Nov 2019 14:36:19 -0800 (PST) Received: from [192.168.0.104] ([91.206.110.132]) by smtp.gmail.com with ESMTPSA id x9sm2120232lfn.21.2019.11.21.14.36.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2019 14:36:19 -0800 (PST) From: Andrii Kolomoiets Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\)) Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Message-Id: Date: Fri, 22 Nov 2019 00:36:18 +0200 To: Eli Zaretskii X-Mailer: Apple Mail (2.3601.0.10) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, > Ah, okay. Btw, region-history-mode is a Git-only feature, so I don't > think I understand why it is in vc.el and not in vc-git.el. Experimental option 'line-range' to command 'log' is added in mercurial 4.4 'region-history' is also implemented in vc-hgcmd. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 18:56:30 2019 Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 23:56:30 +0000 Received: from localhost ([127.0.0.1]:53560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXwJK-0002aK-3z for submit@debbugs.gnu.org; Thu, 21 Nov 2019 18:56:30 -0500 Received: from bird.elm.relay.mailchannels.net ([23.83.212.17]:22064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXwJG-0002a9-Cm for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 18:56:28 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 0E7825A092D; Thu, 21 Nov 2019 23:56:25 +0000 (UTC) Received: from pdx1-sub0-mail-a23.g.dreamhost.com (100-96-15-77.trex.outbound.svc.cluster.local [100.96.15.77]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 86BC45A07EE; Thu, 21 Nov 2019 23:56:24 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a23.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Thu, 21 Nov 2019 23:56:24 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Fearful-Ski: 5b2e0f3871cfb6e1_1574380584809_3040190497 X-MC-Loop-Signature: 1574380584809:1619877265 X-MC-Ingress-Time: 1574380584809 Received: from pdx1-sub0-mail-a23.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a23.g.dreamhost.com (Postfix) with ESMTP id 33502AA00E; Thu, 21 Nov 2019 15:56:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=QgOHhA2Zs67yLqAjB/i7S61MHio=; b= xv0m4pz86fllhDNIp0191IxohLr4+W0jqsJW/ezfv+84H896yJNAgSWeUe2UyTZU h22niZmQcgmkLAEXWf0MCL9wGAt5I8Yjc1eaPSA5QELK1mUARXw+Ett4QY0qyK6x eOPNpyceEVTq92PGYDiKU03N64mWopybm5jOPo1da3c= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a23.g.dreamhost.com (Postfix) with ESMTPSA id 408ABAA010; Thu, 21 Nov 2019 15:56:15 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a23 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <29e2e877-6dc3-b03b-7463-01cff35e05d1@yandex.ru> Date: Fri, 22 Nov 2019 01:08:17 +0200 In-Reply-To: <29e2e877-6dc3-b03b-7463-01cff35e05d1@yandex.ru> (Dmitry Gutov's message of "Thu, 21 Nov 2019 01:37:13 +0200") Message-ID: <87pnhkern2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: Eli Zaretskii , stephen.berman@gmx.net, 38044@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > The approach LGTM. I'd have used "describe" or "show", but it's not > important. The name vc-print-revision was modeled after vc-print-log, vc-print-root-log, vc-print-branch-log that are not the best names but at least consistent for their prefix. >> (setq default-directory rootdir) > > This probably needs a saving (let ((default-directory default-directory)) > ...) above it. This is intentional because on testing I discovered that RET on the diff part of the buffer can't visit source files when default-directory is not root. >> + (read-shell-command >> + "Show revision with command: " >> + (format "%s %s" vc-git-program >> + (mapconcat 'identity args " ")) >> + 'vc-git-history) >> + " " t)))) > > If wonder if some user someday is going to try and input there something > that doesn't start with 'git '. Someone might want to use a wrapper script. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 18:56:37 2019 Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 23:56:37 +0000 Received: from localhost ([127.0.0.1]:53563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXwJO-0002ab-Fe for submit@debbugs.gnu.org; Thu, 21 Nov 2019 18:56:34 -0500 Received: from buffalo.birch.relay.mailchannels.net ([23.83.209.24]:64789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXwJL-0002aR-Ok for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 18:56:32 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7623E5A0AB3; Thu, 21 Nov 2019 23:56:30 +0000 (UTC) Received: from pdx1-sub0-mail-a23.g.dreamhost.com (100-96-6-199.trex.outbound.svc.cluster.local [100.96.6.199]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C579D5A0FCA; Thu, 21 Nov 2019 23:56:29 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a23.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Thu, 21 Nov 2019 23:56:30 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Bitter-Gusty: 04ecbb180e5c9753_1574380590248_3947988572 X-MC-Loop-Signature: 1574380590248:3722775322 X-MC-Ingress-Time: 1574380590247 Received: from pdx1-sub0-mail-a23.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a23.g.dreamhost.com (Postfix) with ESMTP id 27076AA010; Thu, 21 Nov 2019 15:56:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=RHkdI4LBGwtyyFSYO+E8oacOqWo=; b= O91/P2RSSqWEV8wrpd4guJmLlBjNsPcG8up9M/RWRxjLKRjym9K9zN3DWNXext8l ATmSZNj6AnNJ9XshMIVFYMzyN0nFAXvSyCrnntGCbxtUmhb9U8VljPEUUVXUNFPZ Pu3UWZB9UAeQ3afXSHlAzaOGy3CK1GjsvAB1P1RtSVs= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a23.g.dreamhost.com (Postfix) with ESMTPSA id 9B2F5AA011; Thu, 21 Nov 2019 15:56:23 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a23 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> Date: Fri, 22 Nov 2019 01:13:23 +0200 In-Reply-To: <83r221xoll.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Nov 2019 16:59:02 +0200") Message-ID: <87zhgobxcd.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> It doesn't use 'region-history'. I meant using 'region-history-mode' >> on the output buffer. > > Ah, okay. Btw, region-history-mode is a Git-only feature, so I don't > think I understand why it is in vc.el and not in vc-git.el. Maybe region-history-mode is not the best name, but at least it provides fontification for revisions composed of both the commit metadata and the diff of changes. > The reason I think this should be a vc-diff subcommand is that most > kinds of VCS describe a revision as diffs. Where a revision's > description is expected to include meta-data, i.e. the VCS backend > provides a command to show a revision in that format, we should use > that backend command, of course. But conceptually we just show diffs, > so inventing a whole new class of VC commands for a minor variant of > diffs display sounds sub-optimal to me. Similar to wave-particle duality, in revision's duality the revision may be described as either a log metadata or a diff depending on the observer's point of view. A new separate command resolves such dilemma. > Also, why only implement this for a single backend? The corresponding > diff commands exist in every VCS we support, so let's implement this > for all of them, okay? Let us know if you need help with other VCSes. A new command was intended to produce the output similar to e.g. http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6f30642973975a317a9c94ceba737a4bafc89919 i.e. first comes the metadata, then the commit message, and finally the diff. Do other VCSes or their interfaces produce a similar layout? From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 02:20:02 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 07:20:02 +0000 Received: from localhost ([127.0.0.1]:53650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3EV-0005qR-UL for submit@debbugs.gnu.org; Fri, 22 Nov 2019 02:20:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3ET-0005qE-Ah for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 02:19:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY3EM-0002NS-HC; Fri, 22 Nov 2019 02:19:51 -0500 Received: from [176.228.60.248] (port=1908 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY3EL-0006rh-OT; Fri, 22 Nov 2019 02:19:50 -0500 Date: Fri, 22 Nov 2019 09:20:02 +0200 Message-Id: <834kywxtr1.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> (message from Dmitry Gutov on Thu, 21 Nov 2019 23:05:07 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Thu, 21 Nov 2019 23:05:07 +0200 > > On 21.11.2019 22:19, Eli Zaretskii wrote: > > > Here's an alternative proposal. It seems like almost all VCS backends > > we support provide a variant of a "log" command that shows the diffs > > together with the usual meta-data shown by "log". Only RCS and CVS > > don't have such an option of "log", all the rest do (most of them via > > "log -p"). > > Somewhat better, but all backends would have to be updated anyway, for > this to work. It's new functionality, so that goes without saying. Or did you mean something specific when you said "updated"? > So the change in VC backend API is comparable to adding a new > action. We don't necessarily need a change in the API: vc-print-log-internal has enough arguments to pass this new meaning to it and to the backends. But even if there's a change in the API, it isn't a catastrophe from my POV. > I don't mind this too much (asking vc-git-print-log to include the diffs > makes sense, at least), but doing it this way loses out on the > opportunity to support all backends in one fell swoop. I don't understand why would we lose that opportunity. We will have to write new code for each backend in any alternative, and the code to add is really quite simple, so I'm probably missing something here, but what? > I hardly see myself ever choosing 'C-u C-u C-x v L' instead of 'M-x > vc-print-revision'. Simply because I'll never remember the former. That's fine. > Are you really that against a new command? Yes, more or less. IMO, we already have too many of them. VC used to be simple and elegant, and this proliferation of too many high-level commands makes it more and more complex, and inevitably causes us tweak the user level and UI to this or that particular VCS, which is wrong in the long run. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 02:24:36 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 07:24:36 +0000 Received: from localhost ([127.0.0.1]:53654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3Ix-0005xU-Qt for submit@debbugs.gnu.org; Fri, 22 Nov 2019 02:24:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3Iu-0005xG-Pp for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 02:24:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY3Ip-0003yZ-GV; Fri, 22 Nov 2019 02:24:27 -0500 Received: from [176.228.60.248] (port=2190 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY3Io-0007Gk-Lz; Fri, 22 Nov 2019 02:24:27 -0500 Date: Fri, 22 Nov 2019 09:24:41 +0200 Message-Id: <8336egxtja.fsf@gnu.org> From: Eli Zaretskii To: Stephen Berman In-reply-to: <87pnhl9biu.fsf@gmx.net> (message from Stephen Berman on Thu, 21 Nov 2019 22:15:21 +0100) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, juri@linkov.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stephen Berman > Cc: Dmitry Gutov , juri@linkov.net, larsi@gnus.org, > 38044@debbugs.gnu.org > Date: Thu, 21 Nov 2019 22:15:21 +0100 > > However, I'm not thrilled with the thought of having to type two > prefix keys to invoke it. AFAIU, this command is not something that will be invoked too frequently, and typing C-u twice is not much harder than doing it once. > Since one of the desiderata of this command, perhaps even the main > one, is that it should act on the revision ID at point, how about > making just `C-x v L' do that if it recognizes the word at point as > a revision ID? We could do that, yes. > If this is deemed to unreliable, it could be conditioned by a user > option, or perhaps (though more annoying) by asking for > confirmation. Fine with me, assuming the rest of the proposal is accepted. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 02:40:35 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 07:40:35 +0000 Received: from localhost ([127.0.0.1]:53672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3YP-0006LD-Gk for submit@debbugs.gnu.org; Fri, 22 Nov 2019 02:40:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3YO-0006Kv-7P for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 02:40:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY3YI-0008W2-15; Fri, 22 Nov 2019 02:40:26 -0500 Received: from [176.228.60.248] (port=3159 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY3YH-0002lq-GF; Fri, 22 Nov 2019 02:40:25 -0500 Date: Fri, 22 Nov 2019 09:40:40 +0200 Message-Id: <83tv6wwe87.fsf@gnu.org> From: Eli Zaretskii To: Andrii Kolomoiets In-reply-to: (message from Andrii Kolomoiets on Fri, 22 Nov 2019 00:36:18 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrii Kolomoiets > Date: Fri, 22 Nov 2019 00:36:18 +0200 > Cc: 38044@debbugs.gnu.org > > > Ah, okay. Btw, region-history-mode is a Git-only feature, so I don't > > think I understand why it is in vc.el and not in vc-git.el. > > Experimental option 'line-range' to command 'log' is added in mercurial 4.4 > 'region-history' is also implemented in vc-hgcmd. I know, see commit 1110d14. But I was talking about region-history-mode, not vc-region-history. By placing that mode in vc.el, we now require _every_ backend to implement this mode, which doesn't make a lot of sense to me, and you can see in that commit what that causes for backends that do want to implement region-history. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 03:03:26 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 08:03:26 +0000 Received: from localhost ([127.0.0.1]:53699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3uY-0006tZ-4P for submit@debbugs.gnu.org; Fri, 22 Nov 2019 03:03:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3uU-0006tL-Kn for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 03:03:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY3uN-0001TX-I7; Fri, 22 Nov 2019 03:03:17 -0500 Received: from [176.228.60.248] (port=4559 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY3uL-0005r2-EZ; Fri, 22 Nov 2019 03:03:15 -0500 Date: Fri, 22 Nov 2019 10:03:27 +0200 Message-Id: <83mucowd68.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87zhgobxcd.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 22 Nov 2019 01:13:23 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <87zhgobxcd.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, larsi@gnus.org, stephen.berman@gmx.net, > 38044@debbugs.gnu.org > Date: Fri, 22 Nov 2019 01:13:23 +0200 > > >> It doesn't use 'region-history'. I meant using 'region-history-mode' > >> on the output buffer. > > > > Ah, okay. Btw, region-history-mode is a Git-only feature, so I don't > > think I understand why it is in vc.el and not in vc-git.el. > > Maybe region-history-mode is not the best name, but at least > it provides fontification for revisions composed of both > the commit metadata and the diff of changes. My problem is that having region-history-mode in vc.el requires every backend to implement that mode, if it implements region-history. What that results in can be seen in vc-hg.el, where I recently added this command's implementation. Do you like the result? > > Also, why only implement this for a single backend? The corresponding > > diff commands exist in every VCS we support, so let's implement this > > for all of them, okay? Let us know if you need help with other VCSes. > > A new command was intended to produce the output similar to e.g. > > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6f30642973975a317a9c94ceba737a4bafc89919 > > i.e. first comes the metadata, then the commit message, and finally the diff. > > Do other VCSes or their interfaces produce a similar layout? Almost all of them do, see "log -p" command in each VCS ("log --diff" for svn). And the original request was for describing a revision, so if a VCS doesn't support "log -p", we should simply display the diffs, because that's the best description of the revision in those VCSes. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 04:25:36 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 09:25:36 +0000 Received: from localhost ([127.0.0.1]:53745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY5C4-0000NU-5t for submit@debbugs.gnu.org; Fri, 22 Nov 2019 04:25:36 -0500 Received: from mout.gmx.net ([212.227.17.20]:46927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY5Bx-0000NC-Hr for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 04:25:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1574414718; bh=tyKvk0ic2sjhkWdsZ0Mre6JYGcu/aqYBOYSpLNCzHE8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=M3QLqcmCSaOEXJSBKiyujPtkN/OXV967GiamUdxCTGPsHibAcFpSdUpYxBfG8lsqR BqvfERuHOq6BLWUADNUt2mDsPTEsoNcMpYsaR/gOZbOVpYfaFZ6QUFr0UvS2A+TsyP ItVVDIuZ91Ey7DnbZmIhSQjUIkL9WrDw6XFKzWjc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-lfs84 ([84.61.246.1]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MacSY-1i0OKV3Cd0-00c8ka; Fri, 22 Nov 2019 10:25:17 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> Date: Fri, 22 Nov 2019 10:25:15 +0100 In-Reply-To: <8336egxtja.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 22 Nov 2019 09:24:41 +0200") Message-ID: <87h82wmfes.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:N6nmdpUiQmypJWGSb6sUrn4ofZVr9l+OWUaWzhAr4grfqfM0jNd AA+0CNOa1KZMbo3k4cPjybvJwPpqw+ikMMYAE19Ay3YDijFm9I/jjC39RMl0DtZv3NhxsIA qcwWMDKOj2ISD+4IU4Xfm5EEkgsU2UzoOrmnoXdUCBM40hMJTl1muS+nnc9kXHVvPA7+yWh ng+zGjAjVez+rL3FPRDnw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:W0JBbtYLJeg=:TitLc41kXCH0m7aucL8cLD 7vES24PF/P+/B2bYZ28NqQO/5qglsMFGzeV6TnHximK5PMFFVfkeGNxwdNRvlUVortJDw5eTl VAQanvw1e9zgcFb1nbMMYb63d67JIJJbQmYtb2RVOv/uegjD84cK24TSXTG6dKWLbda+LPGCE VCXi9qAYFiJT+ascQFbRPxznYrMTorLdEcxrOZmkWfBBxVpIse7wn6zb2yYV80ItOgxzDrP49 GW33C1jVTbL3SE9TUOJyH8aiB12J6CVF3KCtUNLjBWQATaE8ETJEIdnOdiwKBXSmCAnbZEK4T MkTorlf0UdLgc4g+/cM1sd4yYCvrJ+5KM/An79r+XVoy2diU1avtqu7iGMcoF95W4WD8gf8+y WkJNclGLITrjKnnd3toYsTNo5QC+pCcW4Z4h13PfJkD9+cRrevaH/1sPz7wroaZ9Htibh7UvQ +HEYEy3itYI1dTyemGAQNq+YgVFI37YvJBSOuU3w2VbMSn3xgSHvvUmzxMPW82/pMQGaRlXq0 HTNuQVGnQc1qrw/c6Horcg+kv0b+HEza94vccN5RpOAd+KDqlO53fYPPSqPYjpq2LG9c1zqw8 wVzxZYYP+QlRkyDfr3m168UyhoOK0cIPyvrP/4JYmh5dyxGGTPkpwObhYOV+Rmu92u2LrZh5G sMswaCoo72IWQtvio6jEbcxhIiY+BRMTa+wLEEsh1N72hwqwMR4ZKbE1DHaZsQewri0cXJNID S+5oCDuVu0MakxuII2nRS9EB4PbZOIpoynS4zsZVqz0rvpMnyhTWgZjW9HwJaT+yS3mU6+dyL EMAZhOkJpTeiXpLs4rL2lTjrXkXJaepwWSnyzCWXGy2NeUBxuanj8m8ETPTev4SVLnNpeprPl HZ0uuX0hNWaBf4qyN9DTm3MFnmxpXRixki4yghd+Kk8VRzQ6xmTBvZRZP3izNooEUX7ST8394 Q17vlljxfjQXmWZmM5YtgrlUxYyIQucKrgzM0rMndK8I0qv3UcOPOK+MAt71PoXtXqQHAf8LW qWMxdqtpQHLyl6Rv1Az5SPQv+LyxY7g+Y2ugpB8c1SPLefKRddCKrrfTp3B6Q3vW4/6x8n5rW L7Q4S1PC2SX2S7ThCU/JXzcXWSZFwYw9D40jtWFg7+eBbXHRSKaxLYmLAyX8q1at1KPsF5VQf MfLWuOoLikYOaDNfenXrVqxqx9f7GcicBUH/FCum70ExJeDZ9oChBX9Z/cV/G/XuJEr1bQvi2 wgCclfJ5jfqucHSatWOpCoS6UzYMKR1NM4+fCQeXffXXlGTCpEHh/jxuiOYM= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, juri@linkov.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, 22 Nov 2019 09:24:41 +0200 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: Dmitry Gutov , juri@linkov.net, larsi@gnus.org, >> 38044@debbugs.gnu.org >> Date: Thu, 21 Nov 2019 22:15:21 +0100 >> >> However, I'm not thrilled with the thought of having to type two >> prefix keys to invoke it. > > AFAIU, this command is not something that will be invoked too > frequently, That's not true for me, I use my srb-git-log command much more often than I do `C-x v L' precisely because the emacs-bug and -devel lists make many references to commits by means of the commit hash, and I find it much more convenient to go directly from that to the commit message (and maybe then the diff too), rather than first calling up the whole commit log and searching for the hash in it. > and typing C-u twice is not much harder than doing it > once. I find even just typing one C-u less convenient, hence my suggestion below, which I'm glad you find worth considering. >> Since one of the desiderata of this command, perhaps even the main >> one, is that it should act on the revision ID at point, how about >> making just `C-x v L' do that if it recognizes the word at point as >> a revision ID? > > We could do that, yes. > >> If this is deemed to unreliable, it could be conditioned by a user >> option, or perhaps (though more annoying) by asking for >> confirmation. > > Fine with me, assuming the rest of the proposal is accepted. Thanks, Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 06:19:21 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 11:19:21 +0000 Received: from localhost ([127.0.0.1]:53842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY6y8-00050p-Ob for submit@debbugs.gnu.org; Fri, 22 Nov 2019 06:19:20 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:34207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY6y5-00050b-6e for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 06:19:17 -0500 Received: by mail-wr1-f49.google.com with SMTP id t2so8198792wrr.1 for <38044@debbugs.gnu.org>; Fri, 22 Nov 2019 03:19:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fQ0STmLGhJ+DyfDUR59+KIPBXmlGvUjYCgdaWQIuMag=; b=LG2j9JeR2YwlxLKLxiX0K55xslte8B/iktHcPn9r926xHSpxyLwGdEmF6P5bumvYKa 9RzE+0QPLLzfhgkMJxcVv6ONxQQVMACQN+7rWec7eMsJzsINrME9iQk+cDwlEUZXyDVk jCWYMEh3jzz5KD7wgMmz8VU4Z8ugFA3U+DfovkjwWwQwUplVJT6fc+QPoTtzAHbUB9XG C1XrCTszDU2m8vJMmHN/aiNPcHVxRQrxSe/oL9raLPfZX1yam675uLnrnOz6nidgXq2o jFozQ6MxDboWTTTTu4wIRKb6fxtFKLc2ATvugjn3wS10ZxjDdkhMUA9rcmItvAmSYyaU gFQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fQ0STmLGhJ+DyfDUR59+KIPBXmlGvUjYCgdaWQIuMag=; b=trMDRay9mGVPWztBTnxQCDbr3VpedFxBnoXT2jASmPkleAWAHtAK1zLewVXNTKwfwh TdzJ1Ha8MINyoBmE7QdTHbHk4fWRxJIfRlouCdN3Bg4Ctv8y9LqawuLeoDBdeBilQhFU hE6RfD3ES8gOEYdfeKAo8nzQ812p/uyqZnHXZEgL4odpLwe67fxEyBzLfH0rdiqewA/j Rw9eybrs0rXPgTTbwN03QF4pZmGny5NUOiX6zvxi200wV0cXGo2gjKNDMSnPtUE3+OWl wfCVBAxhbuSnAj++dTLusOG9Awj2tixsGjj3uB8qa+CrbiDM2MmyX4NMVojrCi1NSE5K S76Q== X-Gm-Message-State: APjAAAW2HiBzC/R60zMnmEs9ZDowAmMwVF766WCx1pUbJqzVW4iewNDj /4Ndjp2c03ML3CRKF+pQK3A= X-Google-Smtp-Source: APXvYqw7ck52yyB2A1uLQNaxYrvBMWWaX1PQBFEsLaw0D1Wx7vMnfkevtWaF7gddt44G42Q7wRLVnQ== X-Received: by 2002:a5d:48cf:: with SMTP id p15mr902801wrs.46.1574421551266; Fri, 22 Nov 2019 03:19:11 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id j10sm7237697wrx.30.2019.11.22.03.19.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2019 03:19:10 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii , Stephen Berman References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> From: Dmitry Gutov Message-ID: <21413e96-c697-5deb-2001-4540c38f6169@yandex.ru> Date: Fri, 22 Nov 2019 13:19:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <8336egxtja.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 22.11.2019 9:24, Eli Zaretskii wrote: >> If this is deemed to unreliable, it could be conditioned by a user >> option, or perhaps (though more annoying) by asking for >> confirmation. > Fine with me, assuming the rest of the proposal is accepted. I fail to see how this is less complicated that just adding a new command. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 06:20:39 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 11:20:39 +0000 Received: from localhost ([127.0.0.1]:53846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY6zP-000531-5H for submit@debbugs.gnu.org; Fri, 22 Nov 2019 06:20:39 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:53083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY6zK-00052j-Kd for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 06:20:35 -0500 Received: by mail-wm1-f48.google.com with SMTP id l1so7043348wme.2 for <38044@debbugs.gnu.org>; Fri, 22 Nov 2019 03:20:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LBqG6c7i2nkY3ZheC1NMyjHi5J+L9kKI715rw674GLo=; b=d81HB5AtdQ+Djh+CheqAoecTSjGfhZDqtAeS35wxceq6sI0YA9tkBxUbYu3cUref6y KwUjEK5n3A9ZLPV21TPZ5T1R/ja9P1h8Sf9bn0MmebVS9Brgvct2DxlkcTdOVYz1cYVv KKqtWGz8XdjfGribItfcnxGEAa6o+/IpzRm8BEVsGqARJHIRBFrnAGokjT8CVuUR/gla FNJrwpkHZHHPARj3SKMcvKbXCQkiS3s++rJLrXFd1em4krTEEeAV5xB7aYwm2bVwSI6Y fjkFIjObz6VG7ZDYVCP9Q5J9QTJQBeGo9NHFKkn3/ocH+oVqlFULgxjWeHAVlE1pN8yw X0Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LBqG6c7i2nkY3ZheC1NMyjHi5J+L9kKI715rw674GLo=; b=B+maOxuubdqmNItbNNoSprcXwiKBD2YBMbnXSgtKfHmB1bUWZ5fvX1tpkQQ4FdKsFD bU5OhEBKbIJ3uugh2UF7uEfOaVe4Lw57++68I9D5CPbCUIOxoYsNbn7MW9suvvxwhoTd mWg3NJn7mny2fp7gFm3SCWdc5fnpggKdEXF20YEsDjpOW4s4bS/4Tabx5ChCQBCcSncJ CePsa7Dk2O0Yots2z0z5Vy3raxvIrWM/NSflFCComGwOFvdw4byX7ne1eGvHDYWQ7JZI hbQGSpf9Kt0RpOWdgHR2cl8r7FZs+WlkRx8Fi2demyYWtDJmP8t40tvwataZ2AEltw5x 9GSw== X-Gm-Message-State: APjAAAVeTNpLet08bhemrA7tg0f95Hx31FNg6pKv0kMh1Q3SFfb8H811 ugAUsEq1mb2VsaDr8nYIdSYytQde X-Google-Smtp-Source: APXvYqyuTCo/LzKy5YxGSEKB8wxgEAQ/FK3djiVzY2OUrdAcgRRiEs76pAY1nqhvmd9sIFZJUH3Hcw== X-Received: by 2002:a1c:67c3:: with SMTP id b186mr15602870wmc.84.1574421628662; Fri, 22 Nov 2019 03:20:28 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id 19sm8470916wrc.47.2019.11.22.03.20.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2019 03:20:28 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii , Juri Linkov References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <87zhgobxcd.fsf@mail.linkov.net> <83mucowd68.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Fri, 22 Nov 2019 13:20:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83mucowd68.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 22.11.2019 10:03, Eli Zaretskii wrote: > And the original request was for describing a revision, so if a VCS > doesn't support "log -p", we should simply display the diffs, because > that's the best description of the revision in those VCSes. Why? All VCSes support printing the commit message. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 07:12:57 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 12:12:57 +0000 Received: from localhost ([127.0.0.1]:53877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY7o0-0006Mq-Pd for submit@debbugs.gnu.org; Fri, 22 Nov 2019 07:12:56 -0500 Received: from quimby.gnus.org ([95.216.78.240]:47904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY7nr-0006MW-EC for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 07:12:53 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iY7nj-0002pB-Hl; Fri, 22 Nov 2019 13:12:42 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <21413e96-c697-5deb-2001-4540c38f6169@yandex.ru> Date: Fri, 22 Nov 2019 13:12:38 +0100 In-Reply-To: <21413e96-c697-5deb-2001-4540c38f6169@yandex.ru> (Dmitry Gutov's message of "Fri, 22 Nov 2019 13:19:08 +0200") Message-ID: <87ftigt8i1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > I fail to see how this is less complicated that just adding a new command. I'd rather have a new command. Makes it easier to rebind, which is something that's popular for commands that have long key bindings by default. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: Eli Zaretskii , Stephen Berman , 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > I fail to see how this is less complicated that just adding a new command. I'd rather have a new command. Makes it easier to rebind, which is something that's popular for commands that have long key bindings by default. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 08:04:02 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 13:04:02 +0000 Received: from localhost ([127.0.0.1]:53922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY8bS-00035Z-En for submit@debbugs.gnu.org; Fri, 22 Nov 2019 08:04:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY8bN-000351-SM for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 08:04:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY8bI-0006XL-0b; Fri, 22 Nov 2019 08:03:52 -0500 Received: from [176.228.60.248] (port=3198 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY8bH-0000Ts-Bx; Fri, 22 Nov 2019 08:03:51 -0500 Date: Fri, 22 Nov 2019 15:04:04 +0200 Message-Id: <837e3svz97.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <21413e96-c697-5deb-2001-4540c38f6169@yandex.ru> (message from Dmitry Gutov on Fri, 22 Nov 2019 13:19:08 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <21413e96-c697-5deb-2001-4540c38f6169@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, 38044@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > Date: Fri, 22 Nov 2019 13:19:08 +0200 > > On 22.11.2019 9:24, Eli Zaretskii wrote: > >> If this is deemed to unreliable, it could be conditioned by a user > >> option, or perhaps (though more annoying) by asking for > >> confirmation. > > Fine with me, assuming the rest of the proposal is accepted. > > I fail to see how this is less complicated that just adding a new command. It isn't, not from the implementation POV. But it's one less command to remember. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 08:06:10 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 13:06:10 +0000 Received: from localhost ([127.0.0.1]:53926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY8dV-00038y-WB for submit@debbugs.gnu.org; Fri, 22 Nov 2019 08:06:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY8dP-00038O-Jn for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 08:06:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY8dI-0007D7-4G; Fri, 22 Nov 2019 08:05:56 -0500 Received: from [176.228.60.248] (port=3321 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY8dG-0000fP-6b; Fri, 22 Nov 2019 08:05:55 -0500 Date: Fri, 22 Nov 2019 15:06:06 +0200 Message-Id: <835zjcvz5t.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Fri, 22 Nov 2019 13:20:26 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <87zhgobxcd.fsf@mail.linkov.net> <83mucowd68.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 22 Nov 2019 13:20:26 +0200 > > On 22.11.2019 10:03, Eli Zaretskii wrote: > > And the original request was for describing a revision, so if a VCS > > doesn't support "log -p", we should simply display the diffs, because > > that's the best description of the revision in those VCSes. > > Why? All VCSes support printing the commit message. Because (see above) that's the best description of a revision with those VCSes. And because adding what 'log' produces to that would mean an additional delay with those VCSes, which in this case is not justified, IMO. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 11:26:58 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 16:26:58 +0000 Received: from localhost ([127.0.0.1]:55410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYBlp-0005fq-Sw for submit@debbugs.gnu.org; Fri, 22 Nov 2019 11:26:58 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:32821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYBlm-0005fZ-UW for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 11:26:56 -0500 Received: by mail-wm1-f53.google.com with SMTP id t26so6689017wmi.0 for <38044@debbugs.gnu.org>; Fri, 22 Nov 2019 08:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=907i4tUC6u2vW33aHelYRosayMCHHD+7B4Imuq38ljA=; b=ZLpKAX1b+laeHKObAKyoR85Qln58Z5fYobo6GuWVuTvHK5LT1s9/UcE1j3MORpigt4 dWF3lkxVBOvNw8XWAzhF8MYaGyE4EWU1QkSaqhMKh1vN04YM5D58TQCWy8/6iNUc07b6 lr1Cs07E8xYDm2powj5Biop5YG8om08v8uKdUe1/2EtUh65roFdz6eRTUufVlxNwtaKP sbd8PnbmgJ5LU0mRLr4qdKUTXZfi9RRhTsFelZXbYIjy6RWvl02Lrlf8ZFmdu550d9ac 0qWmwTyPDtvTU2/3B8tChF8NY+83r3vuIM8KpRFU5NA563cyzEBQivxslqicT8NoXU2J LWBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=907i4tUC6u2vW33aHelYRosayMCHHD+7B4Imuq38ljA=; b=U/qfMU5ViTYuU0YBf5S24YY6gJLE2/fNrDVxYvAHrEra+mbMmzIZrVtMjypMEDtygE 94GuUbvP46HACtw8GeckMgGqw/VRyaAGj8BKDc3K4XNU0ssRaoZJBSXCwYx7q3TpMl2J KWZIuEew+ryavpmFcxnn8wMc5py4EFtoGI8NnZqndvZgXVaLuSf/OIN3mMvOonWFtNs7 V+ITrTaCQWatKJ/11GVAWqw7mJFAwQ4Mjh0M3FFWmvF+wOYyalSHuR78j0trn7oh0pXS gEEJlpuYU7WMOoxqZTY5q1DH450FgdX1Torl5GkQu3J9ihMa/g5D/ifRKjH9tnoeEcDM eD4w== X-Gm-Message-State: APjAAAXghPsOsiQcUx2PHCC6GqcgSw8ZfesWM3RvBUxiDlTZCfs/xZR0 PiaOB4IQP41DbygQOgloW2g= X-Google-Smtp-Source: APXvYqwFP6kyQnxTvEmQNIn94UxSKdfLTgMYYliji4pcw8DOLn8LUek+KDzhl3EVfBBWOq69nsn5sw== X-Received: by 2002:a1c:750f:: with SMTP id o15mr16073359wmc.161.1574440005369; Fri, 22 Nov 2019 08:26:45 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id x7sm8225053wrq.41.2019.11.22.08.26.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2019 08:26:44 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <87zhgobxcd.fsf@mail.linkov.net> <83mucowd68.fsf@gnu.org> <835zjcvz5t.fsf@gnu.org> From: Dmitry Gutov Message-ID: <0e13e516-53fd-a0f1-eb7d-bd99a76e49b0@yandex.ru> Date: Fri, 22 Nov 2019 18:26:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <835zjcvz5t.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 22.11.2019 15:06, Eli Zaretskii wrote: >> Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org >> From: Dmitry Gutov >> Date: Fri, 22 Nov 2019 13:20:26 +0200 >> >> On 22.11.2019 10:0 [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnus.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.53 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.53 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 1.0 FREEMAIL_REPLY From and body contain different freemails X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 22.11.2019 15:06, Eli Zaretskii wrote: >> Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org >> From: Dmitry Gutov >> Date: Fri, 22 Nov 2019 13:20:26 +0200 >> >> On 22.11.2019 10:03, Eli Zaretskii wrote: >>> And the original request was for describing a revision, so if a VCS >>> doesn't support "log -p", we should simply display the diffs, because >>> that's the best description of the revision in those VCSes. >> >> Why? All VCSes support printing the commit message. > > Because (see above) that's the best description of a revision with > those VCSes. And because adding what 'log' produces to that would > mean an additional delay with those VCSes, which in this case is not > justified, IMO. That's against the principles of VC, which is making a generic, unified interface. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 11:28:02 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 16:28:02 +0000 Received: from localhost ([127.0.0.1]:55414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYBms-0005hk-9q for submit@debbugs.gnu.org; Fri, 22 Nov 2019 11:28:02 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:35188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYBmk-0005hB-9h for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 11:28:01 -0500 Received: by mail-wr1-f41.google.com with SMTP id s5so9353718wrw.2 for <38044@debbugs.gnu.org>; Fri, 22 Nov 2019 08:27:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=B19zzWxd74Vm3AoXx+ZZWBtI8IG+85QRyTKFrDUWadI=; b=sAIoRPsU6G5wh9KAqiEUluoz0ENduHa2w6Bw949L/NIPP52cofRzwN3O2VtlS1bbXY BoUTgDpw4cmyxE7MVWBTn0pwLFL0CQXM2zg/HI5syp3pni7xti1baP51zL5Mjru/qEU+ LUTM6DaNXAn7eShfGarMMQLEOFiopzywU/lVnh7gPGMGvoCiJUfgy35aeHs92gSBprwP QaFUPXlprdMOBowkpHXLmHtxmIYd5WrBOqbIuxmsqwL/W34JZMb2KKUrFbaLHNsotlle M95TevKLLfIdV/W4jLCX/x+rHMhtkNQfjEZcVr/TysD7+bqZJJqAJszBaCdwkQRfQ4St nyOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B19zzWxd74Vm3AoXx+ZZWBtI8IG+85QRyTKFrDUWadI=; b=nAntZYN4SKwB7DmtsSziItsyW31y0S15QdOFkp/TBqwsmnf8GhcDOulnSznDsDPJ+u JegAMq3kmSw5EZbi5EOfqptpD6ljvInqSRa7Vzhm7AmCE0VLZlAaaFNQc0qV4Q1xLJQH UXjdrRMczJ7S0LLVgMB00McPSwgh1t1zCPWc5iIzr68U7IBCuz24F+tWpnmmonmkC4Ki GQt4FYGECBvFY5Ywitf87yiqHBOPIrblIp8UZJFesr0nXz/OH1rWgfJ1pKjnmIJghzXE TAO3gf2PSQA+TPcyz/AJ7lpvnK0A7diYu/RvFSpj27dCP9ze5Q4QUrbaMtZIkVctXDDA Bxcw== X-Gm-Message-State: APjAAAU8MxGIDbZdPJy8eWCP1kg7ho6b7q0A3xBsTwWQjva0cbFgfvXs knrq8PekJEyVnq4IEXYSlww= X-Google-Smtp-Source: APXvYqyAaYFS/Zz+Lep2+4AsqHYJ+waYNuxo0mQZalCidXHJV2MS2+lFqKthZC02FU08vFBZfGF9TA== X-Received: by 2002:a5d:6706:: with SMTP id o6mr18533919wru.54.1574440068535; Fri, 22 Nov 2019 08:27:48 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id a6sm3910760wmb.1.2019.11.22.08.27.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2019 08:27:47 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <21413e96-c697-5deb-2001-4540c38f6169@yandex.ru> <837e3svz97.fsf@gnu.org> From: Dmitry Gutov Message-ID: <70a0e161-25b1-cae1-319f-c34a74fdf1c2@yandex.ru> Date: Fri, 22 Nov 2019 18:27:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <837e3svz97.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 22.11.2019 15:04, Eli Zaretskii wrote: > But it's one less command > to remember. The command name will be mnemonic. M-x vc--revision TAB, and there you go. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 11:38:31 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 16:38:32 +0000 Received: from localhost ([127.0.0.1]:55419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYBx0-0005x2-DK for submit@debbugs.gnu.org; Fri, 22 Nov 2019 11:38:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYBwx-0005wo-OI for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 11:38:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iYBwk-0007dv-GT; Fri, 22 Nov 2019 11:38:16 -0500 Received: from [176.228.60.248] (port=4337 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iYBwj-0005pf-3W; Fri, 22 Nov 2019 11:38:14 -0500 Date: Fri, 22 Nov 2019 18:38:27 +0200 Message-Id: <83zhgnvpbw.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <0e13e516-53fd-a0f1-eb7d-bd99a76e49b0@yandex.ru> (message from Dmitry Gutov on Fri, 22 Nov 2019 18:26:42 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <87zhgobxcd.fsf@mail.linkov.net> <83mucowd68.fsf@gnu.org> <835zjcvz5t.fsf@gnu.org> <0e13e516-53fd-a0f1-eb7d-bd99a76e49b0@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Fri, 22 Nov 2019 18:26:42 +0200 > > >> Why? All VCSes support printing the commit message. > > > > Because (see above) that's the best description of a revision with > > those VCSes. And because adding what 'log' produces to that would > > mean an additional delay with those VCSes, which in this case is not > > justified, IMO. > > That's against the principles of VC, which is making a generic, unified > interface. The interface is indeed the same, but the results aren't, because each VCS produces different outputs. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 13:51:36 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 18:51:36 +0000 Received: from localhost ([127.0.0.1]:55496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYE1n-0000iC-Mz for submit@debbugs.gnu.org; Fri, 22 Nov 2019 13:51:35 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:54642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYE1h-0000hs-A7 for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 13:51:31 -0500 Received: by mail-wm1-f42.google.com with SMTP id x26so8248230wmk.4 for <38044@debbugs.gnu.org>; Fri, 22 Nov 2019 10:51:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8fHQuCDIZEcirdkZJA0SGJ29CIgH7JOidY7syoPOwZ4=; b=SBkaccPep+ko5hkx9BGF4sON3HTKU/Ox1z4dVy1AXd+JgaXkzhqZtaXtR0mveaGqki LWFoa3K8k5OvJMCMcUQsXHXwLaniuKh5aHiFasw1HnuVPLLwUXAzUlvnCv+8IlaoD180 Z+Ysr/qZVL3zPorxTAbTAKLrdvLWBtzpONetrt0XThrPndkOXFLm4EWgCDDwUVBOgE+M DvOxJOl8C5e+KjPYfrmBLMZsbb3a+9ZVhSi9bCWMPwjLIPS4EQfJ7eGOasntrpcVJ75G WjLhWl7qS88aVd5XByPN7T3GOK4mMWhUuf4DY/1T3seTrKOmY7JK9ikBiko4SbVqnBSa ia7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8fHQuCDIZEcirdkZJA0SGJ29CIgH7JOidY7syoPOwZ4=; b=PvZv/DFtWBl+ZO0ojQS7dDfQb58eAxRmvBWMZHoRDCiq1B6FdEClBtqGvSjv2JN9t4 zGo1ZkFIg2wKThtoHpe96n7H47kmDtzVUQzzDDZXUkCwSQ7t15mzPkeeXZZI22hHh2RV pHeJzQl+jDJLcMZL3OpYo2rSKbPWfWnVcDnkBuXUjwqPF/bcyABlELZoY0Zxn3GhOMXd sfofCBMkRJGqR8T+e9PtN4BkFqxWTbWFxNuXu5F9o/+rIEYSU2Cv+VI59pF4J9F8kCmZ Pd/DVhz15sgC/d7dUofZN9Pp78alO4BBypNjPQQBQq4MY9bmOWl/xQ7YK4Tqe7Nbx1uc fcpg== X-Gm-Message-State: APjAAAVkIK6ZhcD/G0Oopj5YY6LlpkfoPV+bK6al0EHSWKlWZRedDmJr bPGVNoLxeyKvkwUzusQKYXY= X-Google-Smtp-Source: APXvYqzkGoNUNoBsZp9z5R8talVmIhYnZ4P4FFaXhNheGCv+Me0NQPVnGMIV5yn4I1FLKUi25C0kVA== X-Received: by 2002:a1c:9ccd:: with SMTP id f196mr18129628wme.152.1574448683275; Fri, 22 Nov 2019 10:51:23 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id f19sm9650083wrf.23.2019.11.22.10.51.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2019 10:51:22 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Juri Linkov References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <29e2e877-6dc3-b03b-7463-01cff35e05d1@yandex.ru> <87pnhkern2.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <20441040-20fd-d5ba-0c9d-4c6132b37a33@yandex.ru> Date: Fri, 22 Nov 2019 20:51:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87pnhkern2.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 22.11.2019 1:08, Juri Linkov wrote: >> The approach LGTM. I'd have used "describe" or "show", but it's not >> important. > > The name vc-print-revision was modeled after vc-print-log, > vc-print-root-log, vc-print-branch-log that are not the best names > but at least consistent for their prefix. Yeah, OK. >>> (setq default-directory rootdir) >> >> This probably needs a saving (let ((default-directory default-directory)) >> ...) above it. > > This is intentional because on testing I discovered that RET > on the diff part of the buffer can't visit source files > when default-directory is not root. I'm saying your code modifies the value of default-directory in the original buffer as well. Hence the need for a (let ((...)) before that. Just like vc-print-root-log does it. BTW, vc-print-branch-log skips this step, so maybe it also exhibits the bug you mentioned. If so, I wonder if we should move the logic changing default-directory inside vc-print-log-internal. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 14:59:33 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 19:59:33 +0000 Received: from localhost ([127.0.0.1]:55543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYF5Z-0002Hg-3p for submit@debbugs.gnu.org; Fri, 22 Nov 2019 14:59:33 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:40064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYF5W-0002HL-LK for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 14:59:31 -0500 Received: by mail-wm1-f52.google.com with SMTP id y5so8989336wmi.5 for <38044@debbugs.gnu.org>; Fri, 22 Nov 2019 11:59:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=4yFTPIcOLPH5PZu7O4srBhG1HrWVFBt1oZc2N0sG0lM=; b=SAyKjgO1MpgauMRdvqmLfno98CLqn7GciPWha5ROkdOkHbdLnwfynAp8eb9xJb83As WfbUelulinyY7jF7OP+Gdt/xmD/ghhO8OaAv89MHmsKte6dWbFW4qi6Qxu5/iawB81gZ cFOXrlnqdlugRChQVpURHArMC4JdwMo5f3P4uHyi6q+BcDiSIXrUxdezLnf3PZoWD6rL WPi+f13fT5Cw4tm7WTABw9swxX0XaoHTg/Ub6EyZogitpL692/TifZnzH4fc4JgWGT6Y QqDX3yerdGKYXlIl/NUadayjGgjFVp9FZf2l4BvsUpRJvf4Gg92Q8dYjokJ8ytd85xT2 gCfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=4yFTPIcOLPH5PZu7O4srBhG1HrWVFBt1oZc2N0sG0lM=; b=LaxWF0KRG5E+cPvfiGU/lxq9WgxDQtP3ma7Gq7nVnAHERWuA0UK11kMUoi5OJp/UuC roT8bd/xRhAVLr7B9mZ1dTWElgT07tFh0YTOhpH7zspk0gkywY4SnqozWJqpV1Fe/pyQ GVOxMmE9wcDubybSIr058+Uvy4TV2zI5C5nwVOwucDf04+tZEiXhh6nL2bwpjLNrGxxX ueQ8MY2anyt1b/sxP7QolvnuQwOCtZRr707qjvUV/x75YTk1pnbJDmzAJNQgmL2312AQ KtKJbHlWIc9qP80/gVmxbHwCBk9ZhBrkMiHvF3f08T+qeYCBjBf7P07rd8HvpocKnzGO iTsQ== X-Gm-Message-State: APjAAAXXCu0wP6E673b7PFghRoZ305rwQZ3MiKtNP/GKbj5cWFSnFjhY PC6ReWtcBhZO/3Cj/QOuyqE= X-Google-Smtp-Source: APXvYqyZ3hteUcERFI3g4RQTA8/kju9C+brB3rwHd5j3rSjsSEU8ifFl6n5KHPHmovk5aQ2TZ8Z5sg== X-Received: by 2002:a1c:20c6:: with SMTP id g189mr4312817wmg.6.1574452757594; Fri, 22 Nov 2019 11:59:17 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id l26sm15689wmj.48.2019.11.22.11.59.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2019 11:59:16 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> <834kywxtr1.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Fri, 22 Nov 2019 21:59:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <834kywxtr1.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------7C9695B316889BCFD2E827E9" Content-Language: en-US X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) This is a multi-part message in MIME format. --------------7C9695B316889BCFD2E827E9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 22.11.2019 9:20, Eli Zaretskii wrote: >> Somewhat better, but all backends would have to be updated anyway, for >> this to work. > > It's new functionality, so that goes without saying. Or did you mean > something specific when you said "updated"? Not every new functionality needs explicit support from backends. >> So the change in VC backend API is comparable to adding a new >> action. > > We don't necessarily need a change in the API: vc-print-log-internal > has enough arguments to pass this new meaning to it and to the > backends. But even if there's a change in the API, it isn't a > catastrophe from my POV. The backend API. It also has certain backward compatibility expectations. Anyway, I'm saying the change you are proposing is roughly the same magnitude in complexity as adding a new backend action. >> I don't mind this too much (asking vc-git-print-log to include the diffs >> makes sense, at least), but doing it this way loses out on the >> opportunity to support all backends in one fell swoop. > > I don't understand why would we lose that opportunity. We will have > to write new code for each backend in any alternative, Not necessarily. See the attached patch (it's a modification of Juri's). Since we don't have a way to combine async process invocation, there is some complexity there with accept-process-output. But from what I see, the diff operation is considerably more resource-intensive, at least for big Hg repos. There is a catch, however: it requires an implementation of region-history-mode. But, as you remarked, it can be extracted to be more backend-independent. Consequently, for now this "default" implementation only adds print-revision support to Hg. > VC used to > be simple and elegant, and this proliferation of too many high-level > commands makes it more and more complex, I hardly see any complexity in the presence of a command. There's more more of it in tiny details of implementation of the main ones. > and inevitably causes us > tweak the user level and UI to this or that particular VCS, which is > wrong in the long run. When was the last time we did that? And how adding a new command would cause it in this case? --------------7C9695B316889BCFD2E827E9 Content-Type: text/x-patch; name="vc-print-revision-with-default.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="vc-print-revision-with-default.diff" diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index ca4c66a06d..729d98f143 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -80,6 +80,7 @@ ;; - log-search (buffer pattern) OK ;; - log-view-mode () OK ;; - show-log-entry (revision) OK +;; - print-revision (revision) OK ;; - comment-history (file) ?? ;; - update-changelog (files) COULD BE SUPPORTED ;; * diff (file &optional rev1 rev2 buffer async) OK @@ -1163,6 +1164,22 @@ vc-git-print-log (list start-revision))) '("--"))))))) +(defun vc-git-print-revision (buffer revision) + "Show the details of REVISION with output in BUFFER. +With a prefix argument, ask for a command to run that will output +the revision information." + (let ((args `("show" "--no-color" ,(or revision "")))) + (when current-prefix-arg + (setq args (cdr (split-string + (read-shell-command + "Show revision with command: " + (format "%s %s" vc-git-program + (mapconcat 'identity args " ")) + 'vc-git-history) + " " t)))) + (vc-setup-buffer buffer) + (apply 'vc-git-command buffer 'async nil args))) + (defun vc-git-log-outgoing (buffer remote-location) (vc-setup-buffer buffer) (vc-git-command @@ -1226,7 +1243,7 @@ vc-git-log-view-mode (set (make-local-variable 'log-view-file-re) regexp-unmatchable) (set (make-local-variable 'log-view-per-file-logs) nil) (set (make-local-variable 'log-view-message-re) - (if (not (memq vc-log-view-type '(long log-search))) + (if (not (memq vc-log-view-type '(long log-search print-revision))) (cadr vc-git-root-log-format) "^commit *\\([0-9a-z]+\\)")) ;; Allow expanding short log entries. @@ -1235,7 +1252,7 @@ vc-git-log-view-mode (set (make-local-variable 'log-view-expanded-log-entry-function) 'vc-git-expanded-log-entry)) (set (make-local-variable 'log-view-font-lock-keywords) - (if (not (memq vc-log-view-type '(long log-search))) + (if (not (memq vc-log-view-type '(long log-search print-revision))) (list (cons (nth 1 vc-git-root-log-format) (nth 2 vc-git-root-log-format))) (append diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el index 17d38fa400..ae0c93bf9d 100644 --- a/lisp/vc/vc-hg.el +++ b/lisp/vc/vc-hg.el @@ -564,7 +564,8 @@ vc-hg-expanded-log-entry (defun vc-hg-revision-table (files) (let ((default-directory (file-name-directory (car files)))) (with-temp-buffer - (vc-hg-command t nil files "log" "--template" "{rev} ") + (vc-hg-command t nil nil "branches" "--template" "{branch}\n") + (vc-hg-command t nil nil "tags" "--template" "{tag}\n") (split-string (buffer-substring-no-properties (point-min) (point-max)))))) diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 0d29c80d02..be4ed95fe3 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -359,6 +359,10 @@ ;; and make sure it is displayed in the buffer's window. The default ;; implementation of this function works for RCS-style logs. ;; +;; - print-revision (revision) +;; +;; Show details of REVISION. +;; ;; - comment-history (file) ;; ;; Return a string containing all log entries that were made for FILE. @@ -2516,6 +2520,31 @@ vc-print-branch-log (list default-directory) branch t (when (> vc-log-show-limit 0) vc-log-show-limit))) +;;;###autoload +(defun vc-print-revision (revision) + "Show the details of the revision REVISION." + (interactive (list (unless current-prefix-arg + (let ((default (thing-at-point 'word))) + (vc-read-revision + (if default + (format "Revision to show (default %s): " default) + "Revision to show: ") + nil nil default))))) + (when (equal revision "") + (error "No revision specified")) + (let ((backend (vc-deduce-backend)) + rootdir) + (if backend + (setq rootdir (vc-call-backend backend 'root default-directory)) + (setq rootdir (read-directory-name "Directory for VC print-revision: ")) + (setq backend (vc-responsible-backend rootdir)) + (unless backend + (error "Directory is not version controlled"))) + (setq default-directory rootdir) + (vc-incoming-outgoing-internal backend revision + "*vc-revision*" 'print-revision) + (vc-call-backend backend 'region-history-mode))) + ;;;###autoload (defun vc-log-incoming (&optional remote-location) "Show a log of changes that will be received with a pull operation from REMOTE-LOCATION. @@ -3091,6 +3120,30 @@ vc-default-dir-status-files (funcall update-function (mapcar (lambda (file) (list file 'up-to-date)) files))) +(defun vc-default-print-revision (backend buffer revision) + (let* ((buffer-name " *vc-revision-log*") + (buf (get-buffer-create buffer-name)) + proc) + (vc-call-backend backend 'print-log (list default-directory) buf nil revision 1) + (unwind-protect + (progn + (setq proc (get-buffer-process buf)) + (while (process-live-p proc) + (accept-process-output proc 0.1)) + (save-current-buffer + (vc-setup-buffer buffer) + (let ((inhibit-read-only t)) + (insert-buffer-substring buf) + (insert "\n")) + (vc-call-backend backend 'diff (list default-directory) + (vc-call-backend backend 'previous-revision nil revision) + revision + buffer + t) + (vc-run-delayed + (goto-char (point-min))))) + (kill-buffer buf)))) + (defun vc-check-headers () "Check if the current file has any headers in it." (interactive) --------------7C9695B316889BCFD2E827E9-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 16:03:37 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 21:03:37 +0000 Received: from localhost ([127.0.0.1]:55585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYG5Z-0003sK-As for submit@debbugs.gnu.org; Fri, 22 Nov 2019 16:03:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYG5V-0003s6-Mf for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 16:03:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iYG5P-0006Ep-Po; Fri, 22 Nov 2019 16:03:27 -0500 Received: from [176.228.60.248] (port=4584 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iYG5O-0008VB-EM; Fri, 22 Nov 2019 16:03:27 -0500 Date: Fri, 22 Nov 2019 23:03:41 +0200 Message-Id: <83mucnvd1u.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Fri, 22 Nov 2019 21:59:14 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> <834kywxtr1.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Fri, 22 Nov 2019 21:59:14 +0200 > > >> I don't mind this too much (asking vc-git-print-log to include the diffs > >> makes sense, at least), but doing it this way loses out on the > >> opportunity to support all backends in one fell swoop. > > > > I don't understand why would we lose that opportunity. We will have > > to write new code for each backend in any alternative, > > Not necessarily. See the attached patch (it's a modification of Juri's). > > Since we don't have a way to combine async process invocation, there is > some complexity there with accept-process-output. But from what I see, > the diff operation is considerably more resource-intensive, at least for > big Hg repos. > > There is a catch, however: it requires an implementation of > region-history-mode. But, as you remarked, it can be extracted to be > more backend-independent. > > Consequently, for now this "default" implementation only adds > print-revision support to Hg. I'd prefer to use "log -p" in the backend ("log --diff" for svn), because that yields a single command and will work for all the backends except RCS and CVS. The latter two can use "diff". Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 16:43:23 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 21:43:23 +0000 Received: from localhost ([127.0.0.1]:55617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYGi2-00050J-Sh for submit@debbugs.gnu.org; Fri, 22 Nov 2019 16:43:23 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:36170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYGhw-0004zi-UW for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 16:43:17 -0500 Received: by mail-wm1-f49.google.com with SMTP id n188so7335242wme.1 for <38044@debbugs.gnu.org>; Fri, 22 Nov 2019 13:43:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=g37Zmn1WILXzQb8ZWMOyTIfizFSSRGBB/kVvQ0fPYiA=; b=ZhFO5/HpQbriouZ+vaM4/bZPtEbsSwWL7Pq7IyqJo2MZSqRv4ipznVierZ1VvLF6hd 9yL7r9JFz3nhefRbL+1CH/i8m6aTS68FIy+gr6PF/1I3iuTTk821yKZyUGBH8d1zJdor zxMPPMW/wdOSyS2uK9xmLqrib/t+G8eMRSY3pf537kfb5/tWXeAzI2uLlrMMN4+tHdFF zukW0uESw25vrEyvpr4nuC4S/CKaq6SQva+k32Z0ZDwxr9vCiGyFKHK+SAICrqT1/COz sDwchW92RaDi/eILhshhGkmr8cOYT2G/5eQLdB4pJFo9sC5XudDhPN0dfojRVo53Ejb3 iblw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=g37Zmn1WILXzQb8ZWMOyTIfizFSSRGBB/kVvQ0fPYiA=; b=RIz2Tu1w6DkueMKXCgAjbPefe8auVaZ8aT8j9oxYIkpQe2sVURXZdLToyRokhtjEJr pHowFFAUQ+gWqcGUd4bADJcRGXNFMHRT+EpAukZ5hvIdkms0EbsB3VhqKuDKGbYR4BvW Q0NG+OJ/3hvgBn6CzZduGHemV9JlFHD07QEc/QOU/hLZVxySkqBN/qcs3qWOD0WRg1HD NOSCy6GPAIbo2QpDy6TjsVF5vmNN51VR/ENBB6fZifQPq9WTocFPHqOPz46qjqYjj+i1 uUk4kHOC7t7sm29i2QRNBxbQPKOUbk6/zTAnVGTkz1MP+qJDd7ar1v7haIj5at4xgeX8 8gbg== X-Gm-Message-State: APjAAAVIh4jg181ktWJyJqrN/dn+nUMwta5ce8Gw8vMiyDUky17pEW1V PLkx6F6XYC6zvUdEF6KD8/Y= X-Google-Smtp-Source: APXvYqzX6a2iQyDfYooendkQ5zSgSGdU01D3yozeF/cxzfrXkkmVgh14NLfNcYteIvDVh7ZrHP3hQw== X-Received: by 2002:a1c:7e91:: with SMTP id z139mr18329911wmc.15.1574458990943; Fri, 22 Nov 2019 13:43:10 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id 205sm579078wmb.3.2019.11.22.13.43.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2019 13:43:09 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> <834kywxtr1.fsf@gnu.org> <83mucnvd1u.fsf@gnu.org> From: Dmitry Gutov Message-ID: <3b451485-97f2-2260-2574-8fe1b58c670d@yandex.ru> Date: Fri, 22 Nov 2019 23:43:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83mucnvd1u.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 22.11.2019 23:03, Eli Zaretskii wrote: > I'd prefer to use "log -p" in the backend ("log --diff" for svn), > because that yields a single command and will work for all the > backends except RCS and CVS. Would it? For Git, we need 'git log -p -n 1', for Hg, 'hg log -p -l 1'. So it's hard to do the default implementation. If you still mean to update the print-log action (which will mean updating all backends), I'm okay with that essentially, except we'd likely document the extra argument as "also print diffs for each revision". It would be weird for it to mean "show diffs INSTEAD of the revision log" only in CVS and RCS. But if someone wants to implement it that way (with ample commentary), I won't stop them. I do think this should be better invoked via a new user-visible command, though. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 16:51:11 2019 Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 21:51:11 +0000 Received: from localhost ([127.0.0.1]:55621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYGpY-0005EB-Op for submit@debbugs.gnu.org; Fri, 22 Nov 2019 16:51:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYGpS-0005Db-He for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 16:51:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iYGpM-0003jR-ET; Fri, 22 Nov 2019 16:50:56 -0500 Received: from [176.228.60.248] (port=3504 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iYGpL-0004xm-KY; Fri, 22 Nov 2019 16:50:56 -0500 Date: Fri, 22 Nov 2019 23:51:11 +0200 Message-Id: <83k17rvauo.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <3b451485-97f2-2260-2574-8fe1b58c670d@yandex.ru> (message from Dmitry Gutov on Fri, 22 Nov 2019 23:43:08 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> <834kywxtr1.fsf@gnu.org> <83mucnvd1u.fsf@gnu.org> <3b451485-97f2-2260-2574-8fe1b58c670d@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Fri, 22 Nov 2019 23:43:08 +0200 > > On 22.11.2019 23:03, Eli Zaretskii wrote: > > I'd prefer to use "log -p" in the backend ("log --diff" for svn), > > because that yields a single command and will work for all the > > backends except RCS and CVS. > > Would it? > > For Git, we need 'git log -p -n 1', for Hg, 'hg log -p -l 1'. So it's > hard to do the default implementation. I didn't mean to say that we should have a default implementation, I meant to have an implementation in each backend. So small differences in the commands to be issued are not an issue. > If you still mean to update the print-log action (which will mean > updating all backends), I'm okay with that essentially, except we'd > likely document the extra argument as "also print diffs for each > revision". It would be weird for it to mean "show diffs INSTEAD of the > revision log" only in CVS and RCS. But if someone wants to implement it > that way (with ample commentary), I won't stop them. I'd prefer it that way, yes. > I do think this should be better invoked via a new user-visible command, > though. I don't object to having a separate command as well, but not instead of "C-x v L". From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 07:14:50 2019 Received: (at 38044) by debbugs.gnu.org; 23 Nov 2019 12:14:51 +0000 Received: from localhost ([127.0.0.1]:55883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYUJ7-0003Mg-U5 for submit@debbugs.gnu.org; Sat, 23 Nov 2019 07:14:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYUIV-0003LV-2Q for 38044@debbugs.gnu.org; Sat, 23 Nov 2019 07:13:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iYUIO-0000cJ-V5; Sat, 23 Nov 2019 07:13:49 -0500 Received: from [176.228.60.248] (port=4375 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iYUIO-0002wQ-4y; Sat, 23 Nov 2019 07:13:48 -0500 Date: Sat, 23 Nov 2019 14:13:44 +0200 Message-Id: <834kyuvlhj.fsf@gnu.org> From: Eli Zaretskii To: Stephen Berman In-reply-to: <87h82wmfes.fsf@gmx.net> (message from Stephen Berman on Fri, 22 Nov 2019 10:25:15 +0100) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <87h82wmfes.fsf@gmx.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, juri@linkov.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stephen Berman > Cc: dgutov@yandex.ru, juri@linkov.net, larsi@gnus.org, 38044@debbugs.gnu.org > Date: Fri, 22 Nov 2019 10:25:15 +0100 > > I find even just typing one C-u less convenient, hence my suggestion > below, which I'm glad you find worth considering. > > >> Since one of the desiderata of this command, perhaps even the main > >> one, is that it should act on the revision ID at point, how about > >> making just `C-x v L' do that if it recognizes the word at point as > >> a revision ID? > > > > We could do that, yes. > > > >> If this is deemed to unreliable, it could be conditioned by a user > >> option, or perhaps (though more annoying) by asking for > >> confirmation. > > > > Fine with me, assuming the rest of the proposal is accepted. Btw, in the above scenario, I guess it would be more convenient if the revision was displayed in "the other" window, so that the user could continue reading/studying whatever he/she was looking at before invoking the command, is that right? From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 08:18:21 2019 Received: (at 38044) by debbugs.gnu.org; 23 Nov 2019 13:18:21 +0000 Received: from localhost ([127.0.0.1]:55962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYVIo-0001GJ-CR for submit@debbugs.gnu.org; Sat, 23 Nov 2019 08:18:21 -0500 Received: from mout.gmx.net ([212.227.17.21]:54341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYVHP-0000jc-4Z for 38044@debbugs.gnu.org; Sat, 23 Nov 2019 08:17:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1574515001; bh=85/a0bGSuuphrarcXzJ0njNJektuExWM5TKdGzHcLWE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=CakYgSrbn/xzvQjT80B4BVusqCH+6VXuODkRMecFiKL3vD4EkYJhQRNY1pjEdi90H pctFxstkmS7RnbkRfdSP1Yof6F0qm5RcidzgdqiimO0SLaqYFBVTaXtXPoCmEMX+Lq VZfYW7omZLP2GyJeTXy5/UEgDqyA1hBdHeXJ4yys= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-lfs84 ([84.61.246.1]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MsYqp-1hfzyl2xat-00tyAW; Sat, 23 Nov 2019 14:16:40 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <87h82wmfes.fsf@gmx.net> <834kyuvlhj.fsf@gnu.org> Date: Sat, 23 Nov 2019 14:16:38 +0100 In-Reply-To: <834kyuvlhj.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 23 Nov 2019 14:13:44 +0200") Message-ID: <87d0di20nd.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:OJMgmc0w0kbaP8khPhM08Vl7AhMUe9xPa320ieV17dqB8dgC6ZZ IKa7eaTMiazDxJjMwF4EwLcDfMc9y9sU9GI1xEvSGpTztRoZrdV+1O0QigSiipmBVJ9lwkw 1LZ4Q1pFxuyqv2cvZwMoJsubo4k0xXttWn3L5/JGNkbaR9olVaTf9XzSw7iOhdpP9TPzZMb 7tQ088zJ76HjEJMYRkGOw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:3+z9pJLeZvg=:Mwvp/IR+216WGeG6WvFM08 pdarPjeoHU2METRSPdC04YnVnlVV2H6SeE1WbWr4R+UiLMY2xaqoNvmaNERysDnSeK09gLoEW xAAw7mICqNu8w72hg1oIWYpR0McmxYA1dRW7i5068N/2yZLfis+luRHOLbvtU6h3ohJuqXoAf QM+YjZj6SXe8leQ5q+2t9gadHKnRlG/b46b4TyKA28Xg6CmNsMY2ZlM40vv244BcizXUSKAky r5HDN8ItqcgFXixUcas8QN5Gm4pcEDnmFgK/MY5A9FHS2KBjAQhKr79ZzxX+3M4fzH6vz+GIN KUM/3If4LWJLE8mrj6ZDW0xgg0mKaNeLKmHXaKUSFNidHqGPSyykqIPcR/kYLqvRnxsdp72+W 5L7M8r9WGiEYycUdUv/Z76RbnY2kJWE1V9OKR/lyW7KVggwb94RO1kFjJnWEtCqIxNtGfcmLj cYBxfP3EUUH/mcbxdO8cB4XSKzhhozr9eGX+sxuRjQXj6IoizGvr/AJRX8QikxFLlJBysqTMH G2eVecucIMPyVrHlstOS76/jM3b29QmKLM5/FvpASR8DTLRSWDM5RstnRwuRn+MnZaj6UJt40 lRQOcWFrk7zw2TJJ3L0+zJm4q6GmR2YoKDv3tHHtj3sLmlIFr76EtI69qoz8eVNkUGS3pFpu5 l91NVWRiRuQIDnxgJjK0zVlz8nsjRubjFo1njOGkY3H2w0EpxWICUI29PjP0yyeVLo27zY+fH erMyPJrPXzT/hdEIEbFbqfQUtcbz6+g+Dq728PQ9M215lKQMAkW9a5spxWXRIYmdtYh3g6sak 7dKu+jX4vAq7Mb02lcYK3jBF+PJ5PWOPbkrDwN/l4biT6GwFkqwDMYeIlX8Xu2pAuaUiXdAwd Zie0mprV22M/J98DDrgKhGO6CTYzeHLfoV+nTc+dqmxj5p1elHHAk4J1NV0HgtIkon2zFi6SY ehfsCPZrs+J8cSlovTPRL3aRiXNtU807y0k/cetVV7h5UBJemtpNGcryyzitn3bp0utXcaN2m XKx182nUyRaseIqu/QxcHFztYxJT4smO7IHABy/LJMWHgAT3hnJra8IQWpmY4gXTVrMhdDJ0K JyV9sHB+RWDdJC4pLbpmuDVncCoysC4VV8Z8UTUqD0xM/EXvhtp6WQg/+zW4u8A1j1d70V/Pa xeV0hi53JW+9Bikq+oEczi1EOktBvj/hNf1WG02LNHO6LfOVvYFwCeELjxihtB1SmenlSRDCR gpBJWrFR98iRg2iK2aBuY2+XTWbg/UHZaHBg+NZXfnGEghXt8ltnPl4ugCpQ= Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, juri@linkov.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, 23 Nov 2019 14:13:44 +0200 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: dgutov@yandex.ru, juri@linkov.net, larsi@gnus.org, 38044@debbugs= .gnu.org >> Date: Fri, 22 Nov 2019 10:25:15 +0100 >> >> I find even just typing one C-u less convenient, hence my suggestion >> below, which I'm glad you find worth considering. >> >> >> Since one of the desiderata of this command, perhaps even the main >> >> one, is that it should act on the revision ID at point, how about >> >> making just `C-x v L' do that if it recognizes the word at point as >> >> a revision ID? >> > >> > We could do that, yes. >> > >> >> If this is deemed to unreliable, it could be conditioned by a user >> >> option, or perhaps (though more annoying) by asking for >> >> confirmation. >> > >> > Fine with me, assuming the rest of the proposal is accepted. > > Btw, in the above scenario, I guess it would be more convenient if the > revision was displayed in "the other" window, so that the user could > continue reading/studying whatever he/she was looking at before > invoking the command, is that right? Yes, I think so. That's what my home-grown command does, and it's also the way `C-x v L' already works, if I'm not misunderstanding you. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 09:00:16 2019 Received: (at 38044) by debbugs.gnu.org; 23 Nov 2019 14:00:17 +0000 Received: from localhost ([127.0.0.1]:56009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYVxA-0005E2-7a for submit@debbugs.gnu.org; Sat, 23 Nov 2019 09:00:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYVx2-0005Dm-2h for 38044@debbugs.gnu.org; Sat, 23 Nov 2019 08:59:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iYVwv-0001j3-6W; Sat, 23 Nov 2019 08:59:45 -0500 Received: from [176.228.60.248] (port=3562 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iYVwt-0004Vv-8j; Sat, 23 Nov 2019 08:59:44 -0500 Date: Sat, 23 Nov 2019 15:59:39 +0200 Message-Id: <831rtyvgl0.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <3b451485-97f2-2260-2574-8fe1b58c670d@yandex.ru> (message from Dmitry Gutov on Fri, 22 Nov 2019 23:43:08 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> <834kywxtr1.fsf@gnu.org> <83mucnvd1u.fsf@gnu.org> <3b451485-97f2-2260-2574-8fe1b58c670d@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Fri, 22 Nov 2019 23:43:08 +0200 > > For Git, we need 'git log -p -n 1', for Hg, 'hg log -p -l 1'. Btw, it looks like only Git and Src need to explicitly limit the output of 'log' to just a single revision, others have a way of specifying a single revision for 'log'. They all use "-r REVISION" for that. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 13:52:46 2019 Received: (at 38044) by debbugs.gnu.org; 23 Nov 2019 18:52:46 +0000 Received: from localhost ([127.0.0.1]:57814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYaWN-00019a-MM for submit@debbugs.gnu.org; Sat, 23 Nov 2019 13:52:44 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:34702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYaWH-00019C-82 for 38044@debbugs.gnu.org; Sat, 23 Nov 2019 13:52:35 -0500 Received: by mail-wr1-f53.google.com with SMTP id t2so12598812wrr.1 for <38044@debbugs.gnu.org>; Sat, 23 Nov 2019 10:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8Xf/GFSbiQnPPCnFZXMHyx47jHB7mkoaYBurI9InfqM=; b=L/4b/YuMqsGEWDw1ukKJmgYSGmokhTcnLHa4zxv7dsg7pnEy7IHF64cPgnIT1FFjZz DqjRh1tFopG799/Q6S+S89dpUC9r9M9j4PCYSlxPBJzrmpT6kDZ7HNh5Qh7DBmkgh1VF W3lEwqMxlSZy9+5b3MdVP8IHPY8RqbC9avELafZccIRbOP6ZyrRTr5ANCab+Sy6idF4J PSOptO30o7YU6OMGu4JFItechNvzScJ83KNaRd8pkPL6hiireO4TToMlbOY7Ip/yBfoz SrVps2v2TGrt2UVJ8IiaSHahgJVu/brbeYd7PUxsYs5MCvkSLYPMOULUvmN+aopsn0Qr Y4sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8Xf/GFSbiQnPPCnFZXMHyx47jHB7mkoaYBurI9InfqM=; b=C6YoSxJif3MYF8YD4qHJaJgQi4TlsNu6MEhhSB8CZrljSyhhkHb5GVcCyg5qm/CCjl dKyRsUfZWHRcSN9mHprTYpEtkYM1mMNPFDOCj7LOgYbXKn5nht/UogDkt7n5RwYaaVh2 P2Aw3qrP91TGmqwbjmDGrz1v8P1nN7JeYSlOnQs7kEXHRxKdlqWeWm6lggV1klEafkkp L5eo4oCwkVPKrUSrd2Zpvq6nSRQOM/9yQmuJYh0PH7GM0C6ZvdhhnPiO2BEnsGQdQq55 7eBtiKm+3ZBOMMzANptpDak1EoQgzJ+q4AWm/rMtZeN3DdLeX64BzcLeIA42VkLZ+x2J z2Mg== X-Gm-Message-State: APjAAAVpD/frN6Puw+krd6FCgi6T1mVWhhRjIsGWWsVr94l5AMnWDVir 8yBid2bUpWPfqlHiSRHr0fQ= X-Google-Smtp-Source: APXvYqyVHX1JpHGHzz8ecBiPCoR4ZgstbKCYvQk4i3ftGt+Grs2z0v7vc0y4lvIB9OMcdUmJboA/Eg== X-Received: by 2002:adf:edc5:: with SMTP id v5mr23405660wro.322.1574535147309; Sat, 23 Nov 2019 10:52:27 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id b3sm2664139wmj.44.2019.11.23.10.52.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Nov 2019 10:52:26 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> <834kywxtr1.fsf@gnu.org> <83mucnvd1u.fsf@gnu.org> <3b451485-97f2-2260-2574-8fe1b58c670d@yandex.ru> <831rtyvgl0.fsf@gnu.org> From: Dmitry Gutov Message-ID: <9a648062-2095-7165-f066-cd8b321dbb05@yandex.ru> Date: Sat, 23 Nov 2019 20:52:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <831rtyvgl0.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 23.11.2019 15:59, Eli Zaretskii wrote: >> Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, >> juri@linkov.net >> From: Dmitry Gutov >> Date: Fri, 22 Nov 2019 23:43:08 +0200 >> > [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.53 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.53 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 1.0 FREEMAIL_REPLY From and body contain different freemails X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 23.11.2019 15:59, Eli Zaretskii wrote: >> Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, >> juri@linkov.net >> From: Dmitry Gutov >> Date: Fri, 22 Nov 2019 23:43:08 +0200 >> >> For Git, we need 'git log -p -n 1', for Hg, 'hg log -p -l 1'. > > Btw, it looks like only Git and Src need to explicitly limit the > output of 'log' to just a single revision, others have a way of > specifying a single revision for 'log'. They all use "-r REVISION" > for that. I don't think we are going to use this new fact because the print-log implementations already have a start-revision argument, and it's implemented in a way that shows both the given revision and the previous ones. And there is an argument to limit the number of shows revisions. We'll want the new argument to be as orthogonal to the existing ones as possible. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 14:05:06 2019 Received: (at 38044) by debbugs.gnu.org; 23 Nov 2019 19:05:06 +0000 Received: from localhost ([127.0.0.1]:57838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYaiK-0001Tp-Vs for submit@debbugs.gnu.org; Sat, 23 Nov 2019 14:05:03 -0500 Received: from beige.elm.relay.mailchannels.net ([23.83.212.16]:34166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYaiH-0001Tb-0F for 38044@debbugs.gnu.org; Sat, 23 Nov 2019 14:05:00 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id CC51121273; Sat, 23 Nov 2019 19:04:55 +0000 (UTC) Received: from pdx1-sub0-mail-a24.g.dreamhost.com (100-96-196-51.trex.outbound.svc.cluster.local [100.96.196.51]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 33F5320FC4; Sat, 23 Nov 2019 19:04:55 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a24.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sat, 23 Nov 2019 19:04:55 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Stretch-Ruddy: 385747813c793183_1574535895469_418503414 X-MC-Loop-Signature: 1574535895468:957690975 X-MC-Ingress-Time: 1574535895468 Received: from pdx1-sub0-mail-a24.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a24.g.dreamhost.com (Postfix) with ESMTP id A439B83DB6; Sat, 23 Nov 2019 11:04:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=pkEbrGiFaJsiA++vJGnbKpzR75I=; b= rFllk7C0cN2diVYQ1KIFzUv0sKNhQvKA9O4Q0Um8lDvrIaPmf/N5nvPUCL88eTTq 3RbgqAg9SQ6Y/8PEkvh1wRLjsZKbgtHGiDKhZR7HXB+QEb4x9LxciDAl+zAsGnEm vHQUnt9BwnHQRFnHLciL4kioKJpit/eOF2Y8WdTTBtA= Received: from mail.jurta.org (m91-129-105-73.cust.tele2.ee [91.129.105.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a24.g.dreamhost.com (Postfix) with ESMTPSA id B84F783DB9; Sat, 23 Nov 2019 11:04:46 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a24 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> Date: Sat, 23 Nov 2019 20:50:10 +0200 In-Reply-To: <837e3tx9s8.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Nov 2019 22:19:03 +0200") Message-ID: <87d0di7959.fsf@linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain > Here's an alternative proposal. It seems like almost all VCS backends > we support provide a variant of a "log" command that shows the diffs > together with the usual meta-data shown by "log". Only RCS and CVS > don't have such an option of "log", all the rest do (most of them via > "log -p"). > > So we could make this a subcommand of vc-log, more accurately > vc-print-root-log, such that "C-u C-u C-x v L" will prompt for a > revision ID, and display the information produced by such a "log -p" > command (and fall back to displaying just the diffs for RCS and CVS). > > Does this sound better? This is fine. Here's a new patch that implements 'M-1 C-x v L' to limit the log to one revision expanded with diff: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-print-root-log-revision.patch diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index ca4c66a06d..3b977aa1f4 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1160,7 +1159,9 @@ vc-git-print-log (list (concat start-revision ".." (if (equal limit "") "HEAD" limit))) - (list start-revision))) + (if (eq limit 1) + (list "-p" start-revision) + (list start-revision)))) '("--"))))))) (defun vc-git-log-outgoing (buffer remote-location) diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 0d29c80d02..90603541b5 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2475,13 +2475,26 @@ vc-print-log (vc-print-log-internal backend files working-revision nil limit))) ;;;###autoload -(defun vc-print-root-log (&optional limit) +(defun vc-print-root-log (&optional limit revision) "List the change log for the current VC controlled tree in a window. If LIMIT is non-nil, it should be a number specifying the maximum number of revisions to show; the default is `vc-log-show-limit'. -When called interactively with a prefix argument, prompt for LIMIT." +When called interactively with a prefix argument, prompt for LIMIT. +When the prefix argument is a number, use it as LIMIT. +A special case is when the prefix argument is 1, in this case +it asks for the revision and shows it with its diff." (interactive (cond + ((eq current-prefix-arg 1) + (let* ((default (thing-at-point 'word)) + (revision (vc-read-revision + (if default + (format "Revision to show (default %s): " default) + "Revision to show: ") + nil nil default))) + (list 1 revision))) + ((numberp current-prefix-arg) + (list current-prefix-arg)) (current-prefix-arg (let ((lim (string-to-number (read-from-minibuffer @@ -2494,6 +2507,8 @@ vc-print-root-log (list (when (> vc-log-show-limit 0) vc-log-show-limit))))) (let ((backend (vc-deduce-backend)) (default-directory default-directory) + (vc-log-short-style (unless (and (eq limit 1) revision) + vc-log-short-style)) rootdir) (if backend (setq rootdir (vc-call-backend backend 'root default-directory)) @@ -2502,7 +2517,9 @@ vc-print-root-log (unless backend (error "Directory is not version controlled"))) (setq default-directory rootdir) - (vc-print-log-internal backend (list rootdir) nil nil limit))) + (vc-print-log-internal backend (list rootdir) revision revision limit) + (when (and (eq limit 1) revision) + (vc-git-region-history-mode)))) ;;;###autoload (defun vc-print-branch-log (branch) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 14:11:27 2019 Received: (at 38044) by debbugs.gnu.org; 23 Nov 2019 19:11:27 +0000 Received: from localhost ([127.0.0.1]:57857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYaoZ-0001dt-Be for submit@debbugs.gnu.org; Sat, 23 Nov 2019 14:11:27 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:43703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYaoV-0001de-OJ for 38044@debbugs.gnu.org; Sat, 23 Nov 2019 14:11:24 -0500 Received: by mail-wr1-f49.google.com with SMTP id n1so12566400wra.10 for <38044@debbugs.gnu.org>; Sat, 23 Nov 2019 11:11:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UI97pS+IbMat4y+V7cfFjM+r8TX4IdBoN5GM56j2soM=; b=Wqzz3qIj7PaNdPWgaezoi+21KglCmIbm80SvDxMkhfr1ZPEpOi7vHfBBK50SAtxgF4 v3u5qgMj69bsLae0g/KQbAsTyTySVDXlg5hoGe9E9DFOGlD/LaUi0RHtIT/LiAMdC1Ay fK4vjt40xLV1cMk+9Vao5jvzNlt7Tl6LkfCXvNHzMXeEkSUSNxvuZ01sy803ojieFAiC JJpS+XLRHlTury0Aa1HG0dICGzz1T9wB0dRa1TavWRaadpsxZd19cDACuDfQZR3E56Ca k0F9dVdPsrLwPapHLzDKro4WDHkN7c6Zrd5nzK6RC5BTuNpWsmQ1piZtbx/h7K8I8XOv MO1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UI97pS+IbMat4y+V7cfFjM+r8TX4IdBoN5GM56j2soM=; b=typkVpsSr0y1xIbQUrbydFxhOiNjld8LN4QjM5sCm3lqt1xnSnBg+8siy08b7oOSB5 Xh8GUHqlcAv4VxsvdRmfg1NNWJQMxT2AvHWrb5bBU7BBfjYGVd4c+zy1YvTSPP4rlgs8 d2EgqUFpvugJySB2GkBOhAIc5d2bRcaLnTZV+7L2Gfrb7GatcXIzDXYDPi/GD1u4w/Ax QBrLhirj+sSOH9USVF+MtydBg8t5XHKNEllhZG1fZNmgEoVFraGdha70xkKpih/RZqrl pRNOZaOk0YaFUUoA9nDwBMw6L7LJP9mOnVtyjgHSo8895FQtTJYSY8yfMVy5r83x4IfF DfOA== X-Gm-Message-State: APjAAAWSEOVFolqeGJkqeA2krZNfM+mIuQJwW4YWqz27RU+2spnJk+f9 8Xsvj6w8ld04wqVds3Drvmo11WLD X-Google-Smtp-Source: APXvYqyG/ZQGIacQI/g++PgxolUAe5ZFeApXcTuIogyO2q7YHaPzmDsSC3XVcT1xn9IRYd5K2P8LuA== X-Received: by 2002:a5d:634e:: with SMTP id b14mr12319272wrw.255.1574536277704; Sat, 23 Nov 2019 11:11:17 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id y67sm2825957wmy.31.2019.11.23.11.11.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Nov 2019 11:11:17 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Juri Linkov , Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> From: Dmitry Gutov Message-ID: <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> Date: Sat, 23 Nov 2019 21:11:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87d0di7959.fsf@linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 23.11.2019 20:50, Juri Linkov wrote: > - (list start-revision))) > + (if (eq limit 1) > + (list "-p" start-revision) > + (list start-revision)))) > > +A special case is when the prefix argument is 1, in this case > +it asks for the revision and shows it with its diff." I think that's rather ugly (see my comment about having the arguments to be orthogonal), and it precludes the use of this backend action to print a more extensive commit log (with diffs, that is). > + (when (and (eq limit 1) revision) > + (vc-git-region-history-mode)))) A Git-specific function in vc.el? From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 17:46:05 2019 Received: (at 38044) by debbugs.gnu.org; 23 Nov 2019 22:46:05 +0000 Received: from localhost ([127.0.0.1]:57942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYeAC-0006lM-Pj for submit@debbugs.gnu.org; Sat, 23 Nov 2019 17:46:03 -0500 Received: from butterfly.birch.relay.mailchannels.net ([23.83.209.27]:59302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYe9P-0006kC-Pc for 38044@debbugs.gnu.org; Sat, 23 Nov 2019 17:45:50 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 79D1C580C60; Sat, 23 Nov 2019 22:45:10 +0000 (UTC) Received: from pdx1-sub0-mail-a5.g.dreamhost.com (100-96-83-20.trex.outbound.svc.cluster.local [100.96.83.20]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 86A4B58092A; Sat, 23 Nov 2019 22:45:09 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a5.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sat, 23 Nov 2019 22:45:10 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Quick-Little: 6857f6ae2fe4c073_1574549110269_4069701066 X-MC-Loop-Signature: 1574549110269:1456320365 X-MC-Ingress-Time: 1574549110269 Received: from pdx1-sub0-mail-a5.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a5.g.dreamhost.com (Postfix) with ESMTP id 1EBF283E49; Sat, 23 Nov 2019 14:45:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=TyDqCpQb+npbHX/R8fGfMkE+AUQ=; b= 0F30Wmceq5yoVevBHC6ClE8YBGoATor4c7hb6Tm0OsJWhZS4WmsJXXskceYoIDFM HLqsd1sdm4416zDLrL84o+3bIED0sEyncUrcFL/hLmobWaTa8tTPuF0R33KL5Fwx JVjrs8V4dL3kMf0ZfclFz8evORddB70b0ap9Ssmdweo= Received: from mail.jurta.org (m91-129-105-73.cust.tele2.ee [91.129.105.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a5.g.dreamhost.com (Postfix) with ESMTPSA id EA15683E4C; Sat, 23 Nov 2019 14:45:00 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a5 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> Date: Sun, 24 Nov 2019 00:43:37 +0200 In-Reply-To: <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> (Dmitry Gutov's message of "Sat, 23 Nov 2019 21:11:15 +0200") Message-ID: <87mucm43ja.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: Eli Zaretskii , stephen.berman@gmx.net, 38044@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain >> - (list start-revision))) >> + (if (eq limit 1) >> + (list "-p" start-revision) >> + (list start-revision)))) >> +A special case is when the prefix argument is 1, in this case >> +it asks for the revision and shows it with its diff." > > I think that's rather ugly (see my comment about having the arguments to be > orthogonal), and it precludes the use of this backend action to print > a more extensive commit log (with diffs, that is). I rewrote the patch to make it more flexible, so now the function can check 'vc-log-view-type' for the value 'with-diff'. >> + (when (and (eq limit 1) revision) >> + (vc-git-region-history-mode)))) > > A Git-specific function in vc.el? Thanks for noticing, this was intended to call a backend function. But now I rewrote this part as well to call region-history-mode from other place: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-print-root-log-with-diff.patch diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index ca4c66a06d..02a8a3a525 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1161,6 +1161,8 @@ vc-git-print-log "HEAD" limit))) (list start-revision))) + (when (eq vc-log-view-type 'with-diff) + (list "-p")) '("--"))))))) (defun vc-git-log-outgoing (buffer remote-location) @@ -1226,7 +1228,7 @@ vc-git-log-view-mode (set (make-local-variable 'log-view-file-re) regexp-unmatchable) (set (make-local-variable 'log-view-per-file-logs) nil) (set (make-local-variable 'log-view-message-re) - (if (not (memq vc-log-view-type '(long log-search))) + (if (not (memq vc-log-view-type '(long log-search with-diff))) (cadr vc-git-root-log-format) "^commit *\\([0-9a-z]+\\)")) ;; Allow expanding short log entries. @@ -1235,7 +1237,7 @@ vc-git-log-view-mode (set (make-local-variable 'log-view-expanded-log-entry-function) 'vc-git-expanded-log-entry)) (set (make-local-variable 'log-view-font-lock-keywords) - (if (not (memq vc-log-view-type '(long log-search))) + (if (not (memq vc-log-view-type '(long log-search with-diff))) (list (cons (nth 1 vc-git-root-log-format) (nth 2 vc-git-root-log-format))) (append diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 0d29c80d02..5cca3c6dd6 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2361,7 +2361,7 @@ vc-print-log-setup-buttons 'help-echo "Show the log again, including all entries"))) (defun vc-print-log-internal (backend files working-revision - &optional is-start-revision limit) + &optional is-start-revision limit type) "For specified BACKEND and FILES, show the VC log. Leave point at WORKING-REVISION, if it is non-nil. If IS-START-REVISION is non-nil, start the log from WORKING-REVISION @@ -2377,7 +2377,7 @@ vc-print-log-internal (shortlog (not (null (memq (if dir-present 'directory 'file) vc-log-short-style)))) (buffer-name "*vc-change-log*") - (type (if shortlog 'short 'long))) + (type (or type (if shortlog 'short 'long)))) (vc-log-internal-common backend buffer-name files type (lambda (bk buf _type-arg files-arg) @@ -2393,7 +2393,7 @@ vc-print-log-internal (vc-call-backend bk 'show-log-entry working-revision))) (lambda (_ignore-auto _noconfirm) (vc-print-log-internal backend files working-revision - is-start-revision limit))))) + is-start-revision limit type))))) (defvar vc-log-view-type nil "Set this to differentiate the different types of logs.") @@ -2416,7 +2416,10 @@ vc-log-internal-common (let ((inhibit-read-only t)) ;; log-view-mode used to be called with inhibit-read-only bound ;; to t, so let's keep doing it, just in case. - (vc-call-backend backend 'log-view-mode) + (vc-call-backend backend + (if (eq type 'with-diff) + 'region-history-mode + 'log-view-mode)) (set (make-local-variable 'log-view-vc-backend) backend) (set (make-local-variable 'log-view-vc-fileset) files) (set (make-local-variable 'revert-buffer-function) @@ -2475,13 +2478,26 @@ vc-print-log (vc-print-log-internal backend files working-revision nil limit))) ;;;###autoload -(defun vc-print-root-log (&optional limit) +(defun vc-print-root-log (&optional limit revision) "List the change log for the current VC controlled tree in a window. If LIMIT is non-nil, it should be a number specifying the maximum number of revisions to show; the default is `vc-log-show-limit'. -When called interactively with a prefix argument, prompt for LIMIT." +When called interactively with a prefix argument, prompt for LIMIT. +When the prefix argument is a number, use it as LIMIT. +A special case is when the prefix argument is 1, in this case +it asks for the revision and shows it with its diff." (interactive (cond + ((eq current-prefix-arg 1) + (let* ((default (thing-at-point 'word)) + (revision (vc-read-revision + (if default + (format "Revision to show (default %s): " default) + "Revision to show: ") + nil nil default))) + (list 1 revision))) + ((numberp current-prefix-arg) + (list current-prefix-arg)) (current-prefix-arg (let ((lim (string-to-number (read-from-minibuffer @@ -2492,9 +2508,11 @@ vc-print-root-log (list lim))) (t (list (when (> vc-log-show-limit 0) vc-log-show-limit))))) - (let ((backend (vc-deduce-backend)) - (default-directory default-directory) - rootdir) + (let* ((backend (vc-deduce-backend)) + (default-directory default-directory) + (with-diff (and (eq limit 1) revision)) + (vc-log-short-style (unless with-diff vc-log-short-style)) + rootdir) (if backend (setq rootdir (vc-call-backend backend 'root default-directory)) (setq rootdir (read-directory-name "Directory for VC root-log: ")) @@ -2502,7 +2520,8 @@ vc-print-root-log (unless backend (error "Directory is not version controlled"))) (setq default-directory rootdir) - (vc-print-log-internal backend (list rootdir) nil nil limit))) + (vc-print-log-internal backend (list rootdir) revision revision limit + (when with-diff 'with-diff)))) ;;;###autoload (defun vc-print-branch-log (branch) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 25 07:49:45 2019 Received: (at 38044) by debbugs.gnu.org; 25 Nov 2019 12:49:45 +0000 Received: from localhost ([127.0.0.1]:47737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZDoG-0005GU-TB for submit@debbugs.gnu.org; Mon, 25 Nov 2019 07:49:45 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:46901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZDoE-0005GH-F8 for 38044@debbugs.gnu.org; Mon, 25 Nov 2019 07:49:43 -0500 Received: by mail-wr1-f45.google.com with SMTP id z7so14433374wrl.13 for <38044@debbugs.gnu.org>; Mon, 25 Nov 2019 04:49:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vt9nMtT+/79rlmn2XNHH+derGSyJTe4piMDu2nHG5lc=; b=tu8SUDF9nqpPVZ2UF1NHyZyqoMGBHrVta/8QLm1G1rupv26bM1MyX4KW+uqeKqPvkJ NyJkaxYTitQbprldtXUCfLGa1+87ngoN2G5uSAdzpxt5FRFWpihva8a2L231809MsUZ/ zjMPvZWlb0Ygy4m7RLGE8+WL4vMB+Z8TQmvpSfhXy7Bkbdjmw93/AbC2T2my5j811UK/ ZyVL+UfyrOX0tGA9oPZU3ejBoQbvLJFU0WG0ZMCboiHYs3h3VOjhns5q/Jgl7BdJ0VIt 8PwijohUAFJbdA3r9bob08tu6WtcY+oYIRjtnETTPyh7JlUoCoq4Ljw65Adp0o2TrWE+ L8Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vt9nMtT+/79rlmn2XNHH+derGSyJTe4piMDu2nHG5lc=; b=X3XO/DPJgyjAwt6ITELABpBpMjy/aw1ZbhSE+IGvdrRd6CCHCJuC13jHHLutoAmHAG 8R6gD/+2xzH7MIKqJdrqzi+MMdYQmXPBADOr86Dc7/wAZ59teBt/KuHTGVjiwCEEkJpx WxCBsMN9uzB+oJoRUG3EtSgbkibCZTPdQLnWmjeFUTf/kwpAAF9mBkfzVpxxmzxz4sCd 1Hy8EDXAsLT9RaqYIjYIG+faWX6kCWiV/9Xo2e46UqUcUnY8CeGDX2brKRBLNo99uE/t J8SXiBS/tZQTt8dKVmED5KYP50/lpOH6iN+pCwFGGFHCZHzDsZt4RQgokmUoX0tdfvlG bJVQ== X-Gm-Message-State: APjAAAV9MYuBTxSXXuTZ8slJg/C1d+AjwgWxw1WLxpqmMSnGjf1QrN3N X5pEclMHhp0ncJriVzk1sPyuNBWx X-Google-Smtp-Source: APXvYqwLVO+oQJJ1pJ+40yQhtMK6FdRYkSoyrANxYc8F80KDVlqp446DZ1TMus1/M+0+MeoYRVTt9Q== X-Received: by 2002:a5d:4810:: with SMTP id l16mr13205427wrq.127.1574640764831; Sun, 24 Nov 2019 16:12:44 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id j67sm6838998wmb.43.2019.11.24.16.12.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Nov 2019 16:12:43 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Juri Linkov References: <87ftj5at1q.fsf@gnus.org> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <6d316d96-0c2b-27e8-f538-a7909a127b7a@yandex.ru> Date: Mon, 25 Nov 2019 02:12:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87mucm43ja.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 38044 Cc: Eli Zaretskii , stephen.berman@gmx.net, 38044@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 24.11.2019 0:43, Juri Linkov wrote: > I rewrote the patch to make it more flexible, so now the function > can check 'vc-log-view-type' for the value 'with-diff'. Generally, an explicit argument is better than an implicit one. So what's the idea here? Gracefully degrading to just showing a log entry when the backend doesn't support the WITH-DIFF feature? (BTW, the print-revision approach seems better for graceful degradation, but I'm tired of arguing for that). I think it would work, but for that all backends need support for region-history-mode anyway. The caller function doesn't have a way to check the lack of support. So I guess the "proper" choice here is to extract region-history-mode is a way that doesn't need redefinition by all backends. Or a shortcut: catch the vc-not-supported error and call backend's log-view-mode instead. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 25 10:29:20 2019 Received: (at 38044) by debbugs.gnu.org; 25 Nov 2019 15:29:20 +0000 Received: from localhost ([127.0.0.1]:49555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZGIi-0001RX-Gt for submit@debbugs.gnu.org; Mon, 25 Nov 2019 10:29:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZGIb-0001QJ-5O for 38044@debbugs.gnu.org; Mon, 25 Nov 2019 10:29:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iYuNr-0005n2-U6; Sun, 24 Nov 2019 11:05:11 -0500 Received: from [176.228.60.248] (port=1273 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iYuNq-0008HP-1y; Sun, 24 Nov 2019 11:05:11 -0500 Date: Sun, 24 Nov 2019 18:05:10 +0200 Message-Id: <83zhgls1jd.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87mucm43ja.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 24 Nov 2019 00:43:37 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Eli Zaretskii , larsi@gnus.org, stephen.berman@gmx.net, > 38044@debbugs.gnu.org > Date: Sun, 24 Nov 2019 00:43:37 +0200 > > @@ -2416,7 +2416,10 @@ vc-log-internal-common > (let ((inhibit-read-only t)) > ;; log-view-mode used to be called with inhibit-read-only bound > ;; to t, so let's keep doing it, just in case. > - (vc-call-backend backend 'log-view-mode) > + (vc-call-backend backend > + (if (eq type 'with-diff) > + 'region-history-mode > + 'log-view-mode)) Can we avoid calling region-history-mode if the backend doesn't implement it? Or do you plan on adding that to all backends? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 18:20:13 2019 Received: (at 38044) by debbugs.gnu.org; 26 Nov 2019 23:20:13 +0000 Received: from localhost ([127.0.0.1]:53166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZk7w-0001rP-Lg for submit@debbugs.gnu.org; Tue, 26 Nov 2019 18:20:13 -0500 Received: from bonobo.elm.relay.mailchannels.net ([23.83.212.22]:43700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZk7u-0001r7-85 for 38044@debbugs.gnu.org; Tue, 26 Nov 2019 18:20:11 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 09E936A1C4B; Tue, 26 Nov 2019 23:20:09 +0000 (UTC) Received: from pdx1-sub0-mail-a89.g.dreamhost.com (100-96-86-105.trex.outbound.svc.cluster.local [100.96.86.105]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 78F426A1867; Tue, 26 Nov 2019 23:20:08 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a89.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Tue, 26 Nov 2019 23:20:08 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Print-Fearful: 3661ab3c348223e4_1574810408756_1587221380 X-MC-Loop-Signature: 1574810408756:2027709235 X-MC-Ingress-Time: 1574810408755 Received: from pdx1-sub0-mail-a89.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a89.g.dreamhost.com (Postfix) with ESMTP id 2233AA415E; Tue, 26 Nov 2019 15:20:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=awzy/ZzrZluhe0RPptSB8Rp8cj0=; b= KbZgCT+bTXxSi4JvTMtNrM7zDoMoCK+/8sw1kZsLDBaZP+PhuqgKpXC+EE7iYLy+ J0Irk4HtkkUgIHyq8839zod295Ngc08Ic8JincnPb55qSKeF1gh80Vdaq+2iK5uY A3mq3iKw63RPM9dqmnVkXjoNR5BTlX8EKZlXGeTHtqc= Received: from mail.jurta.org (m91-129-96-42.cust.tele2.ee [91.129.96.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a89.g.dreamhost.com (Postfix) with ESMTPSA id 4ABEAA4153; Tue, 26 Nov 2019 15:19:58 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a89 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> <83zhgls1jd.fsf@gnu.org> Date: Wed, 27 Nov 2019 01:01:20 +0200 In-Reply-To: <83zhgls1jd.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 24 Nov 2019 18:05:10 +0200") Message-ID: <87a78i2qf3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain >> @@ -2416,7 +2416,10 @@ vc-log-internal-common >> (let ((inhibit-read-only t)) >> ;; log-view-mode used to be called with inhibit-read-only bound >> ;; to t, so let's keep doing it, just in case. >> - (vc-call-backend backend 'log-view-mode) >> + (vc-call-backend backend >> + (if (eq type 'with-diff) >> + 'region-history-mode >> + 'log-view-mode)) > > Can we avoid calling region-history-mode if the backend doesn't > implement it? Or do you plan on adding that to all backends? A new patch avoids calling region-history-mode if the backend doesn't implement it: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-print-root-log-with-diff-2.patch diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index ca4c66a06d..71307cdffd 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1161,6 +1160,8 @@ vc-git-print-log "HEAD" limit))) (list start-revision))) + (when (eq vc-log-view-type 'with-diff) + (list "-p")) '("--"))))))) (defun vc-git-log-outgoing (buffer remote-location) @@ -1226,7 +1227,7 @@ vc-git-log-view-mode (set (make-local-variable 'log-view-file-re) regexp-unmatchable) (set (make-local-variable 'log-view-per-file-logs) nil) (set (make-local-variable 'log-view-message-re) - (if (not (memq vc-log-view-type '(long log-search))) + (if (not (memq vc-log-view-type '(long log-search with-diff))) (cadr vc-git-root-log-format) "^commit *\\([0-9a-z]+\\)")) ;; Allow expanding short log entries. @@ -1235,7 +1236,7 @@ vc-git-log-view-mode (set (make-local-variable 'log-view-expanded-log-entry-function) 'vc-git-expanded-log-entry)) (set (make-local-variable 'log-view-font-lock-keywords) - (if (not (memq vc-log-view-type '(long log-search))) + (if (not (memq vc-log-view-type '(long log-search with-diff))) (list (cons (nth 1 vc-git-root-log-format) (nth 2 vc-git-root-log-format))) (append diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 0d29c80d02..d0d2c39ac3 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2361,7 +2361,7 @@ vc-print-log-setup-buttons 'help-echo "Show the log again, including all entries"))) (defun vc-print-log-internal (backend files working-revision - &optional is-start-revision limit) + &optional is-start-revision limit type) "For specified BACKEND and FILES, show the VC log. Leave point at WORKING-REVISION, if it is non-nil. If IS-START-REVISION is non-nil, start the log from WORKING-REVISION @@ -2377,7 +2377,7 @@ vc-print-log-internal (shortlog (not (null (memq (if dir-present 'directory 'file) vc-log-short-style)))) (buffer-name "*vc-change-log*") - (type (if shortlog 'short 'long))) + (type (or type (if shortlog 'short 'long)))) (vc-log-internal-common backend buffer-name files type (lambda (bk buf _type-arg files-arg) @@ -2393,7 +2393,7 @@ vc-print-log-internal (vc-call-backend bk 'show-log-entry working-revision))) (lambda (_ignore-auto _noconfirm) (vc-print-log-internal backend files working-revision - is-start-revision limit))))) + is-start-revision limit type))))) (defvar vc-log-view-type nil "Set this to differentiate the different types of logs.") @@ -2416,7 +2416,12 @@ vc-log-internal-common (let ((inhibit-read-only t)) ;; log-view-mode used to be called with inhibit-read-only bound ;; to t, so let's keep doing it, just in case. - (vc-call-backend backend 'log-view-mode) + (vc-call-backend backend + (if (and (eq type 'with-diff) + (vc-find-backend-function + backend 'region-history-mode)) + 'region-history-mode + 'log-view-mode)) (set (make-local-variable 'log-view-vc-backend) backend) (set (make-local-variable 'log-view-vc-fileset) files) (set (make-local-variable 'revert-buffer-function) @@ -2475,13 +2480,26 @@ vc-print-log (vc-print-log-internal backend files working-revision nil limit))) ;;;###autoload -(defun vc-print-root-log (&optional limit) +(defun vc-print-root-log (&optional limit revision) "List the change log for the current VC controlled tree in a window. If LIMIT is non-nil, it should be a number specifying the maximum number of revisions to show; the default is `vc-log-show-limit'. -When called interactively with a prefix argument, prompt for LIMIT." +When called interactively with a prefix argument, prompt for LIMIT. +When the prefix argument is a number, use it as LIMIT. +A special case is when the prefix argument is 1, in this case +it asks for the revision and shows it with its diff." (interactive (cond + ((eq current-prefix-arg 1) + (let* ((default (thing-at-point 'word)) + (revision (read-string + (if default + (format "Revision to show (default %s): " default) + "Revision to show: ") + nil nil default))) + (list 1 revision))) + ((numberp current-prefix-arg) + (list current-prefix-arg)) (current-prefix-arg (let ((lim (string-to-number (read-from-minibuffer @@ -2492,9 +2510,11 @@ vc-print-root-log (list lim))) (t (list (when (> vc-log-show-limit 0) vc-log-show-limit))))) - (let ((backend (vc-deduce-backend)) - (default-directory default-directory) - rootdir) + (let* ((backend (vc-deduce-backend)) + (default-directory default-directory) + (with-diff (and (eq limit 1) revision)) + (vc-log-short-style (unless with-diff vc-log-short-style)) + rootdir) (if backend (setq rootdir (vc-call-backend backend 'root default-directory)) (setq rootdir (read-directory-name "Directory for VC root-log: ")) @@ -2502,7 +2522,8 @@ vc-print-root-log (unless backend (error "Directory is not version controlled"))) (setq default-directory rootdir) - (vc-print-log-internal backend (list rootdir) nil nil limit))) + (vc-print-log-internal backend (list rootdir) revision revision limit + (when with-diff 'with-diff)))) ;;;###autoload (defun vc-print-branch-log (branch) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 18:20:19 2019 Received: (at 38044) by debbugs.gnu.org; 26 Nov 2019 23:20:19 +0000 Received: from localhost ([127.0.0.1]:53169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZk83-0001rk-B5 for submit@debbugs.gnu.org; Tue, 26 Nov 2019 18:20:19 -0500 Received: from egyptian.birch.relay.mailchannels.net ([23.83.209.56]:19165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZk82-0001rc-2G for 38044@debbugs.gnu.org; Tue, 26 Nov 2019 18:20:18 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E3B84581258; Tue, 26 Nov 2019 23:20:16 +0000 (UTC) Received: from pdx1-sub0-mail-a89.g.dreamhost.com (100-96-45-206.trex.outbound.svc.cluster.local [100.96.45.206]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 705AC5811D3; Tue, 26 Nov 2019 23:20:16 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a89.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Tue, 26 Nov 2019 23:20:16 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Zesty-Shrill: 005617c57e140aa4_1574810416721_285082451 X-MC-Loop-Signature: 1574810416721:1648870321 X-MC-Ingress-Time: 1574810416720 Received: from pdx1-sub0-mail-a89.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a89.g.dreamhost.com (Postfix) with ESMTP id 49111A415E; Tue, 26 Nov 2019 15:20:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=5ia6ofciffiVp06BwoVzM0qqncM=; b= iRnjKXalnflK0OCBXQI3ob0ooOCM472FUZJBgsDQ0efc6qiYPze6EZksAF2Sq81O MmUmtVAjV283ouXJc5a5w7e6FmxhGSdfCn4S/6C0iLtectHdIpGL5S/eOv+9ILV2 4ule7IIEvxiCAf77qN01Nn4zNR3J6qLwIMriVKJVQyc= Received: from mail.jurta.org (m91-129-96-42.cust.tele2.ee [91.129.96.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a89.g.dreamhost.com (Postfix) with ESMTPSA id A8F39A415F; Tue, 26 Nov 2019 15:20:07 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a89 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> <6d316d96-0c2b-27e8-f538-a7909a127b7a@yandex.ru> Date: Wed, 27 Nov 2019 01:06:39 +0200 In-Reply-To: <6d316d96-0c2b-27e8-f538-a7909a127b7a@yandex.ru> (Dmitry Gutov's message of "Mon, 25 Nov 2019 02:12:42 +0200") Message-ID: <87ftia1bls.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: Eli Zaretskii , stephen.berman@gmx.net, 38044@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> I rewrote the patch to make it more flexible, so now the function >> can check 'vc-log-view-type' for the value 'with-diff'. > > Generally, an explicit argument is better than an implicit one. > > So what's the idea here? Gracefully degrading to just showing a log entry > when the backend doesn't support the WITH-DIFF feature? Yes, if a backend doesn't support WITH-DIFF, then do nothing special. > (BTW, the print-revision approach seems better for graceful > degradation, but I'm tired of arguing for that). The print-log approach is not bad too: 'C-1 C-x v L' is mnemonic ("show me just 1 revision") and easy to type. > I think it would work, but for that all backends need support for > region-history-mode anyway. The caller function doesn't have a way to > check the lack of support. The new patch I sent now in another message checks if a backend supports region-history-mode. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 19:09:32 2019 Received: (at 38044) by debbugs.gnu.org; 27 Nov 2019 00:09:32 +0000 Received: from localhost ([127.0.0.1]:53213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZktf-00056B-FE for submit@debbugs.gnu.org; Tue, 26 Nov 2019 19:09:32 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:41406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZktd-00055y-OH for 38044@debbugs.gnu.org; Tue, 26 Nov 2019 19:09:30 -0500 Received: by mail-wr1-f44.google.com with SMTP id b18so24575212wrj.8 for <38044@debbugs.gnu.org>; Tue, 26 Nov 2019 16:09:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IudMM6IuU1XqWuYGtUgnfkkJtTV0yrX1469vb+Ewrcc=; b=UGohxJScGuSPtiHngnIMZeDEtfIK9l4TfZr4mDBp9gB8P3daDQq2siW1u9SdEo1ejb d5HicRpDcYNwQ8MpfF3gwRGgXJFWLUcFow8vJp49jwl8MJq+eGqntizQV1hObD08LY1g 17MQ5pIotF6gDb7L+187WpDeHAhTPDvrPYA3/k/1MTd5b8kZueOrzFg+JakYXUOPMcvW MX67gaF5j4pm/L47dagDdoqSuYUW86N7S0gXt0ekp6dTvx3AmGleemqxVNKj7GXiV8bd UK0tr9aUx5vtP3mBxdRDUT8uo3402QHM92IGVkCeF/YrwAkbaW99Lw20YVdAKIJnwA0s rmHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IudMM6IuU1XqWuYGtUgnfkkJtTV0yrX1469vb+Ewrcc=; b=a09T7OAUesbnDshxlnmP/wbJngNIVqHIICK7yBLm268AOzxL+iKeYERI744JDjqlzk ZvsULeBiKxs5S7RKwbW5+z1O7bu9HPx0uU/Bb4chkOgTs0q1YC5AGn4AFB2dmwWrR8fa bFcS7qFcEgF45JmYrjpw4BFKLFtioQHoO5w03shjfATSF/OuxU6NSqSrM0Ncm0EC5Bqu gTuzr3kVZ5p4W1Rc7UpM6sgeSmE1oJu6EpSKNyDDQBzEfIRQSNpC3udEa/zWHSGmPfGl BtBLN141nQtHUtQIZ00Rq0LZOvFNPr46Yn89q+DU4hMpJ6CjcmhyPn5pKJeBAflP4tie zjUA== X-Gm-Message-State: APjAAAWTRUq6pE51Jj7O8tg4fZn8dnM386RS2j3uvj0Ou4k/gyQzNPGR JY0I0ACjfZwX0jzIAFKTkG4= X-Google-Smtp-Source: APXvYqyA19XvekHqcWX4HjACz3sTYxS4QYu0FHd6aBDrpBa55aUWB7YpIQV8YrailVIzwFEQegwkUw== X-Received: by 2002:adf:da4d:: with SMTP id r13mr22161533wrl.307.1574813363829; Tue, 26 Nov 2019 16:09:23 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id m16sm4786623wml.47.2019.11.26.16.09.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Nov 2019 16:09:22 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Juri Linkov References: <87ftj5at1q.fsf@gnus.org> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> <6d316d96-0c2b-27e8-f538-a7909a127b7a@yandex.ru> <87ftia1bls.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <76ffede9-b194-27ba-9452-22f8eefeb614@yandex.ru> Date: Wed, 27 Nov 2019 02:09:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87ftia1bls.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 27.11.2019 1:06, Juri Linkov wrote: >> (BTW, the print-revision approach seems better for graceful >> degradation, but I'm tired of arguing for that). > > The print-log approach is not bad too: > 'C-1 C-x v L' is mnemonic ("show me just 1 revision") and easy to type. I mean the print-revision backend action (which can have a default impl). The user command could be separate, or it could be this one. Anyway... >> I think it would work, but for that all backends need support for >> region-history-mode anyway. The caller function doesn't have a way to >> check the lack of support. > > The new patch I sent now in another message > checks if a backend supports region-history-mode. Thanks, this looks better. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 00:39:10 2019 Received: (at 38044) by debbugs.gnu.org; 27 Nov 2019 05:39:10 +0000 Received: from localhost ([127.0.0.1]:53315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZq2f-00054U-1T for submit@debbugs.gnu.org; Wed, 27 Nov 2019 00:39:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZq2d-00054G-Fq for 38044@debbugs.gnu.org; Wed, 27 Nov 2019 00:39:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iZq2X-0003Rv-1d; Wed, 27 Nov 2019 00:39:01 -0500 Received: from [176.228.60.248] (port=4408 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iZq2W-0003qu-2C; Wed, 27 Nov 2019 00:39:00 -0500 Date: Wed, 27 Nov 2019 07:39:06 +0200 Message-Id: <83lfs1ri85.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87a78i2qf3.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 27 Nov 2019 01:01:20 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> <83zhgls1jd.fsf@gnu.org> <87a78i2qf3.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, larsi@gnus.org, stephen.berman@gmx.net, > 38044@debbugs.gnu.org > Date: Wed, 27 Nov 2019 01:01:20 +0200 > > A new patch avoids calling region-history-mode > if the backend doesn't implement it: Thanks. This seems to implement the command only for Git, though? Or am I missing something? Also, we need to document this. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 00:40:04 2019 Received: (at 38044) by debbugs.gnu.org; 27 Nov 2019 05:40:04 +0000 Received: from localhost ([127.0.0.1]:53319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZq3Y-00056G-7M for submit@debbugs.gnu.org; Wed, 27 Nov 2019 00:40:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZq3W-00055a-Vw for 38044@debbugs.gnu.org; Wed, 27 Nov 2019 00:40:03 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iZq3Q-0004Nm-74; Wed, 27 Nov 2019 00:39:57 -0500 Received: from [176.228.60.248] (port=4464 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iZq3M-0005rn-MU; Wed, 27 Nov 2019 00:39:54 -0500 Date: Wed, 27 Nov 2019 07:40:01 +0200 Message-Id: <83k17lri6m.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87ftia1bls.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 27 Nov 2019 01:06:39 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> <6d316d96-0c2b-27e8-f538-a7909a127b7a@yandex.ru> <87ftia1bls.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Eli Zaretskii , larsi@gnus.org, stephen.berman@gmx.net, > 38044@debbugs.gnu.org > Date: Wed, 27 Nov 2019 01:06:39 +0200 > > > So what's the idea here? Gracefully degrading to just showing a log entry > > when the backend doesn't support the WITH-DIFF feature? > > Yes, if a backend doesn't support WITH-DIFF, then do nothing special. Is there a command in the log buffer to show the diffs if the user wants that? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 16:56:20 2019 Received: (at 38044) by debbugs.gnu.org; 27 Nov 2019 21:56:21 +0000 Received: from localhost ([127.0.0.1]:56304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ia5IK-00088V-L3 for submit@debbugs.gnu.org; Wed, 27 Nov 2019 16:56:20 -0500 Received: from butterfly.birch.relay.mailchannels.net ([23.83.209.27]:59239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ia5II-00088N-HM for 38044@debbugs.gnu.org; Wed, 27 Nov 2019 16:56:19 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 715A25A0BE3; Wed, 27 Nov 2019 21:56:17 +0000 (UTC) Received: from pdx1-sub0-mail-a94.g.dreamhost.com (100-96-14-7.trex.outbound.svc.cluster.local [100.96.14.7]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id EDE425A09A8; Wed, 27 Nov 2019 21:56:16 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a94.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 27 Nov 2019 21:56:17 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Thoughtful-Little: 086808b170887daf_1574891777224_1752018311 X-MC-Loop-Signature: 1574891777224:3657574494 X-MC-Ingress-Time: 1574891777224 Received: from pdx1-sub0-mail-a94.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTP id 86B679C43F; Wed, 27 Nov 2019 13:56:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=VsV0Hlca1tFHy86ayD1G7Covl6M=; b= ELQrj+yJQz0Vd/6uYqEx8hr6lFbcpj4BA9PZL5qHZfujc1pmu9Jj3Gap1P5Tmi2D QvLXG+XQooPohIutC9nW2bE4gJoX0/aUPyFzzMJBlFqonRH1M8W+ZZfD/VniRoQc wbEfrPWX5YueXkayEfJTWnDEVdVXG5tCNRDdBdjouOY= Received: from mail.jurta.org (m91-129-96-42.cust.tele2.ee [91.129.96.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTPSA id 433EC9C458; Wed, 27 Nov 2019 13:56:07 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a94 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> <6d316d96-0c2b-27e8-f538-a7909a127b7a@yandex.ru> <87ftia1bls.fsf@mail.linkov.net> <83k17lri6m.fsf@gnu.org> Date: Wed, 27 Nov 2019 23:32:04 +0200 In-Reply-To: <83k17lri6m.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 27 Nov 2019 07:40:01 +0200") Message-ID: <87r21t6tkb.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> > So what's the idea here? Gracefully degrading to just showing a log entry >> > when the backend doesn't support the WITH-DIFF feature? >> >> Yes, if a backend doesn't support WITH-DIFF, then do nothing special. > > Is there a command in the log buffer to show the diffs if the user > wants that? Yes, the command is log-view-diff. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 17:16:28 2019 Received: (at 38044) by debbugs.gnu.org; 27 Nov 2019 22:16:28 +0000 Received: from localhost ([127.0.0.1]:56348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ia5bo-0002DX-FH for submit@debbugs.gnu.org; Wed, 27 Nov 2019 17:16:28 -0500 Received: from azure.elm.relay.mailchannels.net ([23.83.212.7]:51035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ia5bm-0002DP-Cx for 38044@debbugs.gnu.org; Wed, 27 Nov 2019 17:16:27 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 3E3421410F2; Wed, 27 Nov 2019 22:16:25 +0000 (UTC) Received: from pdx1-sub0-mail-a84.g.dreamhost.com (100-96-83-20.trex.outbound.svc.cluster.local [100.96.83.20]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B3A33140C4C; Wed, 27 Nov 2019 22:16:24 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a84.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 27 Nov 2019 22:16:25 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Trade-Trade: 1baf491d7eb5790f_1574892985011_1166295138 X-MC-Loop-Signature: 1574892985011:4022006428 X-MC-Ingress-Time: 1574892985011 Received: from pdx1-sub0-mail-a84.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a84.g.dreamhost.com (Postfix) with ESMTP id 2B890965E6; Wed, 27 Nov 2019 14:16:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=+naYana4ZMHXo5aFltpCshXfoSw=; b= IaPFn7Xio61OiXdWzrDLycPDLV+cXn5tE0tpt3V6YdM8L4WxetuXEEMVwl8ctRom dEcpHiw0OoHGueBDKCR3r8oqqsyz9aCoGglqW9qEPEDF09O89QQwt9aZN5ycllOz o+0hSPDvwBCah6m704SMDkGIr8fMiTXoeH0lJRAOJ5o= Received: from mail.jurta.org (m91-129-96-42.cust.tele2.ee [91.129.96.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a84.g.dreamhost.com (Postfix) with ESMTPSA id E035D9702D; Wed, 27 Nov 2019 14:16:15 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a84 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Organization: LINKOV.NET References: <87ftj5at1q.fsf@gnus.org> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> <83zhgls1jd.fsf@gnu.org> <87a78i2qf3.fsf@mail.linkov.net> <83lfs1ri85.fsf@gnu.org> Date: Thu, 28 Nov 2019 00:15:34 +0200 In-Reply-To: <83lfs1ri85.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 27 Nov 2019 07:39:06 +0200") Message-ID: <87blsx0xvd.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> A new patch avoids calling region-history-mode >> if the backend doesn't implement it: > > Thanks. > > This seems to implement the command only for Git, though? Or am I > missing something? Sorry, can't help with other backends. But it should be easy to do the same with other backends for anyone who uses them. > Also, we need to document this. Now installed with documentation. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 22:34:57 2019 Received: (at 38044) by debbugs.gnu.org; 28 Nov 2019 03:34:57 +0000 Received: from localhost ([127.0.0.1]:56481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaAa1-00025O-Ik for submit@debbugs.gnu.org; Wed, 27 Nov 2019 22:34:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaAZz-000259-Jm for 38044@debbugs.gnu.org; Wed, 27 Nov 2019 22:34:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iaAZr-0006wb-I2; Wed, 27 Nov 2019 22:34:47 -0500 Received: from [176.228.60.248] (port=4898 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iaAZq-0006eT-02; Wed, 27 Nov 2019 22:34:46 -0500 Date: Thu, 28 Nov 2019 05:34:55 +0200 Message-Id: <83v9r4ptb4.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87r21t6tkb.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 27 Nov 2019 23:32:04 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> <6d316d96-0c2b-27e8-f538-a7909a127b7a@yandex.ru> <87ftia1bls.fsf@mail.linkov.net> <83k17lri6m.fsf@gnu.org> <87r21t6tkb.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) > From: Juri Linkov > Cc: dgutov@yandex.ru, larsi@gnus.org, stephen.berman@gmx.net, > 38044@debbugs.gnu.org > Date: Wed, 27 Nov 2019 23:32:04 +0200 > > >> > So what's the idea here? Gracefully degrading to just showing a log entry > >> > when the backend doesn't support the WITH-DIFF feature? > >> > >> Yes, if a backend doesn't support WITH-DIFF, then do nothing special. > > > > Is there a command in the log buffer to show the diffs if the user > > wants that? > > Yes, the command is log-view-diff. Then I think we are okay here: if a backend doesn't support the likes of "log -p", and the user wants to see the diffs, they can invoke that command manually. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 08:13:21 2019 Received: (at 38044) by debbugs.gnu.org; 1 Dec 2019 13:13:21 +0000 Received: from localhost ([127.0.0.1]:35565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibP2O-0001V5-Vc for submit@debbugs.gnu.org; Sun, 01 Dec 2019 08:13:21 -0500 Received: from mout.gmx.net ([212.227.15.19]:35159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibP2M-0001Up-G1 for 38044@debbugs.gnu.org; Sun, 01 Dec 2019 08:13:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1575205988; bh=cBndZA7ETOUSgjSyOStubacLdXqDKu7TR5nrHb2iYd0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date; b=BrQmX7XALR3PPqszJywbNgvLW6AU3vrep5K4id0+fi7PyDThk9dq53+fpYBo3qMzO L0XGiaks7qAa0jdQ3wmqzOCFKEI30xlGWdbgc47lIPijGaNm4uOmftuTo53vzSkySV M7wjX5oWvfW+pF0kJ1jS0ETEzYE5vqVfUPQBZe0Y= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-lfs84 ([178.1.123.217]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MBDnI-1iVJ9e1chq-00Cl7r; Sun, 01 Dec 2019 14:13:08 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> Date: Sun, 01 Dec 2019 14:13:06 +0100 Message-ID: <8736e4b34t.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:BPqaRwhSJgp1GhYFbeH1mw6mP+fhUH4bHWSrOCWCQ3pwT2VfNhI mI3MUnAd0Zl9HPLFRBTjuiSfF8lSquMnm9SvYmiBzIbXe7tU0WjK60m7/g5hqHNewymeWmt huhM2mXe9I8gz3QRRyWfewqlsH+n6igCJVwQ2v8/ywQesEK1gdysi90OadaklOqU/fOe3XQ eOuFwJ4ru6OW1rzX5OorA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:cxslPeNnEs8=:JWrYLNZNsSEYACwrTQHsC8 QOc+RZAFOYSNxepZ8AYJz8u42lWvqPohxCBHvABg6MWCDEztFFQzc1BC8z52DmQEesBFlI/K7 DEs2oAEW4C8j3pOjcO0COHIdvb3O7/rsR5ttxvV09R9w3Y5JGAhX88m1qgzXMWpwXa7QZ5SUi F+HU7Rcax17nfBuLKPJuzTXeAWiqCeL2WeYM/ogF4QOR7GvExQ7D7ckaYbwpOlbYdIBWqRUkt amsbo94N2R2FaEjDl12KGiuFbNe1d+qEuEl4OkcCP5T5xZNfNl7Trs8s72TFiDIqDbrfUA+E7 ljJSGcERbqgjo4s1Rm5OyaO7/28jhdF+T7QSiF/cXtHz+VkCznTTnedoaeUgjvJlF/OhtFOq8 xSXFW+oHzO617S+Lrj9k6iXW2pdwsIYnqAjXHxlwHJngKd0AHdqH89LfBQH9HRVLMeMaLpyWg vsvEHhwKvxYJ6qo87S+xnMTw5Tpzl+JzopEU2yyizTUl9ZCfemJHXRqMqvNXlVswcqaqe9v9I HxiPogfWzRVvOAm7ytj5geVinkyXVXCISfspJVi1UAAn1E1jTokrcwBoUfDIrk/s7d4xFPxow PpUHTtnOhxcMYMd2UaWKt13NVkquvA+CJo4/xgz3tMRbk+roJfr1mLVkXqtECxeRtqJPU3Yvt 3HT6oa3YW9o24QhBonoaugKfEjyJ45xcwt7RFgy7uE5cRE5HoLrPK/QruQD9vvclBZbXjJBis BhRry7S6uo9J/DVH0EAGOO8n+QRD5vkHLstIeb6BgPHsN9hVpXg+2jtGX5DRh2aIVsDRnvDVv /yLdI6g4vU4JEeuo/gzmL1rUH5L8dqHBYSPrn2ob9OFW4G+nN4P5VrmtO8BXnMsdkEIvIDL// 5tCZSLnXBvHyPcfgOYHu0ULOkVMqiqEW//P1U7WIFOlIMtZ25lrKnTzaPKDud1ZaE0ZwIn4Vj tLDlTP5Ite/5suPkqVgs07usDawfk82Hod3WfHbAD4ohcftDx/A6N+reVJA9orey8ZVlgqTjr CdKm98LmR6K1t99YgbmCE+rHseyG2DbXt/s/JXAw90viIXSPO1akWjnbAsYVrEBlcq0K3Illj iZQXMUnPKMC+WGAgMiUWKsVvtfPJ9+WM8k+G7bWwCM07bQacMw1aAcZM0LJ/nAzBI/4fJhozk D4pDWCgeWTJKloW9cPgrjeaJ2pdta6UGv8kwj/Y1URbQc/X7PIwZL8Dhdg4UW1vpMf5uxfBTh BeZJgBNR0tXMfhJ0SYBjSMH9kdwSxpUBkTwGHe4kZVo1vwRQGpzX/PXHxIOg= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, dgutov@yandex.ru, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On Fri, 22 Nov 2019 09:24:41 +0200 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: Dmitry Gutov , juri@linkov.net, larsi@gnus.org, >> 38044@debbugs.gnu.org >> Date: Thu, 21 Nov 2019 22:15:21 +0100 [...] >> Since one of the desiderata of this command, perhaps even the main >> one, is that it should act on the revision ID at point, how about >> making just `C-x v L' do that if it recognizes the word at point as >> a revision ID? > > We could do that, yes. I haven't found a useful way to do this. >> If this is deemed to unreliable, it could be conditioned by a user >> option, or perhaps (though more annoying) by asking for >> confirmation. > > Fine with me, assuming the rest of the proposal is accepted. On reflection, both of these alternatives don't seem convenient enough to justify them. There is, however, another option that is convenient (at least to me) and easy to implement. Most of the time of I want to look up the log entry and/or diff of the revision ID at point the current buffer is not a version-controlled buffer (typically it's a Gnus buffer), so the default directory is wrong and I have to manually change to the version-controlled root directory. For me this is almost always the Emacs master branch, so it would be convenient if typing `C-1 C-x v L' offered this directory as a default, as a user option. The patch below does this. The way vc-print-root-log sets the root directory is also done exactly the same by vc-root-version-diff, vc-diff-mergebase, vc-root-diff and vc-log-mergebase, so perhaps these commands should also be changed to offer a user-specified default. I haven't used any of these yet, so I don't know if this is as convenient for them as it is for vc-print-root-log. Steve Berman --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: VC patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index d0d2c39ac3..06a3e90837 100644 =2D-- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -848,6 +848,14 @@ vc-revert-show-diff :type 'boolean :version "24.1") +(defcustom vc-default-root-dir nil + "User-specified root directory for VC operations. +Offered as default when the VC backend fails to identify a root +directory." + :type '(choice (const :tag "None" nil) + (file :must-match t :tag "File")) + :version "27.1") + ;; Header-insertion hair (defcustom vc-static-header-alist @@ -2517,7 +2525,8 @@ vc-print-root-log rootdir) (if backend (setq rootdir (vc-call-backend backend 'root default-directory)) - (setq rootdir (read-directory-name "Directory for VC root-log: ")) + (setq rootdir (read-directory-name "Directory for VC root-log: " + vc-default-root-dir)) (setq backend (vc-responsible-backend rootdir)) (unless backend (error "Directory is not version controlled"))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 12:54:15 2019 Received: (at 38044) by debbugs.gnu.org; 1 Dec 2019 17:54:15 +0000 Received: from localhost ([127.0.0.1]:36665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibTQF-0000jG-DA for submit@debbugs.gnu.org; Sun, 01 Dec 2019 12:54:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibTQD-0000j3-MU for 38044@debbugs.gnu.org; Sun, 01 Dec 2019 12:54:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ibTQ7-0000fO-Bt; Sun, 01 Dec 2019 12:54:07 -0500 Received: from [176.228.60.248] (port=1818 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ibTQ6-0002Hu-QW; Sun, 01 Dec 2019 12:54:07 -0500 Date: Sun, 01 Dec 2019 19:53:51 +0200 Message-Id: <83k17glyog.fsf@gnu.org> From: Eli Zaretskii To: Stephen Berman In-reply-to: <8736e4b34t.fsf@gmx.net> (message from Stephen Berman on Sun, 01 Dec 2019 14:13:06 +0100) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <8736e4b34t.fsf@gmx.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, dgutov@yandex.ru, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stephen Berman > Cc: larsi@gnus.org, juri@linkov.net, 38044@debbugs.gnu.org, dgutov@yandex.ru > Date: Sun, 01 Dec 2019 14:13:06 +0100 > > >> Since one of the desiderata of this command, perhaps even the main > >> one, is that it should act on the revision ID at point, how about > >> making just `C-x v L' do that if it recognizes the word at point as > >> a revision ID? > > > > We could do that, yes. > > I haven't found a useful way to do this. ??? The current master AFAICS already does, but only if you invoke "C-x v L" with an argument of 1. Or am I missing something? (It does so quite naively, though: it just picks up the word at point, so I've seen it prompting with default being something like "Copyright". Perhaps we should use number-at-point instead?) > There is, however, another option that is convenient (at least to me) > and easy to implement. Most of the time of I want to look up the log > entry and/or diff of the revision ID at point the current buffer is not > a version-controlled buffer (typically it's a Gnus buffer), so the > default directory is wrong and I have to manually change to the > version-controlled root directory. For me this is almost always the > Emacs master branch, so it would be convenient if typing `C-1 C-x v L' > offered this directory as a default, as a user option. The patch below > does this. The command prompts for a directory, so you can type whatever you want. Having a fixed default doesn't sound very wise to me (do you never have to work with several repositories at the same time?), but I'll defer to Dmitry's opinion here. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 15:43:18 2019 Received: (at 38044) by debbugs.gnu.org; 1 Dec 2019 20:43:18 +0000 Received: from localhost ([127.0.0.1]:36765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibW3q-000792-01 for submit@debbugs.gnu.org; Sun, 01 Dec 2019 15:43:18 -0500 Received: from mout.gmx.net ([212.227.17.20]:54589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibW3o-00078o-9y for 38044@debbugs.gnu.org; Sun, 01 Dec 2019 15:43:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1575232986; bh=WAnL4zEgmMH/3rnvr2icvVcpatNEct+dORE2xASjdJM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=OAnOt/tp21x5Ga3zeoppLN4vbuWzUxpU04Qoe83ITMsi6+MxHRbEQB70tVCAXLVMu LVKA5LxF+UJpBs50ZjDNDI1VLfE5ZgulQiuqm6AeRaiMl9XWo5Oyf3sflaBDyZAXYY VESPpWsRuThnigx8CN4ziOn0J06yqoX7m5sXvZ5M= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-lfs84 ([178.1.123.217]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mj8qj-1i62ed2ULN-00fAbT; Sun, 01 Dec 2019 21:43:06 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <8736e4b34t.fsf@gmx.net> <83k17glyog.fsf@gnu.org> Date: Sun, 01 Dec 2019 21:43:05 +0100 In-Reply-To: <83k17glyog.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 01 Dec 2019 19:53:51 +0200") Message-ID: <87a78baiau.fsf@rub.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:IbAsJdVl6YRYFhtEINbLhKKhxfJk3L28iJ4+yP4vwEyX+GMybXe okA41Wi6Phdps5ClqgAvnRYHNGl7KrpmkaKJOW67fdvtHLFhwsnVd+SwkDb65KdLIvfbaZy fqgSv0mAzaWbM8xka548KyhQpS4Zmii15esBLxh5g0JDeA9DSQaN6AS5bF4YjZayaorhT5k lmGhMJ+r4KJkwHlQbbRuA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ta8HZkV2MGc=:Q4Ak2Dq2IyMMYRYtdenOXT ZcRCUBCI7zzPIV/btOxHVsey9uC8Aw3CSgFgMxK3CzPpKGRDCmE+eEvaRIhoHXyn/FxjGpgud Ey3FWLxLayidHiFoH5+PWEPNXDKbJUyNv5DWmjrzGeyeDsNZaZBE3iEvmjEz39F5dgI/KPOzq UDkthCQz8OqKVW14D8x3K1HH56c/hQCcEhqv5ZZuuH6N9UPBeU6TBL4Y4eoA/Ema85mTTTpqv zurS+oQp5r3ABjgPiDC1oXL6gEpD0l3qX77SbKd7PlgiyyXDv+f8xL1ndQUFf9SAfJjBRtmSf rxYyJdQxgHIjcwip2kophIQno3oOlRYx8mzoytiKADyf55wHBCmlhtgD33lXPCZU8ksTLbj/P Icjxp5bchJp/nxCYPGzTO11LPqJ82VaHR4UZRN/+vTIzSl3QHvXtJYQbuSFkaNxu9cGLWO5hQ Ed0HP9p0D6NfvBcW0dD7v4puB4eaLBpAtQF/hSBifaId5zrVvSytm7dvkOLxDXzG/hKPUGEdk VTHCXghJZJqMetjJn0PeKoH4cEEUO3WEvRzTHLWDoBid/zWugj6BWBiF+m+say2u2aEagPG1a LecBmRT562WYKZBs4IEImVtHUMUTAgtBkROxqt5Ppl311I5tFmSn2aX6SdKk+dsPOm4WPRu5s BBO0Y07ONaqKNTBm9PFp/aNJM79dMHqS+7tm77s9MszbKbKIxE98LtpyxMVzadcz7zrToRiw0 3lN6V0pnkI1YMAgt/QsZaM3HdLt5GyMbactHCngGIp3KPZyLcfkKkL1noi+bFCJNzouUbMESW QE9WTZUjsipLH8XFPh/4UsC+dKelsGHf/l67UtMGbbzGktEsoRpjJe6tDrSW7T4IkCeIvJLr0 oNVEexM2JBjBRPqNSd2uFU47PyRUS3wT+/7hgHY6pRGx/0+LNBNUSTZf6Mzke7Ixz32vyoRFc +eZPOTOOgRDqNSq0aq8KOdbH+y2uG1/GZqAROnCZ3uBdrXC0kq42ZSqm79PE7Dkhz6UpL4dg+ r5I4y9kt7Cq0ddgM2qxt9K1dwRlWxUqZHb50pifLjsVOjpFxVMx7QYp37Z4U4PGu/yvnbzdXE r7MIOwGRqT+AHERPFWkgS0U+aLtR+pffjpLhpxMIXEhDU56KRIqbYSvjkquSexK5GAgo5HcpD J3ejdZUfrB98NGyT8SCoFcnBDi6H0pGnwWG9h50rde8bAWX4L8x0I+/QpY0LUFOrvf7+CIu2d mp8eo4zAX/9ydYqItVXfi7tt499erSju0DlcTxPXufbEjlDQyscd0yjF9r2c= Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, Stephen Berman , 38044@debbugs.gnu.org, dgutov@yandex.ru, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, 01 Dec 2019 19:53:51 +0200 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: larsi@gnus.org, juri@linkov.net, 38044@debbugs.gnu.org, dgutov@y= andex.ru >> Date: Sun, 01 Dec 2019 14:13:06 +0100 >> >> >> Since one of the desiderata of this command, perhaps even the main >> >> one, is that it should act on the revision ID at point, how about >> >> making just `C-x v L' do that if it recognizes the word at point as >> >> a revision ID? >> > >> > We could do that, yes. >> >> I haven't found a useful way to do this. > > ??? The current master AFAICS already does, but only if you invoke > "C-x v L" with an argument of 1. Or am I missing something? My proposal was for `C-x v L' to do double duty, i.e., that if point is on a revision ID, just typing `C-x v L' should show the corresponding commit data and diff, so this would save having to type `C-u 1' or `C-1' first, but ... > (It does so quite naively, though: it just picks up the word at point, > so I've seen it prompting with default being something like > "Copyright". ... this is exactly the problem: if whatever is at point is taken to be a revision ID, then there's no way for `C-x v L' to know when it should (try to) show the commit data and diff as opposed to showing the commit log. > Perhaps we should use number-at-point instead?) I think number-at-point would also get too many false positives to make it really useful. >> There is, however, another option that is convenient (at least to me) >> and easy to implement. Most of the time of I want to look up the log >> entry and/or diff of the revision ID at point the current buffer is not >> a version-controlled buffer (typically it's a Gnus buffer), so the >> default directory is wrong and I have to manually change to the >> version-controlled root directory. For me this is almost always the >> Emacs master branch, so it would be convenient if typing `C-1 C-x v L' >> offered this directory as a default, as a user option. The patch below >> does this. > > The command prompts for a directory, so you can type whatever you > want. This is precisely the extra effort I want to avoid. > Having a fixed default doesn't sound very wise to me (do you > never have to work with several repositories at the same time?), but > I'll defer to Dmitry's opinion here. Since the default value of the proposed user option is nil, those who don't set it will just get the current behavior, and even those who do set it will still get the prompt, but only have to type RET instead of directory name; and of course, if they don't want to use that default, they can type in the directory name they want, just as now. (At first I made the default be immediately used without prompting; this is the most convenient UI if you never use any other repository, but it's obviously too restrictive.) I did consider another idea: instead of having one default root directory, have a list, so users could have all (or the most common) root directories they need, and the one to use would be chosen by read-multiple-choice. But I thought this was probably too complicated a UI to be really convenient for this command. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 16:29:50 2019 Received: (at 38044) by debbugs.gnu.org; 1 Dec 2019 21:29:50 +0000 Received: from localhost ([127.0.0.1]:36810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibWms-0008Mc-EQ for submit@debbugs.gnu.org; Sun, 01 Dec 2019 16:29:50 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:37625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibWmo-0008MO-TS for 38044@debbugs.gnu.org; Sun, 01 Dec 2019 16:29:48 -0500 Received: by mail-wr1-f47.google.com with SMTP id w15so10799882wru.4 for <38044@debbugs.gnu.org>; Sun, 01 Dec 2019 13:29:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CZg1QFQz3gT3jDAKm7P+TGU0TT+bOLdbqC61FHb5Nhg=; b=pMJtl5HH71uh/GoRefLqyQPs+veN67SjepoVnoa84s/wijFyaXR4ScXHi+1ZkelZcX V4C0cOXTdJsux+0SWolBzXWB9ejy036mFT2/YgOuCKHeSswn+MecTQH3IYL+SGkC/AGw kHh2F9L67mRGSBBz6eb4MZCZddH4ny+8Uk5KmNvlRAym8GgKMj4xpLGmWSO5pkJis0+c ABCa9kkXjbGpYf78AGYEmDbxqfycPHl2l/v69XnTnVoev35oISJ88iIbyXTQEYIrQb3b +xHGcG+czfF8KlP6yd2682lXc/PS7KxGQAUjVqY3vL6zQyYnDdlXrqLk7keCFYvZu4ZE pXJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CZg1QFQz3gT3jDAKm7P+TGU0TT+bOLdbqC61FHb5Nhg=; b=LVB+X1VGZL3Qi0KowfOc2hvaD5xMoVi+yRT+1c0Wnp2pXHiMvwmPP0IaR+Kd0k9OwD gsw3vCrUtRnWmbNxyzv0fLgqkY+NS6nJAhjvTE1E9GUXEsV6fzDvsyAPozKnFjJHoG3Q Jvo6ZCg+4+HG47jfsfqt/fxVCsAP5ZvfmATNnQ3rvUQmfsM9IKM+7NmpSlVGDR3Lo24z 8t2b1GthImeU8+rsjP3jePR3UITXBPEIa6PZxyKhE8so5IxfrOlYKbaBhYP/rUTSaYNI gUMIJ4Z3MQR3hiYtu++JtGG05cBimfbCj41zDWToAL7BLKL4GWwvBtlawydt2YFfF7Ae CmQA== X-Gm-Message-State: APjAAAUN7NmoS0ACDTcl5Yq5esFHyFND1KQumdAoy7Xwy9FshAyExIpv 2futYct+OPvYXRFUfWE+89Ukejhr X-Google-Smtp-Source: APXvYqwJIrReU2etS0q6D1d5iXkH4DpO30FseZ/2cPsidGp4Z/mj6X3wYcWQdIXRbDK7HrKjbc7NGA== X-Received: by 2002:adf:e301:: with SMTP id b1mr64831605wrj.280.1575235780554; Sun, 01 Dec 2019 13:29:40 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id f12sm21549128wmf.28.2019.12.01.13.29.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Dec 2019 13:29:39 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii , Stephen Berman References: <87ftj5at1q.fsf@gnus.org> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <8736e4b34t.fsf@gmx.net> <83k17glyog.fsf@gnu.org> From: Dmitry Gutov Message-ID: <02a9ce39-b741-e024-3af6-74ad0b841bc4@yandex.ru> Date: Sun, 1 Dec 2019 23:29:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83k17glyog.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 01.12.2019 19:53, Eli Zaretskii wrote: > The command prompts for a directory, so you can type whatever you > want. Having a fixed default doesn't sound very wise to me (do you > never have to work with several repositories at the same time?), but > I'll defer to Dmitry's opinion here. I don't like to add new user options without seeing concrete demand. For now, only one user wants it and I don't see myself using it, thus far. In cases like this, I usually ask the requester (Stephen!) to write their own custom command and bind to a key combination of their liking (rebind C-x v L, in this particular case). If this turns out to be less than trivial, then we look into changing something. It should be simple in this case, I think. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 16:40:13 2019 Received: (at 38044) by debbugs.gnu.org; 1 Dec 2019 21:40:13 +0000 Received: from localhost ([127.0.0.1]:36821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibWwv-0000DP-76 for submit@debbugs.gnu.org; Sun, 01 Dec 2019 16:40:13 -0500 Received: from mout.gmx.net ([212.227.15.15]:35815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibWwt-0000D7-1m for 38044@debbugs.gnu.org; Sun, 01 Dec 2019 16:40:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1575236400; bh=2EZkx/bEZH3D3sfAz3PKPtMEFkezWi4usl/dKGKx514=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=IqnkLISZ9hUWYROeOFs2JvWvwfXf0sbffKlLEcCtkqPVBsk9KgX4IwXUh91F1ijeQ AObcUNOBIZ7rUKLUjQxJ0mLZib0PfGgclqhwUw+JenJGTd1OTxSwAVKXdX4NTkOmfM IqtQGE5KimmXNA86yvRti7OVNpjfRrqMuuiBnt2s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-lfs84 ([178.1.123.217]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MgNcz-1i8mtz0zqJ-00hwzE; Sun, 01 Dec 2019 22:40:00 +0100 From: Stephen Berman To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <8736e4b34t.fsf@gmx.net> <83k17glyog.fsf@gnu.org> <02a9ce39-b741-e024-3af6-74ad0b841bc4@yandex.ru> Date: Sun, 01 Dec 2019 22:39:58 +0100 In-Reply-To: <02a9ce39-b741-e024-3af6-74ad0b841bc4@yandex.ru> (Dmitry Gutov's message of "Sun, 1 Dec 2019 23:29:37 +0200") Message-ID: <875zizafo1.fsf@rub.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:oybve6PXI1A/VGE5XYhlmf3Jj+hdEgzImcA9HLLpLy4NkxNLh6v RKk1TxfDgcltB4I3kKtgJcHg6R5sGTAnNrE1vWbZAN9puN0m8aUnlLg1z1jt9lOe7urzOX8 dc8lgOyufHlSuW3lxm2gUNNt8cCR1RRkGiR16Poidxsw2BOq62ElqHb9iXxRudLDeHl6hpt 4IHkzOWNpOnrECi6qw9Eg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:nDLfmy1eZ7Q=:G2qvMxKvj4NCmhjrkHHNN3 xo+hxIqRtnNsJkB2SLZnrmHxZzNGlkCcEN3E43iPFBf837aOpaBrPBWH97y/poK+OxrhAfG2X LcaegJfLTQO8JuYhDs5b2Y+mJXSd9D3JKRrzite5f2MxIM/yOKXrcBweCuG7nIqW66mH0cMUm kIV9GznEX9oxfCUh68agD6xmixKf0uvtwjzjyRSbshAptueIvd7jVKoUhDJKg+1o89GBkO1NJ CVRSm2rMDc05Wr+yRTizWhbNUNzmYjyqaioIbK1Mx/bTlJL0gfGcMe20Czd8mqyAurFLiHhzj NI0r0NFZ7hS4CW/j4gm2Mg+msCL3CvbNtbfZVxTByZvGNb3FrPCO9Sv/ARXBiKhpfIM03KNng zSv8owWqsVv7odY2SAKaQRjtsvWs2aM2fCg6N77MF+z4clE1VFaGQBTiOFLLoPf3lgTsjsBDr LzUo0E00rkWfpyxejGBM9N1d/H05fwLZP3W6WfVaHfcg1VuApnJjtV8s63l7lDBvyeMNuy3KE yA/Hj6RyV3/3ahALNBa8gIymA3PJtHipcKGkILNCidkzX/eF3EKabeQQsEq3oeXtj0v7EI5OS tBGC/ovPOq0kt99alMWPb8wFCHP2xwVsO6BLt7SwVIj6QtKJdBnlZpiF72zXKcFzTIjS/qXDN d9Zf9LUWaIw+RiWmcwPKtnT8qdhZd5aT6IMNIDufKW6c6gFSoyqLiFLAvYVqoixCW5gKVLp/h SzvdU49sN1gpKNon7AoocCGDovShbrgrSa7pJRd/D9WZR0eSXLMAxl+J2D0D3vptQWfley6zo CIwvLh7fybYVSRe/sjsRLGCx8Ks4YnwJWfGgPTr7BW5RjRApoIEXzivIzP+g9gmYJRA8YLpMg qvuwfSQYBCNtn/3pFgNtcsKHVuP7On62YYCWplX4SJtyDA5SbLvfKEU0v3QO/JoJriBTf1P4J cILeUg5NR6qne+h/1NeGJt0bFtT8FVN+P0aXkuOCiv8/ov6m1DDHeTzMKZWI8pMH9zf0/20Iz 3YbWOZHV/5Yqe73AUnbA8HCf1KSPYf+iMd35nxnvlLtQXWOWEFPtWBET5IIvVybhvR2pL2IUI paAM5t3C4CJmHELYIZESfWcD0CM4RA6ciqPmfxch9jXHBKvQjqQ1yUFuGfjZq8Pz2S21Wp5XL /wxMs9zRRma7ns581nUn6g1Gb8G5eaKQ8/Joi6Fz+U2DlDaPv6nVLjNnfUWoCSiumvewNULjp +9JE6IFtl0sp79fjnrMRG0LrBmhRDEHuJU1HvqQj5RNKTGxjM1pd+b9d59q8= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: Eli Zaretskii , 38044@debbugs.gnu.org, larsi@gnus.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, 1 Dec 2019 23:29:37 +0200 Dmitry Gutov wrote: > On 01.12.2019 19:53, Eli Zaretskii wrote: >> The command prompts for a directory, so you can type whatever you >> want. Having a fixed default doesn't sound very wise to me (do you >> never have to work with several repositories at the same time?), but >> I'll defer to Dmitry's opinion here. > > I don't like to add new user options without seeing concrete demand. For now, > only one user wants it and I don't see myself using it, thus far. > > In cases like this, I usually ask the requester (Stephen!) to write their own > custom command and bind to a key combination of their liking (rebind C-x v L, > in this particular case). If this turns out to be less than trivial, then we > look into changing something. It should be simple in this case, I think. As mentioned near the start of this bug, I had already written my own command to do essentially what `C-1 C-x v L' now does, but also including the option I proposed. So I'll just keep using that command. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 17:30:30 2019 Received: (at 38044) by debbugs.gnu.org; 1 Dec 2019 22:30:30 +0000 Received: from localhost ([127.0.0.1]:36839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibXja-0001aT-F4 for submit@debbugs.gnu.org; Sun, 01 Dec 2019 17:30:30 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:39416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibXjZ-0001aA-05 for 38044@debbugs.gnu.org; Sun, 01 Dec 2019 17:30:29 -0500 Received: by mail-wr1-f47.google.com with SMTP id y11so38723985wrt.6 for <38044@debbugs.gnu.org>; Sun, 01 Dec 2019 14:30:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/IO5pD5vOmaAMOiC5VGXFqzBCAwTJq9xBmV6bKKh2Po=; b=bu0qyWA59/klQ9zTbwa6zNgZF+tECO8TF0rOZW/Qm0BnUoPZDuJ5lZlsUkM3U6c0RV BvWBIRUOaUzemVPUxWnz6O7Nq5e4m/LaJDSMqur+wm8XFE2JNsFK7+V8dzgQaILvDr8B uJQWcpBgjNrXV8hx9tdWERYdfdO/atx64FuPknbWXz4KL/J0nCzEvUdnRmvFehjbJFVu IERfsS6/OL2/WmtJQ7V6GkcQV4nF67bH79KjTfDz/apvRP45NSb5ORgmbeX2ppUnhUPw 0fxh1a+0fK1h69AMgrlvQuCzQ6DQoqmPE1rAyh0vlWzGHQrUkFhulZHeWz5TQIoHDLhP uGWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/IO5pD5vOmaAMOiC5VGXFqzBCAwTJq9xBmV6bKKh2Po=; b=YbqRogDOQjRFC0SgN94FMsEkzcAyCX3rswmRpJh26v2sExDBP0vxvGcazUSffTzfPw GxPiYsnBVtL5UeKWFXXh887HOMaJ/kj/MKnQdTwUr4ayMn6HeHNQd23qmuUOJhOAHtSk QhbSF2fdHQCL5C8uxoQ+je1iX8mm5TSUfC9Nln1wyKJEwCVCBr+GIZHXH0wZrUDF3iAe 5YZ3C4dAvW1ksK9TEvoATHuQdQj+a9ZejBako5E6S5aGV3Tzx4VLthuDtqIhBK3OCt8U G50syvZbf4xRrgiM4yagkzeuXoxARrf4zDtOJC4b3GK8a57iuETR0FvIq0BRTnx2QIGR EAnA== X-Gm-Message-State: APjAAAXKz6ni55LcV0sE30Wq16CPR08TAindWpdYgYej6w9PtI2bhRVn 1JidezwgCeezsdsqs0XtuZE= X-Google-Smtp-Source: APXvYqw2fswSNGG2LVNYKcoWkwiNe1CT/rljpnlVT23wOogOE4m/075rfSYDa0+rFUibeqxG7kDD5w== X-Received: by 2002:a5d:5381:: with SMTP id d1mr41011473wrv.259.1575239423191; Sun, 01 Dec 2019 14:30:23 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id e18sm15044211wrr.95.2019.12.01.14.30.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Dec 2019 14:30:21 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Stephen Berman References: <87ftj5at1q.fsf@gnus.org> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <8736e4b34t.fsf@gmx.net> <83k17glyog.fsf@gnu.org> <02a9ce39-b741-e024-3af6-74ad0b841bc4@yandex.ru> <875zizafo1.fsf@rub.de> From: Dmitry Gutov Message-ID: Date: Mon, 2 Dec 2019 00:30:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <875zizafo1.fsf@rub.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 01.12.2019 23:39, Stephen Berman wrote: > As mentioned near the start of this bug, I had already written my own > command to do essentially what `C-1 C-x v L' now does, but also > including the option I proposed. So I'll just keep using that command. Then we should keep this as is, for now. But thank you for the request, and others who need this as well should feel free to speak up. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 22:34:30 2019 Received: (at 38044) by debbugs.gnu.org; 2 Dec 2019 03:34:30 +0000 Received: from localhost ([127.0.0.1]:36942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibcTl-0001Ti-Ok for submit@debbugs.gnu.org; Sun, 01 Dec 2019 22:34:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibcTk-0001TW-IN for 38044@debbugs.gnu.org; Sun, 01 Dec 2019 22:34:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ibcTe-00083t-KG; Sun, 01 Dec 2019 22:34:22 -0500 Received: from [176.228.60.248] (port=1684 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ibcTd-0006Ey-W7; Sun, 01 Dec 2019 22:34:22 -0500 Date: Mon, 02 Dec 2019 05:34:09 +0200 Message-Id: <835zizmmdq.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Mon, 2 Dec 2019 00:30:09 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <8736e4b34t.fsf@gmx.net> <83k17glyog.fsf@gnu.org> <02a9ce39-b741-e024-3af6-74ad0b841bc4@yandex.ru> <875zizafo1.fsf@rub.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Dmitry Gutov > Date: Mon, 2 Dec 2019 00:30:09 +0200 > Cc: larsi@gnus.org, 38044@debbugs.gnu.org, juri@linkov.net > > On 01.12.2019 23:39, Stephen Berman wrote: > > As mentioned near the start of this bug, I had already written my own > > command to do essentially what `C-1 C-x v L' now does, but also > > including the option I proposed. So I'll just keep using that command. > > Then we should keep this as is, for now. But thank you for the request, > and others who need this as well should feel free to speak up. What do you think about replacing the call to thing-at-point with number-at-point, where we look at the revision ID? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 05:39:57 2019 Received: (at 38044) by debbugs.gnu.org; 2 Dec 2019 10:39:57 +0000 Received: from localhost ([127.0.0.1]:37144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibj7V-0004NK-Cw for submit@debbugs.gnu.org; Mon, 02 Dec 2019 05:39:57 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:35038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibj7T-0004N7-JG for 38044@debbugs.gnu.org; Mon, 02 Dec 2019 05:39:56 -0500 Received: by mail-wr1-f52.google.com with SMTP id g17so11513158wro.2 for <38044@debbugs.gnu.org>; Mon, 02 Dec 2019 02:39:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yNGtQu6Vc1iwg1C9n27Hr8CR5wdys/i+HxgJh+iRmKQ=; b=eOVHXCFpVhcTvUNtoksNEaDpMfaOZazZSnqQ1hFRiHPItvBhfE3RiyMb0Xq7O2retr wHVDoMQYdW+/SUt4JdKSuKWSVWGtoD5aB3ORRqsR9BAIiTJQygNX4V3AFmhE0wo6y909 saUbTbsw7um/AUqKl67UY0oOvS++HRYyHnZC6XYGqA/HtiGGdaaOyRlku1akgrw7A7cD Zi2A9uXbl9YDRMtmYLs1w0Y6DXd6m/ks7nKxvm5fYaWt9qLdjD9hiKIi+w0ujcJON7lu cRVLQEnele9SL5ZaJJ4PH/v94CErkQeQAZHDbLlmLdtkuFELZxB0JGfz8IiG4nj7YFrp 9WWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yNGtQu6Vc1iwg1C9n27Hr8CR5wdys/i+HxgJh+iRmKQ=; b=qvCYFsAP5J68PJcioWOSJ7RDJEnhmQ2BlZCn+dfQGFhnd9CpH9avKLnv/PB+/jgcTn tVosy2LAy+jKeYaTxFMSjD7wRVoocVLiqUTrU8KUdVYIGBzN/lvih9qTeEbzHASe7UJY W/JilcOzSFYKukuocHD0cI2qV0gA0v4bgJp8288qEZL07LzN9oBS1l2ahQgVUPWLuBK6 S0F7ta0ZkQIthwKYpd/pDS5O5psDCbjySqWQeGSXwYWrXfO1joMblUbpRP9PR+xieg2o 5oh5Nrbgb8dYR/XIya4tqBb1hIKikFEknxiuggsgoBvJy7GgEWc9Fzg9Rds6xJ3HnTrf /4JQ== X-Gm-Message-State: APjAAAX6/s67/GJ+rCBMxJiU5mF2lQXlEvoZGWnNqdmOf4WpNHlftwBK EaTLsDfb3MTK7/ral7SBvb0= X-Google-Smtp-Source: APXvYqx+3uJPw66a3UiGdlKWMpwGycEGKl9Cupo10H9tk0C2BGsl5s3WO9uJxEIU5NVjVZOS3iC3Nw== X-Received: by 2002:a5d:5592:: with SMTP id i18mr717088wrv.55.1575283189737; Mon, 02 Dec 2019 02:39:49 -0800 (PST) Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id o1sm24459181wrn.84.2019.12.02.02.39.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Dec 2019 02:39:48 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <8736e4b34t.fsf@gmx.net> <83k17glyog.fsf@gnu.org> <02a9ce39-b741-e024-3af6-74ad0b841bc4@yandex.ru> <875zizafo1.fsf@rub.de> <835zizmmdq.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Mon, 2 Dec 2019 12:39:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <835zizmmdq.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 02.12.2019 5:34, Eli Zaretskii wrote: >> From: Dmitry Gutov >> Date: Mon, 2 Dec 2019 00:30:09 +0200 >> Cc: larsi@gnus.org, 38044@debbugs.gnu.org, juri@linkov.net >> >> On 01.12.2019 23:39, Stephen Berman wrote: >>> As mentioned near the start of this bug, I had already written my own >>> command to do essentially what `C-1 C-x v L' now does, but also >>> including the option I proposed. So I'll just keep using that command. >> >> Then we should keep this as is, for now. But thank you for the request, >> and others who need this as well should feel free to speak up. > > What do you think about replacing the call to thing-at-point with > number-at-point, where we look at the revision ID? Probably not: - Git revisions are SHA hashes, not numbers. Hg also has commit hashes, though they are less visible. - I'm pretty sure this command will be just as often used with symbolic refs such as branch names. So I'd rather use (thing-at-point 'symbol t) instead. Or a dedicated "thing" that does not depend on the buffer's syntax (and always includes slashes, hyphens and underscores in addition to alphanumerics). From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 06:07:17 2019 Received: (at 38044) by debbugs.gnu.org; 2 Dec 2019 11:07:17 +0000 Received: from localhost ([127.0.0.1]:37154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibjXx-00051R-0A for submit@debbugs.gnu.org; Mon, 02 Dec 2019 06:07:17 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:60906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibjXu-00051H-DW for 38044@debbugs.gnu.org; Mon, 02 Dec 2019 06:07:15 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 47RMl44qvhz1rTYZ; Mon, 2 Dec 2019 12:07:12 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 47RMl418B2z1qqkr; Mon, 2 Dec 2019 12:07:12 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Ddn480WQunHL; Mon, 2 Dec 2019 12:07:11 +0100 (CET) X-Auth-Info: S7t2dseD5dx+giYc5fke4XCr+Zx9YWTxVjUeJuJr8TLsBiSFAgSsY1cPuzWtBYxf Received: from igel.home (ppp-46-244-168-104.dynamic.mnet-online.de [46.244.168.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 2 Dec 2019 12:07:11 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 7E0322C017B; Mon, 2 Dec 2019 12:07:10 +0100 (CET) From: Andreas Schwab To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <8736e4b34t.fsf@gmx.net> <83k17glyog.fsf@gnu.org> <02a9ce39-b741-e024-3af6-74ad0b841bc4@yandex.ru> <875zizafo1.fsf@rub.de> <835zizmmdq.fsf@gnu.org> X-Yow: Do you have exactly what I want in a plaid poindexter bar bat?? Date: Mon, 02 Dec 2019 12:07:10 +0100 In-Reply-To: (Dmitry Gutov's message of "Mon, 2 Dec 2019 12:39:47 +0200") Message-ID: <87immzugtd.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 38044 Cc: Eli Zaretskii , stephen.berman@gmx.net, 38044@debbugs.gnu.org, larsi@gnus.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Dez 02 2019, Dmitry Gutov wrote: > - I'm pretty sure this command will be just as often used with symbolic > refs such as branch names. So I'd rather use (thing-at-point 'symbol t) > instead. Or a dedicated "thing" that does not depend on the buffer's > syntax (and always includes slashes, hyphens and underscores in addition > to alphanumerics). A ref in git basically has filename syntax. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 10:58:38 2019 Received: (at 38044) by debbugs.gnu.org; 2 Dec 2019 15:58:39 +0000 Received: from localhost ([127.0.0.1]:38805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibo5u-0008TF-KA for submit@debbugs.gnu.org; Mon, 02 Dec 2019 10:58:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibo5t-0008T2-0Y for 38044@debbugs.gnu.org; Mon, 02 Dec 2019 10:58:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ibo5n-000842-9h; Mon, 02 Dec 2019 10:58:31 -0500 Received: from [176.228.60.248] (port=2957 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ibo5l-0008K0-Jl; Mon, 02 Dec 2019 10:58:30 -0500 Date: Mon, 02 Dec 2019 17:58:16 +0200 Message-Id: <83tv6ilnxj.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Mon, 2 Dec 2019 12:39:47 +0200) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <8736e4b34t.fsf@gmx.net> <83k17glyog.fsf@gnu.org> <02a9ce39-b741-e024-3af6-74ad0b841bc4@yandex.ru> <875zizafo1.fsf@rub.de> <835zizmmdq.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: stephen.berman@gmx.net, larsi@gnus.org, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Mon, 2 Dec 2019 12:39:47 +0200 > > > What do you think about replacing the call to thing-at-point with > > number-at-point, where we look at the revision ID? > > Probably not: > > - Git revisions are SHA hashes, not numbers. Hg also has commit hashes, > though they are less visible. They are both hex numbers. But I failed to notice that number-at-point needs the 0x prefix to detect hex numbers, sorry. (We could have a new function that accepted hex numbers without 0x.) > - I'm pretty sure this command will be just as often used with symbolic > refs such as branch names. So I'd rather use (thing-at-point 'symbol t) > instead. Or a dedicated "thing" that does not depend on the buffer's > syntax (and always includes slashes, hyphens and underscores in addition > to alphanumerics). We are talking about heuristic guesswork to suggest a reasonable default, not about what forms are accepted. I thought that suggesting only numbers, either decimal or hex, as such a guess should be enough, as I almost never see any other revision IDs in practice. (I do use other types of refs with Git, like reflog and stash refs, but those are local and are extremely unlikely to appear in a discussion.) But if you don't feel that's a good idea, it's fine with me. It just strike me as a mild misfeature that we offer completely unrelated words as "revision IDs". From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 11:06:11 2019 Received: (at 38044) by debbugs.gnu.org; 2 Dec 2019 16:06:11 +0000 Received: from localhost ([127.0.0.1]:38813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iboD9-0000Hf-5C for submit@debbugs.gnu.org; Mon, 02 Dec 2019 11:06:11 -0500 Received: from mail-ed1-f41.google.com ([209.85.208.41]:44970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iboD3-0000Gz-Qd for 38044@debbugs.gnu.org; Mon, 02 Dec 2019 11:06:06 -0500 Received: by mail-ed1-f41.google.com with SMTP id cm12so1913725edb.11 for <38044@debbugs.gnu.org>; Mon, 02 Dec 2019 08:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mZT8ZB7SXRhYF41LJls+zFs1l707AR7xTsXHSqMiRkY=; b=Aa/PXRyEJW8UO/DZN7+/i5TxxGaOo0MFFFz+LoAQXigdY2MGal18ELX6T8oZTAVNJG c7dckM7SAEdj/M4j95ver3ud6tUhpEwtRVSAjm4ha1MllQfxUkP40QurYzHScDEeDwEi rx4fwDjfXRS1PcF6lMpVxVT8n64Wo40wuaYaKwASRvFvqI1LvJky4/Gmh0aBuZG75im5 IIpjNQPi27zY4zkdQ5LSxjVPhVdV3WMjuwMTlJxVHr5VHrMyeBRp2gXwk/gbMvSlEghV bm5wt2nzkJOmYfcBQpv0TCm12QtOlHgTJ+jNfXpsAMrThC6zqp1NM2hC39SLg8Iz4qC0 dkJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mZT8ZB7SXRhYF41LJls+zFs1l707AR7xTsXHSqMiRkY=; b=eg7MHmvAFewHCNKx6KaRQXjyV+iE7YO/0MrcTup3vj+fTPxYT6sMWcXv9lVCRGXA+U 7vSYi5/obRf2yOCGz7ge/Jh+3CYtnPL1os5zwF+D9bX7IT1q3U9TZKPw9nf4X8F8GyXv HfzK0hZ+zyjTUv1Qp7DUfZ13MUlhGF7HfDrpz08HEDjcrWBJ2rA1ekEymZMraSQmi+iB 3j5EzDOlfVlv9BVPSlpdKXCkJEm1hwpHJgcU/iNUQofs4rv76gy0Kj1PPL5hOJg+NA8B bZUDFkptr9+2A8JxH1fsbWzlz05BM0b89oWByB5DGJc24g34iBmTRHaN+C5yX2Br6MEQ Rqgg== X-Gm-Message-State: APjAAAXtSOVvQtC+PZs7xOnpynPP+9bMR5Za19uF61kWbR7bAaGyqEaE NPcAhMwG8wdaWIdd+2/elsI= X-Google-Smtp-Source: APXvYqwJnOScHaH8+4e47+c179bJYakSwuYY8Xsye6XYcsNfFKJq6XgobcK3AIazumRsLfiupR6erQ== X-Received: by 2002:aa7:cf81:: with SMTP id z1mr31130507edx.157.1575302755908; Mon, 02 Dec 2019 08:05:55 -0800 (PST) Received: from [192.168.0.149] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id df3sm1399402edb.1.2019.12.02.08.05.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Dec 2019 08:05:54 -0800 (PST) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <8736e4b34t.fsf@gmx.net> <83k17glyog.fsf@gnu.org> <02a9ce39-b741-e024-3af6-74ad0b841bc4@yandex.ru> <875zizafo1.fsf@rub.de> <835zizmmdq.fsf@gnu.org> <83tv6ilnxj.fsf@gnu.org> From: Dmitry Gutov Message-ID: <77a3b62e-95c0-9f0f-23ec-c277ae8f06c5@yandex.ru> Date: Mon, 2 Dec 2019 18:05:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83tv6ilnxj.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 02.12.2019 17:58, Eli Zaretskii wrote: > (I do use > other types of refs with Git, like reflog and stash refs, but those > are local and are extremely unlikely to appear in a discussion.) We do see branch names often enough. The current code will frequently fail to pick them up, and I think that's unfortunate. > But if you don't feel that's a good idea, it's fine with me. It just > strike me as a mild misfeature that we offer completely unrelated > words as "revision IDs". It's fine if we offer something unrelated as the default because otherwise we'd simply offer nothing (nil). The user can type over it anyway. Not offering something useful when we could is more problematic, IMO. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 19 11:31:20 2020 Received: (at 38044) by debbugs.gnu.org; 19 Jul 2020 15:31:20 +0000 Received: from localhost ([127.0.0.1]:32785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxBHc-0002Nr-5d for submit@debbugs.gnu.org; Sun, 19 Jul 2020 11:31:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxBHZ-0002HS-QY for 38044@debbugs.gnu.org; Sun, 19 Jul 2020 11:31:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZjFmXEw+RI//CqlHRPfmNjgjoEWp9GjI2plZm4HgmfY=; b=svPoo17DO1CnCKVQ8f+f2RqT6F fN7e5PPZM437O28yVIefq7TzvpPr9iI6osjZ7ejG47jKM84de7/aOMPp/4ErN3nCvq9375gnvmZGP zTtD1J71idoG9kmZcP49oBR6P3QhgOYlILGTkYYp9jBKkNg17bsL9r0AgWU/G/Q8xpEE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxBHR-0007KT-1Q for 38044@debbugs.gnu.org; Sun, 19 Jul 2020 17:31:11 +0200 From: Lars Ingebrigtsen To: 38044@debbugs.gnu.org Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> Date: Sun, 19 Jul 2020 17:31:07 +0200 In-Reply-To: <87ftj5at1q.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 03 Nov 2019 16:17:05 +0100") Message-ID: <87365nplms.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > For that case, Emacs should have a command that prompts for an ID > (defaulting to the ID under point), and then (unless default-directory > is already in a vc-controlled directory), prompts for the [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > For that case, Emacs should have a command that prompts for an ID > (defaulting to the ID under point), and then (unless default-directory > is already in a vc-controlled directory), prompts for the directory to > look for that ID, and then display the commit. And this was, indeed, implemented (via `C-u 1 C-x v L' *phew*), so I'm now closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 19 11:31:31 2020 Received: (at control) by debbugs.gnu.org; 19 Jul 2020 15:31:31 +0000 Received: from localhost ([127.0.0.1]:32788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxBHn-0002Xk-Fb for submit@debbugs.gnu.org; Sun, 19 Jul 2020 11:31:31 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxBHl-0002Rj-T7 for control@debbugs.gnu.org; Sun, 19 Jul 2020 11:31:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=E8+H7nPlg+9BZKzvb8Jazb8wop49SNYFFXdGpRa6X4Y=; b=tKbiE2EBSY0v/uvAY/oCpJBLZK xjNA/f32F+UEHLjOJeQLOdW6rio+AtJcExXjutMKsf4NM/kr3CTOJk7W2o2hk9kV6juRJ9vCoydRi rYoHaW9ipMPpJDndoM+GAARN4acPGDJCgF3PKTlZ6NiXernP9EXHBMvTOZlG2uouOi9c=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxBHe-0007Ka-4q for control@debbugs.gnu.org; Sun, 19 Jul 2020 17:31:24 +0200 Date: Sun, 19 Jul 2020 17:31:20 +0200 Message-Id: <871rl7plmf.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #38044 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 38044 fixed close 38044 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 38044 fixed close 38044 27.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 19 13:14:51 2020 Received: (at 38044) by debbugs.gnu.org; 19 Jul 2020 17:14:51 +0000 Received: from localhost ([127.0.0.1]:32894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxCtn-0003w5-33 for submit@debbugs.gnu.org; Sun, 19 Jul 2020 13:14:51 -0400 Received: from mail-ej1-f44.google.com ([209.85.218.44]:42211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxCtj-0003vq-PI for 38044@debbugs.gnu.org; Sun, 19 Jul 2020 13:14:49 -0400 Received: by mail-ej1-f44.google.com with SMTP id f12so15742465eja.9 for <38044@debbugs.gnu.org>; Sun, 19 Jul 2020 10:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BA11T4YNOnTfO9qR/eoNbMnjptzXfDc/0raPYBecCIQ=; b=MMmnLLTt8FPUSaNBtRayECavw5qCQY0ZhWnd++JycADV0DgFlq6d6PFGVn0I7lOInb VUgLJyJpLJD1DEsrANtYg0PrO8KOt+J+mfUCdqu6N98tffLpt3JZ0E1/+ynfuD5mVio+ xTLiYQ30sgfkXGmln0A7mVb0Dg1r9Epd+sYw7OnPiF05IrVlc0l72MV55JvEXAOvlCv3 p5GCHPNEgvztSNkumFSRBacQvcMWm61B9WLwf+aU8+CdIz/my9z96nToz2GoRX1FWbsX aH/WiYg9BtdyJHeqiDvqm0kmK6W1viFkoqt+zWeLLL/X96demFt/PaLScnHV38z2haih 2B1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BA11T4YNOnTfO9qR/eoNbMnjptzXfDc/0raPYBecCIQ=; b=JH3KVII2ZH+G1XhZzpjfs9Lv1efA3Ih26eng0jNKawhMi69izZVI9qUlegzFRse+Yz aHagPz4E+onarJV8COZKYc6TNT7CEsx9YLFIiMuVgTNfL6qHasOWn4b2dn+iUZB9+CaV tYTOM6iiopui6O9RLH7X/eXUGWk7tiT5hEgrGaptTY2rKSe057bCQNyKG7LUHR6/PE6J FvVvVJ07fJaRWbubrEWjrBoa6XawtN0ePXe8sH2sN6GbaPHffO9GGyFr0ob8x6qluv8I CvUE1nhYoocSZzQB8qmtvJsVEykWssIz+lgifel/bqDLFNfJakIPrE6V01rcCDJRE0sw 31wg== X-Gm-Message-State: AOAM533DD+TMnua9vLnOmAFdRITz5u+SHd7ihQkVQ7z+NMhOnwaWteJj myn39oIRHLoxN4fHi4F2nHD3BDTw X-Google-Smtp-Source: ABdhPJw1Rr9xevawxYMQ8gPA+cUA6FI0Qy7Z9DrtYPkHqefRjhiaVP6r2Qc1wWv8Nn4IEQzsIlv96w== X-Received: by 2002:a17:906:76d7:: with SMTP id q23mr17889786ejn.95.1595178881587; Sun, 19 Jul 2020 10:14:41 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id c10sm13769122edt.22.2020.07.19.10.14.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jul 2020 10:14:40 -0700 (PDT) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Lars Ingebrigtsen , 38044@debbugs.gnu.org References: <87ftj5at1q.fsf@gnus.org> <87365nplms.fsf@gnus.org> From: Dmitry Gutov Message-ID: <8d689312-c025-405e-1054-56bc81a95867@yandex.ru> Date: Sun, 19 Jul 2020 20:14:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87365nplms.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 19.07.2020 18:31, Lars Ingebrigtsen wrote: > And this was, indeed, implemented (via `C-u 1 C-x v L'*phew*), so I'm > now closing this bug report. Are you happy with the result? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 19 13:17:10 2020 Received: (at 38044) by debbugs.gnu.org; 19 Jul 2020 17:17:10 +0000 Received: from localhost ([127.0.0.1]:32898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxCw2-00040M-G4 for submit@debbugs.gnu.org; Sun, 19 Jul 2020 13:17:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxCw1-000409-8F for 38044@debbugs.gnu.org; Sun, 19 Jul 2020 13:17:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wdPniOrLxmpIek80is0BUaahQgBupk5UtCJglMDsEDI=; b=qj/utFISK1tAkaM5SoKlrXaCMH ulyk0My4QOiRi8krvHZvKvVchco8YBy11aFzEouXLw+x4/o779o5p5Q0hGxXeKjIXYE/5yMQhMBfw ukNAftf2ZYLnjkdZi8pGgEPsa8PYun3AAepwPnZSXikgVVx3pfIyRjmpmRlmobbQoHy8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxCvr-0002pk-DV; Sun, 19 Jul 2020 19:17:02 +0200 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87365nplms.fsf@gnus.org> <8d689312-c025-405e-1054-56bc81a95867@yandex.ru> Date: Sun, 19 Jul 2020 19:16:58 +0200 In-Reply-To: <8d689312-c025-405e-1054-56bc81a95867@yandex.ru> (Dmitry Gutov's message of "Sun, 19 Jul 2020 20:14:39 +0300") Message-ID: <87k0yzmnlh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > On 19.07.2020 18:31, Lars Ingebrigtsen wrote: >> And this was, indeed, implemented (via `C-u 1 C-x v L'*phew*), so I'm >> now closing this bug report. > > Are you happy with the result? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 19.07.2020 18:31, Lars Ingebrigtsen wrote: >> And this was, indeed, implemented (via `C-u 1 C-x v L'*phew*), so I'm >> now closing this bug report. > > Are you happy with the result? Yes, looks perfect to me. But I wish it'd have been on its own keystroke instead of being a special-case "1" prefix for a command that's quite different conceptually. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 19 15:43:34 2020 Received: (at 38044) by debbugs.gnu.org; 19 Jul 2020 19:43:34 +0000 Received: from localhost ([127.0.0.1]:33079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxFDi-0003RA-6q for submit@debbugs.gnu.org; Sun, 19 Jul 2020 15:43:34 -0400 Received: from mail-ej1-f45.google.com ([209.85.218.45]:45308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxFDg-0003Qx-C3 for 38044@debbugs.gnu.org; Sun, 19 Jul 2020 15:43:32 -0400 Received: by mail-ej1-f45.google.com with SMTP id a1so15942915ejg.12 for <38044@debbugs.gnu.org>; Sun, 19 Jul 2020 12:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=08IZU/E2xB+sDzMPvdEIQW1H9ywnwJMh7vXRQ4Z0qgs=; b=q4eaFlYZntdaGqD6FDzR1akM54dNWbhUNcfSPGm1VyyPT65eQO4pKuTzZR5lnDPok1 xRuA1AFsw/OgAwqJQwdZnk1PKUJeTChwhYn3k+eqSHgkNttbrbkuc8CwtmvR6AaNqwsd DlE5QbC9DAxzF/HyVLODUltBIgMQPdHBQpgsacBThlyuoIiXC/FnxxvIvQGJeBmIADh6 AolwnTTsH/FfD4odWKDYNqcI5gUEYyQ6HWb5Qh39fsz0lVliYHffn9FkMWepoTAUb4FZ 1SY3UEKFO4vsa1OMoNHp77cEwk0YCrzv08ntcexuX0tBR3rjvS5TgG6/josDd80+DJPa 1ThQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=08IZU/E2xB+sDzMPvdEIQW1H9ywnwJMh7vXRQ4Z0qgs=; b=Mm9W9MR3S5UPzydhHfUC1nPrlkDx+h8UR6IZkyrcfBfVhYVIf0CSxtNQRXx8bEuUQs w1bmRS4BgDpexvzLj3mR2tnjs3xxUBWIDEj9uSoyEsCHcWxgLgvop8NxamRf+RtZaMb/ 71nz8baS6HetE7yjId4FKpNsDnM06Qr1rti+bg5t805vUH3zW90UaFTIp3Z1K7M3VgOD fLt2Pnluk5l8ZK0gBJv+ocatF445IvLg7sCMJJ5OpaK19SGGJ6qleEQBiyinG2ECb1F/ I+wdqCZRkPuK67TORSIa/+2ZqSxGac/zRGgC8XoU+iowsjFrUlkEI1hSoZ+Z2DsP0sQB 3O7g== X-Gm-Message-State: AOAM531sPXvy1kck4dN0KPtM+rDp7Ia+a+VEMD8VSx2pxICeMXF4rYOV l2MNC2LxxDV/J4juQN8thkWPgccf X-Google-Smtp-Source: ABdhPJwQloiLZ6ghFF1btL9og8A6P4Meet8pYz4FXr5nNybn1YGmjvbTQf0x3uQ8chyDUanIPz/ltA== X-Received: by 2002:a17:906:c78f:: with SMTP id cw15mr17376138ejb.58.1595187806287; Sun, 19 Jul 2020 12:43:26 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id v24sm13193123eja.29.2020.07.19.12.43.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jul 2020 12:43:25 -0700 (PDT) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Lars Ingebrigtsen References: <87ftj5at1q.fsf@gnus.org> <87365nplms.fsf@gnus.org> <8d689312-c025-405e-1054-56bc81a95867@yandex.ru> <87k0yzmnlh.fsf@gnus.org> From: Dmitry Gutov Message-ID: Date: Sun, 19 Jul 2020 22:43:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87k0yzmnlh.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 19.07.2020 20:16, Lars Ingebrigtsen wrote: >> Are you happy with the result? > > Yes, looks perfect to me. > > But I wish it'd have been on its own keystroke instead of being a > special-case "1" prefix for a command that's quite different > conceptually. Indeed. And the implementation reflects this dissonance as well. But the resulting buffer looks fine, I agree. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 19 15:51:41 2020 Received: (at 38044) by debbugs.gnu.org; 19 Jul 2020 19:51:41 +0000 Received: from localhost ([127.0.0.1]:33099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxFLY-0003e5-OG for submit@debbugs.gnu.org; Sun, 19 Jul 2020 15:51:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxFLW-0003dp-5Y for 38044@debbugs.gnu.org; Sun, 19 Jul 2020 15:51:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hE3TX8U0yp/+Gn8U9K7rlpzTTkvL+WjVakSf7iFYE0k=; b=ANKV8Tm+KUmUhZsVpPkDBN8aW6 5fURmOatnW/xRCo6tOFUBkjLObmd23eYulrBiHhlJNIgI0GEKqkTWNMTEO7ERjztPpf3vF/tf+8KU JzQWeehNNQVKkkVRsWlmuxhTe9uPot/8KEFSyBhAvvX4TbqOEZUbeEKwmJPgce5X1P/w=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxFLN-0004Fs-VO; Sun, 19 Jul 2020 21:51:32 +0200 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87365nplms.fsf@gnus.org> <8d689312-c025-405e-1054-56bc81a95867@yandex.ru> <87k0yzmnlh.fsf@gnus.org> Date: Sun, 19 Jul 2020 21:51:28 +0200 In-Reply-To: (Dmitry Gutov's message of "Sun, 19 Jul 2020 22:43:24 +0300") Message-ID: <87h7u3l1vj.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > On 19.07.2020 20:16, Lars Ingebrigtsen wrote: > >>> Are you happy with the result? >> Yes, looks perfect to me. >> But I wish it'd have been on its own keystroke instead of being a >> special-case " [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 19.07.2020 20:16, Lars Ingebrigtsen wrote: > >>> Are you happy with the result? >> Yes, looks perfect to me. >> But I wish it'd have been on its own keystroke instead of being a >> special-case "1" prefix for a command that's quite different >> conceptually. > > Indeed. And the implementation reflects this dissonance as well. > > But the resulting buffer looks fine, I agree. I've done the following in my .emacs: (global-set-key [(super c)] (lambda () (interactive) (let ((current-prefix-arg 1)) (call-interactively 'vc-print-root-log)))) But those contortions I have to do to even bind this to a different keystrokes further illustrates the problems with having this functionality be in the same command... What were the reasons for squishing these two things into the same function, anyway? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 20 16:56:35 2020 Received: (at 38044) by debbugs.gnu.org; 20 Jul 2020 20:56:35 +0000 Received: from localhost ([127.0.0.1]:36393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxcpv-00041j-Hq for submit@debbugs.gnu.org; Mon, 20 Jul 2020 16:56:35 -0400 Received: from mail-ej1-f45.google.com ([209.85.218.45]:33625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxcps-00041V-Sy for 38044@debbugs.gnu.org; Mon, 20 Jul 2020 16:56:33 -0400 Received: by mail-ej1-f45.google.com with SMTP id n26so19522936ejx.0 for <38044@debbugs.gnu.org>; Mon, 20 Jul 2020 13:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ie31JO2gRNhTBUOpgeSgHz1KefuYfT2b459RjqQR6cI=; b=aSDj1nNIL6pvjGC03ZruPLHsgp48VRUXRJozZ4uB3l9jYCFniCjbSu1jorBW4S2WVI S6OEDTFZjA4q6OcVuKhaZfZqE92OD7tbISEfduuWdmYkyBFCZyK8Ilsis4vBm3Vyi5gh 12jqpQG2nqXLCzTyDZtfblxGTDCad81EWLphtDRCtP09n5AvAY/T2YxjKA8GRjdrIU6H B7TSTzN1TV1KInz3GSBqY3mDd7AxOgzXDhYKE4AKf013ot6nYP8e+uTrM6n06c9iM1qb eHEqZh06p+1uIOXA0tNf56dAvkCE/zxjbSyHSt0/zznIdrs7ebypsfb4nX7S/swhU5NT u3GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ie31JO2gRNhTBUOpgeSgHz1KefuYfT2b459RjqQR6cI=; b=O29klvuoy3Y7rJCKkkvAEt6AvHR1lKam1dNKMev46zVBudQlIQ+MQlEmQmP3jZ9mzu NSl3swXyDpBAkQKX3HU+2C3Ta9dO/lk+XE3JGN2zPz89E1+aKHqEjWKBufc9JCkkaw+9 4FYqJiL5WrAJU0IBMYLEBBFOx04vwGJa6o9rj0DWsp5pg3vssBc6A+Gs/9zX3dlYM8EL mYQL45dJAN9xn5LvVH8ICYKTbBdpVMLUT9WjiY0tu6g7TlaZMZ24z3oC+4kPizP/ZPtS l7f6Lqu2j4pJYy0bK3PTjNIO1yT/9+3PnB/jyrhlC3QIEtjF4C3orXamtlEob1lPpXp/ h1tA== X-Gm-Message-State: AOAM530XVSSWfkqJbTAWJQzq09d3xrUF1qlsQx6O3Csgahr4ahgrmNvy a+pNrj5TahT/l7F0gtjEKRPZ9HeR X-Google-Smtp-Source: ABdhPJy94uwEYT73/6iPXbdjoOI0venjct0sJLpk3gs44QRPvRiLfGSeNUtCJe/3PGacYjeY582ZEQ== X-Received: by 2002:a17:906:38d6:: with SMTP id r22mr19656335ejd.219.1595278586988; Mon, 20 Jul 2020 13:56:26 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id r5sm16127445edx.32.2020.07.20.13.56.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2020 13:56:26 -0700 (PDT) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Lars Ingebrigtsen References: <87ftj5at1q.fsf@gnus.org> <87365nplms.fsf@gnus.org> <8d689312-c025-405e-1054-56bc81a95867@yandex.ru> <87k0yzmnlh.fsf@gnus.org> <87h7u3l1vj.fsf@gnus.org> From: Dmitry Gutov Message-ID: Date: Mon, 20 Jul 2020 23:56:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87h7u3l1vj.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 19.07.2020 22:51, Lars Ingebrigtsen wrote: > What were the reasons for squishing these two things into the same > function, anyway? The dangers of "bending VC to Git's twisted mindset": https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38044#83 From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 21 17:44:48 2020 Received: (at 38044) by debbugs.gnu.org; 21 Jul 2020 21:44:48 +0000 Received: from localhost ([127.0.0.1]:40575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jy048-0002DD-Bh for submit@debbugs.gnu.org; Tue, 21 Jul 2020 17:44:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jy045-0002Cz-M1 for 38044@debbugs.gnu.org; Tue, 21 Jul 2020 17:44:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=q2jt/17XCX4f57SHNkhmgjnkxWhgUebg+0dFRRTAxVw=; b=HRMHhtEsJ36qATRKQhVfWKTBsC 5O/HLyml1lYtLSqt1MCcSAlmp1OseFO2Hzg6KaJyMqSN0X8EnAqvGp7spO/b2YQcQqr2HergoTVTD EA20jjdCw7ejoENV366YyqKw2nhUqXR8M1hvKtpDVvu+mVBHdOpCIUP0YIKwOftlNx04=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jy03w-0005P8-GV; Tue, 21 Jul 2020 23:44:39 +0200 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87365nplms.fsf@gnus.org> <8d689312-c025-405e-1054-56bc81a95867@yandex.ru> <87k0yzmnlh.fsf@gnus.org> <87h7u3l1vj.fsf@gnus.org> Date: Tue, 21 Jul 2020 23:44:36 +0200 In-Reply-To: (Dmitry Gutov's message of "Mon, 20 Jul 2020 23:56:24 +0300") Message-ID: <87h7u0pmpn.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > On 19.07.2020 22:51, Lars Ingebrigtsen wrote: >> What were the reasons for squishing these two things into the same >> function, anyway? > > The dangers of "bending VC to Git's twisted mindset": > > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38044 Cc: 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 19.07.2020 22:51, Lars Ingebrigtsen wrote: >> What were the reasons for squishing these two things into the same >> function, anyway? > > The dangers of "bending VC to Git's twisted mindset": > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38044#83 Uhm... I don't quite follow the logic. "Looking at a specific vc commit" is surely VC agnostic? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 22 11:36:41 2020 Received: (at 38044) by debbugs.gnu.org; 22 Jul 2020 15:36:41 +0000 Received: from localhost ([127.0.0.1]:42840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyGnQ-0003q5-P3 for submit@debbugs.gnu.org; Wed, 22 Jul 2020 11:36:40 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyGnM-0003pp-8W for 38044@debbugs.gnu.org; Wed, 22 Jul 2020 11:36:39 -0400 Received: by mail-wr1-f67.google.com with SMTP id r12so2313504wrj.13 for <38044@debbugs.gnu.org>; Wed, 22 Jul 2020 08:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3EV+V3QLe2rfq0i14hCJiOh8Jx8G96RFHpnF4JxuCxo=; b=Qv/rTAwHb3Ue+h4mCWa5fspJj9j0Vp6drPs4BININqQaZreQyHAOQxksM9L6gZSWph 4QBQGFeohvPXuZJcqdHADNOsAJTz8EQYY64e4I5tirGAwbawvLHOuBdGPmkE71IklE6I zjkf1EmT3EwBt/SlwPVSu5+kQSmeT8NLGS/6/tXTYj8xRvjTrXySdaxgDObSAsYuENhj EEmT/LjDQ+YwTthoZdi+RvfR6NNrzLngmaws9fLOqihVrMIwGkmzc+CEu9mftkp0Ln1s RBo9J5rniKw7usyQj9drUEWWMgMB+Yqe/h/PIIhPFLW6lZQ/uaPaqNsKK2BTrYMS1KrR NfOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3EV+V3QLe2rfq0i14hCJiOh8Jx8G96RFHpnF4JxuCxo=; b=Mq9/AZ6E35qYUWxeAChpGrYVxJAhKfCZhfpZjLDT1LI1Ivgv+UOvsLduCM5wXvVHHl JLR7oFAbkpHWdbnXrS7GRvKJhtMp2j45srYjUkNTCuWbKi3bKAL9WTylaiSDmiJXtnod WOjcM4Cy+ICqIEfR899AQAfSM5okUdH+COKr2NV8iSpt3dsO5AMg1vouywJXvy3YB7Wy r+yrYH5rqHrGZnVQDJIk5itN9WmQZzTsRxgqmdbRNEKKnXocgTCRYGh7mwXITEK2J65C rImBEVZU6S25/IYyEqalsxOT+Z4SGl+NJRUzDZsGP9MnIcY+xirAQ1LUJ3dGBOAyOCTm EH3w== X-Gm-Message-State: AOAM532bGVKqj6xVZLz0X3OKeaoK3N9k8UK2zyGfJtuOAcXeQo0bQU4A O87roKOIlA2Hzg6TXpopWTs= X-Google-Smtp-Source: ABdhPJwsS1G4wtRqvyYY0a4wVJpj4tt5lK5Xt/Ouzob9Fj7Iy+7M3X6bDEtvdhUUCEA6KEXPGbI67A== X-Received: by 2002:adf:f0ce:: with SMTP id x14mr120054wro.137.1595432190391; Wed, 22 Jul 2020 08:36:30 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id n18sm332700wrw.45.2020.07.22.08.36.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2020 08:36:29 -0700 (PDT) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Lars Ingebrigtsen References: <87ftj5at1q.fsf@gnus.org> <87365nplms.fsf@gnus.org> <8d689312-c025-405e-1054-56bc81a95867@yandex.ru> <87k0yzmnlh.fsf@gnus.org> <87h7u3l1vj.fsf@gnus.org> <87h7u0pmpn.fsf@gnus.org> From: Dmitry Gutov Message-ID: Date: Wed, 22 Jul 2020 18:36:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87h7u0pmpn.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 38044 Cc: Eli Zaretskii , 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 22.07.2020 00:44, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> On 19.07.2020 22:51, Lars Ingebrigtsen wrote: >>> What were the reasons for squishing these two things into the same >>> function, anyway? >> The dangers of "bending VC to Git's twisted mindset": >> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38044#83 > Uhm... I don't quite follow the logic. "Looking at a specific vc > commit" is surely VC agnostic? SVN doesn't have a separate command to "show commit", so VC shouldn't either. Right, Eli? Or did I miss some of your arguments here? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 22 12:14:52 2020 Received: (at 38044) by debbugs.gnu.org; 22 Jul 2020 16:14:52 +0000 Received: from localhost ([127.0.0.1]:42878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyHOO-0004jq-5X for submit@debbugs.gnu.org; Wed, 22 Jul 2020 12:14:52 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:38437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyHOK-0004ja-AD for 38044@debbugs.gnu.org; Wed, 22 Jul 2020 12:14:50 -0400 Received: by mail-ej1-f67.google.com with SMTP id br7so2826613ejb.5 for <38044@debbugs.gnu.org>; Wed, 22 Jul 2020 09:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oBLt3XfqTwqbNmmWlkcSK03fh7GYK/U4D7gJWoElHvM=; b=FyUNm9M3+WReSwauHjW0EPWJElDTxWycBqA813EIGWpkIc5ztyIsUpMWLVTYztn9HV dHq/azI62pTaQCADaeiJgGLpimseHye/wkZCPU7kV0wIF+PKAhlMM4/jTdC7VKNu/090 oW37VatW30dVQIIMaN5mdg23XBs0mJhrZaaw79hLuV3/nqByZWc9TVZw3itOpiMK6m0h 8mOjKPCtAVf9D7uulDjQ4KguVArVl30+qh9jVJ1Wnfft8KLpg00VVn01nSUDBqDhExRm JQl809dKM4ZIdJwvtjehWL6/kyLZxxVaTWwP16SV4Meg6XGibNAcDBWD+W5/s6p5G50f FnsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oBLt3XfqTwqbNmmWlkcSK03fh7GYK/U4D7gJWoElHvM=; b=MviYaiRq3M3f90saEVu7FTGfoRWcYFvXmLiWyZObe30UJUQrsVI7aMCBBiD7RrXCJq qsZK4I/7tJjQ2u7mpvgssdF3fr6Ppmki8CPPqf//QA9AS7mcJCtLcG+BSQvAMFeGIPFQ bTp7DrD8Z+EDd3DDpX6GYROnIoAA9lgW4/Tk3R+/MDY7PQhxCfN4ETnxaYgljKiBug5/ VN+UFaTx7iTz5rjmajxZJMeppQ9N0E6WLkyPb4eoi0xETW9/1DTPSsN0wmf2vZCnfFXW AklB1LJyMiTk8zA5nEBpPIYw+mKlHuHIAf84Cw01jQGjImmKzuVoWB+I4lpQpwGFMgQh RpiQ== X-Gm-Message-State: AOAM530oPGgRCEeAIYqUeP/L5Y1P70fU2F/qZE6lxlutmp2snwMT+3WN AiFNAXVULIU0SMdgiR2wx/M= X-Google-Smtp-Source: ABdhPJx6MXStnjTz6L4LnhSzhuBh6yESX6dnCB8FqzkSxhWJUehWV7ZJ2ku82N3z/rLvYgkRJJLIgQ== X-Received: by 2002:a17:906:6004:: with SMTP id o4mr255669ejj.411.1595434482436; Wed, 22 Jul 2020 09:14:42 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id gr15sm68037ejb.84.2020.07.22.09.14.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2020 09:14:41 -0700 (PDT) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit From: Dmitry Gutov To: Lars Ingebrigtsen References: <87ftj5at1q.fsf@gnus.org> <87365nplms.fsf@gnus.org> <8d689312-c025-405e-1054-56bc81a95867@yandex.ru> <87k0yzmnlh.fsf@gnus.org> <87h7u3l1vj.fsf@gnus.org> <87h7u0pmpn.fsf@gnus.org> Message-ID: Date: Wed, 22 Jul 2020 19:14:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 38044 Cc: Eli Zaretskii , 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Forgot to add in Cc. On 22.07.2020 18:36, Dmitry Gutov wrote: > On 22.07.2020 00:44, Lars Ingebrigtsen wrote: >> Dmitry Gutov  writes: >> >>> On 19.07.2020 22:51, Lars Ingebrigtsen wrote: >>>> What were the reasons for squishing these two things into the same >>>> function, anyway? >>> The dangers of "bending VC to Git's twisted mindset": >>> >>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38044#83 >> Uhm...  I don't quite follow the logic.  "Looking at a specific vc >> commit" is surely VC agnostic? > > SVN doesn't have a separate command to "show commit", so VC shouldn't > either. Right, Eli? > > Or did I miss some of your arguments here? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 22 12:26:09 2020 Received: (at 38044) by debbugs.gnu.org; 22 Jul 2020 16:26:09 +0000 Received: from localhost ([127.0.0.1]:42901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyHZJ-00051U-81 for submit@debbugs.gnu.org; Wed, 22 Jul 2020 12:26:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyHZH-00051I-J6 for 38044@debbugs.gnu.org; Wed, 22 Jul 2020 12:26:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52164) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyHZB-0005RQ-KP; Wed, 22 Jul 2020 12:26:01 -0400 Received: from [176.228.60.248] (port=2974 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jyHZA-0005lv-Aj; Wed, 22 Jul 2020 12:26:01 -0400 Date: Wed, 22 Jul 2020 19:25:59 +0300 Message-Id: <83eep3fre0.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: (message from Dmitry Gutov on Wed, 22 Jul 2020 18:36:28 +0300) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit References: <87ftj5at1q.fsf@gnus.org> <87365nplms.fsf@gnus.org> <8d689312-c025-405e-1054-56bc81a95867@yandex.ru> <87k0yzmnlh.fsf@gnus.org> <87h7u3l1vj.fsf@gnus.org> <87h7u0pmpn.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 38044@debbugs.gnu.org, Eli Zaretskii > From: Dmitry Gutov > Date: Wed, 22 Jul 2020 18:36:28 +0300 > > >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38044#83 > > Uhm... I don't quite follow the logic. "Looking at a specific vc > > commit" is surely VC agnostic? > > SVN doesn't have a separate command to "show commit", so VC shouldn't > either. Right, Eli? There are VCS commands to show one or more commits; they are generally called "log" with some command-line arguments to control how many revisions to show and what to show about each one. Git also has a separate command "show" (which can "show" many different objects, not just a commit), but the concept is still the same. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 22 12:39:04 2020 Received: (at 38044) by debbugs.gnu.org; 22 Jul 2020 16:39:04 +0000 Received: from localhost ([127.0.0.1]:42906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyHlo-0005Kh-Eo for submit@debbugs.gnu.org; Wed, 22 Jul 2020 12:39:04 -0400 Received: from mail-ed1-f45.google.com ([209.85.208.45]:42781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyHlk-0005KB-IG for 38044@debbugs.gnu.org; Wed, 22 Jul 2020 12:39:02 -0400 Received: by mail-ed1-f45.google.com with SMTP id z17so2124441edr.9 for <38044@debbugs.gnu.org>; Wed, 22 Jul 2020 09:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+/qf8H5y//DW2NhCTbWVMyJ5NJpZSkJhv90MzdphgOU=; b=F4l6XNg6miRTzOBJVLzJ4G3B4+gjNJ0zxRujDtcgrThAmdvotrIwWm7BjOmogKDLwW XWPeaTnp55srPeOWouYUnc7hXg0Ewi8at0D20vHjbskRl0l99oARrNz/w2B2lwToCfSy 6kz4N/UE657SwzMIDnwDyPfisTKPToJHLPRjO9blw4pBMAUpBcCAbNcvkD+pVz8GFF/O cvEt0iOkaPQYhvOiPBhR12Wb+VReofVejTyb/gKlLDLskxtJ+yEgFe8CDesmNGhwuguX yxmmiCvugDUXbAq6NGgt3nA+DtC6zNHwZr/8v6F4t/y0N+yrakX3AcJ8wTpBT1LJEaiV mjaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+/qf8H5y//DW2NhCTbWVMyJ5NJpZSkJhv90MzdphgOU=; b=KdPXgcxSMfB03XEp4eEl5Cs1dMI+gS5r5f5eo+uSzE25qLRpadSsm5bTuJHlafhdZX 3bdXVgfRrRSb4dlMs1n/Fg9/Zz9wpSPV+rIlSsvh5bMaWV0OVbk7dK4Z3ZfDcxki1OuG Le7zBeG/iuGP5hj4fRE2uzmSSLpvpG1PJA7JY09drW3IFHOBenaX+oDmXcw9iYwq61yQ hVOnZrPalCH+ZKcipUxhqWAgDDDOicUQ8zrgdD+m3BcCMDNPODUwmz5fDv5v/VzdHRjR UtcL4C6aUlCfup6j8EMHfxHEcqrmNlIFdeyru4xTY+DKCTmC8vLevy17++5/gT3oZm22 2I+g== X-Gm-Message-State: AOAM531q2MuC0wNNzgsJVFjawiWiDopOZy4ZoSjs9SBj2ReFNpp5Xxqi WIJKiolXbDtShMTSrihiyEF/iFwK X-Google-Smtp-Source: ABdhPJz3xqbpjVV5lGDBC9gyQOtdujvzgn5oy8vFnZlNFsjfwEiiNueX126+/7nb42OwOWQ/Fu8VxA== X-Received: by 2002:aa7:dc46:: with SMTP id g6mr319256edu.194.1595435934235; Wed, 22 Jul 2020 09:38:54 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id rv16sm120898ejb.60.2020.07.22.09.38.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2020 09:38:53 -0700 (PDT) Subject: Re: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit To: Eli Zaretskii References: <87ftj5at1q.fsf@gnus.org> <87365nplms.fsf@gnus.org> <8d689312-c025-405e-1054-56bc81a95867@yandex.ru> <87k0yzmnlh.fsf@gnus.org> <87h7u3l1vj.fsf@gnus.org> <87h7u0pmpn.fsf@gnus.org> <83eep3fre0.fsf@gnu.org> From: Dmitry Gutov Message-ID: <14b3d2d5-15d1-2de5-6ba5-75fc8194eaf4@yandex.ru> Date: Wed, 22 Jul 2020 19:38:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83eep3fre0.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 38044 Cc: larsi@gnus.org, 38044@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 22.07.2020 19:25, Eli Zaretskii wrote: > There are VCS commands to show one or more commits; they are generally > called "log" with some command-line arguments to control how many > revisions to show and what to show about each one. Some do, some don't. Surely none of them conflate the "show diff as well" argument with "show only one revision". From unknown Sat Aug 09 15:56:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 Aug 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator