Subject: Re: [bug#38042] [PATCH] gnu: lmms: Update to 1.2.1.

From: Kei Kebreau <[email-masked]>
Date: Sun, 03 Nov 2019 20:24:10 -0500

Marius Bakke <[email-masked]> writes:

> Kei Kebreau <[email-masked]> writes:
>
>> * gnu/packages/music.scm (lmms): Update to 1.2.1.
>> [arguments]: Enable Qt 5 support and disbale VST support in configure-flags.
>> Add 'unpack-rpmalloc' phase and remove 'remove-Werror' phase.
>> [native-inputs]: Add qttools and rpmalloc.
>> [inputs]: Replace qt-4 and fluidsynth-1 with qtbase and fluidsynth,
>> respectively; add qtx11extras.
>
> Can you add a comment about what rpmalloc is, and how to tell which
> version to pick?
>

I included the following comment and pushed to the master branch:

  rpmalloc is a public domain memory allocator. This version specified
  below is the version required by LMMS.
  To get the new commit of rpmalloc to use here, run
     `git submodule--helper list | grep rpmalloc | cut -f2 -d' '`
  in the cloned LMMS repository.

> Otherwise LGTM, thanks!

Thanks for reviewing!