GNU bug report logs - #38040
Compiler warnings on win32 build

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#38040: closed (Compiler warnings on win32 build)
Date: Thu, 14 Nov 2019 09:19:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 14 Nov 2019 11:18:32 +0200
with message-id <8336eq95p3.fsf <at> gnu.org>
and subject line Re: bug#38040: Compiler warnings on win32 build
has caused the debbugs.gnu.org bug report #38040,
regarding Compiler warnings on win32 build
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
38040: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38040
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Cecilio Pardo <cpardo <at> imayhem.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Compiler warnings on win32 build
Date: Sun, 03 Nov 2019 01:36:41 +0100

Severity: wishlist
Tags: patch

Building with mingw64, there are a couple of warnings about wrong data
types that can be avoided:


diff --git a/nt/addpm.c b/nt/addpm.c
index a8bcd4a5c7..ff169f7d87 100644
--- a/nt/addpm.c
+++ b/nt/addpm.c
@@ -56,13 +56,13 @@ #define COBJMACROS 1
 #include "../src/epaths.h"
 #endif
 
-HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, DWORD,
-			       DWORD);
+HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, ULONG_PTR,
+			       ULONG_PTR);
 
 HDDEDATA CALLBACK
 DdeCallback (UINT uType, UINT uFmt, HCONV hconv,
 	     HSZ hsz1, HSZ hsz2, HDDEDATA hdata,
-	     DWORD dwData1, DWORD dwData2)
+	     ULONG_PTR dwData1, ULONG_PTR dwData2)
 {
   return ((HDDEDATA) NULL);
 }
diff --git a/nt/ddeclient.c b/nt/ddeclient.c
index e441700397..a63be13f75 100644
--- a/nt/ddeclient.c
+++ b/nt/ddeclient.c
@@ -21,13 +21,13 @@
 #include <stdlib.h>
 #include <stdio.h>
 
-HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, DWORD,
-			       DWORD);
+HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, ULONG_PTR,
+			       ULONG_PTR);
 
 HDDEDATA CALLBACK
 DdeCallback (UINT uType, UINT uFmt, HCONV hconv,
 	     HSZ hsz1, HSZ hsz2, HDDEDATA hdata,
-	     DWORD dwData1, DWORD dwData2)
+	     ULONG_PTR dwData1, ULONG_PTR dwData2)
 {
   return ((HDDEDATA) NULL);
 }

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Cecilio Pardo <cpardo <at> imayhem.com>
Cc: 38040-done <at> debbugs.gnu.org
Subject: Re: bug#38040: Compiler warnings on win32 build
Date: Thu, 14 Nov 2019 11:18:32 +0200

> From: Cecilio Pardo <cpardo <at> imayhem.com>
> Cc: Cecilio Pardo <cpardo <at> imayhem.com>,  38040 <at> debbugs.gnu.org
> Date: Sun, 10 Nov 2019 01:03:51 +0100
> 
> 
> >> Building with mingw64, there are a couple of warnings about wrong data
> >> types that can be avoided:
> >
> > Thanks, I installed a slightly different change, because these types
> > are declared DWORD in mingw.org's MinGW headers.  Please see that the
> > warnings are gone in your build.
> 
> They are gone. Thanks for fixing this.

Thanks, closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.