Subject: bug#38040: closed (Re: bug#38040: Compiler warnings on win32 build)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 14 Nov 2019 09:19:03 +0000

Your bug report

#38040: Compiler warnings on win32 build

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
38040: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38040
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#38040: Compiler warnings on win32 build
From: Eli Zaretskii <[email-masked]>
To: Cecilio Pardo <[email-masked]>
Cc: [email-masked]
Date: Thu, 14 Nov 2019 11:18:32 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Cecilio Pardo <[email-masked]>
> Cc: Cecilio Pardo <[email-masked]>,  [email-masked]
> Date: Sun, 10 Nov 2019 01:03:51 +0100
> 
> 
> >> Building with mingw64, there are a couple of warnings about wrong data
> >> types that can be avoided:
> >
> > Thanks, I installed a slightly different change, because these types
> > are declared DWORD in mingw.org's MinGW headers.  Please see that the
> > warnings are gone in your build.
> 
> They are gone. Thanks for fixing this.

Thanks, closing.

Subject: Compiler warnings on win32 build
From: Cecilio Pardo <[email-masked]>
To: [email-masked]
Date: Sun, 03 Nov 2019 01:36:41 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Severity: wishlist
Tags: patch

Building with mingw64, there are a couple of warnings about wrong data
types that can be avoided:

diff --git a/nt/addpm.c b/nt/addpm.c
index a8bcd4a5c7..ff169f7d87 100644
--- a/nt/addpm.c
+++ b/nt/addpm.c
@@ -56,13 +56,13 @@ #define COBJMACROS 1
 #include "../src/epaths.h"
 #endif
 
-HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, DWORD,
-			       DWORD);
+HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, ULONG_PTR,
+			       ULONG_PTR);
 
 HDDEDATA CALLBACK
 DdeCallback (UINT uType, UINT uFmt, HCONV hconv,
 	     HSZ hsz1, HSZ hsz2, HDDEDATA hdata,
-	     DWORD dwData1, DWORD dwData2)
+	     ULONG_PTR dwData1, ULONG_PTR dwData2)
 {
   return ((HDDEDATA) NULL);
 }
diff --git a/nt/ddeclient.c b/nt/ddeclient.c
index e441700397..a63be13f75 100644
--- a/nt/ddeclient.c
+++ b/nt/ddeclient.c
@@ -21,13 +21,13 @@
 #include <stdlib.h>
 #include <stdio.h>
 
-HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, DWORD,
-			       DWORD);
+HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, ULONG_PTR,
+			       ULONG_PTR);
 
 HDDEDATA CALLBACK
 DdeCallback (UINT uType, UINT uFmt, HCONV hconv,
 	     HSZ hsz1, HSZ hsz2, HDDEDATA hdata,
-	     DWORD dwData1, DWORD dwData2)
+	     ULONG_PTR dwData1, ULONG_PTR dwData2)
 {
   return ((HDDEDATA) NULL);
 }