GNU bug report logs - #38030
[PATCH 00/13] Update KDE frameworks and other KDE stuff

Previous Next

Full log

View this message in rfc822 format

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Miguel Arruga Vivas <rosen644835 <at> gmail.com>
Cc: 38030 <at> debbugs.gnu.org
Subject: [bug#38030] [PATCH 13/13] gnu: kpmcore: Update to 4.0.1
Date: Sun, 3 Nov 2019 11:13:44 +0100

Am 02.11.19 um 19:38 schrieb Miguel Arruga Vivas:
> Hartmut Goebel <h.goebel <at> crazy-compilers.com> wrote:
>> Also move to kde.scm, since it is a frameworks part.
> You moved kholidays to kde-frameworks.scm as it is now part of
> the framework, but this comment seems to suggest that the framework
> parts are located in kde.scm.  Is there any reason to not keep it there?

Oops the commit message is wrong, I will update it just after sending
this mail:

This should read: kpmcore is *not* a framework. Thus I moved it from
kde-frameworks.scm to kde.scm.


> That commented code seems a left over from previous tests. Perhaps
> it should be removed, perhaps a comment makes sense there. :)

You are absolutely right on this.  These comments are left-overs which
should never have gone there. I simply did not review the ackage
definition.


-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.