Subject: Re: [bug#38030] [PATCH 04/13] gnu: Add kcalendarcore.

From: Marius Bakke <[email-masked]>
Date: Sun, 03 Nov 2019 17:08:37 +0100

Hartmut Goebel <[email-masked]> writes:

> This is now a part of KDE Frameworks.
>
> * gnu/packages/kde-frameworks.scm(kcalendarcore): New variable.

[...]

> +(define-public kcalendarcore
> +  (package
> +    (name "kcalendarcore")
> +    (version "5.63.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://kde/stable/frameworks/"
> +                    (version-major+minor version) "/"
> +                    name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "1cqqwpd6faz7sd6jrda564xxvwr231b175h2w3ilxx6hvz9yrps3"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("perl" ,perl)
> +       ("tzdata" ,tzdata)))

This should use 'tzdata-for-tests'.

> +    (inputs
> +     `(("libical" ,libical)
> +       ("qtbase" ,qtbase)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'disable-failing-libical3-tests
> +           (lambda _
> +             (substitute* "autotests/CMakeLists.txt"
> +               (("macro_unit_tests\\(testicaltimezones\\)" line)
> +                (string-append "## " line))
> +               (("target_link_libraries\\(testicaltimezones " line)
> +                (string-append "## " line)))
> +             (for-each
> +              delete-file
> +              (list
> +               "autotests/data/Compat-libical3/AppleICal_1.5.ics"
> +               "autotests/data/Compat-libical3/Evolution_2.8.2_timezone_test.ics"
> +               "autotests/data/Compat-libical3/KOrganizer_3.1a.ics"
> +               "autotests/data/Compat-libical3/MSExchange.ics"
> +               "autotests/data/Compat-libical3/Mozilla_1.0.ics"))
> +             #t))

Can you add some comments about why this is necessary?