Subject: Re: [bug#38030] [PATCH 13/13] gnu: kpmcore: Update to 4.0.1

From: Miguel Arruga Vivas <[email-masked]>
Date: Sat, 2 Nov 2019 19:38:25 +0100

Hi Hartmut,

Just a couple of comments (although I'm not an official reviewer) about
this patch.

Hartmut Goebel <[email-masked]> wrote:
> Also move to kde.scm, since it is a frameworks part.
> 
> * gnu/packages/kde-frameworks.scm(kpmcore): Move from here …
> * gnu/packages/kde.scm(kpmcore): … to here, update to 4.0.1;
> [inputs]: Add qttools; [native-inputs]: Add dbus; [arguments]: New
> element.

You moved kholidays to kde-frameworks.scm as it is now part of
the framework, but this comment seems to suggest that the framework
parts are located in kde.scm.  Is there any reason to not keep it there?

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _
> +             ;(setenv "HOME" (getcwd))
> +             ;(setenv "TMPDIR" (getcwd))
> +             ;(setenv "QT_QPA_PLATFORM" "offscreen")
> +             (invoke "dbus-launch" "ctest" "."))))))

That commented code seems a left over from previous tests.  Perhaps
it should be removed, perhaps a comment makes sense there. :)

Best regards,
Miguel