From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 01 17:40:51 2019 Received: (at submit) by debbugs.gnu.org; 1 Nov 2019 21:40:51 +0000 Received: from localhost ([127.0.0.1]:57391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQef4-0001E8-Uz for submit@debbugs.gnu.org; Fri, 01 Nov 2019 17:40:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:58388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQeez-0001Dv-NZ for submit@debbugs.gnu.org; Fri, 01 Nov 2019 17:40:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37303) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQeew-0004NM-Vk for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 17:40:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQeer-0003bz-9h for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 17:40:39 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:32842) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQeeq-0003O0-Tz for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 17:40:37 -0400 Received: by mail-wr1-x434.google.com with SMTP id s1so10945446wro.0 for ; Fri, 01 Nov 2019 14:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version; bh=uUU0EBNNhzZfz32SMhlbSl68BGrOcvyfiwyM4vj2OZU=; b=dLEh5vdRyglbutS29VFqPsgmXbWvm9Zy3/jFwoyLVcKhrKBddAhopZALdzBIUKpmqY YycJzWAWCBmUdX/1zHoOkZkz3zmLHE/G24ht7XF7ol09CP3/1FGmvBzti8/zGVAiOFjW 0/LrpY4ZjTXUh4DlAtC38I8nRIX9hTWbrEhFpT5UrK5s/NFwWO1Ky8JREyTP0ewCmhWq PaaRDPOztzgj+QjkDIkKUdeHKyRy50M2iOIg+rIKQ6VjMQ0aXbBeqKlwFeWCUm1qNI9E W0VlOfI4jj2/R/TYGzsIWqIwXWg4oEqS4BjV7BHx0jR3Vgz0ynFcqXK7SjvVwimd4oD+ 5NpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=uUU0EBNNhzZfz32SMhlbSl68BGrOcvyfiwyM4vj2OZU=; b=CWWVmG/VyGy2k9HGgKBW6FEV0CtGUgFTnAt+NCy0bgs13UQGFNRDkaHhTtoCK5RRI9 sDt0BMH8/Pjl18fsQb41eYoGVPqdRJYO6CtAODSYmOdIK1a0Eth3i7gImNCU1SL8M9SC DnKAuHlHQ3Ji69AGznZ4Ln32RyigmwGydAJz51ioc48SJHcPfldsoL8fZu75zzwe0LiP rIgQD27BgwHVr8CrMuSYgDcJPm6As+f7eQFI7GAcNTAsZ7FhiptxLTqipML+HBr9HZBx 4ywoUGQbwP0i5W8/v8BddPWBLVKoKx6z+N5g0Sjpp4rMJqSNmEBvzeAkbABKQ0KHH8J+ DHSQ== X-Gm-Message-State: APjAAAXm480PYGXqH29TUQdaYZMAFBdpHWWP8dURiL4b+7hARY9KkOCy l58qcUWralQRyDYxriNrEm0= X-Google-Smtp-Source: APXvYqyQnvg8Py+MKDYQXpWMnCMsDc6EF7EvbjhkDKZjxymFOQc4LW8xcV9OzKolGX+FQL6nD91TwQ== X-Received: by 2002:adf:e747:: with SMTP id c7mr12493812wrn.384.1572644434562; Fri, 01 Nov 2019 14:40:34 -0700 (PDT) Received: from little-buster (alyon-655-1-684-117.w109-213.abo.wanadoo.fr. [109.213.245.117]) by smtp.gmail.com with ESMTPSA id y3sm12477822wro.36.2019.11.01.14.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 14:40:33 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: bug-gnu-emacs@gnu.org Subject: 27.0.50; icomplete sometimes fails to show completions after backward-killing words Date: Fri, 01 Nov 2019 22:40:10 +0100 Message-ID: <874kznwa11.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::434 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, tl;dr unless I'm mistaken, sometimes `while-no-input' returns t despite no input having arrived; this prevents `icomplete-exhibit' from displaying completion candidates. In more details: This is a bit of a heisenbug; hopefully someone out there will know what knobs to tweak to find more information about this. >From emacs -Q: M-x icomplete-mode RET ;; Find a way to set `default-directory' to some long-ish path, ;; e.g. with: M-x find-library RET icomplete RET C-x C-f ;; icomplete should show a bunch of completions. M-DEL M-DEL =E2=80=A6 After each `backward-kill-word', icomplete usually displays new completion candidates with no further user input; sometimes however, no candidates show up until the user does something (e.g. press TAB or start typing). Commit 5860fd3 (Make icomplete-exhibit actually work when navigating up directories) tried to fix this, but AFAICT it merely reduces the odds of the bug happening: I can still reproduce it, although less often. Also, this new call to `redisplay' causes some noticeable flickering when typing characters: the completions blink in and out as I fill in the prompt. I've tinkered with icomplete.el (commenting out the call to `redisplay' since it makes the bug harder to trigger); the closest I got to pin-pointing the cause for this issue was while goofing around in `icomplete-exhibit', specifically with the `while-no-input' part: (let* (=E2=80=A6 (text (while-no-input (icomplete-completions =E2=80=A6))) =E2=80=A6) ;; Do nothing if while-no-input was aborted. (when (stringp text) update overlay=E2=80=A6)) I replaced (when (stringp text) =E2=80=A6) with (if (stringp text) (progn = =E2=80=A6) (message "text is %s" text)): it seems that text is t when icomplete fails to show updated candidates, which according to `while-no-input' means that some input arrived=E2=80=A6 However, when I tried to debug `while-no-input', I got stumped: I tried to do some more printf-debugging[1], but all I observe is that sometimes, the code seems to be interrupted between (let ((throw-on-input ',catch-sym) val) and (setq val (or (input-pending-p) (progn ,@body))) I tried to find where exactly the code gets interrupted, but I could not get a consistent answer; sometimes it seems to be before executing body, sometimes it seems to be somewhere inside `icomplete-completions'=E2=80=A6 What would be the best way to investigate this further? Thank you for your time. [1] With this patch: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=icomplete-debug.patch diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 02eae55a19..31023d5644 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -399,8 +399,6 @@ icomplete-exhibit See `icomplete-mode' and `minibuffer-setup-hook'." (when (and icomplete-mode (icomplete-simple-completing-p)) ;Shouldn't be necessary. - (redisplay) ; FIXME: why is this sometimes needed when moving - ; up dirs in a file-finding table? (save-excursion (goto-char (point-max)) ; Insert the match-status information: @@ -430,13 +428,15 @@ icomplete-exhibit (buffer-undo-list t) deactivate-mark) ;; Do nothing if while-no-input was aborted. - (when (stringp text) - (move-overlay icomplete-overlay (point) (point) (current-buffer)) - ;; The current C cursor code doesn't know to use the overlay's - ;; marker's stickiness to figure out whether to place the cursor - ;; before or after the string, so let's spoon-feed it the pos. - (put-text-property 0 1 'cursor t text) - (overlay-put icomplete-overlay 'after-string text))))))) + (if (stringp text) + (progn + (move-overlay icomplete-overlay (point) (point) (current-buffer)) + ;; The current C cursor code doesn't know to use the overlay's + ;; marker's stickiness to figure out whether to place the cursor + ;; before or after the string, so let's spoon-feed it the pos. + (put-text-property 0 1 'cursor t text) + (overlay-put icomplete-overlay 'after-string text)) + (message "text is %s" text))))))) ;;;_ > icomplete-completions (name candidates predicate require-match) (defun icomplete-completions (name candidates predicate require-match) diff --git a/lisp/subr.el b/lisp/subr.el index b408ef0931..3610fe30f2 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -3727,11 +3727,14 @@ while-no-input (declare (debug t) (indent 0)) (let ((catch-sym (make-symbol "input"))) `(with-local-quit + (message "after with-local-quit") (catch ',catch-sym (let ((throw-on-input ',catch-sym) val) + (message "after catch and let") (setq val (or (input-pending-p) (progn ,@body))) + (message "after setq val") (cond ;; When input arrives while throw-on-input is non-nil, ;; kbd_buffer_store_buffered_event sets quit-flag to the @@ -3746,13 +3749,17 @@ while-no-input ;; such as discarding input etc. We return t in that case ;; because input did arrive during execution of BODY. ((eq quit-flag throw-on-input) + (message "cond: got input") (setq quit-flag nil) t) ;; This is for when the user actually QUITs during ;; execution of BODY. (quit-flag + (message "cond: got quit-flag %s" quit-flag) nil) - (t val))))))) + (t + (message "cond: return val") + val))))))) (defmacro condition-case-unless-debug (var bodyform &rest handlers) "Like `condition-case' except that it does not prevent debugging. --=-=-= Content-Type: text/plain When the bug happens, I get the following messages: after with-local-quit after catch and let text is t PS: It just occured to me that I should search debbugs for "while-no-input" in addition to "icomplete". I just did that; bug#15042 looks like it could maybe be related? In GNU Emacs 27.0.50 (build 6, i686-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2019-10-21 built on little-buster Repository revision: 61fb5214816ef3d57e676d900e499ffcd079a1f9 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Configured using: 'configure --with-xwidgets --with-cairo' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER LCMS2 GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 01 19:28:51 2019 Received: (at submit) by debbugs.gnu.org; 1 Nov 2019 23:28:51 +0000 Received: from localhost ([127.0.0.1]:57544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQgLb-00009r-4l for submit@debbugs.gnu.org; Fri, 01 Nov 2019 19:28:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:55529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQgLY-00009j-Ul for submit@debbugs.gnu.org; Fri, 01 Nov 2019 19:28:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54588) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQgLW-0006Gl-Jr for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 19:28:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQgLU-0005c8-6I for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 19:28:46 -0400 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]:45360) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQgLT-0005Yn-Tr for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 19:28:44 -0400 Received: by mail-io1-xd41.google.com with SMTP id s17so12564769iol.12 for ; Fri, 01 Nov 2019 16:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wLZW51ZyvT64ubgu+xFbnOHNHO0cvkjyFMMsaVcJhCU=; b=nq0xB9cOkSiqQo8+V55/Vybme9eLu35PC0p9ptkqwlyayHUJZ7Mtkxi4cpzh6qI40y rJb0QODrc5qDbLkaWf0deKHB7o0PVdoEEKgCxClFA0gvPxlAuGllZwAai6zDxmO0xkPX ZrqoR3ojnQXXIYB/gN50/zzq3W9NNueZ5nP26WembInNT8c8quX7ozXyAy3jwVxdQ43N RXzDZ5QAwjd9abJO3DW+EahynT1uhJG68fXBE7nBuX9LRiZu7Yr/ZSx7EgtiezcLL/1l BE/686D3xfaOYGsA3paPW5lVmRjqQbkceBc+d8mLDL6U8Gj+ECUtfOqmhGYoc3/wAQ9b v4cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wLZW51ZyvT64ubgu+xFbnOHNHO0cvkjyFMMsaVcJhCU=; b=qXgx3OUagdbBQuirenqxUW6c8o1q8geUFBGo+kuoCekXHdgjcFKBjf0GdblTHom1+9 F8P4USvQymfpkME1TZZwEMPt8kGl5Yuzac27m1GixZYpwM5hwJfWHzJhNfA8x8XNsPcR kF5l+FZDJpfT+X4EWAaWq4rJLm/wSeQgAUK/cwDDiW6l67rlynSVlURx5OZsBkx6YKP7 u9w2wpo3G8Hl2pbv5s6DfV8tpazz9v6X5CcnH/2K4Ty7jLJ7XIWRHdsMG99fjk+6A34r FZXbNKRfRrT7tA7K6mIpUXKI5PWZHDGpSMVhNpOEy1FtvDQTw4vcfN4AJz+dMkG3ewuu l6yw== X-Gm-Message-State: APjAAAUA7ShroOzAuZWra1627PYKy8httBxCoeKAnaTpCQ8ntH9A5Lsq LvyQViMEWf7M2sIyOYaJ0DS6Uv6JoD1UVFUiAvo= X-Google-Smtp-Source: APXvYqytn8lB/blE+SMdOmICa2xLfmPmEClVyCt/LWIykbEGq0bZw+ASF4hO++2UOnKsIujFmx6+1puSiBjEiinRhJg= X-Received: by 2002:a6b:ea0b:: with SMTP id m11mr12170055ioc.97.1572650922227; Fri, 01 Nov 2019 16:28:42 -0700 (PDT) MIME-Version: 1.0 References: <874kznwa11.fsf@gmail.com> In-Reply-To: <874kznwa11.fsf@gmail.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 1 Nov 2019 23:28:30 +0000 Message-ID: Subject: Re: 27.0.50; icomplete sometimes fails to show completions after backward-killing words To: =?UTF-8?Q?K=C3=A9vin_Le_Gouguec?= Content-Type: multipart/alternative; boundary="000000000000933d330596515378" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d41 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000933d330596515378 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Kevin, you're on the right track. The redisplay thing is not the right fix, indeed. Stefan has a fix for this, which he sent me, but I can't find it now. Anyway, it has to do with avoiding the 'select' event in while-no-input. In case you want to try that before Stefan drops by. Jo=C3=A3o On Fri, Nov 1, 2019, 21:40 K=C3=A9vin Le Gouguec wrote: > Hello, > > tl;dr unless I'm mistaken, sometimes `while-no-input' returns t despite > no input having arrived; this prevents `icomplete-exhibit' from > displaying completion candidates. > > In more details: > > This is a bit of a heisenbug; hopefully someone out there will know what > knobs to tweak to find more information about this. > > From emacs -Q: > > M-x icomplete-mode RET > ;; Find a way to set `default-directory' to some long-ish path, > ;; e.g. with: > M-x find-library RET icomplete RET > C-x C-f > ;; icomplete should show a bunch of completions. > M-DEL > M-DEL > =E2=80=A6 > > After each `backward-kill-word', icomplete usually displays new > completion candidates with no further user input; sometimes however, no > candidates show up until the user does something (e.g. press TAB or > start typing). > > Commit 5860fd3 (Make icomplete-exhibit actually work when navigating up > directories) tried to fix this, but AFAICT it merely reduces the odds of > the bug happening: I can still reproduce it, although less often. Also, > this new call to `redisplay' causes some noticeable flickering when > typing characters: the completions blink in and out as I fill in the > prompt. > > I've tinkered with icomplete.el (commenting out the call to `redisplay' > since it makes the bug harder to trigger); the closest I got to > pin-pointing the cause for this issue was while goofing around in > `icomplete-exhibit', specifically with the `while-no-input' part: > > (let* (=E2=80=A6 > (text (while-no-input > (icomplete-completions > =E2=80=A6))) > =E2=80=A6) > ;; Do nothing if while-no-input was aborted. > (when (stringp text) > update overlay=E2=80=A6)) > > I replaced (when (stringp text) =E2=80=A6) with (if (stringp text) (progn= =E2=80=A6) > (message "text is %s" text)): it seems that text is t when icomplete > fails to show updated candidates, which according to `while-no-input' > means that some input arrived=E2=80=A6 > > However, when I tried to debug `while-no-input', I got stumped: I tried > to do some more printf-debugging[1], but all I observe is that > sometimes, the code seems to be interrupted between > > (let ((throw-on-input ',catch-sym) > val) > and > (setq val (or (input-pending-p) > (progn ,@body))) > > I tried to find where exactly the code gets interrupted, but I could not > get a consistent answer; sometimes it seems to be before executing body, > sometimes it seems to be somewhere inside `icomplete-completions'=E2=80= =A6 > > What would be the best way to investigate this further? > > Thank you for your time. > > > [1] With this patch: > > > When the bug happens, I get the following messages: > > after with-local-quit > after catch and let > text is t > > > PS: It just occured to me that I should search debbugs for > "while-no-input" in addition to "icomplete". I just did that; > bug#15042 looks like it could maybe be related? > > > In GNU Emacs 27.0.50 (build 6, i686-pc-linux-gnu, GTK+ Version 3.24.5, > cairo version 1.16.0) > of 2019-10-21 built on little-buster > Repository revision: 61fb5214816ef3d57e676d900e499ffcd079a1f9 > Repository branch: master > Windowing system distributor 'The X.Org Foundation', version 11.0.1200400= 0 > System Description: Debian GNU/Linux 10 (buster) > > Configured using: > 'configure --with-xwidgets --with-cairo' > > Configured features: > XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY > INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF > ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS > LIBSYSTEMD JSON PDUMPER LCMS2 GMP > > Important settings: > value of $LANG: en_US.UTF-8 > locale-coding-system: utf-8-unix > --000000000000933d330596515378 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Kevin, you're on the right track. The redisplay thing= is not the right fix, indeed. Stefan has a fix for this, which he sent me,= but I can't find it now.

= Anyway, it has to do with avoiding the 'select' event in while-no-i= nput.=C2=A0

In case you = want to try that before Stefan drops by.

<= div dir=3D"auto">Jo=C3=A3o

On Fri, Nov 1, 2019, 21:40 K=C3=A9vin Le Go= uguec <kevin.legouguec@gmail.com> wrote:
Hello,

tl;dr unless I'm mistaken, sometimes `while-no-input' returns t des= pite
no input having arrived; this prevents `icomplete-exhibit' from
displaying completion candidates.

In more details:

This is a bit of a heisenbug; hopefully someone out there will know what knobs to tweak to find more information about this.

>From emacs -Q:

=C2=A0 =C2=A0 M-x icomplete-mode RET
=C2=A0 =C2=A0 ;; Find a way to set `default-directory' to some long-ish= path,
=C2=A0 =C2=A0 ;; e.g. with:
=C2=A0 =C2=A0 M-x find-library RET icomplete RET
=C2=A0 =C2=A0 C-x C-f
=C2=A0 =C2=A0 ;; icomplete should show a bunch of completions.
=C2=A0 =C2=A0 M-DEL
=C2=A0 =C2=A0 M-DEL
=C2=A0 =C2=A0 =E2=80=A6

After each `backward-kill-word', icomplete usually displays new
completion candidates with no further user input; sometimes however, no
candidates show up until the user does something (e.g. press TAB or
start typing).

Commit 5860fd3 (Make icomplete-exhibit actually work when navigating up
directories) tried to fix this, but AFAICT it merely reduces the odds of the bug happening: I can still reproduce it, although less often.=C2=A0 Als= o,
this new call to `redisplay' causes some noticeable flickering when
typing characters: the completions blink in and out as I fill in the
prompt.

I've tinkered with icomplete.el (commenting out the call to `redisplay&= #39;
since it makes the bug harder to trigger); the closest I got to
pin-pointing the cause for this issue was while goofing around in
`icomplete-exhibit', specifically with the `while-no-input' part:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (let* (=E2=80=A6
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(text (while-= no-input
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0(icomplete-completions
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =E2=80=A6)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=E2=80=A6) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; Do nothing if while-no-input w= as aborted.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (when (stringp text)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 update overlay=E2=80=A6))<= br>
I replaced (when (stringp text) =E2=80=A6) with (if (stringp text) (progn = =E2=80=A6)
(message "text is %s" text)): it seems that text is t when icompl= ete
fails to show updated candidates, which according to `while-no-input' means that some input arrived=E2=80=A6

However, when I tried to debug `while-no-input', I got stumped: I tried=
to do some more printf-debugging[1], but all I observe is that
sometimes, the code seems to be interrupted between

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((throw-on-input ',catch-sym) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0val)
and
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq val (or (input-pending-p) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0(progn ,@body)))

I tried to find where exactly the code gets interrupted, but I could not get a consistent answer; sometimes it seems to be before executing body, sometimes it seems to be somewhere inside `icomplete-completions'=E2=80= =A6

What would be the best way to investigate this further?

Thank you for your time.


[1] With this patch:


When the bug happens, I get the following messages:

=C2=A0 =C2=A0 after with-local-quit
=C2=A0 =C2=A0 after catch and let
=C2=A0 =C2=A0 text is t


PS: It just occured to me that I should search debbugs for
=C2=A0 =C2=A0 "while-no-input" in addition to "icomplete&quo= t;.=C2=A0 I just did that;
=C2=A0 =C2=A0 bug#15042 looks like it could maybe be related?


In GNU Emacs 27.0.50 (build 6, i686-pc-linux-gnu, GTK+ Version 3.24.5, cair= o version 1.16.0)
=C2=A0of 2019-10-21 built on little-buster
Repository revision: 61fb5214816ef3d57e676d900e499ffcd079a1f9
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.1= 2004000
System Description: Debian GNU/Linux 10 (buster)

Configured using:
=C2=A0'configure --with-xwidgets --with-cairo'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS
LIBSYSTEMD JSON PDUMPER LCMS2 GMP

Important settings:
=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0 locale-coding-system: utf-8-unix
--000000000000933d330596515378-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 01 23:05:34 2019 Received: (at 38024) by debbugs.gnu.org; 2 Nov 2019 03:05:34 +0000 Received: from localhost ([127.0.0.1]:57907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQjjJ-0001ql-V3 for submit@debbugs.gnu.org; Fri, 01 Nov 2019 23:05:34 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQjjF-0001qR-3v for 38024@debbugs.gnu.org; Fri, 01 Nov 2019 23:05:29 -0400 Received: by mail-wr1-f67.google.com with SMTP id o28so11330793wro.7 for <38024@debbugs.gnu.org>; Fri, 01 Nov 2019 20:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=05Z2O4AkdK+AhwCJmKxjIgDJGw3JpX7tIT8I+fog1KA=; b=jijAI00nRRYWKrygohnm42GLUmFINypnsegRSIfvG7BnAfHxmoLl5ZltgSvL7/kliz x3qCX48iBpQletzfcc5mPr4bw6q7/oFiLHeF9lDoob2xqGfutC6C7qhahSZLX5Szxi0x E2Te1LiVqHWalNbBx/f5dKdFZwNnyTLgqxY4uEq6r/s1ikw7/aMiSteLzt5IFIyWOjzx EiYW6fzNMvhVmvokbzKEQRuiMsiKZigJ3Bhd3Oh7s9R2lnBQZMZrMWLTeNkT+GHFcpkw q5HdofUTqo8PsH5Cr++GCmQXV0bZa3/+XkBZ2BjmvdM8tGjLUIdYc/CWE/Gfe83+2FXx 0wAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=05Z2O4AkdK+AhwCJmKxjIgDJGw3JpX7tIT8I+fog1KA=; b=a2ABcgaIERLeM0b8k3iRfBj0X4geF5miJ/cqS17sdkyxoeiw/Wu5JQ45oNao4LEUaY PiKvmyinrB4bNTOWAjuJamZ8J77SlQBPAMa8ZdrxIGGsq2NCiVksfhyYSWxAm8c0lMRS 0TyHnBhS6Nu6Qv8LYTFrf4WyiiteNU490j3mV0KTjzOtjwTnGA7sGjcIGaMqxD/+kcVm lnSMZZHnseNEe9qsNqez15pDsRanolztXajrjj7fP/JhF4o51F1tW8f29P/qsYAsbbsm u6+bF2BPw6eS9tzqkjBGUvtEJMCn07xKJ+ys5Rsm8JY4LcdWtdwblRteRsjXPSITo7xB a6AA== X-Gm-Message-State: APjAAAUyUwR22khFkt8y/RTDgB23CYuNT4TPUMvkNPv9wwzFIY21j8VG bXWU3W3DGuS+kMH7/UNACWc= X-Google-Smtp-Source: APXvYqyW6eYBBpa6iZpZAOzEG65opi8rOSqz5ZZP/2xZZL56Shsc05yWmuZ45sjOnLM/TGT53jKMHQ== X-Received: by 2002:adf:e4c5:: with SMTP id v5mr13837603wrm.106.1572663923299; Fri, 01 Nov 2019 20:05:23 -0700 (PDT) Received: from lolita.yourcompany.com (89-180-151-213.net.novis.pt. [89.180.151.213]) by smtp.gmail.com with ESMTPSA id t24sm13420055wra.55.2019.11.01.20.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 20:05:21 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: 27.0.50; icomplete sometimes fails to show completions after backward-killing words References: <874kznwa11.fsf@gmail.com> Date: Sat, 02 Nov 2019 03:05:17 +0000 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Fri, 1 Nov 2019 23:28:30 +0000") Message-ID: <8736f7nfki.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38024 Cc: 38024@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > Kevin, you're on the right track. The redisplay thing is not the right > fix, indeed. Stefan has a fix for this, which he sent me, but I can't > find it now. > > Anyway, it has to do with avoiding the 'select' event in > while-no-input. Hi K=C3=A9vin, In the meantime, I found the patch and pushed it right away. It worked better than the redisplay hack I had pushed before. The commit you want to test with is 730e7da7ba6a4b545176ea246653928edb10cff4 Let me know how it works for you, Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 03:37:57 2019 Received: (at 38024) by debbugs.gnu.org; 2 Nov 2019 07:37:57 +0000 Received: from localhost ([127.0.0.1]:58027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQnyv-0000YE-13 for submit@debbugs.gnu.org; Sat, 02 Nov 2019 03:37:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQnyr-0000Xx-KH for 38024@debbugs.gnu.org; Sat, 02 Nov 2019 03:37:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iQnym-0000qE-5i; Sat, 02 Nov 2019 03:37:48 -0400 Received: from [176.228.60.248] (port=1721 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iQnyl-0001Jd-Dg; Sat, 02 Nov 2019 03:37:47 -0400 Date: Sat, 02 Nov 2019 09:37:52 +0200 Message-Id: <83o8xuk9tb.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-reply-to: <8736f7nfki.fsf@gmail.com> (message from =?utf-8?B?Sm/Do28g?= =?utf-8?B?VMOhdm9yYQ==?= on Sat, 02 Nov 2019 03:05:17 +0000) Subject: Re: bug#38024: 27.0.50; icomplete sometimes fails to show completions after backward-killing words References: <874kznwa11.fsf@gmail.com> <8736f7nfki.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38024 Cc: 38024@debbugs.gnu.org, monnier@iro.umontreal.ca, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Sat, 02 Nov 2019 03:05:17 +0000 > Cc: 38024@debbugs.gnu.org, Stefan Monnier > > João Távora writes: > > > Kevin, you're on the right track. The redisplay thing is not the right > > fix, indeed. Stefan has a fix for this, which he sent me, but I can't > > find it now. > > > > Anyway, it has to do with avoiding the 'select' event in > > while-no-input. > > Hi Kévin, > > In the meantime, I found the patch and pushed it right away. It worked > better than the redisplay hack I had pushed before. > > The commit you want to test with is > 730e7da7ba6a4b545176ea246653928edb10cff4 The current master displays this warning when byte-compiling icomplete.el: ELC icomplete.elc In end of data: icomplete.el:669:1:Warning: the function `while-no-input-ignore-events' is not known to be defined. while-no-input-ignore-events is not a function, it's a variable. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 07:12:22 2019 Received: (at 38024) by debbugs.gnu.org; 2 Nov 2019 11:12:22 +0000 Received: from localhost ([127.0.0.1]:58275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQrKQ-0001xF-EC for submit@debbugs.gnu.org; Sat, 02 Nov 2019 07:12:22 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:36813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQrKM-0001ws-02 for 38024@debbugs.gnu.org; Sat, 02 Nov 2019 07:12:18 -0400 Received: by mail-wr1-f43.google.com with SMTP id w18so12127291wrt.3 for <38024@debbugs.gnu.org>; Sat, 02 Nov 2019 04:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=kMImBjQDI9GhMHotc73dKU8bEWfxRmsyry9kOHJgrUk=; b=GBzjWrPqXTdMqWpWTTOZEiklhv3geZP1jn6nnJcKWFDJIzGoWJwmLHv+wC+HE54d71 6oV2/KFUvgIWb/usYJAJMViEKdWppjtjjsXDXpygGJfeC9dxhuY+dB0+YqbMrEgujVRi tfXDRZDCb2/1Nzc4JwL5Wv8j730mD9vtY5jXQ9/oZISqXEAgSLwu1kPSXdRob0t6DBEp YgFbNNI+BuuLNctsPpsOFtfBNKQ8qxJ40IlvlhHG7F68AUZV+neTebqql4ta53SHD2a7 y17pdSwliuHor3OUNMcIg/JcjOcJ51lfXpSixQoi6cEcyqsHFa2LLhvpbeJ/s+TG2eZR +tEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=kMImBjQDI9GhMHotc73dKU8bEWfxRmsyry9kOHJgrUk=; b=Wug3aZ+b/cRUHfhnO66CLBsqW5yXugj6mc8FlrhtyJ7qLombw52kR2UVjAO7qPQW+a yOmW7lKCsiuCVJB5JymG2YSBBFksgFryEYd8etP8Y7DS3O7oNOZZ9GhXA9prKeJBH9Xk EX6NpBrJK2R2YaqONAQrWRp5axlY9D7ydMl1Mb/NGUEumMf2dtswhktjdhFCi4KaRqWc Yoa8xtl1cWdYm8Kj7E6GLz9VzQhEt1oS6hb37028bda3GrY4iHJk7J+7+jEdi02IQ1Km /oiu8Ml34BfTCRolNALpIaTVQ5o3WdUUtAhync916L53Rew4fMCc2icq/vUH4n/jFojJ c98A== X-Gm-Message-State: APjAAAUlcAH+MUWq+igsraGgigH/wdr0RsQEZ3KQR+2gqKt6yXTraRyA sX0PpUGUCwp2UjeT786qlf0= X-Google-Smtp-Source: APXvYqxheDNkkr2l5Qb69C9hlZf1JCeqOtB6jydAryy1wOt9iOFVq770HbeM+BmomSNmhuqbn52zqQ== X-Received: by 2002:a5d:4f8b:: with SMTP id d11mr15378700wru.25.1572693131163; Sat, 02 Nov 2019 04:12:11 -0700 (PDT) Received: from lolita.yourcompany.com ([89.180.146.118]) by smtp.gmail.com with ESMTPSA id f13sm9688441wrq.96.2019.11.02.04.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2019 04:12:10 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Eli Zaretskii Subject: Re: bug#38024: 27.0.50; icomplete sometimes fails to show completions after backward-killing words References: <874kznwa11.fsf@gmail.com> <8736f7nfki.fsf@gmail.com> <83o8xuk9tb.fsf@gnu.org> Date: Sat, 02 Nov 2019 11:12:07 +0000 In-Reply-To: <83o8xuk9tb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Nov 2019 09:37:52 +0200") Message-ID: <87y2wymt14.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38024 Cc: 38024@debbugs.gnu.org, monnier@iro.umontreal.ca, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > In end of data: > icomplete.el:669:1:Warning: the function `while-no-input-ignore-events'= is not > known to be defined. > > while-no-input-ignore-events is not a function, it's a variable. Sorry, This was a merge blunder when reordering commits. The reference appears again in the corrct variable form below. I've now fixed the problem in 6911ef3da69333cb7adc1a7fb0a0fc001220a0c4. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 09:07:41 2019 Received: (at 38024) by debbugs.gnu.org; 2 Nov 2019 13:07:41 +0000 Received: from localhost ([127.0.0.1]:58649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQt81-0002eA-2g for submit@debbugs.gnu.org; Sat, 02 Nov 2019 09:07:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQt7z-0002dt-JG for 38024@debbugs.gnu.org; Sat, 02 Nov 2019 09:07:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iQt7u-0004XK-6G; Sat, 02 Nov 2019 09:07:34 -0400 Received: from [176.228.60.248] (port=2380 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iQt7g-0007x1-SD; Sat, 02 Nov 2019 09:07:25 -0400 Date: Sat, 02 Nov 2019 15:07:26 +0200 Message-Id: <8336f6juk1.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-reply-to: <87y2wymt14.fsf@gmail.com> (message from =?utf-8?B?Sm/Do28g?= =?utf-8?B?VMOhdm9yYQ==?= on Sat, 02 Nov 2019 11:12:07 +0000) Subject: Re: bug#38024: 27.0.50; icomplete sometimes fails to show completions after backward-killing words References: <874kznwa11.fsf@gmail.com> <8736f7nfki.fsf@gmail.com> <83o8xuk9tb.fsf@gnu.org> <87y2wymt14.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38024 Cc: 38024@debbugs.gnu.org, monnier@iro.umontreal.ca, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Cc: kevin.legouguec@gmail.com, 38024@debbugs.gnu.org, > monnier@iro.umontreal.ca > Date: Sat, 02 Nov 2019 11:12:07 +0000 > > > while-no-input-ignore-events is not a function, it's a variable. > > Sorry, > > This was a merge blunder when reordering commits. The reference appears > again in the corrct variable form below. I've now fixed the problem in > 6911ef3da69333cb7adc1a7fb0a0fc001220a0c4. Thanks, compiles cleanly now. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 03 05:25:59 2019 Received: (at 38024-done) by debbugs.gnu.org; 3 Nov 2019 10:25:59 +0000 Received: from localhost ([127.0.0.1]:33415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRD55-0004el-Fk for submit@debbugs.gnu.org; Sun, 03 Nov 2019 05:25:59 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:54658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRD53-0004eW-Hh for 38024-done@debbugs.gnu.org; Sun, 03 Nov 2019 05:25:57 -0500 Received: by mail-wm1-f68.google.com with SMTP id z26so425252wmi.4 for <38024-done@debbugs.gnu.org>; Sun, 03 Nov 2019 02:25:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=oNHMUPC5BoAxUXYnNXjNZndXxXteGyU0pY/WwZGjZlA=; b=FPKB0S1BTMR3numPID4+lEPrB6EmUcFRVZ6ON/NhAAetyBbXUGyB5MSLyR6pouXfyn +ZeUAgcyv4Q3rPxPSaoHNld35bs5u9L0m8tT8deccxDmcDq7wXUsliuH0Ci0kSCh+boN vVwvun+9fCAJ2u0f7wGTJLyVPNVe8kKb9I60zvIkLAD8FNSd8wQ5NzR0V9wZHnf67i2j iGTsgwpmp4yPPXMKWAs2QK/L5H3XaF5zdVbfq6VbvYe8FS20fxz4c/EVB7AvABjZljp1 KOfB40QbBPODQyRpw+ZjpTIoECru9mJa5o20oiRJlIiULuuhejRAdpi9tCsSx+GVxh4V WHrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=oNHMUPC5BoAxUXYnNXjNZndXxXteGyU0pY/WwZGjZlA=; b=iBnIt723rNM0mvRNp7h5+1+DXQsEXipuTq0J6kkquyuqGm1s1EwVQfqO3EJa+XZpmy OCc46vwJYtNMhLKL0/kL83Wh6OTIIcrbVuOAqrKm5Se/ymkJy5gIAlfATwA1zY/YjT2k JfHuhDruf65cS2Q5DMbyvsrMhicom4NLmP8IBqjKYMi2RhceR1GQ4c2KCL13PnSiqk1H UVhtCY400fEC7eZS3gzDoD/I9I68b6UkSdcT3hwsc1J+UkvelrRTvx7ga5rI4WftIkww OYyRQkt86yxUwejh6iwOXv3DBPyYvGDukMYg7ayp8lAJYYwNWwZurEqjW4pNJtq38A05 psBw== X-Gm-Message-State: APjAAAWpoWJgkeJdsnA8ffqmJIPQEyBtk6jACt5t1EMsHEKxeHdelhXv PYOyuFWX7FknFeQNgwmkSfA= X-Google-Smtp-Source: APXvYqwu1Ce+xH/M1gKn0iIIodWbbYjoYVj5V9tucHWZt92snKeHIRywi1gOc2WnN2VgQYKjvOBUgA== X-Received: by 2002:a1c:740a:: with SMTP id p10mr2343514wmc.49.1572776751678; Sun, 03 Nov 2019 02:25:51 -0800 (PST) Received: from little-buster ([92.184.112.132]) by smtp.gmail.com with ESMTPSA id z14sm2546124wrl.60.2019.11.03.02.25.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Nov 2019 02:25:50 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Eli Zaretskii Subject: Re: bug#38024: 27.0.50; icomplete sometimes fails to show completions after backward-killing words References: <874kznwa11.fsf@gmail.com> <8736f7nfki.fsf@gmail.com> <83o8xuk9tb.fsf@gnu.org> <87y2wymt14.fsf@gmail.com> <8336f6juk1.fsf@gnu.org> Date: Sun, 03 Nov 2019 11:25:49 +0100 In-Reply-To: <8336f6juk1.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Nov 2019 15:07:26 +0200") Message-ID: <87wochuuhe.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38024-done Cc: 38024-done@debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Thanks, compiles cleanly now. And AFAICT, everything's fine now! (Completions show up no matter how many M-DELs I hit; no more flickering when typing.) Thank you all for working on this; closing (if I'm reading admin/notes/bugtracker correctly). From unknown Sat Aug 16 18:43:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 01 Dec 2019 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 05 16:58:16 2021 Received: (at control) by debbugs.gnu.org; 5 Apr 2021 20:58:16 +0000 Received: from localhost ([127.0.0.1]:38739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTWIa-00059f-Fo for submit@debbugs.gnu.org; Mon, 05 Apr 2021 16:58:16 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTWIY-00059P-2X for control@debbugs.gnu.org; Mon, 05 Apr 2021 16:58:15 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 68CA210021B; Mon, 5 Apr 2021 16:58:08 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F0BC4100068; Mon, 5 Apr 2021 16:58:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1617656286; bh=oFKPrOu61tMpso+KUvwP59kADdcUhBEmSellRD8lJPo=; h=From:To:Subject:References:Date:In-Reply-To:From; b=NcKVXK/WZgMPDMkVILuxMqPg0H/ImYVJ+VMIiPRtqTotq0fJvTMiWaoNS9ptzG9GU YOpj9K88yPJFPxixNzVk29fy3lwUAl3Nd8gT0/cXHIZUnHLM3+8ObUFPnORrQbnlEp 7k8ot81PgRThRzhbufrg6O2iO4HSlwwM5dsVobxFbUjnEVXGfyM15bJfOppfNwpyw1 mzEFp4C+Q0tkbLqjuq2ViF2Yz6/tw1yfWk5NVMT3iCFcMz3HY9inBZSYzzu5e+iOZ5 Zip4Zoq0673+wyX1yDE9cTdn1qfhwK3Dj9jcfB/kQMroLr8h4x1I3KQdmSgHDDrBbV vI7BHf3CE4khA== Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CA14E120169; Mon, 5 Apr 2021 16:58:06 -0400 (EDT) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: Archived problem report bug#38024 (bug#38024: 27.0.50; icomplete sometimes fails to show completions after backward-killing words) Message-ID: References: <874kznwa11.fsf@gmail.com> Date: Mon, 05 Apr 2021 16:58:05 -0400 In-Reply-To: (GNU bug Tracking System's message of "Mon, 05 Apr 2021 19:01:01 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) unarchive 38024 thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 05 16:59:42 2021 Received: (at 38024) by debbugs.gnu.org; 5 Apr 2021 20:59:42 +0000 Received: from localhost ([127.0.0.1]:38745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTWJx-0005CJ-QN for submit@debbugs.gnu.org; Mon, 05 Apr 2021 16:59:42 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTWJw-0005C2-WF for 38024@debbugs.gnu.org; Mon, 05 Apr 2021 16:59:41 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AB99F80055; Mon, 5 Apr 2021 16:59:35 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AFD4680420; Mon, 5 Apr 2021 16:59:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1617656373; bh=IFpCxp/+8iAYgyPoDzqSZcO9KlBd7FmQ375cgBg3Q8g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eH2BVVyKxQKeDuNtD+T/D6QqgQkCoZdLZweC3NUdvLQWMkgnytCN/a9lhbVV6/QVr Hb6oakAo9wAGxVNuM3GMtbVPitRXYAAB0YTIb32qzs+AKPBCPzDUuOezABnIJBmjUr zl1GV7yWZF6bku/K5esbXuuj7vcUu1pedb8Jx9k/TjwOuSdN2oPawx7677GfpMqW8c FfAF5Y4WcNgwQCq22reS11+Fhl31rOfRcptL7O6Z5vYNHsBcCtMaGsmSunmXmmha96 pbjFB45Xa+hU+0mjNPpvdQmHM+bwLx+ek6lPm8qkdLc2pXYHX+Pm8a1zd8zE4ZTeY8 ALGSZ00C31Szg== Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7189112027F; Mon, 5 Apr 2021 16:59:33 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#38024: 27.0.50; icomplete sometimes fails to show completions after backward-killing words Message-ID: References: <874kznwa11.fsf@gmail.com> <8736f7nfki.fsf@gmail.com> <83o8xuk9tb.fsf@gnu.org> <87y2wymt14.fsf@gmail.com> Date: Mon, 05 Apr 2021 16:59:32 -0400 In-Reply-To: <87y2wymt14.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Sat, 02 Nov 2019 11:12:07 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38024 Cc: Daniel Mendler , Eli Zaretskii , 38024@debbugs.gnu.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [ Resending, as usual, since the bug was archived. Sorry. ] Jo=E3o T=E1vora [2019-11-02 11:12:07] wrote: > Eli Zaretskii writes: >> In end of data: >> icomplete.el:669:1:Warning: the function `while-no-input-ignore-events= ' is not >> known to be defined. >> while-no-input-ignore-events is not a function, it's a variable. > Sorry, > This was a merge blunder when reordering commits. The reference appears > again in the corrct variable form below. I've now fixed the problem in > 6911ef3da69333cb7adc1a7fb0a0fc001220a0c4. Hmm... so the patch installed was basically: commit 88f193ed05649b8c622867b8b2623b8cb08fdc96 Author: Jo=E3o T=E1vora Date: Sat Nov 2 02:29:56 2019 +0000 =20=20=20=20 Improve fix for icomplete's backward-kill-word bug#38024 =20=20=20=20=20=20=20=20 * lisp/icomplete.el (icomplete-exhibit): Use while-no-input-ignore-events, not redisplay. =20=20=20=20=20=20=20=20 Co-authored-by: Stefan Monnier =20=20=20=20 diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 02eae55a19..89318ca4c7 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -399,8 +399,6 @@ icomplete-exhibit See `icomplete-mode' and `minibuffer-setup-hook'." (when (and icomplete-mode (icomplete-simple-completing-p)) ;Shouldn't be necessary. - (redisplay) ; FIXME: why is this sometimes needed when moving - ; up dirs in a file-finding table? (save-excursion (goto-char (point-max)) ; Insert the match-status info= rmation: @@ -420,6 +418,11 @@ icomplete-exhibit ;; embarking on computing completions: (sit-for icomplete-compute-delay))) (let* ((field-string (icomplete--field-string)) + ;; Not sure why, but such requests seem to come + ;; every once in a while. It's not fully + ;; deterministic but `C-x C-f M-DEL M-DEL ...' + ;; seems to trigger it fairly often! + (while-no-input-ignore-events '(selection-request)) (text (while-no-input (icomplete-completions field-string but I don't understand why that would help and/or be needed: `selection-request` is (and has been for many years) in the default value of `while-no-input-ignore-events` (as set in `subr.el`), so what this patch ends up doing is forcing `while-no-input` to exit with value t in more cases (i.e. whenever one of the events in (focus-in focus-out help-echo iconify-frame make-frame-visible) comes in) rather than the opposite. What am I missing? Stefan From unknown Sat Aug 16 18:43:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 04 May 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 31 22:34:45 2021 Received: (at control) by debbugs.gnu.org; 1 Nov 2021 02:34:45 +0000 Received: from localhost ([127.0.0.1]:33454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhN9p-0007vV-Gl for submit@debbugs.gnu.org; Sun, 31 Oct 2021 22:34:45 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhN9n-0007vI-Q0 for control@debbugs.gnu.org; Sun, 31 Oct 2021 22:34:44 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 62EF3441D0D; Sun, 31 Oct 2021 22:34:38 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3AA8A441D00; Sun, 31 Oct 2021 22:34:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1635734077; bh=oFKPrOu61tMpso+KUvwP59kADdcUhBEmSellRD8lJPo=; h=From:To:Subject:References:Date:In-Reply-To:From; b=TJeQ6HFiDyyy2DiMWAIXDcZI6yzv409c1lUT8G6g7qLdsAwg4zbCCG4MoYzYwoYkT ugT/ahKTm8gTaH0HWbOu/KLarQaSeg/T6d7/56Nprs/v69AtqtB66azB1klkzzy3E/ mlp0yN9cpGq4l9kx2XxDyDC/SLR8aFYK/H7RLs0o7gXYgiUwRLcV7/Hy985FljunkV AEHLAOpngNhHd72n8NBAI7xHWwHjoL7uKTCDskju58mLLvPFn7IpD4gSR3f6X56s1i 5fclvaX1XG+Ep/dsuYAOqllgpc34cb2b0RyavNiqb1Y6/rgTDdCpE81DGvOm4Qgmav ErfBqIGgfM29A== Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0006A120432; Sun, 31 Oct 2021 22:34:36 -0400 (EDT) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: Archived problem report bug#38024 (bug#38024: 27.0.50; icomplete sometimes fails to show completions after backward-killing words) Message-ID: References: <874kznwa11.fsf@gmail.com> Date: Sun, 31 Oct 2021 22:34:36 -0400 In-Reply-To: (Stefan Monnier's message of "Mon, 05 Apr 2021 16:58:05 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) unarchive 38024 thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 31 22:39:02 2021 Received: (at 38024) by debbugs.gnu.org; 1 Nov 2021 02:39:02 +0000 Received: from localhost ([127.0.0.1]:33466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhNDy-00082Q-1A for submit@debbugs.gnu.org; Sun, 31 Oct 2021 22:39:02 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhNDp-00081l-CS for 38024@debbugs.gnu.org; Sun, 31 Oct 2021 22:39:00 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E5D8C441D00; Sun, 31 Oct 2021 22:38:47 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6F5AE441D0D; Sun, 31 Oct 2021 22:38:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1635734326; bh=9/eLAWq3XDu5MFmJThqNl41/9c3+JxBwCRHBiUE6jxo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=D6qSYwU7d/VXjLNQNOL5Qayzkvx3lKiazkbgUEoxYqFdxTqijyn6ZnJzEoQHFXwfz HtXaPZvg9e6h0JJUgZxm0vhrcNYW+3MWxO24uJM1zkgpEnBct1aDyH/nubW+OGupOO G+6TJsZEeI99/s2QwiXuHTIQtl2T1qX4jNvit5YbJYKxtndsDfHG0qB+Ebn15lPKYV LZ4Q8gaehp6XwbDyo2FYgb2vCyF5mU/nhDmE+NDVPAgCh2WgP+A8sD41kvj95aC4Sq hn8v906CIgrJ+bzt6YQozUTtBClgp0mYbsNdTfHGZTF/m8/qVBBE02cG3h8dhN39v7 ic9xi+ks1fndg== Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 19F90120330; Sun, 31 Oct 2021 22:38:46 -0400 (EDT) From: Stefan Monnier To: Aaron Jensen Subject: Re: Remove icomplete workaround Message-ID: References: Date: Sun, 31 Oct 2021 22:38:45 -0400 In-Reply-To: (Aaron Jensen's message of "Sun, 31 Oct 2021 20:49:23 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38024 Cc: mail@daniel-mendler.de, 38024@debbugs.gnu.org, joaotavora@gmail.com, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Aaron Jensen [2021-10-31 20:49:23] wrote: > Originally added because of: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38024 > > The reason this fixed things was not captured and I can not reproduce > the bug with the fix disabled on master. > > This workaround has been copied to other libraries without clear > understanding of why it existed in the first place and it caused a > problem: https://github.com/minad/vertico/issues/115#issuecomment-947330581 > > Would it be possible to remove it? I'm ccing the original reporter and > fixer in case they are able to shed more light on this or test without > the fix to see if they can reproduce it. > > I've attached a patch if we are good to remove it. Thanks, I just pushed your patch to `master`. We'll see if the problem comes back, and if so, we'll have to try and fix it better. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 31 23:56:08 2021 Received: (at 38024) by debbugs.gnu.org; 1 Nov 2021 03:56:08 +0000 Received: from localhost ([127.0.0.1]:33482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhOQa-0003kX-GC for submit@debbugs.gnu.org; Sun, 31 Oct 2021 23:56:08 -0400 Received: from mail-pl1-f182.google.com ([209.85.214.182]:35750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhOQY-0003k3-Ma for 38024@debbugs.gnu.org; Sun, 31 Oct 2021 23:56:07 -0400 Received: by mail-pl1-f182.google.com with SMTP id n18so10733795plc.2 for <38024@debbugs.gnu.org>; Sun, 31 Oct 2021 20:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MlQuR4uhkdxDae/niNoI0y8V7UHhtakevyGmuvkqkCo=; b=Y14pi0XFR8l5LvtlZLFtpzInMuR0ZvsaZV/t6FEOd/3yyUJ0N1zomj/etQxtDSsuAq rHtJTW/mLaPSRoQaILS+LYFBIJOHzA1t1cyhtU+2TJRBMpe9PRpGFTdsVlZgSAFrxaOv PEYjpKs+m5i+w/Tx4ZV6wDUJDJNEbT7BXbmUWhM5sI/o2t59U3KMimXQl/CbRmAub81s DAoS9clXJJws+TYAXf2X/PqU38BY5UEK2/hPwnveQfY4IRkeJ7N/vTTl8Rf10UtI+opp 7e/JnYIersMdHO+xeozQ2r3DoLdvMcy2sWFVV7x9IZeHu9db1G3W+peY1AdYq7zYjeQh aSgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MlQuR4uhkdxDae/niNoI0y8V7UHhtakevyGmuvkqkCo=; b=cbcgYOvoxhgPNOPdN3N37pqYBD6EIlxSihOBOtJAiBUmyzaAUzLc/uU67a15nPl8uY fa/YGgmV0XjcsTQkpW9InN7nV09d9+WObOEpKHMuYsu9w78dWvCHVyYC7mGDwPIZJ8ui LS4MsBEAitXEwtesBjyqrGe/LKHa9fbe4fUu7tALBTBLtnvT2uf+pNEXgLwfMLQewCaB lghyeWS6Ljeva6mZDkS9ivl+bZu0uPEOIYZ1ch3dahp4BMMnMs76p8LQPZp+UilsHd2k j12rCQCjZ3xT/xPj6HaM0gPF4QpfY8jhRlmy15gm+WjR8SeeUr6oIP9BysOwPKo5ThKw CCTg== X-Gm-Message-State: AOAM532KJnCw51MS8t6DDXh9n2db/SflieAklbNW6iWpDbAF9qLC2ykF 8UIMuDTe3RwyQJSCfkD9oxIiD/34vIJfW9tSnHQ= X-Google-Smtp-Source: ABdhPJxX1pc+kiuf4gFu66wSdS//P9IDt5FYBF8gpo579vRPcsPVfO81oZWYnqRcB2fbOnmdVn5kdJH3kg3rUQPvcds= X-Received: by 2002:a17:90a:c78f:: with SMTP id gn15mr12138666pjb.54.1635738960611; Sun, 31 Oct 2021 20:56:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aaron Jensen Date: Sun, 31 Oct 2021 23:55:49 -0400 Message-ID: Subject: Re: Remove icomplete workaround To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38024 Cc: mail@daniel-mendler.de, 38024@debbugs.gnu.org, joaotavora@gmail.com, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Oct 31, 2021 at 10:38 PM Stefan Monnier wrote: > > Aaron Jensen [2021-10-31 20:49:23] wrote: > > Originally added because of: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38024 > > > > The reason this fixed things was not captured and I can not reproduce > > the bug with the fix disabled on master. > > > > This workaround has been copied to other libraries without clear > > understanding of why it existed in the first place and it caused a > > problem: https://github.com/minad/vertico/issues/115#issuecomment-947330581 > > > > Would it be possible to remove it? I'm ccing the original reporter and > > fixer in case they are able to shed more light on this or test without > > the fix to see if they can reproduce it. > > > > I've attached a patch if we are good to remove it. > > Thanks, I just pushed your patch to `master`. > We'll see if the problem comes back, and if so, we'll have to try and > fix it better. Great, thank you! From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 01 05:28:48 2021 Received: (at 38024) by debbugs.gnu.org; 1 Nov 2021 09:28:49 +0000 Received: from localhost ([127.0.0.1]:33704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhTcW-0008CS-Nc for submit@debbugs.gnu.org; Mon, 01 Nov 2021 05:28:48 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:44852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhTcV-0008CE-Gh for 38024@debbugs.gnu.org; Mon, 01 Nov 2021 05:28:47 -0400 Received: by mail-wr1-f48.google.com with SMTP id d13so27210476wrf.11 for <38024@debbugs.gnu.org>; Mon, 01 Nov 2021 02:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=yEL+mRPeqAWLST8MiRY0wFoW3wPkL8ek/y6WpedJ6ho=; b=pAwH8ypHnqH31FjD5D8ObuXpF24q7c8ZzZHXtOSi8woezeK+aSPKZ9TFGbgpz7S1JV Eo4ayuwUDsdRfRGZy+08s9GA41HYuQHqwOa0vQOWGO8tKu6zZO/gY1AEJBxq/aKHsIhv O3HpIZ3UQCp0lVY7i2FTjxDgfhXkhRSnAm3XxUyRi0+hcPcdX3IVND5fXWNBlHKlJwEP 8rKbp/njpFkkLtgIbXbuT8hx4BDhwo1QFkv4Lt39FsBz9qKHx5eBYz9DRMXiIUrK0tBE 5PT0Ftu0VtSHPrglEzr+/TyNYCo1DCaaJDnrn4rTf6XgjV1/F20ZGrECWYplAGFGxdYl bmTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=yEL+mRPeqAWLST8MiRY0wFoW3wPkL8ek/y6WpedJ6ho=; b=zGB+DuXQeLF/Mne3M3y6s26F+N93ndDIvXjXMuIPL6LeLlfs8TxJIkC6yMuAG9ooYN 9gxRAUqha2b1tbQm54/YOpX0XOWrG4u2gLvyWCVl8bMpKBt+Ut2jWjnbQst/PS9HJR9F sL1cc/rDZQCsKqryqsqgRa0kRBRbU2fFCRQC9jcZQDVBGwC8HJFUNSuKTWEqidVXA0OX hMHQTpbhdXxXP9mLFwXizM+fgDWmkETQQwSnc+tepaiBoCRrJBu66mgSFnUVMuGAFyWB cV89t/2fsfdA9FWoX9NilkEHzMyz4kXzHePgiC0Dp3FUUxjrvVTJaVVcWp1vB/Zd45rO +5DA== X-Gm-Message-State: AOAM5314bPLqMFR+WiVsTa5NQkYjoW7XhCutSe2CfLShNTYpSokhV6qb HcKi412b55Y2jLFPXxUQFry1w6h0oPc= X-Google-Smtp-Source: ABdhPJx2mIVbM/C341Ab6V0bFkDu+EqhxEWZHsWtDHwrnovcaS/Ipy6WsWzzJE6YpZGrNK+EMprvbA== X-Received: by 2002:adf:f448:: with SMTP id f8mr27362842wrp.47.1635758921349; Mon, 01 Nov 2021 02:28:41 -0700 (PDT) Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id n8sm12514965wrp.95.2021.11.01.02.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 02:28:40 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Stefan Monnier Subject: Re: Remove icomplete workaround References: Date: Mon, 01 Nov 2021 10:28:40 +0100 In-Reply-To: (Stefan Monnier's message of "Sun, 31 Oct 2021 22:38:45 -0400") Message-ID: <87ilxckywn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38024 Cc: mail@daniel-mendler.de, 38024@debbugs.gnu.org, joaotavora@gmail.com, Aaron Jensen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hey Aaron, Stefan Monnier writes: > Aaron Jensen [2021-10-31 20:49:23] wrote: >> >> Would it be possible to remove it? I'm ccing the original reporter and >> fixer in case they are able to shed more light on this or test without >> the fix to see if they can reproduce it. >> >> I've attached a patch if we are good to remove it. > > Thanks, I just pushed your patch to `master`. > We'll see if the problem comes back, and if so, we'll have to try and > fix it better. Congrats on your investigation work; I wish I could shed more light on what this workaround was meant to accomplish. I've tried to reproduce my original issue, but so far I was not successful. If my initial report can be trusted, the bug happened (1) back when the development branch was 27.0.50 (commit 61fb521481) (2) on an old battered laptop that I can no longer power on without disturbing loud fan demons. 26.3 no longer compiles on my end[1], so all I could do was try to reproduce on master, where the workaround has been reverted, on other computers I have lying around. The symptoms have not resurfaced yet, so=E2=80=A6 I'll go with a timid, yet hopeful "yay" =F0=9F=99=82 [1] With gcc 11.2.1: sysdep.c:1795:22: error: variably modified =E2=80=98sigsegv_stack=E2=80=99 = at file scope 1795 | static unsigned char sigsegv_stack[SIGSTKSZ]; | ^~~~~~~~~~~~~ From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 01 11:34:16 2021 Received: (at 38024) by debbugs.gnu.org; 1 Nov 2021 15:34:16 +0000 Received: from localhost ([127.0.0.1]:35912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhZJz-00061y-B1 for submit@debbugs.gnu.org; Mon, 01 Nov 2021 11:34:16 -0400 Received: from mail-pl1-f179.google.com ([209.85.214.179]:39589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhZJx-00061U-51 for 38024@debbugs.gnu.org; Mon, 01 Nov 2021 11:34:01 -0400 Received: by mail-pl1-f179.google.com with SMTP id t21so11781737plr.6 for <38024@debbugs.gnu.org>; Mon, 01 Nov 2021 08:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/nUqvropoeN+HLFxoTmGvyG6SiIyWJnF3ezQVYL6q0g=; b=he36mSpAGISc2JeKeuRy7Xst6KFDuTQ0KF64weWpwfWBcUJj08DeWfMS404WUdth58 wbYdNhg4uKoLuDSISM/22omTsU0keWa3OV+gXpu+XvCgzTrdgtdVAQxubgo16bnKRvW5 waowFf2CeZxGIZTFBjPRbqS/CIVgjqbA093fDRd/YYN9/cxnjYjR8Uaa4g4+fUQz/rXu qqyb6W6Z/dGeOSML2xncpbPCM98xYO0p+oeLPgqW681uMXc2OyXi0iNeNvXACc57Ou9I KGEsjhCta3JmLeKmBJpl/h5KyKCwDlPOVyQVQnFoOhZpuhfTZM2/C73JTE+ex/OS5UlP KaBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/nUqvropoeN+HLFxoTmGvyG6SiIyWJnF3ezQVYL6q0g=; b=vN6SxXx/6YoujYUTnXFX/5VWmvcPWe+FAjFpplx1jHTz0cBEu9jaGr89L3dySqUTen APJfAu3Fx5vni7any5vUP1kl9+LT+cXFaeqbBTZ91ulTCC0fxPm3Jbdd70FIPSY53dz2 TpmqaE1zOUuhD8ot0d94VSn7iG/3bAIcbf81Xk2p1WfABhGzI7V4s7kbRu51h65O6W2k JivKTMQJeimm/wQVdw0/q37lPRQ/vPYPKjHkys7WABAxcwFNmLJfDFnMH6DC0JuLWn8l jArs3jF4oGaUGbas9+Y5Fwz58N2O9awehV5oNzIhX/yxe4Hqvvie58ZhX9ELL/o46W3d Aq3A== X-Gm-Message-State: AOAM530bhuMsb52oA3+yPr62MCRB45C1tnnsKPx2ULmpdZQAhA8navLp CJr9/tUcsAMSbcq5xL40sZRlNOvaYMhePDw55y0= X-Google-Smtp-Source: ABdhPJxgDDBNGgHhUSfBvEBIc2pcvaTwt56DxDnzWIQnuwDX3f5rEfOMOEjyjHlQvEKbA+HqnjZPngHlvcHp3hnt2B0= X-Received: by 2002:a17:90a:b795:: with SMTP id m21mr30390202pjr.143.1635780835268; Mon, 01 Nov 2021 08:33:55 -0700 (PDT) MIME-Version: 1.0 References: <87ilxckywn.fsf@gmail.com> In-Reply-To: <87ilxckywn.fsf@gmail.com> From: Aaron Jensen Date: Mon, 1 Nov 2021 11:33:44 -0400 Message-ID: Subject: Re: Remove icomplete workaround To: =?UTF-8?Q?K=C3=A9vin_Le_Gouguec?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38024 Cc: mail@daniel-mendler.de, 38024@debbugs.gnu.org, Stefan Monnier , joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Nov 1, 2021 at 5:28 AM K=C3=A9vin Le Gouguec wrote: > > Hey Aaron, > > Stefan Monnier writes: > > > Aaron Jensen [2021-10-31 20:49:23] wrote: > >> > >> Would it be possible to remove it? I'm ccing the original reporter and > >> fixer in case they are able to shed more light on this or test without > >> the fix to see if they can reproduce it. > >> > >> I've attached a patch if we are good to remove it. > > > > Thanks, I just pushed your patch to `master`. > > We'll see if the problem comes back, and if so, we'll have to try and > > fix it better. > > Congrats on your investigation work; I wish I could shed more light on > what this workaround was meant to accomplish. I've tried to reproduce > my original issue, but so far I was not successful. > > If my initial report can be trusted, the bug happened (1) back when the > development branch was 27.0.50 (commit 61fb521481) (2) on an old > battered laptop that I can no longer power on without disturbing loud > fan demons. > > 26.3 no longer compiles on my end[1], so all I could do was try to > reproduce on master, where the workaround has been reverted, on other > computers I have lying around. The symptoms have not resurfaced yet, > so=E2=80=A6 I'll go with a timid, yet hopeful "yay" =F0=9F=99=82 Thank you for confirming. Hopefully that's the last of it! Best, Aaron From unknown Sat Aug 16 18:43:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 30 Nov 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator