GNU bug report logs - #38013
[PATCH] Rectangular region selection with mouse

Previous Next

Package: emacs;

Reported by: Mattias Engdegård <mattiase <at> acm.org>

Date: Thu, 31 Oct 2019 23:11:01 UTC

Severity: wishlist

Tags: patch

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #155 received at 38013 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: rudalics <at> gmx.at, 38013 <at> debbugs.gnu.org
Subject: Re: bug#38013: [PATCH] Rectangular region selection with mouse
Date: Sat, 23 Nov 2019 13:57:24 +0200

> From: Mattias Engdegård <mattiase <at> acm.org>
> Date: Mon, 18 Nov 2019 19:08:24 +0100
> Cc: rudalics <at> gmx.at, 38013 <at> debbugs.gnu.org
> 
> Here is an updated patch that makes the selection work better with characters that aren't a multiple of the standard font width. 

Thanks, a few minor comments:

> +@defvar fine-grained-mouse-movement

I think this variable's name should start with "mouse-".  Like
mouse-fine-grained-movement or something.

> +    (setq fine-grained-mouse-movement t)

What happens if this function signals an error? won't
fine-grained-mouse-movement be left at its non-nil value?
This bug report was last modified 5 years and 85 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.