GNU bug report logs - #37994
[PATCH] gnu: git: Add PCRE support to "git grep".

Previous Next

Full log

Message #11 received at 37994 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 37994 <at> debbugs.gnu.org
Subject: Re: [bug#37994] [PATCH] gnu: git: Add PCRE support to "git grep".
Date: Wed, 30 Oct 2019 20:53:23 +0100

[Message part 1 (text/plain, inline)]

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> Pierre,
>
> Pierre Neidhardt 写道：
>> * gnu/packages/version-control.scm (git)[inputs]: Add pcre2.
>> [arguments]: Add "USE_LIBPCRE2" to make-flags.
>> (git-minimal)[arguments]: Do not inherit "USE_LIBPCRE2" in 
>> make-flags.
>
> What do you think of removing pcre2 from INPUTS as well?

git-minimal's input is defined explicitly, no need to remove pcre2 since
it's not there.

> I'm a bit worried that upstream will grow auto-detection and/or 
> change the default value of USE_LIBPCRE2 one day, and that would 
> go unnoticed.

Found this: https://stackoverflow.com/a/49826828
Looks like the compile flags are here to stay :)

>> +      ;; For PCRE support in git grep (USE_LIBPCRE2)
>
> Missing ‘.’.

You mean the trailing period?  Actually I just noticed that about half
of those comments in Git have trailing periods.  I can fix it.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.