Subject: Re: [bug#37994] [PATCH] gnu: git: Add PCRE support to "git grep".

From: Tobias Geerinckx-Rice <[email-masked]>
Date: Wed, 30 Oct 2019 18:15:47 +0100

Pierre,

Pierre Neidhardt 写道：
> * gnu/packages/version-control.scm (git)[inputs]: Add pcre2.
> [arguments]: Add "USE_LIBPCRE2" to make-flags.
> (git-minimal)[arguments]: Do not inherit "USE_LIBPCRE2" in 
> make-flags.

What do you think of removing pcre2 from INPUTS as well?

I'm a bit worried that upstream will grow auto-detection and/or 
change the default value of USE_LIBPCRE2 one day, and that would 
go unnoticed.

> +      ;; For PCRE support in git grep (USE_LIBPCRE2)

Missing ‘.’.

Otherwise GTM!

T G-R