From unknown Sat Sep 13 04:54:42 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#37994] [PATCH] gnu: git: Add PCRE support to "git grep". Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Oct 2019 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37994 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 37994@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.157245237411218 (code B ref -1); Wed, 30 Oct 2019 16:20:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Oct 2019 16:19:34 +0000 Received: from localhost ([127.0.0.1]:51347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPqh3-0002us-OT for submit@debbugs.gnu.org; Wed, 30 Oct 2019 12:19:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:60123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPqh1-0002uj-9W for submit@debbugs.gnu.org; Wed, 30 Oct 2019 12:19:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54695) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPqgz-0003NS-E7 for guix-patches@gnu.org; Wed, 30 Oct 2019 12:19:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPqgx-0008QI-Px for guix-patches@gnu.org; Wed, 30 Oct 2019 12:19:28 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:41945) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iPqgx-0008On-Jx for guix-patches@gnu.org; Wed, 30 Oct 2019 12:19:27 -0400 X-Originating-IP: 92.169.151.76 Received: from localhost.localdomain (lfbn-1-4156-76.w92-169.abo.wanadoo.fr [92.169.151.76]) (Authenticated sender: mail@ambrevar.xyz) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 15E8160004 for ; Wed, 30 Oct 2019 16:19:23 +0000 (UTC) From: Pierre Neidhardt Date: Wed, 30 Oct 2019 17:19:13 +0100 Message-Id: <20191030161913.17691-1-mail@ambrevar.xyz> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-GND-Spam-Score: 185 X-GND-Status: SPAM X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.195 X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) * gnu/packages/version-control.scm (git)[inputs]: Add pcre2. [arguments]: Add "USE_LIBPCRE2" to make-flags. (git-minimal)[arguments]: Do not inherit "USE_LIBPCRE2" in make-flags. --- gnu/packages/version-control.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 573fa6f8cc..1dad351ba1 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -183,6 +183,9 @@ as well as the classic centralized workflow.") ;; a problem in 'patch-shebangs'; see . ("bash-for-tests" ,bash) + ;; For PCRE support in git grep (USE_LIBPCRE2) + ("pcre" ,pcre2) + ;; For 'gitweb.cgi' ("perl-cgi" ,perl-cgi) @@ -216,6 +219,8 @@ as well as the classic centralized workflow.") (assoc-ref %build-inputs "bash-for-tests") "/bin/bash") + "USE_LIBPCRE2=yes" + ;; By default 'make install' creates hard links for ;; things in 'libexec/git-core', which leads to huge ;; nars; see . @@ -505,6 +510,8 @@ everything from small to very large projects with speed and efficiency.") (delete-file-recursively (string-append out "/share/gitweb")) #t))))) + ((#:make-flags flags) + `(delete "USE_LIBPCRE2=yes" ,flags)) ((#:configure-flags flags) ''()) ((#:disallowed-references lst '()) -- 2.23.0 From unknown Sat Sep 13 04:54:42 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#37994] [PATCH] gnu: git: Add PCRE support to "git grep". Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Oct 2019 17:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37994 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Neidhardt Cc: 37994@debbugs.gnu.org Received: via spool by 37994-submit@debbugs.gnu.org id=B37994.157245575732208 (code B ref 37994); Wed, 30 Oct 2019 17:16:01 +0000 Received: (at 37994) by debbugs.gnu.org; 30 Oct 2019 17:15:57 +0000 Received: from localhost ([127.0.0.1]:51389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPrZc-0008NQ-PS for submit@debbugs.gnu.org; Wed, 30 Oct 2019 13:15:56 -0400 Received: from tobias.gr ([80.241.217.52]:60436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPrZX-0008ND-37 for 37994@debbugs.gnu.org; Wed, 30 Oct 2019 13:15:55 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 2c483ea8; Wed, 30 Oct 2019 17:15:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=mncvX/xUTB1AdBgXr+syYq Y/XmX+NXVufVS2tsDHDaY=; b=YzQYnG9gdPEz+/ni7nCB5qMD6n59azTXc0KGmq GzMUY+CzSBX6G29EoSB0hHXNP7M1fQBxCb5Ss4CRM8nmDmhWf4X3AmYMgeLlzt4+ BvG7NVMuogqklOt+261Eq5pEyRdWiKGiiGZAX2azRn42RbvHJKVlh+vx58QMrdiH KNtizqM3oeBNnugYuLufUmQTOHxG6qtU0IUgmsytdh0k7LYWrXPTjE3m4Vk9k+ao KZhKN31NwkMbhbOq8Qrhm5rV0kcWVtwSqVYP9zTrC6NVkr/HigPaiu8CN02NGzz6 zF3QHpoerjrmuFVBLHgsMLyQPV+POR+udXSMTWyfNXxXEvzA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 4f5aa33c (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 30 Oct 2019 17:15:48 +0000 (UTC) From: Tobias Geerinckx-Rice References: <20191030161913.17691-1-mail@ambrevar.xyz> In-reply-to: <20191030161913.17691-1-mail@ambrevar.xyz> Date: Wed, 30 Oct 2019 18:15:47 +0100 Message-ID: <874kzqw3wc.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Pierre, Pierre Neidhardt =E5=86=99=E9=81=93=EF=BC=9A > * gnu/packages/version-control.scm (git)[inputs]: Add pcre2. > [arguments]: Add "USE_LIBPCRE2" to make-flags. > (git-minimal)[arguments]: Do not inherit "USE_LIBPCRE2" in=20 > make-flags. What do you think of removing pcre2 from INPUTS as well? I'm a bit worried that upstream will grow auto-detection and/or=20 change the default value of USE_LIBPCRE2 one day, and that would=20 go unnoticed. > + ;; For PCRE support in git grep (USE_LIBPCRE2) Missing =E2=80=98.=E2=80=99. Otherwise GTM! T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl25xUMACgkQ2Imw8BjF STzrKg//YxF0KWIH7kFbN7yqtFhPhaSm4dTVCuuTL+IjY+7QPe4CHP+t8Mk7GrXQ ArOmTbQQM3y9KAApq0jStNpTPOCuSI0f5gjRQ0SyKdzl6kCfgCmnjMx0GRn8HrAC 63JL6dPZfbhEbbSJU9CfE1w0EnlitzLEzkAvhOl8TXiGtpQr+tBNHovTQSEaq9Bx le3V7ZQ/31sNz26GJnMaA5tM7Z+TxL3MDBqSD4ZFuuwJB4N/rEErrG5AG214z19A PNd0wwni3LiPHEaB55a6zDQ0Rl797EPZ7WzTkfocFC4S2np5a2dh2M/7aS5LI9Jk WwHiGIUnfFTOSG26N4kz7vqL8qjPKTBvie/Loosp9Cj7f9OZiJCICDrImMpoSw82 8ACESQ8A2CbimQXeqePF4DA/6aH3nIsLp0tN9IePs2aCX1/Cm7AAfrfuG+EY/hF7 PAC+ZQ+4il/wB0IvcoWQfo5SEnfKpHtCIeJ9qNTKpGqp3Fp5X1ZvtkpOIrzh/QCh N+MGutS6gkdl42v4ksIkxOmyXTQHfe7b743KFbFJucmGRgSJCYICgxEgwmDn9+Hc 2DbHEsS9kJiZ4/JuvGHFRbOQFWdRhaPV/UnZCZdiWZo5/Yo48zkpCENMxSYCWiMu +Y792AV6wQhoySISH2I+3ObEn4tKBIlXuWWoXEH6hX/jSZ8eGJA= =BH+/ -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 13 04:54:42 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#37994] [PATCH] gnu: git: Add PCRE support to "git grep". Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Oct 2019 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37994 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 37994@debbugs.gnu.org Received: via spool by 37994-submit@debbugs.gnu.org id=B37994.157246521130980 (code B ref 37994); Wed, 30 Oct 2019 19:54:02 +0000 Received: (at 37994) by debbugs.gnu.org; 30 Oct 2019 19:53:31 +0000 Received: from localhost ([127.0.0.1]:51530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPu27-00083b-6R for submit@debbugs.gnu.org; Wed, 30 Oct 2019 15:53:31 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:41043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPu22-00083K-Ps for 37994@debbugs.gnu.org; Wed, 30 Oct 2019 15:53:29 -0400 X-Originating-IP: 92.169.151.76 Received: from bababa (lfbn-1-4156-76.w92-169.abo.wanadoo.fr [92.169.151.76]) (Authenticated sender: pierre@atlas.engineer) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 80893FF809; Wed, 30 Oct 2019 19:53:24 +0000 (UTC) From: Pierre Neidhardt In-Reply-To: <874kzqw3wc.fsf@nckx> References: <20191030161913.17691-1-mail@ambrevar.xyz> <874kzqw3wc.fsf@nckx> Date: Wed, 30 Oct 2019 20:53:23 +0100 Message-ID: <87d0ee6mdo.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice writes: > Pierre, > > Pierre Neidhardt =E5=86=99=E9=81=93=EF=BC=9A >> * gnu/packages/version-control.scm (git)[inputs]: Add pcre2. >> [arguments]: Add "USE_LIBPCRE2" to make-flags. >> (git-minimal)[arguments]: Do not inherit "USE_LIBPCRE2" in=20 >> make-flags. > > What do you think of removing pcre2 from INPUTS as well? git-minimal's input is defined explicitly, no need to remove pcre2 since it's not there. > I'm a bit worried that upstream will grow auto-detection and/or=20 > change the default value of USE_LIBPCRE2 one day, and that would=20 > go unnoticed. Found this: https://stackoverflow.com/a/49826828 Looks like the compile flags are here to stay :) >> + ;; For PCRE support in git grep (USE_LIBPCRE2) > > Missing =E2=80=98.=E2=80=99. You mean the trailing period? Actually I just noticed that about half of those comments in Git have trailing periods. I can fix it. =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl256jMACgkQm9z0l6S7 zH9dyAgApT8lTYb7bet9WGsz6aH6pTyV7+dnMsWbJ28qfk9Bi9IOuQvFIFACSUbf cv1LboUE5S1ow3RcaOAqM2OBZOlSfib+ZFV1bJliDcmJ7qMFiEIf0kMbxffVGHnc hzxPYx7+Fm9K2UNqFqXlU0B1q/Kqlvcgvdaxgxowmis+hiRqDi6jYBMx7CqQK1Kb itGvTppRaVjEBWt53tVipUw6MvV2cMD5h6l+Ta7LRqemxPvocEwsKtlPSHV9TlRE Z12LbXtgxhaX0KCgmqgsqjD/nGL0eaTCmf19Pbb8s1KyCPEK1NzVlo+A6sNPjGBX KOCB0kTReptMzqH9u7WsCiql3qHkLw== =0BqG -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 07:52:56 2019 Received: (at control) by debbugs.gnu.org; 2 Nov 2019 11:52:56 +0000 Received: from localhost ([127.0.0.1]:58287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQrxf-000709-SQ for submit@debbugs.gnu.org; Sat, 02 Nov 2019 07:52:56 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:58103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQrxd-000701-Up for control@debbugs.gnu.org; Sat, 02 Nov 2019 07:52:54 -0400 X-Originating-IP: 92.169.151.76 Received: from bababa (lfbn-1-4156-76.w92-169.abo.wanadoo.fr [92.169.151.76]) (Authenticated sender: pierre@atlas.engineer) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id E04D91BF206 for ; Sat, 2 Nov 2019 11:52:51 +0000 (UTC) Date: Sat, 02 Nov 2019 12:52:51 +0100 Message-Id: <87o8xua418.fsf@ambrevar.xyz> To: control@debbugs.gnu.org From: Pierre Neidhardt Subject: control message for bug #37994 X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 37994 quit Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.201 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [217.70.183.201 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) close 37994 quit