From unknown Tue Aug 19 22:01:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#37977 <37977@debbugs.gnu.org> To: bug#37977 <37977@debbugs.gnu.org> Subject: Status: Mount options ignored for root file system Reply-To: bug#37977 <37977@debbugs.gnu.org> Date: Wed, 20 Aug 2025 05:01:01 +0000 retitle 37977 Mount options ignored for root file system reassign 37977 guix submitter 37977 Guillaume Le Vaillant severity 37977 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 29 06:24:19 2019 Received: (at submit) by debbugs.gnu.org; 29 Oct 2019 10:24:19 +0000 Received: from localhost ([127.0.0.1]:46917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPOfj-0002SW-48 for submit@debbugs.gnu.org; Tue, 29 Oct 2019 06:24:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:42040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPOfh-0002SO-5Y for submit@debbugs.gnu.org; Tue, 29 Oct 2019 06:24:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57113) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPOfe-0007Xw-No for bug-guix@gnu.org; Tue, 29 Oct 2019 06:24:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPOfc-0002WM-Qg for bug-guix@gnu.org; Tue, 29 Oct 2019 06:24:13 -0400 Received: from mout01.posteo.de ([185.67.36.65]:51211) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iPOfc-0002Ut-8l for bug-guix@gnu.org; Tue, 29 Oct 2019 06:24:12 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 32189160085 for ; Tue, 29 Oct 2019 11:24:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1572344644; bh=/XZnYY5jGYD3VE18uuo7SxSff45aQZNTEsW0z3sLqcY=; h=From:To:Subject:Date:From; b=YLdMa3obws/W5Ek3lstxWBIcIAqUovkga0kEkY+W1MIAcuLLsIzzbExCkwAFtWjk2 PJnPBFdJFam428BEny7+LYlCwW0XerbFPCSfNoeIa74YCI96xRf+IWYH69TCNfJsNQ Ve30X+gPFRgIHyUR+uzbsfMi8MARBONMh1odqjcTRi1qD2+acPgEvpDMjNxiQNReGb ll5ZCm37L7cYSsVb0UoIeRm6byWlN988sbndGO8ILB//ZrabOZgnkc76p+9cQDAmb+ UfKSgOJH9T4PrtgqaDItZRGmeC4ORChlrEBegl+ScHRMzOEa/w8EiGH6w6cvbZHIcA eVp4mDeFGSo5w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 472SMS3zYSz6ts7 for ; Tue, 29 Oct 2019 11:22:44 +0100 (CET) User-agent: mu4e 1.2.0; emacs 26.3 From: Guillaume Le Vaillant To: bug-guix@gnu.org Subject: Mount options ignored for root file system Date: Tue, 29 Oct 2019 11:22:39 +0100 Message-ID: <87pnif6ec0.fsf@yamatai> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.67.36.65 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The filesystem options declared for the root file system are apparently ignored. This happens for a btrfs root filesystem on a LUKS volume. Exerpt from '/etc/config.scm": --8<---------------cut here---------------start------------->8--- (mapped-devices (list (mapped-device (source (uuid "ee90b2aa-97e8-4ae5-ac72-9bf9058cc949")) (target "cryptroot") (type luks-device-mapping)) (mapped-device (source (uuid "ec9cd327-0370-4e20-baa4-254d03b1901e")) (target "cryptguillaume") (type luks-device-mapping)))) (file-systems (cons* (file-system (mount-point "/") (device "/dev/mapper/cryptroot") (type "btrfs") (options "autodefrag,compress=lzo") (dependencies mapped-devices)) (file-system (mount-point "/home/guillaume") (device "/dev/mapper/cryptguillaume") (type "btrfs") (options "autodefrag,compress=lzo") (dependencies mapped-devices)) %base-file-systems)) --8<---------------cut here---------------end--------------->8--- Exerpt from '/etc/fstab': --8<---------------cut here---------------start------------->8--- /dev/mapper/cryptroot / btrfs autodefrag,compress=lzo /dev/mapper/cryptguillaume /home/guillaume btrfs autodefrag,compress=lzo --8<---------------cut here---------------end--------------->8--- Exerpt from '/etc/mtab': --8<---------------cut here---------------start------------->8--- /dev/mapper/cryptroot / btrfs rw,relatime,ssd,space_cache,subvolid=5,subvol=/ 0 0 /dev/mapper/cryptguillaume /home/guillaume btrfs rw,relatime,compress=lzo,ssd,space_cache,autodefrag,subvolid=5,subvol=/ 0 0 /dev/mapper/cryptroot /gnu/store btrfs ro,relatime,ssd,space_cache,subvolid=5,subvol=/gnu/store 0 0 --8<---------------cut here---------------end--------------->8--- Here we see that the options 'autodefrag' and 'compress=lzo' have disappeared on the root filesystem. Maybe it has something to do with the new '/gnu/store' subvolume that appeared? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 13:28:22 2019 Received: (at 37977) by debbugs.gnu.org; 7 Nov 2019 18:28:22 +0000 Received: from localhost ([127.0.0.1]:43909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSmW6-0005CX-Cm for submit@debbugs.gnu.org; Thu, 07 Nov 2019 13:28:22 -0500 Received: from mout02.posteo.de ([185.67.36.66]:33851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSmW4-0005CI-38 for 37977@debbugs.gnu.org; Thu, 07 Nov 2019 13:28:21 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id AA22C2400E6 for <37977@debbugs.gnu.org>; Thu, 7 Nov 2019 19:28:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1573151293; bh=WMHZ6UzU0JKHkHoU9eMqogcLhAedsu5BfFXHI4AKzp0=; h=From:To:Subject:Date:From; b=q2jdcVacM/HmXs4hIGDbUNg9TQUnuCqzlBI8phjWbknZ5ET/JbTYxL/ZiayCSG+fS bFdQ58Yvz/Anuvawpog6uez64h4i6y1pLtOHrbtPHIOg0V7VKRR/HgnkLp3DcP9QnX wUcHZ20uzrufmgi0D1NjKrjBvPa6VrRXmU0+hNbJEfR2/Ek8QVIViqW4P6/uQcGp/B 5kSPEQJvSFtitvYlKRc/Jl5MskJsaHTFS67JZMSvmgQZutmZVPF5aWRFNR8TXantms OyyHR8D65E4JDrFyygBRsZUvqpUIVI9+jneFKsNZd7uZ1uM+BiE9DLm9JIW+aPe4wM 43QrgGnuhiNcw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 478BjS5tphz9rxL for <37977@debbugs.gnu.org>; Thu, 7 Nov 2019 19:28:12 +0100 (CET) References: <87pnif6ec0.fsf@yamatai> User-agent: mu4e 1.2.0; emacs 26.3 From: Guillaume Le Vaillant To: 37977@debbugs.gnu.org Subject: Re: Mount options ignored for root file system In-reply-to: <87pnif6ec0.fsf@yamatai> Date: Thu, 07 Nov 2019 19:28:10 +0100 Message-ID: <87eeyjils5.fsf@yamatai> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37977 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Guillaume Le Vaillant skribis: > The filesystem options declared for the root file system are apparently > ignored. This happens for a btrfs root filesystem on a LUKS volume. This also happens on a basic btrfs root file system (without LUKS). I tried adding "rootflags=defaults,autodefrag,compress=lzo" in kernel arguments, but it didn't have any effect. I then tried adding a one-shot service that remounts the root file system, and it works, the options declared in '/etc/fstab' are taken into consideration. This service just does 'mount -o remount /'. --8<---------------cut here---------------start------------->8--- (define remount-rootfs-service-type (shepherd-service-type 'remount-rootfs (const (shepherd-service (documentation "Remount rootfs with correct options.") (requirement '(udev)) (provision '(remount-rootfs)) (one-shot? #t) (start #~(lambda _ (invoke (string-append #$util-linux "/bin/mount") "-o" "remount" "/"))))))) (operating-system ... (services (cons* ... (service remount-rootfs-service-type #f) ...))) --8<---------------cut here---------------end--------------->8--- I saw that the 'start' function of 'root-file-system-service-type' doesn't do anything. Is it on purpose? Or could we make it remount the root filesystem? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 05:43:53 2019 Received: (at 37977) by debbugs.gnu.org; 17 Nov 2019 10:43:53 +0000 Received: from localhost ([127.0.0.1]:40383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWI24-0006IZ-OX for submit@debbugs.gnu.org; Sun, 17 Nov 2019 05:43:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWI1z-0006IJ-JV for 37977@debbugs.gnu.org; Sun, 17 Nov 2019 05:43:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iWI1u-0007Ai-BP; Sun, 17 Nov 2019 05:43:42 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47584 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iWI1t-0001hH-RV; Sun, 17 Nov 2019 05:43:42 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Guillaume Le Vaillant Subject: Re: bug#37977: Mount options ignored for root file system References: <87pnif6ec0.fsf@yamatai> <87eeyjils5.fsf@yamatai> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 Brumaire an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 17 Nov 2019 11:43:39 +0100 In-Reply-To: <87eeyjils5.fsf@yamatai> (Guillaume Le Vaillant's message of "Thu, 07 Nov 2019 19:28:10 +0100") Message-ID: <87bltapyuc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37977 Cc: 37977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Guillaume, Guillaume Le Vaillant skribis: > Guillaume Le Vaillant skribis: > >> The filesystem options declared for the root file system are apparently >> ignored. This happens for a btrfs root filesystem on a LUKS volume. > > This also happens on a basic btrfs root file system (without LUKS). > > I tried adding "rootflags=3Ddefaults,autodefrag,compress=3Dlzo" in kernel > arguments, but it didn't have any effect. [...] > I saw that the 'start' function of 'root-file-system-service-type' > doesn't do anything. Is it on purpose? Or could we make it remount the > root filesystem? By definition, when shepherd is started, the root file system is already mounted; that=E2=80=99s why the =E2=80=98start=E2=80=99 method of the =E2= =80=98root-file-system-service=E2=80=99 does nothing. The root file system is mounted by =E2=80=98mount-root-file-system=E2=80=99= in linux-boot.scm, and you=E2=80=99re right: it happily ignores any options in= the object for =E2=80=9C/=E2=80=9D. :-) A solution would be to have =E2=80=98boot-system=E2=80=99 take an additional #:root-file-system-options parameter that it would pass down to =E2=80=98mount-root-file-system=E2=80=99, which would honor it. Would you like to give it a try? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 09:17:39 2019 Received: (at 37977) by debbugs.gnu.org; 17 Nov 2019 14:17:39 +0000 Received: from localhost ([127.0.0.1]:40500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWLMw-0000Uu-VT for submit@debbugs.gnu.org; Sun, 17 Nov 2019 09:17:39 -0500 Received: from mout02.posteo.de ([185.67.36.66]:35297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWLMt-0000Ug-Lw for 37977@debbugs.gnu.org; Sun, 17 Nov 2019 09:17:36 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 9DB8D2400FD for <37977@debbugs.gnu.org>; Sun, 17 Nov 2019 15:17:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1574000249; bh=Nyhy8Q8HGziglRHVNbDh3l41prcSEByY2Vq+DZqftME=; h=From:To:Cc:Subject:Date:From; b=PjQCfqbOL11FUwLfrYtVyaqHXGzZOiGNngekSN7q9XALueP/djqZY5AMAySRZcN3z KUezK1BAa8FrVz6q2+GKsgfEt6w87deVPlqlNkWJeOEhD6p4yXaWtc+lJqN0HY4MTP uujB+/ZbWOwUA/KVFodfrUfdY4V7zMFDaS2S0OMxxcCSGY8gTLSPadz8r8jNtvq5my Dw8/zYtpfUjMensRvOZOY05ZTrqLw4zG9NBYT2cDKtMQxOYBp7iqAHA5HtQYZxJEGX 3d98wnHaQtSCpxMgLGnFOEKbzyHmRV2tGMVKmYFNo+5Cdwu4l90PVDyv/Oa2LedsTy /9p/3efbMhYvw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47GDgW5DRFz9rxY; Sun, 17 Nov 2019 15:17:27 +0100 (CET) References: <87pnif6ec0.fsf@yamatai> <87eeyjils5.fsf@yamatai> <87bltapyuc.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Guillaume Le Vaillant To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#37977: Mount options ignored for root file system In-reply-to: <87bltapyuc.fsf@gnu.org> Date: Sun, 17 Nov 2019 15:17:24 +0100 Message-ID: <87pnhqy4cr.fsf@yamatai> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37977 Cc: 37977@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s skribis: > The root file system is mounted by =E2=80=98mount-root-file-system=E2=80= =99 in > linux-boot.scm, and you=E2=80=99re right: it happily ignores any options = in the > object for =E2=80=9C/=E2=80=9D. :-) > > A solution would be to have =E2=80=98boot-system=E2=80=99 take an additio= nal > #:root-file-system-options parameter that it would pass down to > =E2=80=98mount-root-file-system=E2=80=99, which would honor it. > > Would you like to give it a try? The attached patch adds an 'options' parameter to 'mount-root-file-system' and makes 'boot-system' use it with the content of the 'options' field of the object for "/". It's not exactly the solution you described (adding a keyword argument to 'boot-system'), but I think it should work. What do you think? I tried it with my btrfs root file system, and it is correctly mounted with the options declared in my '/etc/config.scm' file. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-linux-boot-Don-t-ignore-options-when-mounting-root-f.patch Content-Transfer-Encoding: quoted-printable >From 3597f0fda6f6a13bf1fdab0fcde4f72ece688d93 Mon Sep 17 00:00:00 2001 From: Guillaume Le Vaillant Date: Sun, 17 Nov 2019 14:15:21 +0100 Subject: [PATCH] linux-boot: Don't ignore options when mounting root file system. * gnu/build/linux-boot.scm (mount-root-file-system): Add the 'options' keyword argument and use it when mounting the root file system. (boot-system): Pass the root file system options to 'mount-root-file-system'. --- gnu/build/linux-boot.scm | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/gnu/build/linux-boot.scm b/gnu/build/linux-boot.scm index 84a5447977..a8a9c2e2c8 100644 --- a/gnu/build/linux-boot.scm +++ b/gnu/build/linux-boot.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Cour= t=C3=A8s ;;; Copyright =C2=A9 2017 Mathieu Othacehe +;;; Copyright =C2=A9 2019 Guillaume Le Vaillant ;;; ;;; This file is part of GNU Guix. ;;; @@ -357,15 +358,16 @@ the last argument of `mknod'." (filter-map string->number (scandir "/proc"))))) =20 (define* (mount-root-file-system root type - #:key volatile-root?) + #:key volatile-root? options) "Mount the root file system of type TYPE at device ROOT. If VOLATILE-RO= OT? is true, mount ROOT read-only and make it an overlay with a writable tmpfs -using the kernel built-in overlayfs." +using the kernel built-in overlayfs. OPTIONS indicates the options to use +to mount ROOT." =20 (if volatile-root? (begin (mkdir-p "/real-root") - (mount root "/real-root" type MS_RDONLY) + (mount root "/real-root" type MS_RDONLY options) (mkdir-p "/rw-root") (mount "none" "/rw-root" "tmpfs") =20 @@ -382,7 +384,7 @@ using the kernel built-in overlayfs." "lowerdir=3D/real-root,upperdir=3D/rw-root/upper,workdir=3D= /rw-root/work")) (begin (check-file-system root type) - (mount root "/root" type))) + (mount root "/root" type 0 options))) =20 ;; Make sure /root/etc/mtab is a symlink to /proc/self/mounts. (false-if-exception @@ -472,6 +474,12 @@ upon error." mounts) "ext4")) =20 + (define root-fs-options + (any (lambda (fs) + (and (root-mount-point? fs) + (file-system-options fs))) + mounts)) + (display "Welcome, this is GNU's early boot Guile.\n") (display "Use '--repl' for an initrd REPL.\n\n") =20 @@ -524,7 +532,8 @@ upon error." (else (file-system-label root))))) (mount-root-file-system (canonicalize-device-spec root) root-fs-type - #:volatile-root? volatile-root?)) + #:volatile-root? volatile-root? + #:options root-fs-options)) (mount "none" "/root" "tmpfs")) =20 ;; Mount the specified file systems. --=20 2.24.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 05:32:29 2019 Received: (at 37977-done) by debbugs.gnu.org; 18 Nov 2019 10:32:29 +0000 Received: from localhost ([127.0.0.1]:43224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWeKb-0001XI-66 for submit@debbugs.gnu.org; Mon, 18 Nov 2019 05:32:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWeKY-0001X4-RD for 37977-done@debbugs.gnu.org; Mon, 18 Nov 2019 05:32:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iWeKT-0005ql-NC; Mon, 18 Nov 2019 05:32:21 -0500 Received: from nat-eduroam-36-gw-01-bso.bordeaux.inria.fr ([194.199.1.36]:53942 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iWeKR-0006xr-9x; Mon, 18 Nov 2019 05:32:19 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Guillaume Le Vaillant Subject: Re: bug#37977: Mount options ignored for root file system References: <87pnif6ec0.fsf@yamatai> <87eeyjils5.fsf@yamatai> <87bltapyuc.fsf@gnu.org> <87pnhqy4cr.fsf@yamatai> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 Brumaire an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 18 Nov 2019 11:32:16 +0100 In-Reply-To: <87pnhqy4cr.fsf@yamatai> (Guillaume Le Vaillant's message of "Sun, 17 Nov 2019 15:17:24 +0100") Message-ID: <878sodlbkf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37977-done Cc: 37977-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Guillaume, Guillaume Le Vaillant skribis: > The attached patch adds an 'options' parameter to > 'mount-root-file-system' and makes 'boot-system' use it with the > content of the 'options' field of the object for "/". >=20 > It's not exactly the solution you described (adding a keyword argument > to 'boot-system'), but I think it should work. What do you think? It looks great to me. > From 3597f0fda6f6a13bf1fdab0fcde4f72ece688d93 Mon Sep 17 00:00:00 2001 > From: Guillaume Le Vaillant > Date: Sun, 17 Nov 2019 14:15:21 +0100 > Subject: [PATCH] linux-boot: Don't ignore options when mounting root file > system. > > * gnu/build/linux-boot.scm (mount-root-file-system): Add the 'options' > keyword argument and use it when mounting the root file system. > (boot-system): Pass the root file system options to > 'mount-root-file-system'. Applied, thanks! Ludo=E2=80=99. From unknown Tue Aug 19 22:01:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 16 Dec 2019 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator