GNU bug report logs - #37968
[PATCH] gnu: python-pyro4: Update to 4.77.

Previous Next

Full log

Message #10 received at 37968-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Giacomo Leidi <goodoldpaul <at> autistici.org>, 37968-done <at> debbugs.gnu.org
Cc: Giacomo Leidi <goodoldpaul <at> autistici.org>
Subject: Re: [bug#37968] [PATCH] gnu: python-pyro4: Update to 4.77.
Date: Mon, 28 Oct 2019 22:54:58 +0100

[Message part 1 (text/plain, inline)]

Giacomo Leidi <goodoldpaul <at> autistici.org> writes:

> * gnu/packages/python-xyz.scm (python-pyro4): Update to 4.77.

Applied with this tiny change:

[diff (text/x-patch, inline)]

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 57fb77a95a..bf5371c07a 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -14337,9 +14337,8 @@ such as figshare or Zenodo.")
        (sha256
         (base32 "0gsjg869y4gpy265s1gj1f2qy6jn5iz8r2bwwnq78r1r5yi15zib"))))
     (build-system python-build-system)
-    ;; FIXME
     (arguments
-     '(#:tests? #f)) ; The test suite requires network access.
+     '(#:tests? #f)) ;FIXME: Some tests require network access.
     (native-inputs
      `(("python-cloudpickle" ,python-cloudpickle)
        ("python-dill" ,python-dill)

[Message part 3 (text/plain, inline)]

Apparently the tests never ran before.  In the future, it would be great
to selectively disable just the tests that require network access, so
that we notice any breakage early.

Anyway, thanks for the patch!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.