Subject: bug#37968: closed (Re: [bug#37968] [PATCH] gnu: python-pyro4: Update to 4.77.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 28 Oct 2019 21:56:06 +0000

Your bug report

#37968: [PATCH] gnu: python-pyro4: Update to 4.77.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
37968: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37968
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#37968] [PATCH] gnu: python-pyro4: Update to 4.77.
From: Marius Bakke <[email-masked]>
To: Giacomo Leidi <[email-masked]>, [email-masked]
Cc: Giacomo Leidi <[email-masked]>
Date: Mon, 28 Oct 2019 22:54:58 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Giacomo Leidi <[email-masked]> writes:

> * gnu/packages/python-xyz.scm (python-pyro4): Update to 4.77.

Applied with this tiny change:

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 57fb77a95a..bf5371c07a 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -14337,9 +14337,8 @@ such as figshare or Zenodo.")
        (sha256
         (base32 "0gsjg869y4gpy265s1gj1f2qy6jn5iz8r2bwwnq78r1r5yi15zib"))))
     (build-system python-build-system)
-    ;; FIXME
     (arguments
-     '(#:tests? #f)) ; The test suite requires network access.
+     '(#:tests? #f)) ;FIXME: Some tests require network access.
     (native-inputs
      `(("python-cloudpickle" ,python-cloudpickle)
        ("python-dill" ,python-dill)

Apparently the tests never ran before.  In the future, it would be great
to selectively disable just the tests that require network access, so
that we notice any breakage early.

Anyway, thanks for the patch!

Subject: [PATCH] gnu: python-pyro4: Update to 4.77.
From: Giacomo Leidi <[email-masked]>
To: [email-masked]
Cc: Giacomo Leidi <[email-masked]>
Date: Mon, 28 Oct 2019 18:44:14 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/python-xyz.scm (python-pyro4): Update to 4.77.
---
 gnu/packages/python-xyz.scm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7dba1500b5..e58b2d84c4 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -14324,14 +14324,21 @@ such as figshare or Zenodo.")
 (define-public python-pyro4
   (package
     (name "python-pyro4")
-    (version "4.75")
+    (version "4.77")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "Pyro4" version))
        (sha256
-        (base32 "1dfpp36imddx19yv0kd28gk1l71ckhpqy6jd590wpm2680jw15rq"))))
+        (base32 "0gsjg869y4gpy265s1gj1f2qy6jn5iz8r2bwwnq78r1r5yi15zib"))))
     (build-system python-build-system)
+    ;; FIXME
+    (arguments
+     '(#:tests? #f)) ; The test suite requires network access.
+    (native-inputs
+     `(("python-cloudpickle" ,python-cloudpickle)
+       ("python-dill" ,python-dill)
+       ("python-msgpack" ,python-msgpack)))
     (propagated-inputs
      `(("python-serpent" ,python-serpent)))
     (home-page "https://pyro4.readthedocs.io")
-- 
2.23.0