From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 11:47:00 2019 Received: (at submit) by debbugs.gnu.org; 28 Oct 2019 15:47:00 +0000 Received: from localhost ([127.0.0.1]:46229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iP7ES-0002cP-D8 for submit@debbugs.gnu.org; Mon, 28 Oct 2019 11:47:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:48422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iP7EQ-0002cI-Fw for submit@debbugs.gnu.org; Mon, 28 Oct 2019 11:46:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59751) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iP7EO-0002H6-Ag for guix-patches@gnu.org; Mon, 28 Oct 2019 11:46:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iP7EM-0008K9-Hb for guix-patches@gnu.org; Mon, 28 Oct 2019 11:46:55 -0400 Received: from mout-p-201.mailbox.org ([80.241.56.171]:44142) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iP7EM-0008EW-7K for guix-patches@gnu.org; Mon, 28 Oct 2019 11:46:54 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 471zbk3cxrzQl94 for ; Mon, 28 Oct 2019 16:46:42 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1572277600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=rKfBBtC/0UuQ2G7+c+u7tCPvOZLlmdHJFp7vdyszSk4=; b=W9OfkqAwuoqqQlAd1lGTlcqQQ686R3Ny8RZMXoQBblsthBwnDVIzyOvtKXnwcnkP/FlU10 HyNX4D9Zardk6ssXUiUkDevB5ncLPa9NpKbcQV688tpDZ9izSrXeHuLQ77EY/qovQGE1e4 QuBha/NXMpbJ2ifGzuWkz5l1DJc+42yzdggDqHyxaQGALf7aHXw3BSO/roWLzr37/xuvoM pUsq4vu7M56dcHKpTXYXIlJusj4djZg5Dbt5UUDRSyKngOUg6dkzAbDL79Ozc9OtmOIwWR XiUQFBeziFpxD8CdbGC1nYk/SiekQp8LxBzNHRthiXErI+WqHMd/oRNIl5ln+Q== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de [80.241.56.116]) (amavisd-new, port 10030) with ESMTP id wfAIViy7JrA8 for ; Mon, 28 Oct 2019 16:46:39 +0100 (CET) From: Brendan Tildesley To: guix-patches@gnu.org Subject: [PATCH] gnu: scdoc: Set PREFIX instead of patching Makefile. Date: Tue, 29 Oct 2019 00:46:33 +0900 Message-Id: <20191028154633.3483-1-mail@brendan.scot> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.241.56.171 X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) scdoc installs a scdoc.pc file in lib/pkgconfig, but it embeds prefix=3D/usr/local unless the Makefile was patched before 'build. Howeve= r, it seemed better to simply set the PREFIX make-flag instead, since the Makef= ile correctly checks for it. Diffoscope shows the output is identical with ei= ther method. * gnu/packages/man.scm (scdoc)[arguments]: Set PREFIX instead of patching Makefile with output path. --- gnu/packages/man.scm | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/gnu/packages/man.scm b/gnu/packages/man.scm index de2377a14e..dc55e0a4ed 100644 --- a/gnu/packages/man.scm +++ b/gnu/packages/man.scm @@ -251,15 +251,11 @@ automatically.") "00zc3rzj97gscby31djlqyczvqpyhrl66i44czwzmmn7rc5j03m1")))) (build-system gnu-build-system) (arguments - `(#:make-flags '("CC=3Dgcc") + `(#:make-flags + (list "CC=3Dgcc" (string-append "PREFIX=3D" (assoc-ref %outputs "o= ut"))) #:phases (modify-phases %standard-phases - (delete 'configure) - (add-before 'install 'hardcode-paths - (lambda* (#:key outputs #:allow-other-keys) - (substitute* "Makefile" - (("/usr/local") (assoc-ref outputs "out"))) - #t))))) + (delete 'configure)))) (home-page "https://git.sr.ht/~sircmpwn/scdoc") (synopsis "Simple man page generator") (description "scdoc is a simple man page generator written for POSIX = systems --=20 2.23.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 18:01:21 2019 Received: (at 37963-done) by debbugs.gnu.org; 28 Oct 2019 22:01:21 +0000 Received: from localhost ([127.0.0.1]:46492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPD4j-0006oN-3Y for submit@debbugs.gnu.org; Mon, 28 Oct 2019 18:01:21 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:41579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPD4d-0006o4-3W for 37963-done@debbugs.gnu.org; Mon, 28 Oct 2019 18:01:19 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 6419238A; Mon, 28 Oct 2019 18:01:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 28 Oct 2019 18:01:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=buOzwWHCQiq5AA7JAg+4Ir/p9L f8ykw3H5vOKeYkSuc=; b=eClm/lzYvkTjlRsUckIaOFJkGYWUP3zzixTJoZ5HzI 7NzwtfU890LvaaJHobpUVHFbeUgLSGDQSXarQLkV+OSiI1CCkPRvyI7zLlh2IDsg AiU3AbaOJ5t860xgOkNaj+j2Rsy55idOBpSW4/3SYDwcb/dhpd/ZZ6WPRuTNl+bi yVApUAMH2tYNBjiWUIn9vqXoL5OkgpJM3upBgYXfdXApfknDsDIhW+zg4H1QCl/T yJMzLvk5Sl0+QBNafv1VzpQJd7tDt9top51p/JYUmzdIFu/Nqs5oRWD+cvL+Wprg tZxbbvjzI6b7Iy6AgcCYDEne27LBP3QUC6usXws2eOng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=buOzwW HCQiq5AA7JAg+4Ir/p9Lf8ykw3H5vOKeYkSuc=; b=FHmxiK/8l/DcOQyF3oHsXO rUvIJZkRr76czKwZB7JrJC3gwhe/SjD/sVAWd++rcP1hGWsaUgoq6io/51/k9dAz sbMlBRKIN9QEXU7nAGtI7PPz2UISdX6gXEhNUy/uNos/kZ5469UcW4Ejv8CTkVS5 aYs2xmqPrF0pDKTB6JEDYq+RsxbOANLhEKuTWJY2Su/fKoCIKta0haH2prZG1JTw Q1iB5NXkHt/1NYxQV8nob7e7QjeY3g0tB20dvu6YMRBjukS5y5BCfkIdhihUnOJt AY/ODGBTe7Owj+m4ugI9wqbbENgPAF3L0OsBbHZ4suCcBO+cG92p3hdHoqx/9eEQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleelgdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesghdtre ertdertdenucfhrhhomhepofgrrhhiuhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghs thhmrghilhdrtghomheqnecukfhppeeivddrudeirdduledvrdduhedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhmnecuvehluhhs thgvrhfuihiivgepud X-ME-Proxy: Received: from localhost (ti0006q161-0149.bb.online.no [62.16.192.150]) by mail.messagingengine.com (Postfix) with ESMTPA id 74FFBD60063; Mon, 28 Oct 2019 18:01:08 -0400 (EDT) From: Marius Bakke To: Brendan Tildesley , 37963-done@debbugs.gnu.org Subject: Re: [bug#37963] [PATCH] gnu: scdoc: Set PREFIX instead of patching Makefile. In-Reply-To: <20191028154633.3483-1-mail@brendan.scot> References: <20191028154633.3483-1-mail@brendan.scot> User-Agent: Notmuch/0.29.1 (https://notmuchmail.org) Emacs/26.2 (x86_64-pc-linux-gnu) Date: Mon, 28 Oct 2019 23:01:07 +0100 Message-ID: <87y2x4ttr0.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37963-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Brendan Tildesley writes: > scdoc installs a scdoc.pc file in lib/pkgconfig, but it embeds > prefix=/usr/local unless the Makefile was patched before 'build. However, it > seemed better to simply set the PREFIX make-flag instead, since the Makefile > correctly checks for it. Diffoscope shows the output is identical with either > method. > > * gnu/packages/man.scm (scdoc)[arguments]: Set PREFIX instead of patching > Makefile with output path. Good catch, applied! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl23ZSMACgkQoqBt8qM6 VPqPnAgArexoBlGfLidzdb8gYr40bdC0tlThsNlZ/zpIdBlHuhzq+m/BOw6OTv6z gDZ7hrP2EEEdPT51XaWNejasDJCqYkR8GnEHTlFbxjyZ/dtlLCJd6TLVaGskN/lt iaUjaqInjpgrq9IT3LvIZZPEHAw7xfa8bi2bsXcB9IpnyHi2het+G6oRkI0ftz7c C0oCq6OeT4af/At7aXDVu/f0ezUc4C31tEmDulVLpwNq2XlTT9abX6g0rRlR8BRj vDH2HZ9Q6mgJ0LMQn1E8AC3QaffPFCAYylGNio/k7sw0i6BBo5GgwtUkWhcVKj9/ LfEb6immbfbasn7ZD48BwNisfsL+AA== =4HQ+ -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 13 04:54:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 26 Nov 2019 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator