GNU bug report logs - #37962
[PATCH] gnu: emacs-evil: Remove undo-tree dependency.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37962 in the body.
You can then email your comments to 37962 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-evil: Remove undo-tree dependency.
Date: Mon, 28 Oct 2019 16:34:35 +0100

Because it is buggy and unnecessary.  See
<https://github.com/emacs-evil/evil/issues/1074>.

* gnu/packages/emacs-xyz.scm (emacs-evil)[propagated-inputs]: Remove
emacs-undo-tree and emacs-goto-chg.
---
 gnu/packages/emacs-xyz.scm | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 688206452e..ba8ece1e22 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7418,9 +7418,6 @@ news items, openrc and runscripts.")
         (base32
          "1833w397xhac5g3pp25szr2gyvclxy91aw27azvbmsx94pyk2a3q"))))
     (build-system emacs-build-system)
-    (propagated-inputs
-     `(("emacs-undo-tree" ,emacs-undo-tree)
-       ("emacs-goto-chg" ,emacs-goto-chg)))
     (home-page "https://github.com/emacs-evil/evil")
     (synopsis "Extensible Vi layer for Emacs")
     (description
-- 
2.23.0

Message #8 received at 37962 <at> debbugs.gnu.org (full text, mbox):

From: clement <at> lassieur.org (Clément Lassieur)
To: 37962 <at> debbugs.gnu.org
Subject: Re: [bug#37962] [PATCH] gnu: emacs-evil: Remove undo-tree dependency.
Date: Mon, 28 Oct 2019 16:43:26 +0100

The idea is that if people need it, they can install it and it'll just
work, but I personnaly don't want 'u' to be bound to undo-tree because
it has unfixed bugs that can lead to data loss[1].

'r' won't work anymore, but C-/ can be used instead[2].

Cheers,
Clément

[1]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-430012097
[2]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-470690948

Message #11 received at 37962 <at> debbugs.gnu.org (full text, mbox):

From: clement <at> lassieur.org (Clément Lassieur)
To: 37962 <at> debbugs.gnu.org
Subject: Re: [bug#37962] [PATCH] gnu: emacs-evil: Remove undo-tree dependency.
Date: Mon, 28 Oct 2019 16:50:00 +0100

clement <at> lassieur.org (Clément Lassieur) writes:

> The idea is that if people need it, they can install it and it'll just
> work, but I personnaly don't want 'u' to be bound to undo-tree because
> it has unfixed bugs that can lead to data loss[1].
>
> 'r' won't work anymore, but C-/ can be used instead[2].

I meant C-r (undo-tree-redo).

>
> Cheers,
> Clément
>
> [1]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-430012097
> [2]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-470690948

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 37962 <at> debbugs.gnu.org
Subject: Re: [bug#37962] [PATCH] gnu: emacs-evil: Remove undo-tree dependency.
Date: Tue, 29 Oct 2019 08:43:27 +0100

Hello Clément,

This LGTM!

Thanks,

Mathieu

Clément Lassieur writes:

> Because it is buggy and unnecessary.  See
> <https://github.com/emacs-evil/evil/issues/1074>.
>
> * gnu/packages/emacs-xyz.scm (emacs-evil)[propagated-inputs]: Remove
> emacs-undo-tree and emacs-goto-chg.
> ---
>  gnu/packages/emacs-xyz.scm | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 688206452e..ba8ece1e22 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -7418,9 +7418,6 @@ news items, openrc and runscripts.")
>          (base32
>           "1833w397xhac5g3pp25szr2gyvclxy91aw27azvbmsx94pyk2a3q"))))
>      (build-system emacs-build-system)
> -    (propagated-inputs
> -     `(("emacs-undo-tree" ,emacs-undo-tree)
> -       ("emacs-goto-chg" ,emacs-goto-chg)))
>      (home-page "https://github.com/emacs-evil/evil")
>      (synopsis "Extensible Vi layer for Emacs")
>      (description

Message #20 received at 37962 <at> debbugs.gnu.org (full text, mbox):

From: clement <at> lassieur.org (Clément Lassieur)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 37962 <at> debbugs.gnu.org
Subject: Re: [bug#37962] [PATCH] gnu: emacs-evil: Remove undo-tree dependency.
Date: Tue, 29 Oct 2019 11:07:47 +0100

thanks!  Pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.