GNU bug report logs - #37945
Saving file erases minor mode font locking.

Previous Next

Package: auctex;

Reported by: Prashant Sachdeva <sachdevaprash <at> gmail.com>

Date: Sun, 27 Oct 2019 17:46:01 UTC

Severity: normal

Done: Tassilo Horn <tsdh <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37945: closed (Saving file erases minor mode font locking.)
Date: Sun, 14 Jun 2020 12:21:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 14 Jun 2020 14:20:47 +0200
with message-id <87blll2600.fsf <at> gnu.org>
and subject line Re: bug#37945: [Auctex] Revert font locking to defaults
has caused the debbugs.gnu.org bug report #37945,
regarding Saving file erases minor mode font locking.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37945: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37945
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Prashant Sachdeva <sachdevaprash <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: Saving file erases minor mode font locking.
Date: Sun, 27 Oct 2019 10:45:09 -0700
[Message part 3 (text/plain, inline)]
When saving files, the lisp files for some style files (e.g. expl3, minted)
call font-latex-update-font-lock, which has the following lines to revert
the font locking to defaults (around line 1287-88 of font-latex.el):

(setq font-lock-set-defaults nil)
(font-lock-set-defaults)

This removes any font locking done by minor modes (e.g. hl-todo-mode,
outshine-mode). There should be another way of applying these styles that
does not override previously set font properties, or reapplies the font
lock applied by minor modes.

Emacs  : GNU Emacs 26.3 (build 1, x86_64-apple-darwin18.7.0, Carbon Version
158 AppKit 1671.6)
 of 2019-10-19
Package: 12.1.2

Also covered as a bug in hl-todo-mode
<https://github.com/tarsius/hl-todo/issues/26#issuecomment-546637535>.

- Prashant
[Message part 4 (text/html, inline)]
[Message part 5 (message/rfc822, inline)]
From: Tassilo Horn <tsdh <at> gnu.org>
To: Dominik Schrempf <dominik.schrempf <at> gmail.com>
Cc: 37945-done <at> debbugs.gnu.org
Subject: Re: bug#37945: [Auctex] Revert font locking to defaults
Date: Sun, 14 Jun 2020 14:20:47 +0200
Tassilo Horn <tsdh <at> gnu.org> writes:

>> thanks a lot for working on this.  I tested the mentioned branch and
>> indeed, it works flawlessly.  As far as I can see now, no other
>> regressions were introduced,
>
> That's good news.  I give it some days of testing by others and then
> I'll merge it into master.  So hopefully it'll be fixed in GNU AUCTeX
> 12.2.4.

Ok, the branch is now merged into master and we'll be doing a new ELPA
release in some days.

I'm closing this report now.  Thanks a lot for testing!

Bye,
Tassilo


This bug report was last modified 4 years and 345 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.