From unknown Sun Jun 22 08:05:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37943: assoc-default is wrongly flagged as side-effect-free. Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Oct 2019 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 37943@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.157217910523514 (code B ref -1); Sun, 27 Oct 2019 12:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Oct 2019 12:25:05 +0000 Received: from localhost ([127.0.0.1]:41773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOhbV-000676-7A for submit@debbugs.gnu.org; Sun, 27 Oct 2019 08:25:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:48740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOhbR-00066c-1a for submit@debbugs.gnu.org; Sun, 27 Oct 2019 08:25:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53754) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOhbQ-0004PH-1p for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2019 08:25:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOhbP-0005kI-0Y for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2019 08:24:59 -0400 Received: from colin.muc.de ([193.149.48.1]:26985 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1iOhbO-0005ih-MY for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2019 08:24:58 -0400 Received: (qmail 23553 invoked by uid 3782); 27 Oct 2019 12:24:56 -0000 Received: from acm.muc.de (p2E5D5E17.dip0.t-ipconnect.de [46.93.94.23]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 27 Oct 2019 13:24:55 +0100 Received: (qmail 28041 invoked by uid 1000); 27 Oct 2019 12:24:55 -0000 Date: Sun, 27 Oct 2019 12:24:55 +0000 Message-ID: <20191027122455.GB27491@ACM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, Emacs. Emacs 27. In the source for assoc-default (in subr.el) appears (declare (side-effect-free t)) . This is not true when the TEST argument to assoc-default itself changes the match-data. I suggest removing this declaration from the function rather than amending the code with a save-match-data. There are calls to assoc-default in set-auto-mode where the caller relies on the match data set by the function when TEST is string-match. :-( -- Alan Mackenzie (Nuremberg, Germany). From unknown Sun Jun 22 08:05:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37943: assoc-default is wrongly flagged as side-effect-free. Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Oct 2019 15:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Mackenzie Cc: 37943@debbugs.gnu.org Received: via spool by 37943-submit@debbugs.gnu.org id=B37943.157227627932528 (code B ref 37943); Mon, 28 Oct 2019 15:25:01 +0000 Received: (at 37943) by debbugs.gnu.org; 28 Oct 2019 15:24:39 +0000 Received: from localhost ([127.0.0.1]:46200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iP6so-0008Sa-QB for submit@debbugs.gnu.org; Mon, 28 Oct 2019 11:24:38 -0400 Received: from quimby.gnus.org ([80.91.231.51]:42006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iP6sl-0008SQ-W9 for 37943@debbugs.gnu.org; Mon, 28 Oct 2019 11:24:36 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iP6si-0000VB-LV; Mon, 28 Oct 2019 16:24:35 +0100 From: Lars Ingebrigtsen References: <20191027122455.GB27491@ACM> Date: Mon, 28 Oct 2019 16:24:32 +0100 In-Reply-To: <20191027122455.GB27491@ACM> (Alan Mackenzie's message of "Sun, 27 Oct 2019 12:24:55 +0000") Message-ID: <87zhhk99lb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alan Mackenzie writes: > In the source for assoc-default (in subr.el) appears > > (declare (side-effect-free t)) > > . This is not true when the TEST argument to assoc-default itself > changes the match-data. > > I suggest [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alan Mackenzie writes: > In the source for assoc-default (in subr.el) appears > > (declare (side-effect-free t)) > > . This is not true when the TEST argument to assoc-default itself > changes the match-data. > > I suggest removing this declaration from the function rather than > amending the code with a save-match-data. There are calls to > assoc-default in set-auto-mode where the caller relies on the match data > set by the function when TEST is string-match. :-( Yeah, I don't think any function that takes a closure as an argument should be marked side-effect free? The TEST function can side-effect as much as it wants. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 08:05:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37943: assoc-default is wrongly flagged as side-effect-free. Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Aug 2020 23:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Alan Mackenzie , 37943@debbugs.gnu.org Received: via spool by 37943-submit@debbugs.gnu.org id=B37943.15983983736169 (code B ref 37943); Tue, 25 Aug 2020 23:33:01 +0000 Received: (at 37943) by debbugs.gnu.org; 25 Aug 2020 23:32:53 +0000 Received: from localhost ([127.0.0.1]:36526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAiQv-0001bM-BS for submit@debbugs.gnu.org; Tue, 25 Aug 2020 19:32:53 -0400 Received: from mail-yb1-f171.google.com ([209.85.219.171]:45602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAiQt-0001Xz-Nk for 37943@debbugs.gnu.org; Tue, 25 Aug 2020 19:32:52 -0400 Received: by mail-yb1-f171.google.com with SMTP id x2so182890ybf.12 for <37943@debbugs.gnu.org>; Tue, 25 Aug 2020 16:32:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=tQpNWnlpnORiWHzCCNnQ2Esp+exY5ok3lEJ6YqHu97o=; b=DXW2xS1g/x7bkwtWNIqJ9eV5Q9dqul7GRGJTLlaTUwnlrPEVg2zAeBUSfAkEqevYW0 cQcZxDiGOyKrdKmzig4tGQ5/V19LB0bS+kFjKJ5RX4Sg/WIGS0Lbby9l5ZlNRXCZL1nb yRZga41OUMv8E/wXV4yHEiZfd6IMbizteulLYMAX4VxawWfID3TR4QphS275Y3UrBFsh P4IeNMi3w6z4zrEyqr+bpTqIePmhedGW9+HMuTMCgITMvsfQEeLYmYK2fVp+GIggbAm/ SRDZzcdKMqnSE+ko+v/feN4FLdxoBdt+jf0lWpmJMPCNgbTh1WzwqhpP0KfYUKNFe/rW nDZA== X-Gm-Message-State: AOAM532h2wx3ZR4Xx/UazoP71zPOZd5rRFpryVryjYNLmqhHLefBO6a2 V3c13aCy5rIlrT49zEoIr0wmSkOcTkMOgfzhWlw= X-Google-Smtp-Source: ABdhPJx8C+7cvj4/gMBbYtI02MMHesdqbPB1lM0qLTkDjVv5pc2BYdGZWJAWwWx7rFd5oh9UB+LabO6agsTy1gHMaF8= X-Received: by 2002:a25:b290:: with SMTP id k16mr17455881ybj.389.1598398366175; Tue, 25 Aug 2020 16:32:46 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 25 Aug 2020 16:32:45 -0700 From: Stefan Kangas In-Reply-To: <87zhhk99lb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 28 Oct 2019 16:24:32 +0100") References: <20191027122455.GB27491@ACM> <87zhhk99lb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 25 Aug 2020 16:32:45 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > Alan Mackenzie writes: > >> In the source for assoc-default (in subr.el) appears >> >> (declare (side-effect-free t)) >> >> . This is not true when the TEST argument to assoc-default itself >> changes the match-data. >> >> I suggest removing this declaration from the function rather than >> amending the code with a save-match-data. There are calls to >> assoc-default in set-auto-mode where the caller relies on the match data >> set by the function when TEST is string-match. :-( > > Yeah, I don't think any function that takes a closure as an argument > should be marked side-effect free? The TEST function can side-effect as > much as it wants. No further replies within 43 weeks. Should we just go ahead and remove it then? No one seems to be objecting. From unknown Sun Jun 22 08:05:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37943: assoc-default is wrongly flagged as side-effect-free. Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Aug 2020 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: Alan Mackenzie , 37943@debbugs.gnu.org Received: via spool by 37943-submit@debbugs.gnu.org id=B37943.15984341499451 (code B ref 37943); Wed, 26 Aug 2020 09:30:02 +0000 Received: (at 37943) by debbugs.gnu.org; 26 Aug 2020 09:29:09 +0000 Received: from localhost ([127.0.0.1]:37367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kArjx-0002SM-Ke for submit@debbugs.gnu.org; Wed, 26 Aug 2020 05:29:09 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kArjv-0002Ru-Ve for 37943@debbugs.gnu.org; Wed, 26 Aug 2020 05:29:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Hm8DwDwXssS2gO0f33CcLpk0G7eQONSLtpMSVXCYMY4=; b=UB1K08cF0wLCXwJ8KIESoiTmZp Ixauk/K9YxZscQkBse6cH0ns5uiaYdORxo/Fr+V3wYXZsboxl024RpT1Gz65H1FWiL0x4ySPY8Mcz gYTkV49W8zDY+c8aZGIeYsRsD7ppttoxt8lIyQ3bHGXEsttnNaPiNsz/Nnz2P8TJyHD4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kArjm-0003QA-7I; Wed, 26 Aug 2020 11:29:00 +0200 From: Lars Ingebrigtsen References: <20191027122455.GB27491@ACM> <87zhhk99lb.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEWAjz4/TDT///+A qekiAAAAAWJLR0QCZgt8ZAAAAAd0SU1FB+QIGgkcKnzIoAoAAAFESURBVCjPVVLRqsUwCItQ3x3U /7GwvVuo//8rN45x4A7Gao1J1GFMfM/v8EXrfMfhG3LSEIKhnvB6Rids10FVEs1iqUK5BfxAxl1I FRALRCozCigp7RA2b8zjAzIZ3AGyBMQYXIlVtaAkmEiUjYLCQSRRTXdNqAbq2QVJQlzyUns0puMc 2ymhCxQ8ZE1hOTG4KxKaEIqwmLcSMJCkUmvkY/3FY/OaqWcNHOgsOmNnzKPWOk6Ix2INpeu+ikYc WvTcmfVQgh2+Nd41Ofd42UhdQR27qSPVDsbPQXtLTREpo2tDtxDDux8wE2yOgXu3ZQfBa6XWOwPs 5HSMU/2mU8LMfji3cDrYvZrA06J6w3p7NE98flvgSrb2lFif56H6v81ldEa0N1elve3cvNHqJoyM 9W4tZS+2yIDv+x9gsObMGC9Mpv8B6r1bK52pww8AAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDgt MjZUMDk6Mjg6NDIrMDA6MDBda25aAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA4LTI2VDA5OjI4 OjQyKzAwOjAwLDbW5gAAAABJRU5ErkJggg== X-Now-Playing: Various's _Kaleidoscope (1)_: "Ill Considered - Long Way Home (Live At The Crypt)" Date: Wed, 26 Aug 2020 11:28:56 +0200 In-Reply-To: (Stefan Kangas's message of "Tue, 25 Aug 2020 16:32:45 -0700") Message-ID: <87wo1l3gdj.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > Should we just go ahead and remove it then? No one seems to be > objecting. Yup. I've now done so on the trunk. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Should we just go ahead and remove it then? No one seems to be > objecting. Yup. I've now done so on the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 26 05:29:20 2020 Received: (at control) by debbugs.gnu.org; 26 Aug 2020 09:29:20 +0000 Received: from localhost ([127.0.0.1]:37372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kArk7-0002Sn-R5 for submit@debbugs.gnu.org; Wed, 26 Aug 2020 05:29:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kArk6-0002Sa-Dm for control@debbugs.gnu.org; Wed, 26 Aug 2020 05:29:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3bgp3B6bLtmds5W2mJizCpQ9LcG82WnnYUEOtRq4824=; b=kFK3gAvH6rcC9SvQ8QD21lnUKd 4JyrTJhM9iw9QhJTGHHrTw4llAPisn/zMm2huHngtD0rl2wsb/Ymi7WlPEEhZNpVDlBXvTAVHCv6b SziZ75pUAur+qHmuZZCU6dwkcuL9yonrMlmpWi3vmU574a/t+QHKq5acYyphEWmdZQJY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kArjy-0003Qe-JF for control@debbugs.gnu.org; Wed, 26 Aug 2020 11:29:12 +0200 Date: Wed, 26 Aug 2020 11:29:09 +0200 Message-Id: <87v9h53gd6.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #37943 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 37943 fixed close 37943 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 37943 fixed close 37943 28.1 quit