GNU bug report logs - #37941
26.3.50; Wrong behavior when reverting a tabulated-list-mode buffer with truncated lines

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37941 in the body.
You can then email your comments to 37941 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michał Krzywkowski <mkrzywkow <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.3.50;
 Wrong behavior when reverting a tabulated-list-mode buffer with
 truncated lines
Date: Sun, 27 Oct 2019 11:02:39 +0100

[Message part 1 (text/plain, inline)]

When I revert a regular tabulated-list-mode buffer, the point stays the
same, and the displayed buffer boundaries remain the same as well.

However, when the entries in tabulated-list-entries contain strings that
are too long and will be truncated, reverting such buffer will scroll
the screen by one line.

To see this behavior, evaluate in emacs -Q, then type g:

  (with-current-buffer (generate-new-buffer "test")
    (require 'cl-lib)
    (tabulated-list-mode)
    (setq tabulated-list-format [("No." 5) ("Message" 10)])
    (let ((message (make-string 100 ?a)))
      (setq tabulated-list-entries
            (cl-loop for i from 1 to 100
                     collect `(,i [,(number-to-string i) ,message]))))
    (tabulated-list-init-header)
    (revert-buffer)
    (forward-line 50)
    (pop-to-buffer (current-buffer))
    (recenter))

You can also see that if the lines are not truncated, the behavior is
correct.

In GNU Emacs 26.3.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)
 of 2019-10-08 built on debian
Repository revision: 55dcd32ad2209dc34bfb6b713bf73be9bf4c4cb2
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description:	Debian GNU/Linux 10 (buster)


--
Michał Krzywkowski
PGP: A5A7 06C4 28EF 8F64 2868 13A1 7BDE C129 F0B8 09A1

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 37941 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michał Krzywkowski <mkrzywkow <at> gmail.com>
Cc: 37941 <at> debbugs.gnu.org
Subject: Re: bug#37941: 26.3.50;
 Wrong behavior when reverting a tabulated-list-mode buffer with
 truncated lines
Date: Sun, 27 Oct 2019 17:09:15 +0200

> From: Michał Krzywkowski <mkrzywkow <at> gmail.com>
> Date: Sun, 27 Oct 2019 11:02:39 +0100
> 
> When I revert a regular tabulated-list-mode buffer, the point stays the
> same, and the displayed buffer boundaries remain the same as well.
> 
> However, when the entries in tabulated-list-entries contain strings that
> are too long and will be truncated, reverting such buffer will scroll
> the screen by one line.
> 
> To see this behavior, evaluate in emacs -Q, then type g:
> 
>   (with-current-buffer (generate-new-buffer "test")
>     (require 'cl-lib)
>     (tabulated-list-mode)
>     (setq tabulated-list-format [("No." 5) ("Message" 10)])
>     (let ((message (make-string 100 ?a)))
>       (setq tabulated-list-entries
>             (cl-loop for i from 1 to 100
>                      collect `(,i [,(number-to-string i) ,message]))))
>     (tabulated-list-init-header)
>     (revert-buffer)
>     (forward-line 50)
>     (pop-to-buffer (current-buffer))
>     (recenter))
> 
> You can also see that if the lines are not truncated, the behavior is
> correct.

Thanks, should be fixed now.  Please test.

Message #11 received at 37941 <at> debbugs.gnu.org (full text, mbox):

From: Michał Krzywkowski <mkrzywkow <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Michał Krzywkowski <mkrzywkow <at> gmail.com>,
 37941 <at> debbugs.gnu.org
Subject: Re: bug#37941: 26.3.50;
 Wrong behavior when reverting a tabulated-list-mode buffer with
 truncated lines
Date: Sun, 27 Oct 2019 20:12:49 +0100

[Message part 1 (text/plain, inline)]

>>>>> "Eli" == Eli Zaretskii <eliz <at> gnu.org> writes:
    Eli> Thanks, should be fixed now.  Please test.

Indeed the problem is fixed now, thanks.

--
Michał Krzywkowski
PGP: A5A7 06C4 28EF 8F64 2868 13A1 7BDE C129 F0B8 09A1

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 37941-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michał Krzywkowski <mkrzywkow <at> gmail.com>
Cc: 37941-done <at> debbugs.gnu.org
Subject: Re: bug#37941: 26.3.50;
 Wrong behavior when reverting a tabulated-list-mode buffer with
 truncated lines
Date: Sun, 27 Oct 2019 21:24:25 +0200

> From: Michał Krzywkowski <mkrzywkow <at> gmail.com>
> Cc: Michał Krzywkowski <mkrzywkow <at> gmail.com>,
>  37941 <at> debbugs.gnu.org
> Date: Sun, 27 Oct 2019 20:12:49 +0100
> 
> >>>>> "Eli" == Eli Zaretskii <eliz <at> gnu.org> writes:
>     Eli> Thanks, should be fixed now.  Please test.
> 
> Indeed the problem is fixed now, thanks.

Thanks for testing, I'm therefore closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.