From unknown Fri Aug 15 14:45:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#37924 <37924@debbugs.gnu.org> To: bug#37924 <37924@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Fix make-gcc-libc Reply-To: bug#37924 <37924@debbugs.gnu.org> Date: Fri, 15 Aug 2025 21:45:18 +0000 retitle 37924 [PATCH] gnu: Fix make-gcc-libc reassign 37924 guix-patches submitter 37924 Carl Dong severity 37924 normal tag 37924 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 25 11:40:40 2019 Received: (at submit) by debbugs.gnu.org; 25 Oct 2019 15:40:40 +0000 Received: from localhost ([127.0.0.1]:39263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iO1hg-0002BR-DR for submit@debbugs.gnu.org; Fri, 25 Oct 2019 11:40:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:48286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iO1hc-0002BE-KC for submit@debbugs.gnu.org; Fri, 25 Oct 2019 11:40:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58997) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iO1hY-000738-Rk for guix-patches@gnu.org; Fri, 25 Oct 2019 11:40:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iO1hW-0008W7-6o for guix-patches@gnu.org; Fri, 25 Oct 2019 11:40:32 -0400 Received: from mail4.protonmail.ch ([185.70.40.27]:39107) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iO1hV-0008Ur-LK for guix-patches@gnu.org; Fri, 25 Oct 2019 11:40:30 -0400 Date: Fri, 25 Oct 2019 15:40:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carldong.me; s=protonmail; t=1572018026; bh=+c2c6iuh1FYlXbGnhRl34kIscJFYpCOnG6qnm+qtlkw=; h=Date:To:From:Reply-To:Subject:Feedback-ID:From; b=RB0FN9aNaHMpTmAneRFSEog/EVt01zG+wlpEm1q+tHa3CR1NpRa5FmYEOPTdKOX9s IcpYwhg0UuLRkUqfS/DEErefqlH29bm51ep/oDigWzaEiCdOnth7IiP0KaGmkJ59+B yKEykfKc/XST15s1mKD+apZAdOgJDA0Fi3uLtjaA= To: "guix-patches@gnu.org" From: Carl Dong Subject: [PATCH] gnu: Fix make-gcc-libc Message-ID: Feedback-ID: a8j8tDUaJ4AYuDVBywMTwsJebN4w8TVXadJLsJb8td3t3dZi9RdXFlPaQvoFKnI9KgXySsPXcRkajVyY0cGTcA==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.70.40.27 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Carl Dong Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Reviewers, would like some insight into whether it's okay to remove the FLAGS_FOR_TARGET. From what I can tell it comes from CROSS-GCC-ARGUMENTS in= (gnu packages cross-base) which might not be needed here since we're not cross-building. I've tested this toolchain built without FLAGS_FOR_TARGET a= nd it _seems_ to work fine. ----- Until now the following wouldn't build: --8<---------------cut here---------------start------------->8--- (use-modules (gnu packages commencement) (gnu packages gcc) (gnu packages base)) (make-gcc-libc gcc-9 glibc-2.27) --8<---------------cut here---------------end--------------->8--- * gnu/packages/base.scm (make-gcc-libc)[phases]: Add environment variables to place the target libc on the system header search path. [make-flags]: Remove unncessary FLAGS_FOR_TARGET. [native-inputs]: Construct in a way that doesn't require emptying inputs. --- gnu/packages/base.scm | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm index 4e80a2fadb..3a3360dc7a 100644 --- a/gnu/packages/base.scm +++ b/gnu/packages/base.scm @@ -981,18 +981,23 @@ with the Linux kernel.") (substitute-keyword-arguments (ensure-keyword-arguments (package-arguments base-gcc) '(#:implicit-inputs? #f)) - ((#:make-flags flags) - `(let ((libc (assoc-ref %build-inputs "libc"))) - ;; FLAGS_FOR_TARGET are needed for the target libraries t= o receive - ;; the -Bxxx for the startfiles. - (cons (string-append "FLAGS_FOR_TARGET=3D-B" libc "/lib") - ,flags))))) + ((#:phases phases) + `(modify-phases ,phases + (add-before 'configure 'treat-glibc-as-system-header + (lambda _ + (let ((libc (assoc-ref %build-inputs "libc"))) + ;; GCCs build processes requires that the libc + ;; we're building against is on the system header + ;; search path. + (for-each (lambda (var) + (setenv var (string-append libc "/inclu= de"))) + '("C_INCLUDE_PATH" "CPLUS_INCLUDE_PATH")) + #t))))))) (native-inputs - `(("libc" ,libc) - ("libc:static" ,libc "static") - ,@(append (package-inputs base-gcc) - (fold alist-delete (%final-inputs) '("libc" "libc:= static"))))) - (inputs '()))) + `(,@(package-native-inputs base-gcc) + ,@(append (fold alist-delete (%final-inputs) '("libc" "libc:= static"))) + ("libc" ,libc) + ("libc:static" ,libc "static"))))) (define-public (make-glibc-locales glibc) (package -- 2.23.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 25 12:21:59 2019 Received: (at 37924) by debbugs.gnu.org; 25 Oct 2019 16:21:59 +0000 Received: from localhost ([127.0.0.1]:39296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iO2La-0003Gh-6j for submit@debbugs.gnu.org; Fri, 25 Oct 2019 12:21:58 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:18145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iO2LX-0003GH-Ma for 37924@debbugs.gnu.org; Fri, 25 Oct 2019 12:21:52 -0400 Date: Fri, 25 Oct 2019 16:21:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carldong.me; s=protonmail; t=1572020504; bh=fCFc+HHAjKqbFdv5lOwNwNm1yn4yy/sAGcax0UDdfh4=; h=Date:To:From:Reply-To:Subject:Feedback-ID:From; b=J+3WxRrN9HGOuXpYNGMjd91Jb1W1c4HDyTUNvd7B5xluEtraX5tdXzwlYWo46rVqy E1HuNQFRT1UDIirKEb924N6MWGJeQlVs8+/4fSZfd6glv4sDeicz+XY8BTv3i+lsNX qVtmbnERXIg7Ge6c24BfvTTdRjpcqt3LCcWYJt3M= To: "37924@debbugs.gnu.org" <37924@debbugs.gnu.org> From: Carl Dong Subject: [PATCH 2/2] ci: Add 'make-gcc-toolchain' packages Message-ID: Feedback-ID: a8j8tDUaJ4AYuDVBywMTwsJebN4w8TVXadJLsJb8td3t3dZi9RdXFlPaQvoFKnI9KgXySsPXcRkajVyY0cGTcA==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37924 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Carl Dong Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/ci.scm (%core-packages): Add 'glibc-2.28', a toolchain with default 'gcc', and a toolchain targeting 'glibc-2.28'. --- gnu/ci.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/ci.scm b/gnu/ci.scm index 5d5a826647..74df3c34ab 100644 --- a/gnu/ci.scm +++ b/gnu/ci.scm @@ -110,9 +110,11 @@ SYSTEM." ;; Note: Don't put the '-final' package variants because (1) that's ;; implicit, and (2) they cannot be cross-built (due to the explicit inp= ut ;; chain.) - (list gcc-4.8 gcc-4.9 gcc-5 glibc binutils + (list gcc-4.8 gcc-4.9 gcc-5 glibc glibc-2.28 binutils gmp mpfr mpc coreutils findutils diffutils patch sed grep gawk gnu-gettext hello guile-2.0 guile-2.2 zlib gzip xz + (make-gcc-toolchain gcc) + (make-gcc-toolchain gcc glibc-2.28) %bootstrap-binaries-tarball %binutils-bootstrap-tarball (%glibc-bootstrap-tarball) -- 2.23.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 04 17:18:38 2019 Received: (at 37924) by debbugs.gnu.org; 4 Nov 2019 22:18:38 +0000 Received: from localhost ([127.0.0.1]:37668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRkgH-0006oZ-MW for submit@debbugs.gnu.org; Mon, 04 Nov 2019 17:18:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRkgG-0006oK-Mi for 37924@debbugs.gnu.org; Mon, 04 Nov 2019 17:18:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iRkgA-00042Y-TI; Mon, 04 Nov 2019 17:18:31 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36176 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iRkgA-0008BG-9y; Mon, 04 Nov 2019 17:18:30 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Carl Dong Subject: Re: [bug#37924] [PATCH] gnu: Fix make-gcc-libc References: Date: Mon, 04 Nov 2019 23:18:28 +0100 In-Reply-To: (Carl Dong's message of "Fri, 25 Oct 2019 15:40:19 +0000") Message-ID: <87y2wv4763.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37924 Cc: 37924@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Carl, Carl Dong skribis: > Reviewers, would like some insight into whether it's okay to remove the > FLAGS_FOR_TARGET. From what I can tell it comes from CROSS-GCC-ARGUMENTS = in (gnu > packages cross-base) which might not be needed here since we're not > cross-building. I've tested this toolchain built without FLAGS_FOR_TARGET= and it > _seems_ to work fine. I think it wouldn=E2=80=99t hurt to keep FLAGS_FOR_TARGET, but like you wri= te, it seems to be for cross-compilation only, so I guess it=E2=80=99s OK to re= move it here since =E2=80=98make-gcc-libc=E2=80=99 is meant to build native tool= chains anyway. > Until now the following wouldn't build: > > (use-modules (gnu packages commencement) > (gnu packages gcc) > (gnu packages base)) > > (make-gcc-libc gcc-9 glibc-2.27) > > * gnu/packages/base.scm (make-gcc-libc)[phases]: Add environment > variables to place the target libc on the system header search path. > [make-flags]: Remove unncessary FLAGS_FOR_TARGET. > [native-inputs]: Construct in a way that doesn't require emptying > inputs. LGTM, thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 04 17:22:15 2019 Received: (at 37924) by debbugs.gnu.org; 4 Nov 2019 22:22:15 +0000 Received: from localhost ([127.0.0.1]:37672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRkjn-0006vT-89 for submit@debbugs.gnu.org; Mon, 04 Nov 2019 17:22:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRkjl-0006vF-Lx for 37924@debbugs.gnu.org; Mon, 04 Nov 2019 17:22:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iRkjg-0000AB-9B; Mon, 04 Nov 2019 17:22:08 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36178 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iRkjf-0008RJ-OG; Mon, 04 Nov 2019 17:22:08 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Carl Dong Subject: Re: [bug#37924] [PATCH 2/2] ci: Add 'make-gcc-toolchain' packages References: Date: Mon, 04 Nov 2019 23:22:04 +0100 In-Reply-To: (Carl Dong's message of "Fri, 25 Oct 2019 16:21:40 +0000") Message-ID: <87sgn34703.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37924 Cc: "37924@debbugs.gnu.org" <37924@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Carl Dong skribis: > * gnu/ci.scm (%core-packages): Add 'glibc-2.28', a toolchain with > default 'gcc', and a toolchain targeting 'glibc-2.28'. The problem is =E2=80=98%core-packages=E2=80=99 is only built when we expli= citly choose the =E2=80=9Ccore=E2=80=9D subset in CI (which we do only when experimentin= g with =E2=80=98core-updates=E2=80=99 early on); in other cases, all the public pa= ckages get built and =E2=80=98%core-packages=E2=80=99 does not matter. Would it be an option to have: (define-public gcc/glibc-2.28 (make-gcc-libc gcc glibc-2.28)) in (gnu packages base), or does that create circular dependency issues (I don=E2=80=99t think so, but better be safe)? If we did that, that package would automatically picked up in CI. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 16 11:36:14 2019 Received: (at 37924-done) by debbugs.gnu.org; 16 Nov 2019 16:36:14 +0000 Received: from localhost ([127.0.0.1]:39644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iW13V-0007gH-Te for submit@debbugs.gnu.org; Sat, 16 Nov 2019 11:36:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iW13T-0007g4-U4 for 37924-done@debbugs.gnu.org; Sat, 16 Nov 2019 11:36:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iW13O-00068o-G0; Sat, 16 Nov 2019 11:36:06 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47208 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iW13N-0000oK-NN; Sat, 16 Nov 2019 11:36:06 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Carl Dong Subject: Re: [bug#37924] [PATCH] gnu: Fix make-gcc-libc References: Date: Sat, 16 Nov 2019 17:36:04 +0100 In-Reply-To: (Carl Dong's message of "Fri, 25 Oct 2019 15:40:19 +0000") Message-ID: <87k17zwzgr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37924-done Cc: 37924-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Carl Dong skribis: > Until now the following wouldn't build: > > (use-modules (gnu packages commencement) > (gnu packages gcc) > (gnu packages base)) > > (make-gcc-libc gcc-9 glibc-2.27) > > * gnu/packages/base.scm (make-gcc-libc)[phases]: Add environment > variables to place the target libc on the system header search path. > [make-flags]: Remove unncessary FLAGS_FOR_TARGET. > [native-inputs]: Construct in a way that doesn't require emptying > inputs. > --- > gnu/packages/base.scm | 27 ++++++++++++++++----------- > 1 file changed, 16 insertions(+), 11 deletions(-) This was pushed as 2b1d708294f0aced5c991baed146e0ae4e7d63dd, closing! Ludo=E2=80=99. From unknown Fri Aug 15 14:45:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 15 Dec 2019 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator