GNU bug report logs - #37923
[PATCH 0/2] gnu: profanity: Add configure flags and inputs for better defaults.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37923 in the body.
You can then email your comments to 37923 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: Guix <guix-patches <at> gnu.org>
Subject: [PATCH 0/2] gnu: profanity: Add configure flags and inputs for
 better defaults.
Date: Fri, 25 Oct 2019 17:17:11 +0200

This makes OMEMO and desktop notifications available.
As Jack mentioned [1], the home page was redirected. I've updated it.

[1]: https://lists.gnu.org/archive/html/guix-devel/2019-10/msg00610.html

-- 
Tanguy

Message #8 received at 37923 <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: 37923 <at> debbugs.gnu.org
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: [PATCH 1/2] gnu: profanity: Add configure flags and inputs for better
 defaults.
Date: Fri, 25 Oct 2019 17:20:39 +0200

* gnu/packages/messaging.scm (profanity)[arguments]<#configure-flags>:
Add --enable-omemo, --enable-notifications and --enable-icon.
[native-inputs]: Add libnotify and libsignal-protocol-c.
---
 gnu/packages/messaging.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index f890ad8dd5..ca01a4492e 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1627,6 +1627,11 @@ are both supported).")
                (base32
                 "0nxh81j8ky0fzv47pip1jb7rs5rrin3jx0f3h632bvpjiya45r1z"))))
     (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "--enable-omemo"
+             "--enable-icon"
+             "--enable-notifications")))
     (inputs
      `(("curl" ,curl)
        ("expat" ,expat)
@@ -1642,7 +1647,9 @@ are both supported).")
        ("autoconf-archive" ,autoconf-archive)
        ("automake" ,automake)
        ("cmocka" ,cmocka)
+       ("libnotify" ,libnotify)
        ("libtool" ,libtool)
+       ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("pkg-config" ,pkg-config)))
     (synopsis "Console-based XMPP client")
     (description "Profanity is a console based XMPP client written in C
-- 
2.23.0

Message #11 received at 37923 <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: 37923 <at> debbugs.gnu.org
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: [PATCH 2/2] gnu: profanity: Update home-page URL.
Date: Fri, 25 Oct 2019 17:20:40 +0200

* gnu/packages/messaging.scm (profanity)[home-page]: Update URL.
---
 gnu/packages/messaging.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index ca01a4492e..afbb97487a 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1654,7 +1654,7 @@ are both supported).")
     (synopsis "Console-based XMPP client")
     (description "Profanity is a console based XMPP client written in C
 using ncurses and libmesode, inspired by Irssi.")
-    (home-page "http://www.profanity.im")
+    (home-page "https://profanity-im.github.io")
     (license license:gpl3+)))
 
 (define-public libircclient
-- 
2.23.0

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>, 37923 <at> debbugs.gnu.org
Subject: Re: [bug#37923] [PATCH 1/2] gnu: profanity: Add configure flags and
 inputs for better defaults.
Date: Fri, 25 Oct 2019 19:25:19 +0200

Hey Tanguy,

Much better with git send-email ;) A few remarks below:

> +     `(#:configure-flags
         ^
It can be ' because there are no unquoting in the following list.

> +             "--enable-icon"
                              ^
I think it is --enable-icons but that triggers missing inputs. You can
have a look to nix recipe if needed.

Thanks,

Mathieu

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 37923 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#37923] [PATCH 1/2] gnu: profanity: Add configure flags and
 inputs for better defaults.
Date: Sat, 26 Oct 2019 18:12:46 +0200

Hi Mathieu,


Le 10/25, Mathieu Othacehe a écrit :
> Much better with git send-email ;) A few remarks below:
> 
> > +     `(#:configure-flags
>          ^
> It can be ' because there are no unquoting in the following list.

Done!


> > +             "--enable-icon"
>                               ^
> I think it is --enable-icons but that triggers missing inputs. You can
> have a look to nix recipe if needed.

Outch! Sorry for that! Actually when I added it I thought "if I don't
spell it properly, configure will fail, won't it?"… obviously I was
wrong! ^_^'


v2 is following.

I also added "--enable-c-plugins" and "--enable-otr" with the comment
from Nix expression ("Enable feature flags, so that build fail if libs
are missing") in the commit message. And I added "--enable-pgp" in
a separate commit… but I guess you'll squash everything together, right?

I tried to add "--enable-python-plugins" and "python" as a native input,
but it did not work! So, for now, I left it out.

Thanks again for reviewing!

-- 
Tanguy

Message #26 received at 37923 <at> debbugs.gnu.org (full text, mbox):

From: tanguy <at> bioneland.org
To: 37923 <at> debbugs.gnu.org
Cc: tanguy <at> bioneland.org
Subject: [PATCH v2 1/4] gnu: profanity: Add configure flags and inputs for
 better defaults.
Date: Sat, 26 Oct 2019 18:16:50 +0200

From: Tanguy Le Carrour <tanguy <at> bioneland.org>

* gnu/packages/messaging.scm (profanity)[arguments]<#configure-flags>:
Add --enable-omemo, --enable-notifications and --enable-icon.
[native-inputs]: Add libnotify and libsignal-protocol-c.
---
 gnu/packages/messaging.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index f890ad8dd5..b56a3e92cb 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1627,6 +1627,11 @@ are both supported).")
                (base32
                 "0nxh81j8ky0fzv47pip1jb7rs5rrin3jx0f3h632bvpjiya45r1z"))))
     (build-system gnu-build-system)
+    (arguments
+     '(#:configure-flags
+       (list "--enable-omemo"
+             "--enable-icons"
+             "--enable-notifications")))
     (inputs
      `(("curl" ,curl)
        ("expat" ,expat)
@@ -1642,7 +1647,10 @@ are both supported).")
        ("autoconf-archive" ,autoconf-archive)
        ("automake" ,automake)
        ("cmocka" ,cmocka)
+       ("gtk+" ,gtk+-2)
+       ("libnotify" ,libnotify)
        ("libtool" ,libtool)
+       ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("pkg-config" ,pkg-config)))
     (synopsis "Console-based XMPP client")
     (description "Profanity is a console based XMPP client written in C
-- 
2.23.0

Message #29 received at 37923 <at> debbugs.gnu.org (full text, mbox):

From: tanguy <at> bioneland.org
To: 37923 <at> debbugs.gnu.org
Cc: "tlecarrour <at> easter-eggs.com" <tlecarrour <at> easter-eggs.com>,
 tanguy <at> bioneland.org
Subject: [PATCH v2 3/4] gnu: profanity: Add configure flags,
 so that build fail if libs are missing.
Date: Sat, 26 Oct 2019 18:16:52 +0200

From: "tlecarrour <at> easter-eggs.com" <tlecarrour <at> easter-eggs.com>

* gnu/packages/messaging.scm (profanity)[arguments]<#configure-flags>:
Add --enable-c-plugins and --enable-otr.
---
 gnu/packages/messaging.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 63b14287ce..626aec4908 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1629,7 +1629,9 @@ are both supported).")
     (build-system gnu-build-system)
     (arguments
      '(#:configure-flags
-       (list "--enable-omemo"
+       (list "--enable-c-plugins"
+             "--enable-otr"
+             "--enable-omemo"
              "--enable-icons"
              "--enable-notifications")))
     (inputs
-- 
2.23.0

Message #32 received at 37923 <at> debbugs.gnu.org (full text, mbox):

From: tanguy <at> bioneland.org
To: 37923 <at> debbugs.gnu.org
Cc: "tlecarrour <at> easter-eggs.com" <tlecarrour <at> easter-eggs.com>,
 tanguy <at> bioneland.org
Subject: [PATCH v2 4/4] gnu: profanity: Add configure flags for better
 defaults.
Date: Sat, 26 Oct 2019 18:16:53 +0200

From: "tlecarrour <at> easter-eggs.com" <tlecarrour <at> easter-eggs.com>

* gnu/packages/messaging.scm (profanity)[arguments]<#configure-flags>:
Add --enable-pgp.
---
 gnu/packages/messaging.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 626aec4908..a6e9dcbbb3 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1632,6 +1632,7 @@ are both supported).")
        (list "--enable-c-plugins"
              "--enable-otr"
              "--enable-omemo"
+             "--enable-pgp"
              "--enable-icons"
              "--enable-notifications")))
     (inputs
-- 
2.23.0

Message #35 received at 37923 <at> debbugs.gnu.org (full text, mbox):

From: tanguy <at> bioneland.org
To: 37923 <at> debbugs.gnu.org
Cc: tanguy <at> bioneland.org
Subject: [PATCH v2 2/4] gnu: profanity: Update home-page URL.
Date: Sat, 26 Oct 2019 18:16:51 +0200

From: Tanguy Le Carrour <tanguy <at> bioneland.org>

* gnu/packages/messaging.scm (profanity)[home-page]: Update URL.
---
 gnu/packages/messaging.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index b56a3e92cb..63b14287ce 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1655,7 +1655,7 @@ are both supported).")
     (synopsis "Console-based XMPP client")
     (description "Profanity is a console based XMPP client written in C
 using ncurses and libmesode, inspired by Irssi.")
-    (home-page "http://www.profanity.im")
+    (home-page "https://profanity-im.github.io")
     (license license:gpl3+)))
 
 (define-public libircclient
-- 
2.23.0

Message #38 received at 37923 <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: 37923 <at> debbugs.gnu.org
Subject: [PATCH 0/4] gnu: profanity: Add configure flags and inputs for
 better defaults.
Date: Sat, 26 Oct 2019 23:09:58 +0200

Wrong author in 2 of the commits! Sorry, sending v3!

-- 
Tanguy

Message #41 received at 37923 <at> debbugs.gnu.org (full text, mbox):

From: tanguy <at> bioneland.org
To: 37923 <at> debbugs.gnu.org
Cc: tanguy <at> bioneland.org
Subject: [PATCH v3 1/4] gnu: profanity: Add configure flags and inputs for
 better defaults.
Date: Sat, 26 Oct 2019 23:11:07 +0200

From: Tanguy Le Carrour <tanguy <at> bioneland.org>

* gnu/packages/messaging.scm (profanity)[arguments]<#configure-flags>:
Add --enable-omemo, --enable-notifications and --enable-icon.
[native-inputs]: Add libnotify and libsignal-protocol-c.
---
 gnu/packages/messaging.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index f890ad8dd5..b56a3e92cb 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1627,6 +1627,11 @@ are both supported).")
                (base32
                 "0nxh81j8ky0fzv47pip1jb7rs5rrin3jx0f3h632bvpjiya45r1z"))))
     (build-system gnu-build-system)
+    (arguments
+     '(#:configure-flags
+       (list "--enable-omemo"
+             "--enable-icons"
+             "--enable-notifications")))
     (inputs
      `(("curl" ,curl)
        ("expat" ,expat)
@@ -1642,7 +1647,10 @@ are both supported).")
        ("autoconf-archive" ,autoconf-archive)
        ("automake" ,automake)
        ("cmocka" ,cmocka)
+       ("gtk+" ,gtk+-2)
+       ("libnotify" ,libnotify)
        ("libtool" ,libtool)
+       ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("pkg-config" ,pkg-config)))
     (synopsis "Console-based XMPP client")
     (description "Profanity is a console based XMPP client written in C
-- 
2.23.0

Message #44 received at 37923 <at> debbugs.gnu.org (full text, mbox):

From: tanguy <at> bioneland.org
To: 37923 <at> debbugs.gnu.org
Cc: tanguy <at> bioneland.org
Subject: [PATCH v3 3/4] gnu: profanity: Add configure flags,
 so that build fail if libs are missing.
Date: Sat, 26 Oct 2019 23:11:09 +0200

From: Tanguy Le Carrour <tanguy <at> bioneland.org>

* gnu/packages/messaging.scm (profanity)[arguments]<#configure-flags>:
Add --enable-c-plugins and --enable-otr.
---
 gnu/packages/messaging.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 63b14287ce..626aec4908 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1629,7 +1629,9 @@ are both supported).")
     (build-system gnu-build-system)
     (arguments
      '(#:configure-flags
-       (list "--enable-omemo"
+       (list "--enable-c-plugins"
+             "--enable-otr"
+             "--enable-omemo"
              "--enable-icons"
              "--enable-notifications")))
     (inputs
-- 
2.23.0

Message #47 received at 37923 <at> debbugs.gnu.org (full text, mbox):

From: tanguy <at> bioneland.org
To: 37923 <at> debbugs.gnu.org
Cc: tanguy <at> bioneland.org
Subject: [PATCH v3 2/4] gnu: profanity: Update home-page URL.
Date: Sat, 26 Oct 2019 23:11:08 +0200

From: Tanguy Le Carrour <tanguy <at> bioneland.org>

* gnu/packages/messaging.scm (profanity)[home-page]: Update URL.
---
 gnu/packages/messaging.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index b56a3e92cb..63b14287ce 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1655,7 +1655,7 @@ are both supported).")
     (synopsis "Console-based XMPP client")
     (description "Profanity is a console based XMPP client written in C
 using ncurses and libmesode, inspired by Irssi.")
-    (home-page "http://www.profanity.im")
+    (home-page "https://profanity-im.github.io")
     (license license:gpl3+)))
 
 (define-public libircclient
-- 
2.23.0

Message #50 received at 37923 <at> debbugs.gnu.org (full text, mbox):

From: tanguy <at> bioneland.org
To: 37923 <at> debbugs.gnu.org
Cc: tanguy <at> bioneland.org
Subject: [PATCH v3 4/4] gnu: profanity: Add configure flags for better
 defaults.
Date: Sat, 26 Oct 2019 23:11:10 +0200

From: Tanguy Le Carrour <tanguy <at> bioneland.org>

* gnu/packages/messaging.scm (profanity)[arguments]<#configure-flags>:
Add --enable-pgp.
---
 gnu/packages/messaging.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 626aec4908..a6e9dcbbb3 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1632,6 +1632,7 @@ are both supported).")
        (list "--enable-c-plugins"
              "--enable-otr"
              "--enable-omemo"
+             "--enable-pgp"
              "--enable-icons"
              "--enable-notifications")))
     (inputs
-- 
2.23.0

Message #53 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: tanguy <at> bioneland.org, 37923-done <at> debbugs.gnu.org
Subject: Re: [bug#37923] [PATCH v3 1/4] gnu: profanity: Add configure flags
 and inputs for better defaults.
Date: Mon, 28 Oct 2019 11:31:07 +0100

Hello Tanguy,

Pushed with minor changes in commit log and title.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.