From unknown Sun Jun 22 00:54:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37916: GNUS: wrong item selected in gnus-thread-hide-subtree customization Resent-From: Sergey Organov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Oct 2019 07:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37916 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 37916@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.157198763115589 (code B ref -1); Fri, 25 Oct 2019 07:14:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Oct 2019 07:13:51 +0000 Received: from localhost ([127.0.0.1]:37203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNtnD-00043M-5r for submit@debbugs.gnu.org; Fri, 25 Oct 2019 03:13:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:54042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNtnB-00043F-Ef for submit@debbugs.gnu.org; Fri, 25 Oct 2019 03:13:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40001) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNtn9-0007xP-Rm for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 03:13:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNtn8-0005qu-NP for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 03:13:47 -0400 Received: from mail.javad.com ([54.86.164.124]:40122) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iNtn8-0005qR-Ef for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 03:13:46 -0400 Received: from osv (unknown [89.175.180.246]) by mail.javad.com (Postfix) with ESMTPSA id 4F8F03EB70 for ; Fri, 25 Oct 2019 07:13:45 +0000 (UTC) Authentication-Results: mail.javad.com; dkim=pass (1024-bit key; unprotected) header.d=javad.com header.i=@javad.com header.b=agy602yK; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=javad.com; s=default; t=1571987625; bh=NpWIZ/5kKDXAPtej2wvTVJ0wi9d2SIPtQ5eI6wl6b3E=; l=1166; h=Received:From:To:Subject; b=agy602yKwKZZ47TjWvD38+rt+XYpxR10si1i68a+cPm4iQuGr1NcUgET4IkSwRgbp mrPCtFnrLQKCzYsdyN13qKoGWjDTjNlpQhm/ZAdFKF3NWfAUA+f+MIFitVryz08fOv xK8Zd8Ynpdriasn23k8eDAwXdohAYJ5s0eJC1YHY= Authentication-Results: ip-172-31-2-110; spf=pass (sender IP is 89.175.180.246) smtp.mailfrom=osv@javad.com smtp.helo=osv Received-SPF: pass (ip-172-31-2-110: connection is authenticated) Received: from osv by osv with local (Exim 4.84_2) (envelope-from ) id 1iNtn5-0000PW-TB for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 10:13:43 +0300 From: Sergey Organov Date: Fri, 25 Oct 2019 10:13:43 +0300 Message-ID: <87mudp9u1k.fsf@osv.gnss.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 54.86.164.124 X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The "Non-nil" defcustom item is selected in customization buffer when actual value of the gnus-thread-hide-subtree is 'nil. -- 8< -- Fix gnus-thread-hide-subtree defcustom Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: javad.com] 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sorganov[at]gmail.com) 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=osv%40javad.com; ip=209.51.188.17; r=debbugs.gnu.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.51.188.17 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 SPOOFED_FREEMAIL No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) The "Non-nil" defcustom item is selected in customization buffer when actual value of the gnus-thread-hide-subtree is 'nil. -- 8< -- Fix gnus-thread-hide-subtree defcustom * lisp/gnus/gnus-sum.el (gnus-thread-hide-subtree): fix order of items to prevent first 'sexp' from matching 'nil, that caused "Non-nil" item to be selected in customization buffer when actual variable value is 'nil. --- lisp/gnus/gnus-sum.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index b5d7448..1970465 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -332,11 +332,11 @@ This can be a predicate specifier which says which threads to hide. If threads are hidden, you have to run the command `gnus-summary-show-thread' by hand or select an article." :group 'gnus-thread - :type '(radio (sexp :format "Non-nil\n" + :type '(radio (const nil) + (sexp :format "Non-nil\n" :match (lambda (widget value) (not (or (consp value) (functionp value)))) :value t) - (const nil) (sexp :tag "Predicate specifier"))) (defcustom gnus-thread-hide-killed t -- 2.1.4 From unknown Sun Jun 22 00:54:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37916: GNUS: wrong item selected in gnus-thread-hide-subtree customization Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Oct 2019 10:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37916 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sergey Organov Cc: 37916@debbugs.gnu.org Received: via spool by 37916-submit@debbugs.gnu.org id=B37916.157200000519140 (code B ref 37916); Fri, 25 Oct 2019 10:41:01 +0000 Received: (at 37916) by debbugs.gnu.org; 25 Oct 2019 10:40:05 +0000 Received: from localhost ([127.0.0.1]:37357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNx0n-0004yd-2t for submit@debbugs.gnu.org; Fri, 25 Oct 2019 06:40:05 -0400 Received: from quimby.gnus.org ([80.91.231.51]:55970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNx0i-0004y4-Sr for 37916@debbugs.gnu.org; Fri, 25 Oct 2019 06:40:03 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNx0e-0007mG-OG; Fri, 25 Oct 2019 12:39:59 +0200 From: Lars Ingebrigtsen References: <87mudp9u1k.fsf@osv.gnss.ru> Date: Fri, 25 Oct 2019 12:39:56 +0200 In-Reply-To: <87mudp9u1k.fsf@osv.gnss.ru> (Sergey Organov's message of "Fri, 25 Oct 2019 10:13:43 +0300") Message-ID: <87a79pds77.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sergey Organov writes: > The "Non-nil" defcustom item is selected in customization buffer when > actual value of the gnus-thread-hide-subtree is 'nil. Hm... 'nil and nil are the same. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sergey Organov writes: > The "Non-nil" defcustom item is selected in customization buffer when > actual value of the gnus-thread-hide-subtree is 'nil. Hm... 'nil and nil are the same. [...] > - :type '(radio (sexp :format "Non-nil\n" > + :type '(radio (const nil) > + (sexp :format "Non-nil\n" > :match (lambda (widget value) > (not (or (consp value) (functionp value)))) > :value t) > - (const nil) Oh, I see. I think the problem is that that :match is just wrong. Changing the order of the values (as this patch does) also makes the problem go away, but I think the right fix here is to fix the :match. So I've installed the following patch instead: diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index b5d744843f..f21bc7584e 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -334,7 +334,7 @@ gnus-thread-hide-subtree :group 'gnus-thread :type '(radio (sexp :format "Non-nil\n" :match (lambda (widget value) - (not (or (consp value) (functionp value)))) + (and value (not (functionp value)))) :value t) (const nil) (sexp :tag "Predicate specifier"))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 25 06:40:08 2019 Received: (at control) by debbugs.gnu.org; 25 Oct 2019 10:40:08 +0000 Received: from localhost ([127.0.0.1]:37360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNx0q-0004yv-Bg for submit@debbugs.gnu.org; Fri, 25 Oct 2019 06:40:08 -0400 Received: from quimby.gnus.org ([80.91.231.51]:55988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNx0n-0004ye-Lh for control@debbugs.gnu.org; Fri, 25 Oct 2019 06:40:05 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNx0k-0007mP-PI for control@debbugs.gnu.org; Fri, 25 Oct 2019 12:40:04 +0200 Date: Fri, 25 Oct 2019 12:40:02 +0200 Message-Id: <878sp9ds71.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #37916 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 37916 fixed close 37916 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 37916 fixed close 37916 27.1 quit From unknown Sun Jun 22 00:54:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37916: GNUS: wrong item selected in gnus-thread-hide-subtree customization Resent-From: Sergey Organov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Oct 2019 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37916 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: 37916@debbugs.gnu.org Received: via spool by 37916-submit@debbugs.gnu.org id=B37916.157200914716757 (code B ref 37916); Fri, 25 Oct 2019 13:13:01 +0000 Received: (at 37916) by debbugs.gnu.org; 25 Oct 2019 13:12:27 +0000 Received: from localhost ([127.0.0.1]:37463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNzOE-0004MD-VX for submit@debbugs.gnu.org; Fri, 25 Oct 2019 09:12:27 -0400 Received: from mail.javad.com ([54.86.164.124]:59469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNzO9-0004M2-TT for 37916@debbugs.gnu.org; Fri, 25 Oct 2019 09:12:25 -0400 Received: from osv (unknown [89.175.180.246]) by mail.javad.com (Postfix) with ESMTPSA id 31AB83EA59; Fri, 25 Oct 2019 13:12:21 +0000 (UTC) Authentication-Results: mail.javad.com; dkim=pass (1024-bit key; unprotected) header.d=javad.com header.i=@javad.com header.b=drE8b/9N; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=javad.com; s=default; t=1572009141; bh=IwGNZ4nUI6M4By+3MMLtmxA5E4I9vpARQgdQRIapG40=; l=877; h=Received:From:To:Subject; b=drE8b/9NnTGsewybNIuQh2Ui1YTMSaWFId5UW9cpnpeIJrtp/c6lZiLzLQgq5KKpp 7IsWZ9tQ95S6jypvdk7zoMMptoECdv1gZUCL8hasQH1zKYlSksFU/dD14rOsVLQcMH HUP2+hjo6BwRYXdhPhFJNJAdpE4QogMgm8PCU2wY= Authentication-Results: ip-172-31-2-110; spf=pass (sender IP is 89.175.180.246) smtp.mailfrom=osv@javad.com smtp.helo=osv Received-SPF: pass (ip-172-31-2-110: connection is authenticated) Received: from osv by osv with local (Exim 4.84_2) (envelope-from ) id 1iNzO7-0000qM-N4; Fri, 25 Oct 2019 16:12:19 +0300 From: Sergey Organov References: <87mudp9u1k.fsf@osv.gnss.ru> <87a79pds77.fsf@gnus.org> Date: Fri, 25 Oct 2019 16:12:19 +0300 In-Reply-To: <87a79pds77.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 25 Oct 2019 12:39:56 +0200") Message-ID: <87zhhp3r64.fsf@osv.gnss.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Lars Ingebrigtsen writes: > Sergey Organov writes: > >> The "Non-nil" defcustom item is selected in customization buffer when >> actual value of the gnus-thread-hide-subtree is 'nil. > > Hm... 'nil and nil are the same. > > [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnus.org] 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sorganov[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [54.86.164.124 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Lars Ingebrigtsen writes: > Sergey Organov writes: > >> The "Non-nil" defcustom item is selected in customization buffer when >> actual value of the gnus-thread-hide-subtree is 'nil. > > Hm... 'nil and nil are the same. > > [...] > >> - :type '(radio (sexp :format "Non-nil\n" >> + :type '(radio (const nil) >> + (sexp :format "Non-nil\n" >> :match (lambda (widget value) >> (not (or (consp value) (functionp value)))) >> :value t) >> - (const nil) > > Oh, I see. I think the problem is that that :match is just wrong. > Changing the order of the values (as this patch does) also makes the > problem go away, but I think the right fix here is to fix the :match. Yes, I also thought it is, but took kludgy way as I'm not familiar with the :math specifications. Thanks for fixing it the right way! -- Sergey