GNU bug report logs - #37908
[PATCH 0/2] Remove monolithic qt5 (and other unused package)

Previous Next

Full log

Message #40 received at 37908-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Efraim Flashner <efraim <at> flashner.co.il>, Ludovic Courtès
 <ludo <at> gnu.org>
Cc: 37908-close <at> debbugs.gnu.org
Subject: Re: [bug#37908] [PATCH 0/2] Remove monolithic qt5 (and other unused
 package)
Date: Fri, 1 Nov 2019 17:09:43 +0100

[Message part 1 (text/plain, inline)]

Am 01.11.19 um 15:39 schrieb Efraim Flashner:
>> Please ensure that “guix build qt <at> 4 -nd” returns the same derivation
>> before and after the change.


Done already before submitting the patch :-) But I repeated it now and
this revealed some error. So many thanks for nagging :-)

>>
>> Perhaps add a comment above saying that ‘qt’ used to refer to the
>> monolithic Qt 5.x package?
Done.

> I didn't apply it locally, I can do it in about 36 hours, but it looks
> good. IIRC we have qt4 inheriting from qt5, and qtbase was its own
> definition so nothing should change on that side.


Correct. I added some more explanation to the commit message to make
this more clear.

Pushed as  02511196d99ebc5e385e9dc7f733ffbe848e25ca

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.