GNU bug report logs - #37889
[PATCH] Remove obsolete doc references to XEmacs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37889 in the body.
You can then email your comments to 37889 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove obsolete doc references to XEmacs
Date: Wed, 23 Oct 2019 16:41:22 +0200

[Message part 1 (text/plain, inline)]

There are a few references in various doc strings and comments which I
think will confuse users and make maintaining Emacs harder for no
gain.

The attached patch removes most of them.  Any objections to any of this?

Best regards,
Stefan Kangas

[0001-Remove-obsolete-doc-references-to-XEmacs.patch (application/octet-stream, attachment)]

Message #8 received at 37889 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 37889 <at> debbugs.gnu.org
Subject: Re: bug#37889: [PATCH] Remove obsolete doc references to XEmacs
Date: Wed, 23 Oct 2019 21:56:01 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Wed, 23 Oct 2019 16:41:22 +0200
> 
> There are a few references in various doc strings and comments which I
> think will confuse users and make maintaining Emacs harder for no
> gain.
> 
> The attached patch removes most of them.  Any objections to any of this?

I object to the likes of this:

> --- a/doc/misc/pcl-cvs.texi
> +++ b/doc/misc/pcl-cvs.texi
> @@ -185,12 +185,6 @@ Contributors
>  Linus Tolke contributed useful comments
>  on both the functionality and the documentation.
>  
> -@item
> -@c jwz@@jwz.com
> -Jamie Zawinski contributed
> -@file{pcl-cvs-lucid.el}, which was later renamed to
> -@file{pcl-cvs-xemacs.el}.
> -
>  @item
>  Leif Lonnblad contributed RCVS support (since superseded by the new
>  remote CVS support).
> @@ -215,9 +209,8 @@ Contributors
>  
>  @item
>  @c greg.klanderman@@alum.mit.edu
> -Greg Klanderman implemented
> -toggling of marked files, setting of CVS command flags via prefix
> -arguments, updated the XEmacs support, updated the manual, and fixed
> +Greg Klanderman implemented toggling of marked files, setting of CVS
> +command flags via prefix arguments, updated the manual, and fixed
>  numerous bugs.

To me, this is akin to rewriting history: those people contributed to
the development in the past, and we should keep the attributions out
of respect for their work.

I have no problem with other changes you proposed.

Thanks.

Message #11 received at 37889 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37889 <at> debbugs.gnu.org
Subject: Re: bug#37889: [PATCH] Remove obsolete doc references to XEmacs
Date: Wed, 23 Oct 2019 22:16:10 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> > The attached patch removes most of them.  Any objections to any of this?
>
> I object to the likes of this:
[...]
> To me, this is akin to rewriting history: those people contributed to
> the development in the past, and we should keep the attributions out
> of respect for their work.

I mostly thought it was confusing to talk about contributions to
another text editor in our source code, but perhaps the patch was a
bit too enthusiastic.  I obviously agree that we should respect their
work, so I'll just take that part out.

> I have no problem with other changes you proposed.

Thanks for the review.

Best regards,
Stefan Kangas

Message #14 received at 37889 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37889 <at> debbugs.gnu.org
Subject: Re: bug#37889: [PATCH] Remove obsolete doc references to XEmacs
Date: Wed, 23 Oct 2019 22:38:14 +0200

[Message part 1 (text/plain, inline)]

I've attached a new version of the patch here, in case anyone has any
further comments.  Otherwise, I intend to commit this in a couple of
days.

Best regards,
Stefan Kangas

[0001-Remove-obsolete-doc-references-to-XEmacs-Bug-37899.patch (application/octet-stream, attachment)]

Message #17 received at 37889 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37889 <at> debbugs.gnu.org
Subject: Re: bug#37889: [PATCH] Remove obsolete doc references to XEmacs
Date: Mon, 28 Oct 2019 15:56:27 +0100

close 37889 27.1
quit

Stefan Kangas <stefan <at> marxist.se> writes:
> I've attached a new version of the patch here, in case anyone has any
> further comments.  Otherwise, I intend to commit this in a couple of
> days.

Now pushed to master as commit c515d4eeb2.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.