GNU bug report logs - #37878
[PATCH] Add auto-insert skeleton for ".dir-locals.el"

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37878 in the body.
You can then email your comments to 37878 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add auto-insert skeleton for ".dir-locals.el"
Date: Wed, 23 Oct 2019 01:04:15 +0200

[Message part 1 (text/plain, inline)]

Steps to reproduce:
0. emacs -Q
1. M-x auto-insert-mode
2. C-x C-f .dir-locals.el RET

Result: The entire Emacs standard header gets inserted into the
buffer, complete with author, copyright notice, provide-statement,
etc.
Expected result: Either don't insert anything or use a custom skeleton.

Please find attached a proposed patch, which adds a skeleton for
"dir-locals.el" to auto-insert-alist.  I believe it would make it
easier for especially beginning Emacs users to use ".dir-locals.el".
(Open the file, type M-x auto-insert, and voilá.)

Any comments?

Best regards,
Stefan Kangas

[0001-Add-auto-insert-skeleton-for-.dir-locals.el.patch (application/octet-stream, attachment)]

Message #8 received at 37878 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 37878 <at> debbugs.gnu.org
Subject: Re: bug#37878: [PATCH] Add auto-insert skeleton for ".dir-locals.el"
Date: Thu, 24 Oct 2019 00:19:09 +0300

> Steps to reproduce:
> 0. emacs -Q
> 1. M-x auto-insert-mode
> 2. C-x C-f .dir-locals.el RET
>
> Result: The entire Emacs standard header gets inserted into the
> buffer, complete with author, copyright notice, provide-statement,
> etc.
> Expected result: Either don't insert anything or use a custom skeleton.
>
> Please find attached a proposed patch, which adds a skeleton for
> "dir-locals.el" to auto-insert-alist.  I believe it would make it
> easier for especially beginning Emacs users to use ".dir-locals.el".
> (Open the file, type M-x auto-insert, and voilá.)
>
> Any comments?

Good addition for someone who doesn't use add-dir-local-variable
that inserts this header.

BTW, please also add the same two lines to the header of
.dir-locals.el in Emacs repository.

Message #11 received at 37878 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37878 <at> debbugs.gnu.org
Subject: Re: bug#37878: [PATCH] Add auto-insert skeleton for ".dir-locals.el"
Date: Sat, 02 Nov 2019 04:30:14 +0100

close 37878 27.1
thanks

Juri Linkov <juri <at> linkov.net> writes:

>> Steps to reproduce:
>> 0. emacs -Q
>> 1. M-x auto-insert-mode
>> 2. C-x C-f .dir-locals.el RET
>>
>> Result: The entire Emacs standard header gets inserted into the
>> buffer, complete with author, copyright notice, provide-statement,
>> etc.
>> Expected result: Either don't insert anything or use a custom skeleton.
>>
>> Please find attached a proposed patch, which adds a skeleton for
>> "dir-locals.el" to auto-insert-alist.  I believe it would make it
>> easier for especially beginning Emacs users to use ".dir-locals.el".
>> (Open the file, type M-x auto-insert, and voilá.)
>>
>> Any comments?
>
> Good addition for someone who doesn't use add-dir-local-variable
> that inserts this header.

Thanks for the review.  Now pushed to master as commit 6c82aafcc0.

> BTW, please also add the same two lines to the header of
> .dir-locals.el in Emacs repository.

Good idea.  I did that in commit 7cde03484.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.