From unknown Fri Jun 20 07:19:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37874: 27.0.50; A recent commit broke doc-view (and pdf-tools) Resent-From: Andreas Politz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Oct 2019 18:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37874 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 37874@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15717688748787 (code B ref -1); Tue, 22 Oct 2019 18:28:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Oct 2019 18:27:54 +0000 Received: from localhost ([127.0.0.1]:60472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMyss-0002He-Cf for submit@debbugs.gnu.org; Tue, 22 Oct 2019 14:27:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:47681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMysr-0002HX-93 for submit@debbugs.gnu.org; Tue, 22 Oct 2019 14:27:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58417) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMysp-0001fQ-Uu for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 14:27:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMyso-0001bF-GX for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 14:27:51 -0400 Received: from gateway-a.fh-trier.de ([143.93.54.181]:55428) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iMyso-0001Xc-0t for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 14:27:50 -0400 X-Virus-Scanned: by Amavisd-new + Sophos + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Received: from localhost (x4dbd8c51.dyn.telefonica.de [77.189.140.81]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id 64FA31906BBD for ; Tue, 22 Oct 2019 20:27:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1571768858; bh=rSgJqlBr8jDOjcQhHprkdVR+7dE=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=SWzLxczyrfR8tG79k97jMb/fu4YGOig0OhDiudP85Ju6FXIO9oPk4qWGBoRVHetY7 0hbTZA9Rs+votxSJgI9zbpQXeFg3njD91jk3NlikOT0Q/O0XqAcu/IVMV/dkj9WwAE 8AmQ3wX2eGV+icJbFViQrpc4PbRJccIn7wmQlbak= From: Andreas Politz Date: Tue, 22 Oct 2019 20:27:37 +0200 Message-ID: <87wocwprdy.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 143.93.54.181 X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Since commit 9c66b09950cf2db50eb6d818656a268ef750bfe6 image-next-line returns the current window-vscroll as a unit of pixels. Before, it was returning it in terms of character-height. This breaks multiple functions in doc-view, which are comparing those values to the value of (window-vscroll). If this change is going to stay doc-view.el needs to be adapted as well. -ap From unknown Fri Jun 20 07:19:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37874: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37874 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tassilo Horn Cc: 37874@debbugs.gnu.org, 37578@debbugs.gnu.org, politza@hochschule-trier.de Received: via spool by 37874-submit@debbugs.gnu.org id=B37874.157185353732643 (code B ref 37874); Wed, 23 Oct 2019 17:59:02 +0000 Received: (at 37874) by debbugs.gnu.org; 23 Oct 2019 17:58:57 +0000 Received: from localhost ([127.0.0.1]:34974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNKuP-0008UP-70 for submit@debbugs.gnu.org; Wed, 23 Oct 2019 13:58:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNKuK-0008U0-Cs; Wed, 23 Oct 2019 13:58:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iNKuB-0006sa-Vh; Wed, 23 Oct 2019 13:58:44 -0400 Received: from [176.228.60.248] (port=2636 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iNKu2-0006wP-AF; Wed, 23 Oct 2019 13:58:35 -0400 Date: Wed, 23 Oct 2019 20:58:15 +0300 Message-Id: <8336fjz6mg.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87a79rxx5y.fsf@gnu.org> (message from Tassilo Horn on Wed, 23 Oct 2019 18:07:53 +0200) References: <83wodj4lab.fsf@gnu.org> <86muejsert.fsf@gmail.com> <87a79rxx5y.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tassilo Horn > Cc: ynyaaa@gmail.com, 37578@debbugs.gnu.org, Eli Zaretskii > Date: Wed, 23 Oct 2019 18:07:53 +0200 > > > image-mode.el was scrolling images vertically in units of canonical > > character height, so it couldn't handle the last portion of an image > > smaller than the height of one character. > > > > This is now fixed on the master branch. > > Your change 9c66b09950cf2db50eb6d818656a268ef750bfe6 broke doc-view.el > and the pdf-tools package whose author already filed bug#37874 for the > issue. > > Could you have a look? If the image functions stay returning pixel > values that's ok but Andreas and I will need to adapt pdf-tools and > doc-view.el accordingly. Sorry, I didn't think some other package will use that function, it looked like an internal subroutine. I should have checked. To answer your question: I see no reason to go back to character units in this function. We could either adapt the other packages to the change, or add a new function that will work like the previous image-next-line. What would you prefer? If the only problem is with comparing against the value returned by window-vscroll, then perhaps the former is easier and simpler? Thanks. From unknown Fri Jun 20 07:19:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image) References: <87wocwprdy.fsf@hochschule-trier.de> In-Reply-To: <87wocwprdy.fsf@hochschule-trier.de> Resent-From: Andreas Politz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 18:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37874 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Tassilo Horn Cc: 37874@debbugs.gnu.org, 37578@debbugs.gnu.org Received: via spool by 37874-submit@debbugs.gnu.org id=B37874.15718565485315 (code B ref 37874); Wed, 23 Oct 2019 18:50:02 +0000 Received: (at 37874) by debbugs.gnu.org; 23 Oct 2019 18:49:08 +0000 Received: from localhost ([127.0.0.1]:35026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNLgy-0001Na-D4 for submit@debbugs.gnu.org; Wed, 23 Oct 2019 14:49:08 -0400 Received: from gateway-b.fh-trier.de ([143.93.54.182]:59036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNLgu-0001NL-NY; Wed, 23 Oct 2019 14:49:05 -0400 X-Virus-Scanned: by Amavisd-new + Sophos + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Received: from [192.168.178.20] (x4db50291.dyn.telefonica.de [77.181.2.145]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-b.fh-trier.de (Postfix) with ESMTPSA id 6CC0517B542; Wed, 23 Oct 2019 20:49:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1571856542; bh=+Hee+ckDEyIjXtI25+rJ4gItUYk=; h=Date:Subject:Message-ID:From:To:Cc:MIME-Version:Content-Type; b=LARhsZNLBH4vSmIgMenMrfNUA+JAR+EB5Q6f9CCvGnAICD8uJ6miv7W3w2KIU4Udx acbI/kgD8dNBrjTJtD7xJgPv2MOzCZJH4+PK05b6mT0iETSXSv4Jqfy+RCwYzdwB8T CLByyShvK0ryAMfLCVcXwAm4tb6Azqrofe43rHCA= Date: Wed, 23 Oct 2019 20:49:04 +0200 Message-ID: Importance: normal From: Andreas Politz MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="--_com.android.email_2456543848563990" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) ----_com.android.email_2456543848563990 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SSBoYXZlIGFscmVhZHkgYWRhcHRlZCBteSBwYWNrYWdlIGluIGEgYnJhbmNoLiDCoEFuZCBJIHRo aW5rIHRoZSByZXF1aXJlZCBjaGFuZ2VzIGFyZSBzdHJhaWdodGZvcndhcmQuIEkgc3VwcG9zZSB0 aGUgc2FtZSBob2xkcyBmb3IgZG9jLXZpZXcuCgpBbmRyZWFz ----_com.android.email_2456543848563990 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGh0bWw+PGhlYWQ+PG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0 L2h0bWw7IGNoYXJzZXQ9VVRGLTgiPjwvaGVhZD48Ym9keSA+SSBoYXZlIGFscmVhZHkgYWRhcHRl ZCBteSBwYWNrYWdlIGluIGEgYnJhbmNoLiAmbmJzcDtBbmQgSSB0aGluayB0aGUgcmVxdWlyZWQg Y2hhbmdlcyBhcmUgc3RyYWlnaHRmb3J3YXJkLiBJIHN1cHBvc2UgdGhlIHNhbWUgaG9sZHMgZm9y IGRvYy12aWV3LjxkaXY+PGJyPjwvZGl2PjxkaXY+QW5kcmVhczwvZGl2PjwvYm9keT48L2h0bWw+ ----_com.android.email_2456543848563990-- From unknown Fri Jun 20 07:19:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image) Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 18:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37874 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Politz , Eli Zaretskii Cc: 37874@debbugs.gnu.org, 37578@debbugs.gnu.org Received: via spool by 37874-submit@debbugs.gnu.org id=B37874.15718570306105 (code B ref 37874); Wed, 23 Oct 2019 18:58:02 +0000 Received: (at 37874) by debbugs.gnu.org; 23 Oct 2019 18:57:10 +0000 Received: from localhost ([127.0.0.1]:35037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNLoj-0001aJ-Ub for submit@debbugs.gnu.org; Wed, 23 Oct 2019 14:57:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNLoh-0001a1-GB; Wed, 23 Oct 2019 14:57:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iNLob-0003e6-7U; Wed, 23 Oct 2019 14:57:01 -0400 Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:41893) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1iNLoS-0003aX-JI; Wed, 23 Oct 2019 14:56:55 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id D74BC21BF7; Wed, 23 Oct 2019 14:56:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 23 Oct 2019 14:56:51 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrkeelgddufeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvfffkjghffgfugggtgfesthekgidttderjeenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucfkphepkeegrddufedvrd elledrgeeinecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgr uhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedvleekqdhtshguhh eppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhmnecuvehluhhsthgvrhfuihiivgep td X-ME-Proxy: Received: from [192.168.0.109] (p5484632e.dip0.t-ipconnect.de [84.132.99.46]) by mail.messagingengine.com (Postfix) with ESMTPA id 50E28D6005A; Wed, 23 Oct 2019 14:56:50 -0400 (EDT) From: Tassilo Horn Date: Wed, 23 Oct 2019 20:56:48 +0200 Message-ID: <16df9fa8580.27dc.69bc538c4644581689883e654f15bce0@gnu.org> In-Reply-To: References: User-Agent: AquaMail/1.20.0-1469 (build: 102100004) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="UTF-8" Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On October 23, 2019 8:49:17 PM Andreas Politz wrote: > I have already adapted my package in a branch.  And I think the required > changes are straightforward. I suppose the same holds for doc-view. Ok, great. I'll adapt doc-view.el ASAP and then close this issue. Thanks for your report. Bye, Tassilo From unknown Fri Jun 20 07:19:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 19:03:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37874 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tassilo Horn Cc: 37874@debbugs.gnu.org, 37578@debbugs.gnu.org, politza@hochschule-trier.de Received: via spool by 37874-submit@debbugs.gnu.org id=B37874.157185732813179 (code B ref 37874); Wed, 23 Oct 2019 19:03:03 +0000 Received: (at 37874) by debbugs.gnu.org; 23 Oct 2019 19:02:08 +0000 Received: from localhost ([127.0.0.1]:35043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNLtX-0003Q6-Ja for submit@debbugs.gnu.org; Wed, 23 Oct 2019 15:02:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNLtT-0003Lp-9p; Wed, 23 Oct 2019 15:02:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iNLtO-00058y-2y; Wed, 23 Oct 2019 15:01:58 -0400 Received: from [176.228.60.248] (port=2508 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iNLtG-00028T-Uq; Wed, 23 Oct 2019 15:01:53 -0400 Date: Wed, 23 Oct 2019 22:01:33 +0300 Message-Id: <83tv7zxp4i.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <16df9fa8580.27dc.69bc538c4644581689883e654f15bce0@gnu.org> (message from Tassilo Horn on Wed, 23 Oct 2019 20:56:48 +0200) References: <16df9fa8580.27dc.69bc538c4644581689883e654f15bce0@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tassilo Horn > CC: <37578@debbugs.gnu.org>, <37874@debbugs.gnu.org> > Date: Wed, 23 Oct 2019 20:56:48 +0200 > > On October 23, 2019 8:49:17 PM Andreas Politz > wrote: > > > I have already adapted my package in a branch.  And I think the required > > changes are straightforward. I suppose the same holds for doc-view. > > Ok, great. I'll adapt doc-view.el ASAP and then close this issue. Thanks > for your report. Thanks, and sorry again for not being more vigilant. From unknown Fri Jun 20 07:19:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Andreas Politz Subject: bug#37874: closed (Re: bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image)) Message-ID: References: <87o8y4wp5l.fsf@gnu.org> <87wocwprdy.fsf@hochschule-trier.de> X-Gnu-PR-Message: they-closed 37874 X-Gnu-PR-Package: emacs Reply-To: 37874@debbugs.gnu.org Date: Fri, 25 Oct 2019 20:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1572035042-4779-1" This is a multi-part message in MIME format... ------------=_1572035042-4779-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #37874: 27.0.50; A recent commit broke doc-view (and pdf-tools) which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 37874@debbugs.gnu.org. --=20 37874: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D37874 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1572035042-4779-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 37874-done) by debbugs.gnu.org; 25 Oct 2019 20:23:18 +0000 Received: from localhost ([127.0.0.1]:39399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iO67B-0001Dq-U2 for submit@debbugs.gnu.org; Fri, 25 Oct 2019 16:23:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iO678-0001DS-Dc; Fri, 25 Oct 2019 16:23:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iO672-0002sd-9Z; Fri, 25 Oct 2019 16:23:08 -0400 Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:40759) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1iO671-0005G0-LQ; Fri, 25 Oct 2019 16:23:07 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id E7D0D210F2; Fri, 25 Oct 2019 16:23:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 25 Oct 2019 16:23:05 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleefgdduhedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtgfesthhqredttderjeenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucfkphepkeegrddufedvrd elledrgeeinecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgr uhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedvleekqdhtshguhh eppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhmnecuvehluhhsthgvrhfuihiivgep td X-ME-Proxy: Received: from thinkpad-t440p (p5484632e.dip0.t-ipconnect.de [84.132.99.46]) by mail.messagingengine.com (Postfix) with ESMTPA id 8D1728005B; Fri, 25 Oct 2019 16:23:04 -0400 (EDT) From: Tassilo Horn To: Eli Zaretskii Subject: Re: bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image) References: <16df9fa8580.27dc.69bc538c4644581689883e654f15bce0@gnu.org> <83tv7zxp4i.fsf@gnu.org> Date: Fri, 25 Oct 2019 22:23:02 +0200 In-Reply-To: <83tv7zxp4i.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 23 Oct 2019 22:01:33 +0300") Message-ID: <87o8y4wp5l.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37874-done Cc: 37874-done@debbugs.gnu.org, 37578@debbugs.gnu.org, politza@hochschule-trier.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> > I have already adapted my package in a branch. =C2=A0And I think the >> > required changes are straightforward. I suppose the same holds for >> > doc-view. >>=20 >> Ok, great. I'll adapt doc-view.el ASAP and then close this >> issue. Thanks for your report. I've fixed doc-view just now (bug#37874) with commit a0f7ea5999. > Thanks, and sorry again for not being more vigilant. You're welcome, Tassilo ------------=_1572035042-4779-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Oct 2019 18:27:54 +0000 Received: from localhost ([127.0.0.1]:60472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMyss-0002He-Cf for submit@debbugs.gnu.org; Tue, 22 Oct 2019 14:27:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:47681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMysr-0002HX-93 for submit@debbugs.gnu.org; Tue, 22 Oct 2019 14:27:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58417) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMysp-0001fQ-Uu for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 14:27:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMyso-0001bF-GX for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 14:27:51 -0400 Received: from gateway-a.fh-trier.de ([143.93.54.181]:55428) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iMyso-0001Xc-0t for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 14:27:50 -0400 X-Virus-Scanned: by Amavisd-new + Sophos + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Received: from localhost (x4dbd8c51.dyn.telefonica.de [77.189.140.81]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id 64FA31906BBD for ; Tue, 22 Oct 2019 20:27:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1571768858; bh=rSgJqlBr8jDOjcQhHprkdVR+7dE=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=SWzLxczyrfR8tG79k97jMb/fu4YGOig0OhDiudP85Ju6FXIO9oPk4qWGBoRVHetY7 0hbTZA9Rs+votxSJgI9zbpQXeFg3njD91jk3NlikOT0Q/O0XqAcu/IVMV/dkj9WwAE 8AmQ3wX2eGV+icJbFViQrpc4PbRJccIn7wmQlbak= From: Andreas Politz To: bug-gnu-emacs@gnu.org Subject: 27.0.50; A recent commit broke doc-view (and pdf-tools) Date: Tue, 22 Oct 2019 20:27:37 +0200 Message-ID: <87wocwprdy.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 143.93.54.181 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Since commit 9c66b09950cf2db50eb6d818656a268ef750bfe6 image-next-line returns the current window-vscroll as a unit of pixels. Before, it was returning it in terms of character-height. This breaks multiple functions in doc-view, which are comparing those values to the value of (window-vscroll). If this change is going to stay doc-view.el needs to be adapted as well. -ap ------------=_1572035042-4779-1--