GNU bug report logs - #37869
[PATCH] pull: Honor '/etc/guix/channels.scm'.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 37869 <at> debbugs.gnu.org
Subject: [bug#37869] [PATCH] pull: Honor '/etc/guix/channels.scm'.
Date: Fri, 01 Nov 2019 12:24:30 +0100

Hi Oleg,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
> […]
>
>>> From: Ludovic Courtès <ludovic.courtes <at> inria.fr>
>>>
>>> * guix/scripts/pull.scm (channel-list)[global-file]: New variable.
>>> [channels]: Honor it.
>>> * doc/guix.texi (Invoking guix pull): Document it.
>>
>> Pushed as 49af34cfac89d384c46269bfd9388b2c73b1220a.
>
> I got an error during the guix pull:
>
> oleg <at> guixsd ~$ guix pull
> News for channel 'guix'
> Backtrace:
> In guix/ui.scm:
>   1730:12 19 (run-guix-command _ . _)
> In ice-9/boot-9.scm:
>     829:9 18 (catch _ _ #<procedure 7f289995e018 at guix/ui.scm:642…> …)
>     829:9 17 (catch _ _ #<procedure 7f289995e030 at guix/ui.scm:765…> …)
>     829:9 16 (catch _ _ #<procedure 7f2896e85828 at guix/scripts/pu…> …)
> In guix/store.scm:
>    623:10 15 (call-with-store _)
> In guix/status.scm:
>     768:4 14 (call-with-status-report _ _)
> In guix/scripts/pull.scm:
>    804:24 13 (_)
> In guix/store.scm:
>   1815:24 12 (run-with-store #<store-connection 256.99 7f288e2ff3c0> …)
> In guix/scripts/pull.scm:
>    393:28 11 (_ #<store-connection 256.99 7f288a4366c0>)
>    356:15 10 (display-channel-news-headlines _)
> In srfi/srfi-1.scm:
>    592:29  9 (map1 _)
>    592:17  8 (map1 ((#<<channel> name: guix url: "https://git.sa…> …)))
> In guix/scripts/pull.scm:
>    283:11  7 (display-channel-specific-news _ _ #:port _ #:concise? _)
> In srfi/srfi-1.scm:
>     640:9  6 (for-each #<procedure 7f2888451060 at guix/scripts/pul…> …)
> In guix/scripts/pull.scm:
>    241:12  5 (display-news-entry-title _ _ #<output: file /dev/pts/13>)
> In guix/ui.scm:
>   1210:23  4 (texi->plain-text _)
> In texinfo.scm:
>   1131:22  3 (parse _)
>    979:31  2 (loop #<input: string 7f289890b930> (*fragment*) _ _ _)
>    910:31  1 (loop #<input: string 7f289890b930> #f #<procedure ide…> …)
>    745:27  0 (_ #<input: string 7f289890b930> #f #f #<procedure 7f2…> …)
>
> texinfo.scm:745:27: Throw to key `parser-error' with args `(#<input: string 7f289890b930> "EOF while reading a token " "reading char data")'.

My bad!  Tobias fixed it in 6b00a5f4a79819db08cb4d8e9f24a01445b7962b,
thanks Tobias!

I think we need (1) a way to validate channel news, and (2) graceful
handling of Texinfo errors.  Commit
6330db4d55bf9be3702cc03145470c970fb7ae9b implements #2.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.