Subject: Re: [bug#37863] [PATCH] gnu: emacs-helm-projectile: Apply patch.

From: Mathieu Othacehe <[email-masked]>
Date: Mon, 28 Oct 2019 15:45:55 +0100

Hello Stephen,

As this project seems unmaintained and the last release was in 2016, I
think the best option would be to package a 0.14.0-1 based on
helm-projectile last commit.

Thanks,

Mathieu

Stephen Webber writes:

> * gnu/packages/emacs-xyz.scm (emacs-helm-projectile): Apply patch.
> * gnu/packages/patches/emacs-helm-projectile-require-dash.patch: New file.
> ---
>  gnu/packages/emacs-xyz.scm                          |  4 +++-
>  .../emacs-helm-projectile-require-dash.patch        | 13 +++++++++++++
>  2 files changed, 16 insertions(+), 1 deletion(-)
>  create mode 100644 gnu/packages/patches/emacs-helm-projectile-require-dash.patch
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 8c3c50efdc..5ed2cf67bc 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -6967,7 +6967,9 @@ as well as features for editing search results.")
>               (commit (string-append "v" version))))
>         (file-name (git-file-name name version))
>         (sha256
> -        (base32 "0lph38p112fridighqcizpsyzjbv7qr3d8prbfj6w6q6gfl6cna4"))))
> +        (base32 "0lph38p112fridighqcizpsyzjbv7qr3d8prbfj6w6q6gfl6cna4"))
> +       (patches
> +        (search-patches "emacs-helm-projectile-require-dash.patch"))))
>      (build-system emacs-build-system)
>      (propagated-inputs
>       `(("emacs-dash" ,emacs-dash)
> diff --git a/gnu/packages/patches/emacs-helm-projectile-require-dash.patch b/gnu/packages/patches/emacs-helm-projectile-require-dash.patch
> new file mode 100644
> index 0000000000..9da3deff50
> --- /dev/null
> +++ b/gnu/packages/patches/emacs-helm-projectile-require-dash.patch
> @@ -0,0 +1,13 @@
> +Make dash dependency explicit - this issue is resolved in master and is
> +documented at https://github.com/bbatsov/helm-projectile/issues/120
> +
> +--- a/helm-projectile.el
> ++++ b/helm-projectile.el
> +@@ -41,6 +41,7 @@
> + 
> + (require 'projectile)
> + (require 'cl-lib)
> ++(require 'dash)
> + (require 'grep)
> + (require 'helm)
> + (require 'helm-types)