GNU bug report logs - #37833
[PATCH] sddm-service-type: Add default configuration.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Brendan Tildesley <mail <at> brendan.scot>
Subject: bug#37833: closed (Re: [bug#37833] [PATCH] sddm-service-type: Add
 default configuration.)
Date: Mon, 21 Oct 2019 13:48:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#37833: [PATCH] sddm-service-type: Add default configuration.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 37833 <at> debbugs.gnu.org.

-- 
37833: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37833
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brendan Tildesley <mail <at> brendan.scot>
Cc: 37833-done <at> debbugs.gnu.org
Subject: Re: [bug#37833] [PATCH] sddm-service-type: Add default configuration.
Date: Mon, 21 Oct 2019 15:47:02 +0200

Hi Brendan,

Brendan Tildesley <mail <at> brendan.scot> skribis:

> * gnu/services/sddm.scm: Unlike gdm-service-type, sddm-service-type cannot be
> configured in an operating-system configuration by simply adding (service
> sddm-service-type). This adds the default SDDM configuration just like GDM
> does.

Applied with a tweaked commit log that more closely matches our
conventions.

Thank you!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Brendan Tildesley <mail <at> brendan.scot>
To: guix-patches <at> gnu.org
Subject: [PATCH] sddm-service-type: Add default configuration.
Date: Sun, 20 Oct 2019 23:12:02 +0900

* gnu/services/sddm.scm: Unlike gdm-service-type, sddm-service-type cannot be
configured in an operating-system configuration by simply adding (service
sddm-service-type). This adds the default SDDM configuration just like GDM
does.
---
 gnu/services/sddm.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm
index b0e6d40260..f33f1f93b9 100644
--- a/gnu/services/sddm.scm
+++ b/gnu/services/sddm.scm
@@ -316,7 +316,8 @@ Relogin="              (if (sddm-configuration-relogin? config)
                         (service-extension account-service-type
                                            (const %sddm-accounts))
                         (service-extension profile-service-type
-                                           sddm-profile-service)))))
+                                           sddm-profile-service)))
+                (default-value (sddm-configuration))))
 
 (define* (sddm-service #:optional (config (sddm-configuration)))
   "Run the @uref{https://github.com/sddm/sddm,SSDM display manager}
-- 
2.23.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.