Subject: bug#37833: closed (Re: [bug#37833] [PATCH] sddm-service-type: Add default configuration.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 21 Oct 2019 13:48:02 +0000

Your bug report

#37833: [PATCH] sddm-service-type: Add default configuration.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
37833: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37833
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#37833] [PATCH] sddm-service-type: Add default configuration.
From: Ludovic Courtès <[email-masked]>
To: Brendan Tildesley <[email-masked]>
Cc: [email-masked]
Date: Mon, 21 Oct 2019 15:47:02 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Brendan,

Brendan Tildesley <[email-masked]> skribis:

> * gnu/services/sddm.scm: Unlike gdm-service-type, sddm-service-type cannot be
> configured in an operating-system configuration by simply adding (service
> sddm-service-type). This adds the default SDDM configuration just like GDM
> does.

Applied with a tweaked commit log that more closely matches our
conventions.

Thank you!

Ludo’.

Subject: [PATCH] sddm-service-type: Add default configuration.
From: Brendan Tildesley <[email-masked]>
To: [email-masked]
Date: Sun, 20 Oct 2019 23:12:02 +0900
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/services/sddm.scm: Unlike gdm-service-type, sddm-service-type cannot be
configured in an operating-system configuration by simply adding (service
sddm-service-type). This adds the default SDDM configuration just like GDM
does.
---
 gnu/services/sddm.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm
index b0e6d40260..f33f1f93b9 100644
--- a/gnu/services/sddm.scm
+++ b/gnu/services/sddm.scm
@@ -316,7 +316,8 @@ Relogin="              (if (sddm-configuration-relogin? config)
                         (service-extension account-service-type
                                            (const %sddm-accounts))
                         (service-extension profile-service-type
-                                           sddm-profile-service)))))
+                                           sddm-profile-service)))
+                (default-value (sddm-configuration))))
 
 (define* (sddm-service #:optional (config (sddm-configuration)))
   "Run the @uref{https://github.com/sddm/sddm,SSDM display manager}
-- 
2.23.0