Subject: bug#37825: closed (Re: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 31 Oct 2019 23:24:02 +0000

Your bug report

#37825: [PATCH] gnu: bitcoin-abc: Update to 0.20.4.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
37825: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37825
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4.
From: Marius Bakke <[email-masked]>
To: Guillaume Le Vaillant <[email-masked]>, [email-masked]
Cc: Guillaume Le Vaillant <[email-masked]>
Date: Fri, 01 Nov 2019 00:23:45 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Guillaume Le Vaillant <[email-masked]> writes:

> * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4.
>   [source]: Fix uri.
>   [inputs]: Use bdb-5.3 (bdb-4.8 is not supported).
>   [arguments]: Add 'fix-tests' phase.

[...]

> +    (arguments
> +     (substitute-keyword-arguments (package-arguments bitcoin-core)
> +       ((#:phases phases)
> +        `(modify-phases ,phases
> +           (add-after 'unpack 'fix-tests
> +             ;; Disable 'check-devtools' test which tries to run a
> +             ;; python script that doesn't exist.
> +             (lambda _
> +               (substitute* "Makefile.in"
> +                 (("^check-local: check-devtools")
> +                  "check-local:"))
> +               #t))))))

Do you know why this script is not distributed?  Should we provide it,
or was it a packaging mistake upstream?

In any case I pushed this patch in
28d46d9d4317180b348ad5baeddad8ef25ed430a.  Thank you!

Subject: [PATCH] gnu: bitcoin-abc: Update to 0.20.4.
From: Guillaume Le Vaillant <[email-masked]>
To: [email-masked]
Cc: Guillaume Le Vaillant <[email-masked]>
Date: Sat, 19 Oct 2019 20:48:37 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4.
  [source]: Fix uri.
  [inputs]: Use bdb-5.3 (bdb-4.8 is not supported).
  [arguments]: Add 'fix-tests' phase.
---
 gnu/packages/finance.scm | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 960e3adeb3..0ab6489aeb 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -1133,15 +1133,35 @@ Trezor wallet.")
   (package
     (inherit bitcoin-core)
     (name "bitcoin-abc")
-    (version "0.19.8")
+    (version "0.20.4")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://download.bitcoinabc.org/"
-                                  version "/linux/src/bitcoin-abc-"
+                                  version "/src/bitcoin-abc-"
                                   version ".tar.gz"))
               (sha256
                (base32
-                "0ndvkxv5m8346bdhfqzgdiz1k9wyjycj05jp7daf9pml3cw79sz5"))))
+                "0fld54z3l7z7k5n35rrjichjnx37j9xp0rv8i69m3x4qfj1xk2np"))))
+    (inputs
+     `(("bdb" ,bdb-5.3)
+       ("boost" ,boost)
+       ("libevent" ,libevent)
+       ("miniupnpc" ,miniupnpc)
+       ("openssl" ,openssl)
+       ("protobuf" ,protobuf)
+       ("qtbase" ,qtbase)))
+    (arguments
+     (substitute-keyword-arguments (package-arguments bitcoin-core)
+       ((#:phases phases)
+        `(modify-phases ,phases
+           (add-after 'unpack 'fix-tests
+             ;; Disable 'check-devtools' test which tries to run a
+             ;; python script that doesn't exist.
+             (lambda _
+               (substitute* "Makefile.in"
+                 (("^check-local: check-devtools")
+                  "check-local:"))
+               #t))))))
     (home-page "https://www.bitcoinabc.org/")
     (synopsis "Bitcoin ABC peer-to-peer full node for the Bitcoin Cash protocol")
     (description
-- 
2.23.0