Subject: Re: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4.

From: Marius Bakke <[email-masked]>
Date: Sun, 03 Nov 2019 18:11:50 +0100

Guillaume Le Vaillant <[email-masked]> writes:

> Marius Bakke skribis:
>
>> Guillaume Le Vaillant <[email-masked]> writes:
>>
>>> * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4.
>>>   [source]: Fix uri.
>>>   [inputs]: Use bdb-5.3 (bdb-4.8 is not supported).
>>>   [arguments]: Add 'fix-tests' phase.
>>
>> [...]
>>
>>> +    (arguments
>>> +     (substitute-keyword-arguments (package-arguments bitcoin-core)
>>> +       ((#:phases phases)
>>> +        `(modify-phases ,phases
>>> +           (add-after 'unpack 'fix-tests
>>> +             ;; Disable 'check-devtools' test which tries to run a
>>> +             ;; python script that doesn't exist.
>>> +             (lambda _
>>> +               (substitute* "Makefile.in"
>>> +                 (("^check-local: check-devtools")
>>> +                  "check-local:"))
>>> +               #t))))))
>>
>> Do you know why this script is not distributed?  Should we provide it,
>> or was it a packaging mistake upstream?
>>
>> In any case I pushed this patch in
>> 28d46d9d4317180b348ad5baeddad8ef25ed430a.  Thank you!
>
> I'm not sure if it's a packaging mistake or a makefile mistake (if these
> tests are not supposed to be run on a release version). They are tests
> to check that some development tools work correctly (e.g. tools to
> generate a header file which is included in the release tarball, to
> update the copyright years in the headers, etc).

I see, thanks for the explanation.  Perhaps we are simply using the
wrong Makefile target?  By default gnu-build-system runs 'make check' in
the 'check' phase: some packages use 'make test' or 'make ci' instead.

Something to look out for in the next version.  :-)