From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 19 14:49:06 2019 Received: (at submit) by debbugs.gnu.org; 19 Oct 2019 18:49:06 +0000 Received: from localhost ([127.0.0.1]:53557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLtmj-00068s-Mh for submit@debbugs.gnu.org; Sat, 19 Oct 2019 14:49:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:50578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLtmi-00068l-DR for submit@debbugs.gnu.org; Sat, 19 Oct 2019 14:49:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41751) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLtmg-0007FQ-RK for guix-patches@gnu.org; Sat, 19 Oct 2019 14:49:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLtmf-0005x8-ED for guix-patches@gnu.org; Sat, 19 Oct 2019 14:49:02 -0400 Received: from mout02.posteo.de ([185.67.36.66]:47469) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iLtme-0005w4-RP for guix-patches@gnu.org; Sat, 19 Oct 2019 14:49:01 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 397482400FC for ; Sat, 19 Oct 2019 20:48:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1571510938; bh=5QIB0InOoQzzSRBjcNMupExJBbW5tNQhHHQrash92QE=; h=From:To:Cc:Subject:Date:From; b=WRZignpTg7i0sNHuEKP1cdSrJaRkaiwBil/01zXXISY4ngg3GLjjEcZ4ZNQvYZPSD YfGYhdt5BUpNfhPmMA13zRyDjnMJrBKCi4LUB20DaF+Xgdi5m4MkjLchnAa1g7kCON GpECBEmtaq8rkgD1ZVlqgooR7x23jiDO4/qOJ1zOIaHLS59W/kxmj7mgnRtfBDq6/e jTzJ13VN7fgh+yldpWgZTWO8a9SVkE40l/T5YvciJPj2dTR25e84D9v9xsMDnBz81e IKjwk3dUHok+P+uIvztyvhKgmGLfOHUtOCNdnM40iRHWmSlAGSWF7+c7aN/3TMmCxd anu3DyRpuIhAA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46wX475Bn2z9rxN; Sat, 19 Oct 2019 20:48:55 +0200 (CEST) From: Guillaume Le Vaillant To: guix-patches@gnu.org Subject: [PATCH] gnu: bitcoin-abc: Update to 0.20.4. Date: Sat, 19 Oct 2019 20:48:37 +0200 Message-Id: <20191019184837.21457-1-glv@posteo.net> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.67.36.66 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Guillaume Le Vaillant X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4. [source]: Fix uri. [inputs]: Use bdb-5.3 (bdb-4.8 is not supported). [arguments]: Add 'fix-tests' phase. --- gnu/packages/finance.scm | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index 960e3adeb3..0ab6489aeb 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -1133,15 +1133,35 @@ Trezor wallet.") (package (inherit bitcoin-core) (name "bitcoin-abc") - (version "0.19.8") + (version "0.20.4") (source (origin (method url-fetch) (uri (string-append "https://download.bitcoinabc.org/" - version "/linux/src/bitcoin-abc-" + version "/src/bitcoin-abc-" version ".tar.gz")) (sha256 (base32 - "0ndvkxv5m8346bdhfqzgdiz1k9wyjycj05jp7daf9pml3cw79sz5"))= )) + "0fld54z3l7z7k5n35rrjichjnx37j9xp0rv8i69m3x4qfj1xk2np"))= )) + (inputs + `(("bdb" ,bdb-5.3) + ("boost" ,boost) + ("libevent" ,libevent) + ("miniupnpc" ,miniupnpc) + ("openssl" ,openssl) + ("protobuf" ,protobuf) + ("qtbase" ,qtbase))) + (arguments + (substitute-keyword-arguments (package-arguments bitcoin-core) + ((#:phases phases) + `(modify-phases ,phases + (add-after 'unpack 'fix-tests + ;; Disable 'check-devtools' test which tries to run a + ;; python script that doesn't exist. + (lambda _ + (substitute* "Makefile.in" + (("^check-local: check-devtools") + "check-local:")) + #t)))))) (home-page "https://www.bitcoinabc.org/") (synopsis "Bitcoin ABC peer-to-peer full node for the Bitcoin Cash p= rotocol") (description --=20 2.23.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 31 19:23:56 2019 Received: (at 37825-done) by debbugs.gnu.org; 31 Oct 2019 23:23:56 +0000 Received: from localhost ([127.0.0.1]:54476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQJnH-0008FY-Ro for submit@debbugs.gnu.org; Thu, 31 Oct 2019 19:23:56 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:46005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQJnF-0008FI-8r for 37825-done@debbugs.gnu.org; Thu, 31 Oct 2019 19:23:53 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 9627E52B; Thu, 31 Oct 2019 19:23:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 31 Oct 2019 19:23:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=PZFp/cIpgv7sVp00AvNuE0yK+B B6/PzVtcA3QVHSLHo=; b=FdsLvzk7XdoZxUyQgmIxlETZSt6TuLKW3yR5DgOebe 4BrnBhzE+ylBAXiQo1LTakk/E6fqYN8MhwL/em600gC6oVGWD6HASs/Yw+zYrx/J ueEv4WRY2amI9TqEScuLvuwboCkXC4jt/I+UpisH4+jGPkOsaOq2oSFqUZvCultV GruYZ5MJv6NeEMgtoWwh4XARMQybcQoOJc1+DO7BZQmGVSNWVJgzxUgpeMaiKjCT OsPt5WicGMdmjvum0w4V26nlK2uFFATU1cU8vxdG+PsBke8y+iX6b5sjE3TEDaA3 tWWgdof1EkoEPRbhhocQZ8LMoEC1vwkQerDES0L6Uyzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=PZFp/c Ipgv7sVp00AvNuE0yK+BB6/PzVtcA3QVHSLHo=; b=fn2zmu2+vfXMoogdVy+IQa 1pFvNJtGrzJG1jJGDmqagbYtTYOVV8q1pgr8W9Gdq1wRkJAWThxdhTHy/AF692Q3 RaM9819o3TGUz/TsDttY30HME1jIH02HABN/mWHrG1QbVIrLnTFTcjA4o+mmoZ1N MFdkfO4nqLR91A9UKYV2VQfeYp72aYIeshB46fe4AP3BYQFTSxWr/oiOfxm4KrU6 q61vjdSH0JFfem7jQ35tVD4vn5rH4P1pevKJmzlQEo7a92XzzZW+L4ZnG4nn9Bqz dLb1MXvflbwl8BeJgwQnSQlEXf66XXZ1u4K7ryqmU0jfbkNxKVhMpMEnbgK/LJsA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddtiedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesghdtre ertdertdenucfhrhhomhepofgrrhhiuhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghs thhmrghilhdrtghomheqnecukfhppeeivddrudeirdduledvrdduhedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhmnecuvehluhhs thgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (ti0006q161-0149.bb.online.no [62.16.192.150]) by mail.messagingengine.com (Postfix) with ESMTPA id 9B18F80060; Thu, 31 Oct 2019 19:23:46 -0400 (EDT) From: Marius Bakke To: Guillaume Le Vaillant , 37825-done@debbugs.gnu.org Subject: Re: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4. In-Reply-To: <20191019184837.21457-1-glv@posteo.net> References: <20191019184837.21457-1-glv@posteo.net> User-Agent: Notmuch/0.29.1 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Fri, 01 Nov 2019 00:23:45 +0100 Message-ID: <87tv7oo5xa.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37825-done Cc: Guillaume Le Vaillant X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Guillaume Le Vaillant writes: > * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4. > [source]: Fix uri. > [inputs]: Use bdb-5.3 (bdb-4.8 is not supported). > [arguments]: Add 'fix-tests' phase. [...] > + (arguments > + (substitute-keyword-arguments (package-arguments bitcoin-core) > + ((#:phases phases) > + `(modify-phases ,phases > + (add-after 'unpack 'fix-tests > + ;; Disable 'check-devtools' test which tries to run a > + ;; python script that doesn't exist. > + (lambda _ > + (substitute* "Makefile.in" > + (("^check-local: check-devtools") > + "check-local:")) > + #t)))))) Do you know why this script is not distributed? Should we provide it, or was it a packaging mistake upstream? In any case I pushed this patch in 28d46d9d4317180b348ad5baeddad8ef25ed430a. Thank you! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl27bQEACgkQoqBt8qM6 VPqz0QgA1CZwHiBED+NENN8JmzhemZYwF+IBK/8H77s7Xu7PwG57oNZ6bAIqmekR dAKjOaJ5dCAvsfk8FMffHMUjfW2cK9J9+EL6wRQWPbSTSmZ7iYYvRnJFQOFvGCUH OCIe9VlUfJY9pBS42NVJ30jIrBvnPwO+cfMNCc5kFoQ+mUQ9s/bN/na/rim4+kki 7j+OrHN1A2CQukROxH0+p+bcCM2Wx5lCjbFjocdVw2J2GlFqG/xhLGPktALPlZMm 8TGSs5bTFqo2/RaVec9Z4fT5VdTN3Zq9cWvDkwQ3J93+fEJKuANfcKZg/rEIProa BF7VODVMTZ6KcTTdQseHBwi9ITnTgg== =wiqW -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 01 06:18:44 2019 Received: (at 37825) by debbugs.gnu.org; 1 Nov 2019 10:18:44 +0000 Received: from localhost ([127.0.0.1]:55065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQU0y-00023C-67 for submit@debbugs.gnu.org; Fri, 01 Nov 2019 06:18:44 -0400 Received: from mout02.posteo.de ([185.67.36.66]:47127) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQU0t-00022u-Nf for 37825@debbugs.gnu.org; Fri, 01 Nov 2019 06:18:40 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id D47C82400E6 for <37825@debbugs.gnu.org>; Fri, 1 Nov 2019 11:18:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1572603512; bh=JnqFqHDhd3Lkjv6nl03nVBq4vSs8EodvOobaYFkaOzE=; h=From:To:Cc:Subject:Date:From; b=LcAGQAQQPCR9gVNNUFQGRVyGsFm1MngU/1/SnR176KfsuFqyn+HuBK+hqYAdeIyMI zdbTpyl5z4FggHS3tipmaGn+5RtC9TC3Ph8q7zD/T/gpzdX1tMwkd5ZJvYsr+s+mAw PPIkML+iVcXD/27oLBG2Q0s7llxiPU8E0u5o6M9T+WubmypqMsB3Pdj18SwhYgwV4a Ks2vWrjAf0wnGVwMFW1W/5PoQZkbMOvM5tqB/Vpui3PBA14qffL5xpyGcfPTytsNvQ GP1+SwO98tcfDEbw0oX7yIiD4FTd+zpUuDEjfHE/ywpQncMKASTv9wjx65q0B9VULy DN3KyI2fSIMKQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 474J781ZTTz9s2D; Fri, 1 Nov 2019 11:18:27 +0100 (CET) References: <20191019184837.21457-1-glv@posteo.net> <87tv7oo5xa.fsf@devup.no> User-agent: mu4e 1.2.0; emacs 26.3 From: Guillaume Le Vaillant To: Marius Bakke Subject: Re: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4. In-reply-to: <87tv7oo5xa.fsf@devup.no> Date: Fri, 01 Nov 2019 11:18:25 +0100 Message-ID: <87tv7nlx1q.fsf@yamatai> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37825 Cc: 37825@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Marius Bakke skribis: > Guillaume Le Vaillant writes: > >> * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4. >> [source]: Fix uri. >> [inputs]: Use bdb-5.3 (bdb-4.8 is not supported). >> [arguments]: Add 'fix-tests' phase. > > [...] > >> + (arguments >> + (substitute-keyword-arguments (package-arguments bitcoin-core) >> + ((#:phases phases) >> + `(modify-phases ,phases >> + (add-after 'unpack 'fix-tests >> + ;; Disable 'check-devtools' test which tries to run a >> + ;; python script that doesn't exist. >> + (lambda _ >> + (substitute* "Makefile.in" >> + (("^check-local: check-devtools") >> + "check-local:")) >> + #t)))))) > > Do you know why this script is not distributed? Should we provide it, > or was it a packaging mistake upstream? > > In any case I pushed this patch in > 28d46d9d4317180b348ad5baeddad8ef25ed430a. Thank you! I'm not sure if it's a packaging mistake or a makefile mistake (if these tests are not supposed to be run on a release version). They are tests to check that some development tools work correctly (e.g. tools to generate a header file which is included in the release tarball, to update the copyright years in the headers, etc). From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 03 12:12:00 2019 Received: (at 37825) by debbugs.gnu.org; 3 Nov 2019 17:12:00 +0000 Received: from localhost ([127.0.0.1]:35039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRJPz-0004dD-Ti for submit@debbugs.gnu.org; Sun, 03 Nov 2019 12:12:00 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRJPy-0004cz-IY for 37825@debbugs.gnu.org; Sun, 03 Nov 2019 12:11:59 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7B183202F2; Sun, 3 Nov 2019 12:11:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 03 Nov 2019 12:11:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=G8H9DW8jdjJz8lFf4UX2fS6FRT OUVEK6OGG6dRMw2xM=; b=oQJDLTc6Cn6y3P5IcvGsQ4nYQjZFqFBv9oOMFFp8m1 e1fpUPKXWIwfvpFNAVe54tAH2Z1Uvip/dkvZSWl//Pm7BOvgTr8KgyOWsbGIs8Tq HqV27aAjOlBo2uYQUbCWm7Q55jxkrfYe68IM5umu7u8JBKtjr/Tw5ZA5WoytK/8q CaOMtwTygO+p/Z4QtSu7k/+j7Jgt8d4hPoE2biC/8gjb3G4trB0kLDPBqzPgPLZ9 TWjtslK0WjI5cKqETAASTc7HPBvEAJLTKyWuUVSPk7gYXcTdpmetTQGAOHuhzX0c cSZrYnHJDvQOZ/g9pjDNZ3uUBHr30hi+vdGKvS8lXL7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=G8H9DW 8jdjJz8lFf4UX2fS6FRTOUVEK6OGG6dRMw2xM=; b=IGN831JusqxeGcprO4KP5v 1STaSrI+vRWUnph7NKMSdj55hrF2eN1TIoP+jkZeDLvZynyRDM9yUlRXr1ij6nq/ TabZN2sz9wWpPXvg122WSRl4V5Mb5tY26zuxpotanog2znjH1XfsClBF993uITao 5kw5l00wMoIfYUEwKJogPc9V0g9low3bs759P4htm9goblt/WMUyWoVMOPg8ZwUH JfgtngIeESiqE0LCIKvheclR3Xy67oZINtWQ3cjK4M4xjdtEHnFr/s28qQCBQ/Ua NH2trfw2CGH0sY5ERRtfocP0A3whStVDui6DL9Ehu/yVWScvao/qUwDPjUAOqdkA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudduuddguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtd erredtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgr shhtmhgrihhlrdgtohhmqeenucfkphepiedvrdduiedrudelvddrudehtdenucfrrghrrg hmpehmrghilhhfrhhomhepmhgsrghkkhgvsehfrghsthhmrghilhdrtghomhenucevlhhu shhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (ti0006q161-0149.bb.online.no [62.16.192.150]) by mail.messagingengine.com (Postfix) with ESMTPA id 6FDDC80060; Sun, 3 Nov 2019 12:11:52 -0500 (EST) From: Marius Bakke To: Guillaume Le Vaillant Subject: Re: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4. In-Reply-To: <87tv7nlx1q.fsf@yamatai> References: <20191019184837.21457-1-glv@posteo.net> <87tv7oo5xa.fsf@devup.no> <87tv7nlx1q.fsf@yamatai> User-Agent: Notmuch/0.29.1 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sun, 03 Nov 2019 18:11:50 +0100 Message-ID: <87r22oopex.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37825 Cc: 37825@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Guillaume Le Vaillant writes: > Marius Bakke skribis: > >> Guillaume Le Vaillant writes: >> >>> * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4. >>> [source]: Fix uri. >>> [inputs]: Use bdb-5.3 (bdb-4.8 is not supported). >>> [arguments]: Add 'fix-tests' phase. >> >> [...] >> >>> + (arguments >>> + (substitute-keyword-arguments (package-arguments bitcoin-core) >>> + ((#:phases phases) >>> + `(modify-phases ,phases >>> + (add-after 'unpack 'fix-tests >>> + ;; Disable 'check-devtools' test which tries to run a >>> + ;; python script that doesn't exist. >>> + (lambda _ >>> + (substitute* "Makefile.in" >>> + (("^check-local: check-devtools") >>> + "check-local:")) >>> + #t)))))) >> >> Do you know why this script is not distributed? Should we provide it, >> or was it a packaging mistake upstream? >> >> In any case I pushed this patch in >> 28d46d9d4317180b348ad5baeddad8ef25ed430a. Thank you! > > I'm not sure if it's a packaging mistake or a makefile mistake (if these > tests are not supposed to be run on a release version). They are tests > to check that some development tools work correctly (e.g. tools to > generate a header file which is included in the release tarball, to > update the copyright years in the headers, etc). I see, thanks for the explanation. Perhaps we are simply using the wrong Makefile target? By default gnu-build-system runs 'make check' in the 'check' phase: some packages use 'make test' or 'make ci' instead. Something to look out for in the next version. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl2/ClcACgkQoqBt8qM6 VPqtgwf+O/bNWF7RWcvTbZWX7XBbC9njVW+JcMv5fcqkoLD4GwTSSIdgvmCBYdQr tYUTz3EY2W4C0EjosTD79kUe0Wn+13sXvLzYfttbIimOlNxRwROYUbBpKQlHwh7O dOBI1F5YB9TjeFZmLsrtRCGXKX81bYMrjqTBtlq9q0oV3+cObTpN4lNUb0b6YSLZ yaSNVuJUd9nYTPyPAGy09GlYryivvdyPEC6IZt76M6H4mylS03ZPj9pXCtZI3cvZ IDwNDhHDuJqnjztnQG796yQDaMei0D1s4s2u0lVThJrx5yAkZP5FORX40M5h5mgn 8HtU6rKzNfK3c9o83V5bQUCZ+882gA== =oihI -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 21 10:40:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 02 Dec 2019 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator