GNU bug report logs - #37806
27.0.50; Need to "extend" face-remap.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ergus <spacibba <at> aol.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37806: closed (27.0.50; Need to "extend" face-remap.el)
Date: Sun, 20 Oct 2019 19:59:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 20 Oct 2019 21:58:29 +0200
with message-id <20191020195829.baxhszeu4soeuad7 <at> Ergus>
and subject line Re: bug#37806: 27.0.50; Need to "extend" face-remap.el
has caused the debbugs.gnu.org bug report #37806,
regarding 27.0.50; Need to "extend" face-remap.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37806: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37806
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stephen Berman <stephen.berman <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Need to "extend" face-remap.el
Date: Fri, 18 Oct 2019 11:14:09 +0200

[Message part 3 (text/plain, inline)]

0. emacs -Q
1. C-x C-+ (i.e. M-x text-scale-adjust)
2. M-x variable-pitch-mode or M-x buffer-face-mode
=> Args out of range: [nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground ...], 19

The error happens because the vector of face attributes defined in
face-remap.el is missing the recently added :extend attribute, so it is
too short.  This also breaks the MELPA package charmap.el (that's where
I hit the error).  The patch below fixes this, though perhaps now would
be a good time to do what the comment above the definition of the vector
says: "This variable should probably be defined in C code where the
actual definitions are available."  Or is this simple fix good enough?

(The vector is also missing the :distant-foreground attribute, so the
patch adds that as well.  This absence happened to be innocuous because
the first element of the vector is nil, in order to make the attribute
indices match those of the enum lface_attribute_index defined in
dispextern.h, so the vector was long enough; but after the addition of
the :extend attribute, it wasn't anymore (only the indices of the vector
are used in face-remap.el).)

In GNU Emacs 27.0.50 (build 17, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0)
 of 2019-10-18 built on strobe-lfs84
Repository revision: 2d13a3f68d4724af52e47675bedf60709c7b5171
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12003000
System Description: Linux From Scratch

[face-remap.diff (text/x-patch, inline)]

diff --git a/lisp/face-remap.el b/lisp/face-remap.el
index 5cdecb92ee..8e565264fe 100644
--- a/lisp/face-remap.el
+++ b/lisp/face-remap.el
@@ -69,7 +69,7 @@ internal-lisp-face-attributes
   [nil
    :family :foundry :swidth :height :weight :slant :underline :inverse
    :foreground :background :stipple :overline :strike :box
-   :font :inherit :fontset :vector])
+   :font :inherit :fontset :distant :extend :vector])

 (defun face-attrs-more-relative-p (attrs1 attrs2)
   "Return true if ATTRS1 contains a greater number of relative

[Message part 5 (message/rfc822, inline)]

From: Ergus <spacibba <at> aol.com>
To: 37806-done <at> debbugs.gnu.org
Subject: Re: bug#37806: 27.0.50; Need to "extend" face-remap.el
Date: Sun, 20 Oct 2019 21:58:29 +0200

Fixed in commit: 270ca8c2735cfc7935b9e4d0b770a55138493e

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.