From unknown Sat Jun 21 10:39:46 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#37806 <37806@debbugs.gnu.org> To: bug#37806 <37806@debbugs.gnu.org> Subject: Status: 27.0.50; Need to "extend" face-remap.el Reply-To: bug#37806 <37806@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:39:46 +0000 retitle 37806 27.0.50; Need to "extend" face-remap.el reassign 37806 emacs submitter 37806 Stephen Berman severity 37806 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 18 05:14:23 2019 Received: (at submit) by debbugs.gnu.org; 18 Oct 2019 09:14:23 +0000 Received: from localhost ([127.0.0.1]:49368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLOL0-0001Iv-RL for submit@debbugs.gnu.org; Fri, 18 Oct 2019 05:14:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:51929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLOKy-0001In-ES for submit@debbugs.gnu.org; Fri, 18 Oct 2019 05:14:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44605) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLOKx-0006Oj-6b for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 05:14:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLOKw-00079P-0r for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 05:14:19 -0400 Received: from mout.gmx.net ([212.227.15.19]:45907) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLOKv-00074D-JM for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 05:14:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1571390051; bh=XCCWewhCCAgRNxREXm0T3S58HdbGlRdS1YsSDTBedJM=; h=X-UI-Sender-Class:From:To:Subject:Date; b=eFpZKoBzUQhb6eGehuHk8wuQkEZuNkDve8Uj+k0C44ztgXj1QW1B6yDEMudrkg5zB xs5V6IQCKYglJgznyyA1SI/rVTOPL0rRiyBH6REMy1bVMuV553sC8M1EQjG+2Gpxh1 EjlH/lsqO+QanbV542kZzbw1ok6RXKcf4It6Aq8M= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-lfs84 ([178.6.146.152]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2E1M-1huQ5U3SN4-013ajq for ; Fri, 18 Oct 2019 11:14:10 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Need to "extend" face-remap.el Date: Fri, 18 Oct 2019 11:14:09 +0200 Message-ID: <875zkmmn4u.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:eq1PoRI2XXypXXPFymx0R+l682iphpTLyAARWR0p5TIH59xSumT ikVZbnHu3fsMJdDnpBnigzVf06GXHFBlVO3bFNVXkxkjitDLjjuqKAjpP08/ZU4Hm1NeeT7 Au1nNfhNbti84mHc3O6x/yjs15hZzCtYpfAAysZka34B/gXMXJuOGXcY3mTqyJzK3hlRN0K A6nrSbHmm09+5CsfvpvcA== X-UI-Out-Filterresults: notjunk:1;V03:K0:T0pFg4fVNrk=:lj6tpRnkeHs5EE0dqvZsMM eUnWPJHDIw3an7eqRM2M5ErDQxVPrag2T2xog4mXJOHTCIMkNLu3RlMXI2aGspSJQcsEKxF7k RPK4gIhyMdWEF7VAZ5M3OZtJpFjhBGNNr4KxY23qYrnKJE/Ym0FV9VStfhZfaCd7VwK/XVCcl hqJ3fEGUkBPOXsJSsHde+icZSP75SvTPBKvI0I6GRql+48sz3/qUMXC+QwJIG1oO0QPMrs4ZA sZxJ7WrPB3l82+m1WsOs26EYsUIicVdy+SGt8sh/arRjHj9/qWteHrbsdGsCrKkKCUbJAkTX/ euZxNFi+EA/UnNGeLlRsh8TzRYfRuuEaXXbmgmDHasHcwCeP7XB5GuUyFlLj11P7aICi7YAMD wBTZkXAP9yV6C/oE8KoY0Fc1JNaxxBdtK4j2ZwKZTHvTz8y1TdpRb0XrdH1cffOFuDuBd7sbA +qIwB7W8f+bs0q8OxVpIc3sfKPCOYzxFnzEbwCtOVs5ULMX9nUEvqXLsfzct4CcZIFBmSdp/I PCWyTqrR8pPDWwnK4Iiaj69xUkrpn8NK9yzH0FjUFIhSywvKpDKsdP30r4KkRZA8a7YlhdUbt CssZG00+91QVYTuQ4PChk9b/AJTwSya8ll53DJxvCCem3mPZA0kePt1MdVafO0rcr4Nfsh5mM otUtzVUtjW/H1ufIScVXdb39fzsGgwcqdxt21ZaK5sbfOgoFtcqUx6T759G5Rv3qL9jckl4H7 4IHBDFocMgFgzi16AVUpiSXcgV/+WanMpcg4JRLCOIAw1HvtyqF4nme36CZYPM3IPESIWuGLM NuTzor9OYWxoMUVmAA/BYJflT6udRwyWLWyQAuocHonFxJltvL+BKs6jet3zDGEnLBB3mS9te BwWP/VjrREqQNAWWY/0d+WcwqbABKa36guUusx2Z5l5qfyIkXSMkfu2FC7ZeyM/6F172P71K3 9IxD1Pun7bWNhM8LW01AdybHqXHkL9mIN8vl4UGaZEkm+dSaFQY0pYSX0W/0DXGL67L96xM98 eULZBgOfB3YTtEXZhKa8UnULAzIV7rioR9mPonCINfvt9Q0Rl4TSwlrP4PXRsPqz/976qzIWT 3kJPvEIJqd4veUZ5YLx10vEd5WOrhW5qlFZhXYgWlITWjwSvjBN95m1LZ/gV9bq+glpADreWM BzwmhXG9bkxLbiH487u1kXYjCKl6ccK7h6NJIO4r8xy908GP1ZXrUkfVr/rAzCP9+IpUQq4D5 NaGjOdusHwnKxLUfqK2oJtvOWtc/ZSDRzGdbghl0ZbLR9Y7mpesx/U5OSeNE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.19 X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain 0. emacs -Q 1. C-x C-+ (i.e. M-x text-scale-adjust) 2. M-x variable-pitch-mode or M-x buffer-face-mode => Args out of range: [nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground ...], 19 The error happens because the vector of face attributes defined in face-remap.el is missing the recently added :extend attribute, so it is too short. This also breaks the MELPA package charmap.el (that's where I hit the error). The patch below fixes this, though perhaps now would be a good time to do what the comment above the definition of the vector says: "This variable should probably be defined in C code where the actual definitions are available." Or is this simple fix good enough? (The vector is also missing the :distant-foreground attribute, so the patch adds that as well. This absence happened to be innocuous because the first element of the vector is nil, in order to make the attribute indices match those of the enum lface_attribute_index defined in dispextern.h, so the vector was long enough; but after the addition of the :extend attribute, it wasn't anymore (only the indices of the vector are used in face-remap.el).) In GNU Emacs 27.0.50 (build 17, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2019-10-18 built on strobe-lfs84 Repository revision: 2d13a3f68d4724af52e47675bedf60709c7b5171 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: Linux From Scratch --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=face-remap.diff Content-Description: face-remap patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/face-remap.el b/lisp/face-remap.el index 5cdecb92ee..8e565264fe 100644 =2D-- a/lisp/face-remap.el +++ b/lisp/face-remap.el @@ -69,7 +69,7 @@ internal-lisp-face-attributes [nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground :background :stipple :overline :strike :box - :font :inherit :fontset :vector]) + :font :inherit :fontset :distant :extend :vector]) (defun face-attrs-more-relative-p (attrs1 attrs2) "Return true if ATTRS1 contains a greater number of relative --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 19 13:33:52 2019 Received: (at 37806) by debbugs.gnu.org; 19 Oct 2019 17:33:52 +0000 Received: from localhost ([127.0.0.1]:53512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLsbv-0003uA-Ay for submit@debbugs.gnu.org; Sat, 19 Oct 2019 13:33:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLsbu-0003ty-0E for 37806@debbugs.gnu.org; Sat, 19 Oct 2019 13:33:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iLsbo-0000ML-Kd; Sat, 19 Oct 2019 13:33:44 -0400 Received: from [176.228.60.248] (port=2230 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iLsbn-0002mK-RN; Sat, 19 Oct 2019 13:33:44 -0400 Date: Sat, 19 Oct 2019 20:33:33 +0300 Message-Id: <835zkk7i8i.fsf@gnu.org> From: Eli Zaretskii To: Stephen Berman , Ergus In-reply-to: <875zkmmn4u.fsf@gmx.net> (message from Stephen Berman on Fri, 18 Oct 2019 11:14:09 +0200) Subject: Re: bug#37806: 27.0.50; Need to "extend" face-remap.el References: <875zkmmn4u.fsf@gmx.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37806 Cc: 37806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stephen Berman > Date: Fri, 18 Oct 2019 11:14:09 +0200 > > 0. emacs -Q > 1. C-x C-+ (i.e. M-x text-scale-adjust) > 2. M-x variable-pitch-mode or M-x buffer-face-mode > => Args out of range: [nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground ...], 19 > > The error happens because the vector of face attributes defined in > face-remap.el is missing the recently added :extend attribute, so it is > too short. This also breaks the MELPA package charmap.el (that's where > I hit the error). The patch below fixes this, though perhaps now would > be a good time to do what the comment above the definition of the vector > says: "This variable should probably be defined in C code where the > actual definitions are available." Or is this simple fix good enough? > > (The vector is also missing the :distant-foreground attribute, so the > patch adds that as well. This absence happened to be innocuous because > the first element of the vector is nil, in order to make the attribute > indices match those of the enum lface_attribute_index defined in > dispextern.h, so the vector was long enough; but after the addition of > the :extend attribute, it wasn't anymore (only the indices of the vector > are used in face-remap.el).) > > In GNU Emacs 27.0.50 (build 17, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) > of 2019-10-18 built on strobe-lfs84 > Repository revision: 2d13a3f68d4724af52e47675bedf60709c7b5171 > Repository branch: master > Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 > System Description: Linux From Scratch > > > diff --git a/lisp/face-remap.el b/lisp/face-remap.el > index 5cdecb92ee..8e565264fe 100644 > --- a/lisp/face-remap.el > +++ b/lisp/face-remap.el > @@ -69,7 +69,7 @@ internal-lisp-face-attributes > [nil > :family :foundry :swidth :height :weight :slant :underline :inverse > :foreground :background :stipple :overline :strike :box > - :font :inherit :fontset :vector]) > + :font :inherit :fontset :distant :extend :vector]) > > (defun face-attrs-more-relative-p (attrs1 attrs2) > "Return true if ATTRS1 contains a greater number of relative Thanks. Jimmy, could you please take a look? From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 20 08:22:09 2019 Received: (at 37806) by debbugs.gnu.org; 20 Oct 2019 12:22:09 +0000 Received: from localhost ([127.0.0.1]:53987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMADo-0000mi-KJ for submit@debbugs.gnu.org; Sun, 20 Oct 2019 08:22:08 -0400 Received: from mout.gmx.net ([212.227.15.18]:37187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMADm-0000m6-8M for 37806@debbugs.gnu.org; Sun, 20 Oct 2019 08:22:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1571574115; bh=h2UyoilaDazaw94hF7ZUUBx11TpjCxVMIeJVk7hS3KI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=TB64o3o/fLXAkboXzkh0xjEoNwQycNjyt3qMQ71oy6jwbBo6h0RQNsYKeNZmMZm5J GfVGmjTPAxvsdxdETg3pr+xFLE5i7/ZDoXbRFCr+khI1Jzmsz4l9yPwB1JfFTl/k/j 7VNj4UnT+yE4tpkKlJNPINM0bk0i4NVyhlHxPPO4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-lfs84 ([188.109.159.139]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mf0BM-1hpqbx1H1W-00gcVf; Sun, 20 Oct 2019 14:21:55 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#37806: 27.0.50; Need to "extend" face-remap.el References: <875zkmmn4u.fsf@gmx.net> <835zkk7i8i.fsf@gnu.org> Date: Sun, 20 Oct 2019 14:21:50 +0200 In-Reply-To: <835zkk7i8i.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Oct 2019 20:33:33 +0300") Message-ID: <87r237txnl.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:MgCNo2QXHpzSZPrii4vEl2PyumJ79rYl4TLda1gZR2YZwy6Dna0 7Dt2K6NwlxxcqxdSU/ziQrPiKY7SyuL7XANjKys3dhBNamH46LQNw4pCkU+TaXh3mxF+3MQ iL9NQbTi/GK8WVIDcazKIK90LWKGVVaifFpQe4z4M/GEPpra/F+F6nRx2hwFqL5tQ4jRLzw /p3hJhBuqOPjNpGOXVl7Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:+7F2hIp2R6s=:CToKSvbM/LgLg0NBoQ0aJA iLeEcsU8kHcmRHiv/r1rjrnVMCZxAqMWkrIsC1ZOARdgmjg/ZSroibev/Z8mm7NRTwcw5xEKc q4a9Hvu4tFVHG9qHf2wLx0mgI63r5MgEQHC65Ekkcp81VtDwPVt2UznG5htCdXx0m8BR3T2bd 6evf/7rxv7S/ya6QEo1itM58Qo9pnRDZF4wMvIKrxffW2q/BJavRW+tNwfB2g8DcCpBEdk62d Kgcf8q+dvx9uJNRtS9mlPUt0kmR2nL7OpYBS/jgpJeTzQo50m0hMzJt0I3XpAAzmwGMdCCUzr uklIehJNbfvKMWxt+kCtXB63dH6IrJWuga67CYCnH01sIX88VY1NT/E35uUxX6U2EGz/BcycK XWv481fgSSmRJXrPXNtjUZU5eCB3zvQFYqLarnm2Mr8D5XtRsNg8Boh1S/g5vQuqBNicBSyox op7r5kZZoC4Pm6d2nG6z0ePuZDlkLkQ/3TNbDWSqk1MWO1L5B0DTqas0b+lpDtjeAPnjtfJNL MVz0MJnymQeAo+yflxC+e6fdDOQGDv3baCFDnyWkSr/ZPYgGSR3d3yJSsx6TEWtYOf+ZHGZjx 3BloPhM7r8SIiNeV7pzTNSxpbZoutiiH4t8rKJsYcjRnX7wHT78SbQsS4DQggBOD1L+aBNKGs j9mUENTGytjcxHECMagppIpN7Kwra9ODLtk68r/OaP1+XEpiYQHRfvRPUspKNarzgt4/EPf4M ecCxo3XqEr8GjdN7TU1aA7LXCqnMcTAeRxL+I3kH1mGp+7YGU2AfMaQeWmKBNrgEcJ4UELUzN o/hAhmxOqmmwFXsFb2YSJ/4i6CSaUN6YX8985wu/7nMJWnNtKkOXzM0AHdn54x4Mf/3RYjyMm 3DVcHJOiTSNj86E3E/4jpvHLAB7evaTiGofpoF8qGF5+y3XsD/PQd+PxUGmnWvc0dAeswRto8 YBvZyoQvLdrcCF5SdG9TLUTUP5UGakI8H6zJIW2dqarS1iKWd0aNcpTaK2RgugNpOPeUbrEEY BVsBjR6nejtOwL9fjhuZm7KSjM4cHak2JI4fONv4sN6S9To4HUN1XcZWxB++z00CQKiTd95/V Vd06pcaV0VSO3HGuemO+CAmMcn3Ukzu+dVr2WHM6HAkj4vtvwtRiDgIiAmnzuw9S6grMUne+n wh+KSGFqyANBOIa/DOrR78OGLR1/GhmIcPP9M1A41ts3jHpAgaPK1UE7XjjZEsWey23XaqcEO CV9JEEOmA9YuzSBs7ZkZGpfEwr3be4+Xz8NQk3BdKG+U3nIdU0QdDlDUoZU4= Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37806 Cc: Ergus , 37806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, 19 Oct 2019 20:33:33 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Date: Fri, 18 Oct 2019 11:14:09 +0200 >> >> 0. emacs -Q >> 1. C-x C-+ (i.e. M-x text-scale-adjust) >> 2. M-x variable-pitch-mode or M-x buffer-face-mode >> =3D> Args out of range: [nil :family :foundry :swidth :height :weight := slant :underline :inverse :foreground ...], 19 >> >> The error happens because the vector of face attributes defined in >> face-remap.el is missing the recently added :extend attribute, so it is >> too short. This also breaks the MELPA package charmap.el (that's where >> I hit the error). The patch below fixes this, though perhaps now would >> be a good time to do what the comment above the definition of the vecto= r >> says: "This variable should probably be defined in C code where the >> actual definitions are available." Or is this simple fix good enough? >> >> (The vector is also missing the :distant-foreground attribute, so the >> patch adds that as well. This absence happened to be innocuous because >> the first element of the vector is nil, in order to make the attribute >> indices match those of the enum lface_attribute_index defined in >> dispextern.h, so the vector was long enough; but after the addition of >> the :extend attribute, it wasn't anymore (only the indices of the vecto= r >> are used in face-remap.el).) >> >> In GNU Emacs 27.0.50 (build 17, x86_64-pc-linux-gnu, GTK+ Version 3.24.= 5, cairo version 1.16.0) >> of 2019-10-18 built on strobe-lfs84 >> Repository revision: 2d13a3f68d4724af52e47675bedf60709c7b5171 >> Repository branch: master >> Windowing system distributor 'The X.Org Foundation', version 11.0.12003= 000 >> System Description: Linux From Scratch >> >> >> diff --git a/lisp/face-remap.el b/lisp/face-remap.el >> index 5cdecb92ee..8e565264fe 100644 >> --- a/lisp/face-remap.el >> +++ b/lisp/face-remap.el >> @@ -69,7 +69,7 @@ internal-lisp-face-attributes >> [nil >> :family :foundry :swidth :height :weight :slant :underline :inverse >> :foreground :background :stipple :overline :strike :box >> - :font :inherit :fontset :vector]) >> + :font :inherit :fontset :distant :extend :vector]) >> >> (defun face-attrs-more-relative-p (attrs1 attrs2) >> "Return true if ATTRS1 contains a greater number of relative > > Thanks. > > Jimmy, could you please take a look? This bug (and bug#37824, which is the same) isn't due to the addition of the :extend attribute per se, but to that addition increasing the length of lface_attribute_index, which makes it necessary to adjust the length of internal-lisp-face-attributes, only the indices of which face-remap.el actually uses, as I noted above. Indeed, the following patch also fixes this bug: diff --git a/lisp/face-remap.el b/lisp/face-remap.el index 5cdecb92ee..e429752df9 100644 =2D-- a/lisp/face-remap.el +++ b/lisp/face-remap.el @@ -66,7 +66,7 @@ ;; definitions are available. ;; (defvar internal-lisp-face-attributes - [nil + [nil nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground :background :stipple :overline :strike :box :font :inherit :fontset :vector]) But then we might as well just use a vector with all nil (or arbitrary) elements whose length is LFACE_VECTOR_SIZE (maybe that's even how the comment in face-remap.el quoted above could be understood). The simplest fix is to just add the missing attributes, as my first patch does, but then on any future changes to lface_vector_size internal-lisp-face-attributes will have to be correspondingly adjusted. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 20 10:39:53 2019 Received: (at 37806) by debbugs.gnu.org; 20 Oct 2019 14:39:53 +0000 Received: from localhost ([127.0.0.1]:55079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMCN6-0002Ce-Lb for submit@debbugs.gnu.org; Sun, 20 Oct 2019 10:39:53 -0400 Received: from sonic308-17.consmr.mail.ir2.yahoo.com ([77.238.178.145]:44949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMCN3-0002CP-Ie for 37806@debbugs.gnu.org; Sun, 20 Oct 2019 10:39:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1571582383; bh=nkc1BF//uplB9NpgYWoTLzLKoI4vieNqfJVSLKEfuzk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=aPNIoDR9D9trqC+Fl93BoZm5t1qjm8Oygce/HSZPJ06PCjBwcTVPgw1eUiLU0x6E+NAahBL0eOwZRk22aS2ySogwCMyEGoVz3ZTEEPfth0pdbR5+zFNGmXe6pTTLlXbZVM3xMbjRyhnnnMyOsFKKeGIaska/AFeIMULTuEifYPp6AszBj2tht0d4jUvb9Ja3WbyN+NeSesScjViXDz+We1Wak/OEPJ9pc2DjG3YuNQIS4FiDP9Z8GbN5UzamS64nKA0CRfOh6LBbrrM6/bxd2L1H4/K8zmFNvcOhkTcuCV5imbKMDk1ACbn8Q0TpsMq1ZT/tR3vualqiX4hKPEb0aA== X-YMail-OSG: miCSnbYVM1lIlzGFDAMzvxPB7vybVaIyKgJ8OQ4WrPapHeTIyiyv_M40fKqVfGC hbZIPxjOqTO3RtzN6XtgmL8MbsJo6eCe8Vnu6IGeWN69Zq_nCOhbXz_GdzBKjJvUWbwoiQDBcf3L tn7AP08cdAF4b6p4jkVVHOXaPFxrwncYAJS.JkLY.BupD_2WfbbieAEk_2lpmMs5c8jcBM0wf5aS ZtZ.7_aG60EVOBhr4VYCf.ZfIP7zkouX7dPaP4BKwljOxWsDHs61SjOvYRbUUyys96oG.2SxcUYA ETae67Rs1RlSdXPhfvmcyu27g6FIfOmXgNUX7tkQk9Rv_l30B8jQydlRnUEV9BH4TTRBfezQIldl LSGAeRwCBv6oGlVyxeJWffh0G8XM8qZnw6hxG31QZW4P5_mr4zuscwwag8dG9wKPZZv92DkvSP0o LJplP02xkVjTRi92uZMBWM8Z31ZMqhjRTjywG1BmBCxLK5Nq_DG6sivuaboXvW0YohK5PStyZBcA ZCcqnG9ql1810me0hHkYC159V0Z1b7mAFft869Zj6n5ugX87SIAqqIMbjeLwQrPKtJqR2T3i.wHC z7K2djJjfLXc_u_NTeMRuQ.K_ITb7.yescgbEn4RpadyubCsjOOEsQcT2mI8pr3bBgmavwM6SANF E37R5qKGF5.yEB_8cBceaCVG4m.6a6RFb2QZglyJOPRI_vyI8i7OPhD7Wbd2wqeYi7KHmaKh4kgX bQl2g3KRXmJo7BsIWusKJNg392F_ygYc9QprgaHehl0OrjBN.2sQOr3bTu_HP48gBWQKMRFoBJen FUcOdBOR4MZRp3._ZLpMTm93P8UaFPg5NnzODWlWbh1Ns2D6m3AuHFl97_jGUlXmyH2xmSdQQ9_g O4zjX73JKJKNKdED0OsnTNmzTM.pYT9cvBA3FNarsmfJmPAgjgeiAYHPvjEm2n6QRtsTPS58OXlw pHqY3_RxIsv_x66aMtLQW0zS3hcdq_z6AVXVZuZPL1JOkyUcOYrSrZCEhcsJ5tz7zRUSYMOkXXEe Z9GuxK4R1fDjBqZm3q2xreD5UT7m6FewbFFLHoO_KGFdiRw0YFPZpKRs.asw_P4TbIHWDjwVmY2. diJ5FlOe64TkODaOeevXZsDeZRnr94gbTBKOBVdotR5NVc_q93igXpLz6ekU6kLG6LLQOps5f8RQ 2F7XwA8aRumZf8ipKM0dwrLpP9j0ITzpdb78nMtU_QEng0hmeDL37zKaXFnK04sDp0Wwqlx8rbui wml5ht2794.a33ihduTe9W3w6no7jZ4LNUqSCZpypv6pxNl2Jws9kA0Bkerqs8VzNsnbGDiG513K UWyOymJ4qp74M8g-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ir2.yahoo.com with HTTP; Sun, 20 Oct 2019 14:39:43 +0000 Received: by smtp423.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 7c57f1cb39c2c41acd44f63b33a75af1; Sun, 20 Oct 2019 14:39:42 +0000 (UTC) Date: Sun, 20 Oct 2019 16:39:30 +0200 From: Ergus To: Stephen Berman Subject: Re: bug#37806: 27.0.50; Need to "extend" face-remap.el Message-ID: <20191020143930.ugxiakrap7yym6qw@Ergus> References: <875zkmmn4u.fsf@gmx.net> <835zkk7i8i.fsf@gnu.org> <87r237txnl.fsf@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87r237txnl.fsf@gmx.net> User-Agent: NeoMutt/20180716 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37806 Cc: Eli Zaretskii , 37806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Oct 20, 2019 at 02:21:50PM +0200, Stephen Berman wrote: >On Sat, 19 Oct 2019 20:33:33 +0300 Eli Zaretskii wrote: > >>> From: Stephen Berman >>> Date: Fri, 18 Oct 2019 11:14:09 +0200 >>> >>> 0. emacs -Q >>> 1. C-x C-+ (i.e. M-x text-scale-adjust) >>> 2. M-x variable-pitch-mode or M-x buffer-face-mode >>> => Args out of range: [nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground ...], 19 >>> >>> The error happens because the vector of face attributes defined in >>> face-remap.el is missing the recently added :extend attribute, so it is >>> too short. This also breaks the MELPA package charmap.el (that's where >>> I hit the error). The patch below fixes this, though perhaps now would >>> be a good time to do what the comment above the definition of the vector >>> says: "This variable should probably be defined in C code where the >>> actual definitions are available." Or is this simple fix good enough? >>> >>> (The vector is also missing the :distant-foreground attribute, so the >>> patch adds that as well. This absence happened to be innocuous because >>> the first element of the vector is nil, in order to make the attribute >>> indices match those of the enum lface_attribute_index defined in >>> dispextern.h, so the vector was long enough; but after the addition of >>> the :extend attribute, it wasn't anymore (only the indices of the vector >>> are used in face-remap.el).) >>> >>> In GNU Emacs 27.0.50 (build 17, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) >>> of 2019-10-18 built on strobe-lfs84 >>> Repository revision: 2d13a3f68d4724af52e47675bedf60709c7b5171 >>> Repository branch: master >>> Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 >>> System Description: Linux From Scratch >>> >>> >>> diff --git a/lisp/face-remap.el b/lisp/face-remap.el >>> index 5cdecb92ee..8e565264fe 100644 >>> --- a/lisp/face-remap.el >>> +++ b/lisp/face-remap.el >>> @@ -69,7 +69,7 @@ internal-lisp-face-attributes >>> [nil >>> :family :foundry :swidth :height :weight :slant :underline :inverse >>> :foreground :background :stipple :overline :strike :box >>> - :font :inherit :fontset :vector]) >>> + :font :inherit :fontset :distant :extend :vector]) >>> >>> (defun face-attrs-more-relative-p (attrs1 attrs2) >>> "Return true if ATTRS1 contains a greater number of relative >> >> Thanks. >> >> Jimmy, could you please take a look? > >This bug (and bug#37824, which is the same) isn't due to the addition of >the :extend attribute per se, but to that addition increasing the length >of lface_attribute_index, which makes it necessary to adjust the length >of internal-lisp-face-attributes, only the indices of which >face-remap.el actually uses, as I noted above. Indeed, the following >patch also fixes this bug: > >diff --git a/lisp/face-remap.el b/lisp/face-remap.el >index 5cdecb92ee..e429752df9 100644 >--- a/lisp/face-remap.el >+++ b/lisp/face-remap.el >@@ -66,7 +66,7 @@ > ;; definitions are available. > ;; > (defvar internal-lisp-face-attributes >- [nil >+ [nil nil > :family :foundry :swidth :height :weight :slant :underline :inverse > :foreground :background :stipple :overline :strike :box > :font :inherit :fontset :vector]) > >But then we might as well just use a vector with all nil (or arbitrary) >elements whose length is LFACE_VECTOR_SIZE (maybe that's even how the >comment in face-remap.el quoted above could be understood). > >The simplest fix is to just add the missing attributes, as my first >patch does, but then on any future changes to lface_vector_size >internal-lisp-face-attributes will have to be correspondingly adjusted. > >Steve Berman Yes the problem is just the size of the vector, because actually the elements in it are wrong as they are not as defined anywhere else. The proper fix must be to declare the vector in the C side using the real symbols like: Lisp_Object internal-lisp-face-attributes[LFACE_VECTOR_SIZE] = { Qnil QCfamily, QCfoundry, QCwidth QCheight, QCweight, QCslant, QCunderline, QCinverse_video, QCforeground, QCbackground, QCstipple, QCoverline, QCstrike_through, QCbox, QCfont, QCinherit, QCfontset, QCdistant_foreground, QCextend }; But using makevector or a similar api from C. This vector can be used in some other parts in the code where we are duplicating code now, but this will require a refactor I don't know if it is desired. So I will submit the simplest fix now and if Eli gives me a green light I will implement the better version. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 20 11:00:55 2019 Received: (at 37806) by debbugs.gnu.org; 20 Oct 2019 15:00:55 +0000 Received: from localhost ([127.0.0.1]:55103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMChS-0002mJ-Np for submit@debbugs.gnu.org; Sun, 20 Oct 2019 11:00:55 -0400 Received: from sonic303-20.consmr.mail.ir2.yahoo.com ([77.238.178.201]:35641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMChP-0002m3-VF for 37806@debbugs.gnu.org; Sun, 20 Oct 2019 11:00:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1571583645; bh=stcFzrxHzqjMJ8//VeBhv3JupU/ByhkZ/pUrOQN8Xkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=CQtLeODNP0tyXRjjXyQ3XPu3u3qhuZAnRPWO3LOCnAzPqyFHf/zpQlw8RMIdHsdUp7dsBsaA8mHZaKv0dOOxwx7LMHG1PtE1VbBZOJ0T61pGodqf8V+ALQqUCny4FdRlOVh0Dr4k1TMlhazRmXq91pdwkvRctkxQsH9yZ7EG/rm7WZXJsBAJxZOdsmqji3Gnwzu8ccLV6oMo5pxFrogS8yU+P6ubIM/7yeF66ruZm5tnbQKEa6U8UlfFnT5jv5u9oCGQC1uSreENW101sQBB9VCDvQhW4iKSYiJfEE8CY1bd+fq9OpH80tW0nGZw9QvxHpn8Fzu/dMZaevQl5FjD+A== X-YMail-OSG: PMSG5FsVM1ktvoI93RDD7kbUVW7JInbomgi2Dl2Cu8Bgo7QxqM7f5ukhXzkO1vH mTEQZNmdIrH1EAjKVAuVAk_H86LG07TV.JHyk85hgdL2TAtXaq3REie.TGGygdmXaFgvlOsWaM1W W_OTxIsfK1Ee8gJh5n9Pi.x4lgZADl8Id3QoSYeLF7njNRDk6o2pUFT2PhgXWiHA.nJKH_lvhc_b zRD7iluR31PX1NKURHkmn8t2FYNl5CfglDGEo4oa913Z6b5tsr5u24K5jOjj1CnOkMLtnJBJrAi8 6OlyGG6zT0wVhB5CB8_PXitr7yMb3tXysqXgL6R6Mb9psVujSTjmPWk1CZ2oOhkVzxfyx.F_NIm_ 7WNaWdso8qoiJjNDv9bt9Ues_5FE4BX0KpTkcGGtW6LjQ6S_.LeOPFJQemKtiNMy1qqYMYgKTn13 HuD1XajghrnTarU4CcbSSkAhpZ5qoXfrWOPghXvv.pnIv8a2umgVDPkhplS2t4cfaQTc8fVfCoaG 1c.xGnHI0GTDNQpVKuQ5a864uplzpS6bO80chcAr0EowWUKI.bh0B7KCsLMcPuuG491UXbnl4D0d kHiiOYaBu9FR29LYfoz7.o_AxQb1c3QgNBlhTwUJkmuXPsksV7nShL_t4Fq2b6JwDpIXz.WB7DCn 14gkQSxWAVGxs7DZVcKW2ev5H331lBp_Yq6JwRBrtww4duj2N7CjG9kFT4pKdNL1SRXgJbuSqrcq NuGHHVy1MyyAn154kpGAGQ8J20TmEmlNeAWywInM7YkaJz81XtJiw6r7F1leJZcYkMKHkcMY0RZ9 hopCJcyu6RWHbjAuK0Y9s3CQlFDcHPDCTrKxwK_6KW1J2EYzvk.Pw_eTAolMcjVOb55NHM9mo79g ROnJpRtA.PFcsSmFcWegajhilYGzvNJmaecTfkzdXMcoFOYpcwJqsyyXiyoRbTNx3js417QolcSk HgO5vb9f40Z2VPUmnNMNzQLLh1Ru1Xv.gtQ8Nl3PQeJt.n8tct5SlYB.SsUpJGTA9j0RuCijH64z iLQa7ScoUithSTNlowzkp0_VrqXGnjkM6f4NfVq2cgM0ysjmUsJ77xSZxPg955xcnfsWtMAP_XZj AAs51wpH2PvgjV5SMPM0P6avXFHPhcQSyQZLWdLPShpScVDuWEdqLcBhY5jw7009GuB4vVtzBf4v wx_B9z9M0TrbAQsGhfUUvu109bT3fQ0ZW6AoY_55DSboPC2JErV5G0UAxmgI0xSDNy7O5InFh7eW WYM4urTG5azxVU4UveHgzkSD0Dvc7JcB5lmn3VKYX41K3Cfm_vlLlSTOsmwcm9HbqgIxXgrHrTy4 9MoxX.OZxeME- Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ir2.yahoo.com with HTTP; Sun, 20 Oct 2019 15:00:45 +0000 Received: by smtp422.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 7feb2cde45bd9f69a5f8e4b4c5724014; Sun, 20 Oct 2019 15:00:45 +0000 (UTC) Date: Sun, 20 Oct 2019 17:00:32 +0200 From: Ergus To: Eli Zaretskii Subject: Re: bug#37806: 27.0.50; Need to "extend" face-remap.el Message-ID: <20191020150032.4uu2jwbg6exl766b@Ergus> References: <875zkmmn4u.fsf@gmx.net> <835zkk7i8i.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <835zkk7i8i.fsf@gnu.org> User-Agent: NeoMutt/20180716 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37806 Cc: Stephen Berman , 37806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Oct 19, 2019 at 08:33:33PM +0300, Eli Zaretskii wrote: >> From: Stephen Berman >> Date: Fri, 18 Oct 2019 11:14:09 +0200 >> >> 0. emacs -Q >> 1. C-x C-+ (i.e. M-x text-scale-adjust) >> 2. M-x variable-pitch-mode or M-x buffer-face-mode >> => Args out of range: [nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground ...], 19 >> >> The error happens because the vector of face attributes defined in >> face-remap.el is missing the recently added :extend attribute, so it is >> too short. This also breaks the MELPA package charmap.el (that's where >> I hit the error). The patch below fixes this, though perhaps now would >> be a good time to do what the comment above the definition of the vector >> says: "This variable should probably be defined in C code where the >> actual definitions are available." Or is this simple fix good enough? >> >> (The vector is also missing the :distant-foreground attribute, so the >> patch adds that as well. This absence happened to be innocuous because >> the first element of the vector is nil, in order to make the attribute >> indices match those of the enum lface_attribute_index defined in >> dispextern.h, so the vector was long enough; but after the addition of >> the :extend attribute, it wasn't anymore (only the indices of the vector >> are used in face-remap.el).) >> >> In GNU Emacs 27.0.50 (build 17, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) >> of 2019-10-18 built on strobe-lfs84 >> Repository revision: 2d13a3f68d4724af52e47675bedf60709c7b5171 >> Repository branch: master >> Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 >> System Description: Linux From Scratch >> >> >> diff --git a/lisp/face-remap.el b/lisp/face-remap.el >> index 5cdecb92ee..8e565264fe 100644 >> --- a/lisp/face-remap.el >> +++ b/lisp/face-remap.el >> @@ -69,7 +69,7 @@ internal-lisp-face-attributes >> [nil >> :family :foundry :swidth :height :weight :slant :underline :inverse >> :foreground :background :stipple :overline :strike :box >> - :font :inherit :fontset :vector]) >> + :font :inherit :fontset :distant :extend :vector]) >> >> (defun face-attrs-more-relative-p (attrs1 attrs2) >> "Return true if ATTRS1 contains a greater number of relative > >Thanks. > >Jimmy, could you please take a look? Hi: I just pushed a fix for this. BTW: I don't know how to close a bug report. It is not in the CONTRIBUTE file. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 20 11:06:07 2019 Received: (at 37806) by debbugs.gnu.org; 20 Oct 2019 15:06:07 +0000 Received: from localhost ([127.0.0.1]:55107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMCmV-0002u2-GK for submit@debbugs.gnu.org; Sun, 20 Oct 2019 11:06:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMCmT-0002tX-PG for 37806@debbugs.gnu.org; Sun, 20 Oct 2019 11:06:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMCmO-0006kE-9y; Sun, 20 Oct 2019 11:06:00 -0400 Received: from [176.228.60.248] (port=2231 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMCm7-0007rS-2O; Sun, 20 Oct 2019 11:05:50 -0400 Date: Sun, 20 Oct 2019 18:05:31 +0300 Message-Id: <8336fn5uf8.fsf@gnu.org> From: Eli Zaretskii To: Ergus In-reply-to: <20191020143930.ugxiakrap7yym6qw@Ergus> (message from Ergus on Sun, 20 Oct 2019 16:39:30 +0200) Subject: Re: bug#37806: 27.0.50; Need to "extend" face-remap.el References: <875zkmmn4u.fsf@gmx.net> <835zkk7i8i.fsf@gnu.org> <87r237txnl.fsf@gmx.net> <20191020143930.ugxiakrap7yym6qw@Ergus> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37806 Cc: stephen.berman@gmx.net, 37806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 20 Oct 2019 16:39:30 +0200 > From: Ergus > Cc: Eli Zaretskii , 37806@debbugs.gnu.org > > The proper fix must be to declare the vector in the C side using the > real symbols like: > > Lisp_Object internal-lisp-face-attributes[LFACE_VECTOR_SIZE] = { > Qnil QCfamily, QCfoundry, QCwidth QCheight, > QCweight, QCslant, QCunderline, QCinverse_video, > QCforeground, QCbackground, QCstipple, QCoverline, > QCstrike_through, QCbox, QCfont, QCinherit, QCfontset, > QCdistant_foreground, QCextend > }; > > But using makevector or a similar api from C. Yes, and face-remap.el even says so. You can "steal" the way this is done from coding.c, starting around line 11635 (but there should be no need to staticpro a variable that is visible from Lisp, unlike Vcoding_category_table). Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 20 11:13:14 2019 Received: (at 37806) by debbugs.gnu.org; 20 Oct 2019 15:13:14 +0000 Received: from localhost ([127.0.0.1]:55126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMCtO-00035Y-2N for submit@debbugs.gnu.org; Sun, 20 Oct 2019 11:13:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMCtL-00035L-Vs for 37806@debbugs.gnu.org; Sun, 20 Oct 2019 11:13:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMCtG-0001Vc-Rt; Sun, 20 Oct 2019 11:13:06 -0400 Received: from [176.228.60.248] (port=2686 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMCtG-0008Ur-BE; Sun, 20 Oct 2019 11:13:06 -0400 Date: Sun, 20 Oct 2019 18:12:58 +0300 Message-Id: <831rv75u2t.fsf@gnu.org> From: Eli Zaretskii To: Ergus In-reply-to: <20191020150032.4uu2jwbg6exl766b@Ergus> (message from Ergus on Sun, 20 Oct 2019 17:00:32 +0200) Subject: Re: bug#37806: 27.0.50; Need to "extend" face-remap.el References: <875zkmmn4u.fsf@gmx.net> <835zkk7i8i.fsf@gnu.org> <20191020150032.4uu2jwbg6exl766b@Ergus> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37806 Cc: stephen.berman@gmx.net, 37806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 20 Oct 2019 17:00:32 +0200 > From: Ergus > Cc: Stephen Berman , 37806@debbugs.gnu.org > > I just pushed a fix for this. Thanks. > BTW: I don't know how to close a bug report. It is not in the CONTRIBUTE > file. See admin/notes/bugtracker. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 20 15:58:57 2019 Received: (at 37806-done) by debbugs.gnu.org; 20 Oct 2019 19:58:57 +0000 Received: from localhost ([127.0.0.1]:55319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMHLs-0003Z3-Nn for submit@debbugs.gnu.org; Sun, 20 Oct 2019 15:58:56 -0400 Received: from sonic311-31.consmr.mail.ir2.yahoo.com ([77.238.176.163]:45097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMHLq-0003Yl-6U for 37806-done@debbugs.gnu.org; Sun, 20 Oct 2019 15:58:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1571601528; bh=uBQ4+WdR4kpHkG2M2Bue0AlJW9dUg46BcT65Vm99E+U=; h=Date:From:To:Subject:References:In-Reply-To:From:Subject; b=P1VncI2itX2IrQMOhmBSC16TFmY8kXq8C2y7RxwV4F/v/Ay2A4JDXZUXnS2QCH7DM+Bu+A1HK/bbvezV2Xtv9FHbVhoufro7ojmMVZjlCT/T+2jt7ii/IStHZQbWPaEK1caN8Qza/GBYg24gP2EwV75gB85Gj35o47ss5sHlmhC5SZ3Ffk4CPuDCMynAtCAFhuVKmvSeNt5JBdxanDVazSTDVmu8V9FX2fVrkog/k1xlh84ksPEAjYiaEkNVBHGElGTiN+OuABrhwd4b4FAFrxBG3Fb0i0cfU5AfhP1xaFryyPTyS+hYQYHrtQXzfjCTRfMtMrmnm+6f4dvTNN7D7A== X-YMail-OSG: EVbsKCEVM1mgii2YBoSACj59jfgAR7eOYUdn.TtnJiC_P0M.Shjmr8G9n_joNjE 37WzOWkollptA9lPOCdo2I9rcGXv4mddh5YZKQFQZf8JQ5NzKEg.YEBapEoxAUvvQBvM6uy5dT2e JK.a_wuV.5zw2WYKOCoVhzOf.1ISN3hOybwNt9nw7GfzbB_mXAHRB0sYKQlAW_XsZb2AG0pLX5yw F5WopUA4SU3ghBbGoyztDOsm5nk2c6ZXFv4IPWEoEJwOvUm0qyIZS4OTF23k8GZZpnHjhz_.1leH 7Es9yP91Fdw4noIxSCPpRCFXsEb54aLABOunnRv45_3ASW0mVuLaKfLezx.hx5zeNOyLVhu1V63e A7BG4G7BzmDcY8sv1emHoIWnMocAIA0QftfOUtxsz4t6JxfVnb73eHyhSwmUixH5pxI2mKA471ZH rKAeNK5xHqzKde5mGryguSXUq3U0mKwRLz9zzMiIDO88qtISczoO32CKbNM3fTj7z1SKHNdAItGo HHpw4vb7_0tnk0Gig8KjJ8wmPE0y8I48Q2qXIVdf5FIWPwXD5aLxu0E5tTsYlz0prEAQb_xbiQjK aykierl2FnbwAyH0BAEVLOYePIbwOGhj2rPZj0_hc8Z0TmFFVqJEK0kZb7L5vQQ6A8wf93Xw1fWs CTL1c.v.1T9NL_rHcHY_yyMD1HBfcTj0QVztS41gCx7srh3Jo1vFz8fvDk6eQsdsjU3sZTrLFruq 7KjhOK6hTAHbJjFw.jdt_A9ncZvU7tse7uEExhHH5hvDuMDgNU.jRjOfdYTOCNtcvezLk.k2Q8H2 LxlobOO5ME3X8dNJG_Ci39wSkm.owzPBYVw4bwN1I3BzdCr.v2.qlMPGqe_dpw8ccIhntXLlunAY 6tqbyYdviMJB9_J_.wOs3mjphSpykTGQ.Ns9cLa_jQUMh8kiC7T_vjPH5mQFU1Dh7_JrOlKeJPS2 kw2vG_9sIwM0KLUw7o3aFuwKllHJ6F_SwOVY3hQ0dR0qH5DCynECHIvfMqS8E2ginfVwwPgaLX.9 JdbXffRui3vOseOHuDE7XmBqyTT7hrlY.QIxCpCmpzVbCs.LP.IuO_jDqrote1Tc5ZfGHG0WEwqd gWmPz4Vi.6NQTMwxC_OqcaNZEQ2MJldU1iDFJYME9b0T7WavxSxp_zI6e2FkC2ssY02k9p1nqYXz eX.9w7PWuOAhLAemI_Abxvi6nsBzXMfrThB186w4Xnqh6vCHwhZIorkKMOltVbvHdz_eJ5EGdmzC Gn19d5CRkjJa4j3vNJb9ppf7ftFg9VX7_vJXfDo6wKeSbfya_06WFLz9x0fw8R1iXNdOyb9kjaRv lg15O Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Sun, 20 Oct 2019 19:58:47 +0000 Received: by smtp426.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID ae242ab71294391590058e8a68ce0370; Sun, 20 Oct 2019 19:58:42 +0000 (UTC) Date: Sun, 20 Oct 2019 21:58:29 +0200 From: Ergus To: 37806-done@debbugs.gnu.org Subject: Re: bug#37806: 27.0.50; Need to "extend" face-remap.el Message-ID: <20191020195829.baxhszeu4soeuad7@Ergus> References: <875zkmmn4u.fsf@gmx.net> <835zkk7i8i.fsf@gnu.org> <87r237txnl.fsf@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87r237txnl.fsf@gmx.net> User-Agent: NeoMutt/20180716 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37806-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixed in commit: 270ca8c2735cfc7935b9e4d0b770a55138493e From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 21 03:20:13 2019 Received: (at 37806) by debbugs.gnu.org; 21 Oct 2019 07:20:13 +0000 Received: from localhost ([127.0.0.1]:55652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMRzB-0005N2-E5 for submit@debbugs.gnu.org; Mon, 21 Oct 2019 03:20:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMRz9-0005Mm-SZ for 37806@debbugs.gnu.org; Mon, 21 Oct 2019 03:20:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:32815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMRz4-00068M-OL; Mon, 21 Oct 2019 03:20:06 -0400 Received: from [176.228.60.248] (port=1871 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMRz3-0006nE-UD; Mon, 21 Oct 2019 03:20:06 -0400 Date: Mon, 21 Oct 2019 10:20:00 +0300 Message-Id: <831rv64lb3.fsf@gnu.org> From: Eli Zaretskii To: spacibba@aol.com In-reply-to: <8336fn5uf8.fsf@gnu.org> (message from Eli Zaretskii on Sun, 20 Oct 2019 18:05:31 +0300) Subject: Re: bug#37806: 27.0.50; Need to "extend" face-remap.el References: <875zkmmn4u.fsf@gmx.net> <835zkk7i8i.fsf@gnu.org> <87r237txnl.fsf@gmx.net> <20191020143930.ugxiakrap7yym6qw@Ergus> <8336fn5uf8.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37806 Cc: stephen.berman@gmx.net, 37806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 20 Oct 2019 18:05:31 +0300 > From: Eli Zaretskii > Cc: stephen.berman@gmx.net, 37806@debbugs.gnu.org > > > Date: Sun, 20 Oct 2019 16:39:30 +0200 > > From: Ergus > > Cc: Eli Zaretskii , 37806@debbugs.gnu.org > > > > The proper fix must be to declare the vector in the C side using the > > real symbols like: > > > > Lisp_Object internal-lisp-face-attributes[LFACE_VECTOR_SIZE] = { > > Qnil QCfamily, QCfoundry, QCwidth QCheight, > > QCweight, QCslant, QCunderline, QCinverse_video, > > QCforeground, QCbackground, QCstipple, QCoverline, > > QCstrike_through, QCbox, QCfont, QCinherit, QCfontset, > > QCdistant_foreground, QCextend > > }; > > > > But using makevector or a similar api from C. > > Yes, and face-remap.el even says so. > > You can "steal" the way this is done from coding.c, starting around > line 11635 (but there should be no need to staticpro a variable that > is visible from Lisp, unlike Vcoding_category_table). > > > So I will submit the simplest fix now and if Eli gives me a green light > > I will implement the better version. Jimmy, in case it was unclear, my comments above is the "green light" you asked for implementing a better version in xfaces.c. We should have done that cleanup long ago, IMO. Thanks. From unknown Sat Jun 21 10:39:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 18 Nov 2019 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator