GNU bug report logs - #37788
[PATCH] gnu: Add minisign.

Previous Next

Package: guix-patches;

Reported by: Tanguy Le Carrour <tanguy <at> bioneland.org>

Date: Thu, 17 Oct 2019 08:03:03 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <m.othacehe <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 37788 <at> debbugs.gnu.org
Subject: Re: [bug#37788] [PATCH] gnu: Add minisign.
Date: Thu, 17 Oct 2019 17:32:58 +0200

Hello Tanguy,

> Remove new blank line at EOF.

Please pass --subject-prefix="PATCH v2" to git format-patch so that it
is easier to identify patch revisions.

> +     ; No test suite

You can put it on the same line as the one below.

> +     `(#:tests? #f))

You also did forget to add the Copyright on top.

Otherwise seems fine :). I fixed the points above and pushed it.

Mathieu
This bug report was last modified 5 years and 277 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.