GNU bug report logs - #37774
27.0.50; new :extend attribute broke visuals of all themes and other packages

Previous Next

Package: emacs;

Reported by: Andrey Orst <andreyorst <at> gmail.com>

Date: Wed, 16 Oct 2019 07:32:01 UTC

Severity: normal

Found in version 27.0.50

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


Message #517 received at 37774 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37774 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#37774: 27.0.50; new :extend attribute broke visuals of all
 themes and other packages
Date: Thu, 12 Dec 2019 01:02:42 +0200
0. emacs -Q
1. Eval: (progn (load-library "ldap") (customize-variable 'ldap-host-parameters-alist))
2. Click the button "INS".
3. Where are the input fields?  I don't see any.  Are they lost?
   These fields were visible in the previous version.
   Ah, this is the :extend fallout in action.

That means this patch is in order:

diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
index 94ab938a22..aabb3be197 100644
--- a/lisp/wid-edit.el
+++ b/lisp/wid-edit.el
@@ -126,15 +126,16 @@ widget-mouse-face
 ;; background, at least on light-background TTYs.
 (defface widget-field '((((type tty))
 			 :background "yellow3"
-			 :foreground "black")
+			 :foreground "black"
+			 :extend t)
 			(((class grayscale color)
 			  (background light))
-			 :background "gray85")
+			 :background "gray85" :extend t)
 			(((class grayscale color)
 			  (background dark))
-			 :background "dim gray")
+			 :background "dim gray" :extend t)
 			(t
-			 :slant italic))
+			 :slant italic :extend t))
   "Face used for editable fields."
   :group 'widget-faces)
 

I wonder how many similar fields shrunk to the size of the cursor
still exist.  Maybe web forms in eww?




This bug report was last modified 5 years and 162 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.